From: Krzysztof Kozlowski <krzk@kernel.org> To: k.konieczny@partner.samsung.com Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Kukjin Kim <kgene@kernel.org>, Kyungmin Park <kyungmin.park@samsung.com>, Mark Rutland <mark.rutland@arm.com>, MyungJoo Ham <myungjoo.ham@samsung.com>, Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>, Viresh Kumar <vireshk@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org> Subject: Re: [PATCH 0/3] add coupled regulators for Exynos5422/5800 Date: Wed, 10 Jul 2019 11:00:53 +0200 [thread overview] Message-ID: <CAJKOXPd+UZ2MdrTVfBv5UYzK5LgKNQHUFzRbRNeq271EaDSchg@mail.gmail.com> (raw) In-Reply-To: <20190708141140.24379-1-k.konieczny@partner.samsung.com> On Mon, 8 Jul 2019 at 16:12, <k.konieczny@partner.samsung.com> wrote: > > From: Kamil Konieczny <k.konieczny@partner.samsung.com> > > Hi, > > The main purpose of this patch series is to add coupled regulators for > Exynos5422/5800 to keep constrain on voltage difference between vdd_arm > and vdd_int to be at most 300mV. In exynos-bus instead of using > regulator_set_voltage_tol() with default voltage tolerance it should be > used regulator_set_voltage_triplet() with volatege range, and this is > already present in opp/core.c code, so it can be reused. While at this, > move setting regulators into opp/core. > > This patchset was tested on Odroid XU3. > > The last patch depends on two previous. So you break the ABI... I assume that patchset maintains bisectability. However there is no explanation why ABI break is needed so this does not look good... Best regards, Krzysztof > > Regards, > Kamil > > Kamil Konieczny (2): > opp: core: add regulators enable and disable > devfreq: exynos-bus: convert to use dev_pm_opp_set_rate() > > Marek Szyprowski (1): > ARM: dts: exynos: add initial data for coupled regulators for > Exynos5422/5800 > > arch/arm/boot/dts/exynos5420.dtsi | 34 ++-- > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 4 + > arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 + > arch/arm/boot/dts/exynos5800.dtsi | 32 ++-- > drivers/devfreq/exynos-bus.c | 172 +++++++----------- > drivers/opp/core.c | 13 ++ > 6 files changed, 120 insertions(+), 139 deletions(-) > > -- > 2.22.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: k.konieczny@partner.samsung.com Cc: Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, linux-arm-kernel@lists.infradead.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Stephen Boyd <sboyd@kernel.org>, Viresh Kumar <vireshk@kernel.org>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Chanwoo Choi <cw00.choi@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Kukjin Kim <kgene@kernel.org>, MyungJoo Ham <myungjoo.ham@samsung.com>, devicetree@vger.kernel.org, Marek Szyprowski <m.szyprowski@samsung.com> Subject: Re: [PATCH 0/3] add coupled regulators for Exynos5422/5800 Date: Wed, 10 Jul 2019 11:00:53 +0200 [thread overview] Message-ID: <CAJKOXPd+UZ2MdrTVfBv5UYzK5LgKNQHUFzRbRNeq271EaDSchg@mail.gmail.com> (raw) In-Reply-To: <20190708141140.24379-1-k.konieczny@partner.samsung.com> On Mon, 8 Jul 2019 at 16:12, <k.konieczny@partner.samsung.com> wrote: > > From: Kamil Konieczny <k.konieczny@partner.samsung.com> > > Hi, > > The main purpose of this patch series is to add coupled regulators for > Exynos5422/5800 to keep constrain on voltage difference between vdd_arm > and vdd_int to be at most 300mV. In exynos-bus instead of using > regulator_set_voltage_tol() with default voltage tolerance it should be > used regulator_set_voltage_triplet() with volatege range, and this is > already present in opp/core.c code, so it can be reused. While at this, > move setting regulators into opp/core. > > This patchset was tested on Odroid XU3. > > The last patch depends on two previous. So you break the ABI... I assume that patchset maintains bisectability. However there is no explanation why ABI break is needed so this does not look good... Best regards, Krzysztof > > Regards, > Kamil > > Kamil Konieczny (2): > opp: core: add regulators enable and disable > devfreq: exynos-bus: convert to use dev_pm_opp_set_rate() > > Marek Szyprowski (1): > ARM: dts: exynos: add initial data for coupled regulators for > Exynos5422/5800 > > arch/arm/boot/dts/exynos5420.dtsi | 34 ++-- > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 4 + > arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 + > arch/arm/boot/dts/exynos5800.dtsi | 32 ++-- > drivers/devfreq/exynos-bus.c | 172 +++++++----------- > drivers/opp/core.c | 13 ++ > 6 files changed, 120 insertions(+), 139 deletions(-) > > -- > 2.22.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-10 9:01 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20190708141158eucas1p17d4b50978dbe1e5c876ce6d8f433cc95@eucas1p1.samsung.com> 2019-07-08 14:11 ` [PATCH 0/3] add coupled regulators for Exynos5422/5800 k.konieczny 2019-07-08 14:11 ` k.konieczny [not found] ` <CGME20190708141159eucas1p1751506975ff96a436e14940916623722@eucas1p1.samsung.com> 2019-07-08 14:11 ` [PATCH 1/3] opp: core: add regulators enable and disable k.konieczny 2019-07-08 14:11 ` k.konieczny 2019-07-09 5:40 ` Viresh Kumar 2019-07-09 5:40 ` Viresh Kumar 2019-07-09 5:40 ` Viresh Kumar 2019-07-10 10:16 ` Kamil Konieczny 2019-07-10 10:16 ` Kamil Konieczny 2019-07-10 10:42 ` Kamil Konieczny 2019-07-10 10:42 ` Kamil Konieczny 2019-07-10 10:42 ` Kamil Konieczny 2019-07-10 10:43 ` Kamil Konieczny 2019-07-10 10:43 ` Kamil Konieczny 2019-07-10 13:52 ` Kamil Konieczny 2019-07-10 13:52 ` Kamil Konieczny 2019-07-10 17:01 ` Krzysztof Kozlowski 2019-07-10 17:01 ` Krzysztof Kozlowski 2019-07-10 17:01 ` Krzysztof Kozlowski 2019-07-11 6:22 ` Viresh Kumar 2019-07-11 6:22 ` Viresh Kumar 2019-07-11 12:58 ` Kamil Konieczny 2019-07-11 12:58 ` Kamil Konieczny 2019-07-11 12:58 ` Kamil Konieczny [not found] ` <CGME20190708141200eucas1p144ca3b2a5b4019aaa5773d23c0236f31@eucas1p1.samsung.com> 2019-07-08 14:11 ` [PATCH 2/3] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate() k.konieczny 2019-07-08 14:11 ` k.konieczny 2019-07-10 17:04 ` Krzysztof Kozlowski 2019-07-10 17:04 ` Krzysztof Kozlowski 2019-07-10 17:04 ` Krzysztof Kozlowski 2019-07-11 13:36 ` Kamil Konieczny 2019-07-11 13:36 ` Kamil Konieczny 2019-07-11 13:36 ` Kamil Konieczny [not found] ` <CGME20190708141200eucas1p12bf901a2589efe92b133b357d2cbc57e@eucas1p1.samsung.com> 2019-07-08 14:11 ` [PATCH 3/3] ARM: dts: exynos: add initial data for coupled regulators for Exynos5422/5800 k.konieczny 2019-07-08 14:11 ` k.konieczny 2019-07-10 9:02 ` Krzysztof Kozlowski 2019-07-10 9:02 ` Krzysztof Kozlowski 2019-07-10 9:02 ` Krzysztof Kozlowski 2019-07-10 9:00 ` Krzysztof Kozlowski [this message] 2019-07-10 9:00 ` [PATCH 0/3] add " Krzysztof Kozlowski 2019-07-10 9:00 ` Krzysztof Kozlowski 2019-07-10 10:03 ` Kamil Konieczny 2019-07-10 10:03 ` Kamil Konieczny 2019-07-10 10:03 ` Kamil Konieczny 2019-07-10 10:14 ` Krzysztof Kozlowski 2019-07-10 10:14 ` Krzysztof Kozlowski 2019-07-10 10:14 ` Krzysztof Kozlowski 2019-07-10 13:51 ` Kamil Konieczny 2019-07-10 13:51 ` Kamil Konieczny 2019-07-10 13:51 ` Kamil Konieczny 2019-07-10 17:01 ` Krzysztof Kozlowski 2019-07-10 17:01 ` Krzysztof Kozlowski 2019-07-10 17:01 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJKOXPd+UZ2MdrTVfBv5UYzK5LgKNQHUFzRbRNeq271EaDSchg@mail.gmail.com \ --to=krzk@kernel.org \ --cc=b.zolnierkie@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=k.konieczny@partner.samsung.com \ --cc=kgene@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mark.rutland@arm.com \ --cc=myungjoo.ham@samsung.com \ --cc=nm@ti.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=vireshk@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.