* [PATCH] drm/bridge: sii9234: silence warning about regulators during deferred probe
@ 2020-02-26 10:13 ` Marek Szyprowski
0 siblings, 0 replies; 8+ messages in thread
From: Marek Szyprowski @ 2020-02-26 10:13 UTC (permalink / raw)
To: dri-devel, linux-samsung-soc
Cc: Jernej Skrabec, Neil Armstrong, Jonas Karlman, Andrzej Hajda,
Bartlomiej Zolnierkiewicz, Laurent Pinchart, Marek Szyprowski
Don't confuse user with meaningless warning about failure in getting
regulators in case of deferred probe.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/gpu/drm/bridge/sii9234.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
index f81f81b7051f..b1258f0ed205 100644
--- a/drivers/gpu/drm/bridge/sii9234.c
+++ b/drivers/gpu/drm/bridge/sii9234.c
@@ -836,7 +836,8 @@ static int sii9234_init_resources(struct sii9234 *ctx,
ctx->supplies[3].supply = "cvcc12";
ret = devm_regulator_bulk_get(ctx->dev, 4, ctx->supplies);
if (ret) {
- dev_err(ctx->dev, "regulator_bulk failed\n");
+ if (ret != -EPROBE_DEFER)
+ dev_err(ctx->dev, "regulator_bulk failed\n");
return ret;
}
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/bridge: sii9234: silence warning about regulators during deferred probe
2020-02-26 10:13 ` Marek Szyprowski
@ 2020-02-26 10:24 ` Laurent Pinchart
-1 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2020-02-26 10:24 UTC (permalink / raw)
To: Marek Szyprowski
Cc: dri-devel, linux-samsung-soc, Bartlomiej Zolnierkiewicz,
Neil Armstrong, Andrzej Hajda, Jonas Karlman, Jernej Skrabec
Hi Marek,
Thank you for the patch.
On Wed, Feb 26, 2020 at 11:13:07AM +0100, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about failure in getting
> regulators in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/sii9234.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
> index f81f81b7051f..b1258f0ed205 100644
> --- a/drivers/gpu/drm/bridge/sii9234.c
> +++ b/drivers/gpu/drm/bridge/sii9234.c
> @@ -836,7 +836,8 @@ static int sii9234_init_resources(struct sii9234 *ctx,
> ctx->supplies[3].supply = "cvcc12";
> ret = devm_regulator_bulk_get(ctx->dev, 4, ctx->supplies);
> if (ret) {
> - dev_err(ctx->dev, "regulator_bulk failed\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(ctx->dev, "regulator_bulk failed\n");
> return ret;
> }
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/bridge: sii9234: silence warning about regulators during deferred probe
@ 2020-02-26 10:24 ` Laurent Pinchart
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2020-02-26 10:24 UTC (permalink / raw)
To: Marek Szyprowski
Cc: Jernej Skrabec, linux-samsung-soc, Neil Armstrong, Jonas Karlman,
dri-devel, Andrzej Hajda, Bartlomiej Zolnierkiewicz
Hi Marek,
Thank you for the patch.
On Wed, Feb 26, 2020 at 11:13:07AM +0100, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about failure in getting
> regulators in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/sii9234.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
> index f81f81b7051f..b1258f0ed205 100644
> --- a/drivers/gpu/drm/bridge/sii9234.c
> +++ b/drivers/gpu/drm/bridge/sii9234.c
> @@ -836,7 +836,8 @@ static int sii9234_init_resources(struct sii9234 *ctx,
> ctx->supplies[3].supply = "cvcc12";
> ret = devm_regulator_bulk_get(ctx->dev, 4, ctx->supplies);
> if (ret) {
> - dev_err(ctx->dev, "regulator_bulk failed\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(ctx->dev, "regulator_bulk failed\n");
> return ret;
> }
>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge: sii9234: silence warning about regulators during deferred probe
2020-02-26 10:13 ` Marek Szyprowski
@ 2020-02-26 12:01 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2020-02-26 12:01 UTC (permalink / raw)
To: Marek Szyprowski
Cc: dri-devel, linux-samsung-soc, Bartlomiej Zolnierkiewicz,
Laurent Pinchart, Neil Armstrong, Andrzej Hajda, Jonas Karlman,
Jernej Skrabec
On Wed, 26 Feb 2020 at 11:13, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> Don't confuse user with meaningless warning about failure in getting
> regulators in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/gpu/drm/bridge/sii9234.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge: sii9234: silence warning about regulators during deferred probe
@ 2020-02-26 12:01 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2020-02-26 12:01 UTC (permalink / raw)
To: Marek Szyprowski
Cc: Jernej Skrabec, linux-samsung-soc, Neil Armstrong,
Bartlomiej Zolnierkiewicz, dri-devel, Andrzej Hajda,
Jonas Karlman, Laurent Pinchart
On Wed, 26 Feb 2020 at 11:13, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> Don't confuse user with meaningless warning about failure in getting
> regulators in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/gpu/drm/bridge/sii9234.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge: sii9234: silence warning about regulators during deferred probe
2020-02-26 10:13 ` Marek Szyprowski
@ 2020-03-27 7:45 ` Andrzej Hajda
-1 siblings, 0 replies; 8+ messages in thread
From: Andrzej Hajda @ 2020-03-27 7:45 UTC (permalink / raw)
To: Marek Szyprowski, dri-devel, linux-samsung-soc
Cc: Jernej Skrabec, Neil Armstrong, Jonas Karlman,
Bartlomiej Zolnierkiewicz, Laurent Pinchart
On 26.02.2020 11:13, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about failure in getting
> regulators in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/gpu/drm/bridge/sii9234.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
> index f81f81b7051f..b1258f0ed205 100644
> --- a/drivers/gpu/drm/bridge/sii9234.c
> +++ b/drivers/gpu/drm/bridge/sii9234.c
> @@ -836,7 +836,8 @@ static int sii9234_init_resources(struct sii9234 *ctx,
> ctx->supplies[3].supply = "cvcc12";
> ret = devm_regulator_bulk_get(ctx->dev, 4, ctx->supplies);
> if (ret) {
> - dev_err(ctx->dev, "regulator_bulk failed\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(ctx->dev, "regulator_bulk failed\n");
> return ret;
> }
>
Queued to next.
Andrzej
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/bridge: sii9234: silence warning about regulators during deferred probe
@ 2020-03-27 7:45 ` Andrzej Hajda
0 siblings, 0 replies; 8+ messages in thread
From: Andrzej Hajda @ 2020-03-27 7:45 UTC (permalink / raw)
To: Marek Szyprowski, dri-devel, linux-samsung-soc
Cc: Bartlomiej Zolnierkiewicz, Jernej Skrabec, Jonas Karlman,
Laurent Pinchart, Neil Armstrong
On 26.02.2020 11:13, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about failure in getting
> regulators in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/gpu/drm/bridge/sii9234.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
> index f81f81b7051f..b1258f0ed205 100644
> --- a/drivers/gpu/drm/bridge/sii9234.c
> +++ b/drivers/gpu/drm/bridge/sii9234.c
> @@ -836,7 +836,8 @@ static int sii9234_init_resources(struct sii9234 *ctx,
> ctx->supplies[3].supply = "cvcc12";
> ret = devm_regulator_bulk_get(ctx->dev, 4, ctx->supplies);
> if (ret) {
> - dev_err(ctx->dev, "regulator_bulk failed\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(ctx->dev, "regulator_bulk failed\n");
> return ret;
> }
>
Queued to next.
Andrzej
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread