From: Krzysztof Kozlowski <k.kozlowski@samsung.com> To: Anand Moon <linux.amoon@gmail.com> Cc: Lukasz Majewski <l.majewski@samsung.com>, Guenter Roeck <linux@roeck-us.net>, Markus Reichl <m.reichl@fivetechno.de>, Eduardo Valentin <edubezval@gmail.com>, Sjoerd Simons <sjoerd.simons@collabora.co.uk>, Russell King <linux@arm.linux.org.uk>, Kukjin Kim <kgene@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0 Date: Wed, 13 May 2015 16:31:37 +0900 [thread overview] Message-ID: <CAJKOXPdKtMO3f8YzHXtuZ042jkFRL4wa978=TggSQk8FahubRg@mail.gmail.com> (raw) In-Reply-To: <1431499020-3912-5-git-send-email-linux.amoon@gmail.com> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>: > update the cooling level for cpu0 to avoid following message. Capitalize sentence. In commit subject add missing colon after "exynos5420". > > root@odroidxu3:~# dmesg | grep ther This command not needed, we all know how to use dmesg and grep. > [ 0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0: > could not get #cooling-cells for /cpus/cpu@0 > > Tested-by: Markus Reichl <m.reichl@fivetechno.de> > Acked-by: Lukasz Majewski <l.majewski@samsung.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/boot/dts/exynos5420.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index 4531753..c75ed16 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -61,6 +61,10 @@ > reg = <0x0>; > clock-frequency = <1800000000>; > cci-control-port = <&cci_control1>; > + > + cooling-min-level = <10>; > + cooling-max-level = <7>; > + #cooling-cells = <2>; /* min followed by max */ I might be missing something but I do not understand which cooling levels are referenced here. In my exynos5420.dtsi file there are no frequencies for cpu0 node. Could you help me understand this? Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0 Date: Wed, 13 May 2015 16:31:37 +0900 [thread overview] Message-ID: <CAJKOXPdKtMO3f8YzHXtuZ042jkFRL4wa978=TggSQk8FahubRg@mail.gmail.com> (raw) In-Reply-To: <1431499020-3912-5-git-send-email-linux.amoon@gmail.com> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>: > update the cooling level for cpu0 to avoid following message. Capitalize sentence. In commit subject add missing colon after "exynos5420". > > root at odroidxu3:~# dmesg | grep ther This command not needed, we all know how to use dmesg and grep. > [ 0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0: > could not get #cooling-cells for /cpus/cpu at 0 > > Tested-by: Markus Reichl <m.reichl@fivetechno.de> > Acked-by: Lukasz Majewski <l.majewski@samsung.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/boot/dts/exynos5420.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index 4531753..c75ed16 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -61,6 +61,10 @@ > reg = <0x0>; > clock-frequency = <1800000000>; > cci-control-port = <&cci_control1>; > + > + cooling-min-level = <10>; > + cooling-max-level = <7>; > + #cooling-cells = <2>; /* min followed by max */ I might be missing something but I do not understand which cooling levels are referenced here. In my exynos5420.dtsi file there are no frequencies for cpu0 node. Could you help me understand this? Best regards, Krzysztof
next prev parent reply other threads:[~2015-05-13 7:31 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-13 6:36 v5 Exynos5422 odroidxu3 pwm-fan control using thermal sensors Anand Moon 2015-05-13 6:36 ` Anand Moon 2015-05-13 6:36 ` [PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board Anand Moon 2015-05-13 6:36 ` Anand Moon 2015-05-13 7:11 ` Krzysztof Kozlowski 2015-05-13 7:11 ` Krzysztof Kozlowski [not found] ` <CAJKOXPefJwqvfZPDovQ6EjEOBfuJkidgeYDF_=KC9O+=2=_KoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-05-13 7:46 ` Anand Moon 2015-05-13 7:46 ` Anand Moon 2015-06-14 5:31 ` Krzysztof Kozlowski 2015-06-14 5:31 ` Krzysztof Kozlowski 2015-06-14 5:35 ` Anand Moon 2015-06-14 5:35 ` Anand Moon 2015-05-13 8:17 ` [PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node tothe " Kukjin Kim 2015-05-13 8:17 ` Kukjin Kim 2015-05-13 6:36 ` [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base Anand Moon 2015-05-13 6:36 ` Anand Moon [not found] ` <1431499020-3912-3-git-send-email-linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-05-13 7:21 ` Krzysztof Kozlowski 2015-05-13 7:21 ` Krzysztof Kozlowski 2015-05-13 8:21 ` Anand Moon 2015-05-13 8:21 ` Anand Moon 2015-05-13 8:32 ` Krzysztof Kozlowski 2015-05-13 8:32 ` Krzysztof Kozlowski [not found] ` <CAJKOXPfC9nGEsYJ3qJ6m_iMsB=D8_6sOEpLQzEvmLry5zS5j3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-05-13 8:45 ` Anand Moon 2015-05-13 8:45 ` Anand Moon 2015-05-14 16:16 ` Anand Moon 2015-05-14 16:16 ` Anand Moon 2015-05-15 0:12 ` Krzysztof Kozlowski 2015-05-15 0:12 ` Krzysztof Kozlowski [not found] ` <CAJKOXPd_1rTZZCz66nQKidUOOEBmgUD+05fHUBvXN-VuD5mTCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-05-15 1:36 ` Anand Moon 2015-05-15 1:36 ` Anand Moon 2015-05-19 7:28 ` Anand Moon 2015-05-19 7:28 ` Anand Moon [not found] ` <CANAwSgTbjmSxhJj4o2pnD5pR2V9JbQ3az+TSSCDwgwNnvF7P9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-05-19 7:42 ` Krzysztof Kozlowski 2015-05-19 7:42 ` Krzysztof Kozlowski [not found] ` <CADoNuNfuDCn_vvACc0=xj0MjdKr4pYcj_-Xh0--Q8_qciuW5YA@mail.gmail.com> 2015-05-20 14:59 ` Anand Moon 2015-05-20 14:59 ` Anand Moon 2015-05-21 0:03 ` Krzysztof Kozlowski 2015-05-21 0:03 ` Krzysztof Kozlowski 2015-05-23 17:35 ` Anand Moon 2015-05-23 17:35 ` Anand Moon 2015-05-24 4:33 ` Krzysztof Kozlowski 2015-05-24 4:33 ` Krzysztof Kozlowski 2015-05-24 5:19 ` Anand Moon 2015-05-24 5:19 ` Anand Moon 2015-05-13 6:36 ` [PATCHv5 3/5] ARM: dts: define default thermal-zones for exynos5422 Anand Moon 2015-05-13 6:36 ` Anand Moon 2015-05-13 7:23 ` Krzysztof Kozlowski 2015-05-13 7:23 ` Krzysztof Kozlowski [not found] ` <CAJKOXPerF9xgGzFuU+HC_9QaOAAMkoQo2DxH0Y=NwLJ7TMWH0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-05-13 8:02 ` Krzysztof Kozlowski 2015-05-13 8:02 ` Krzysztof Kozlowski 2015-05-13 13:16 ` Lukasz Majewski 2015-05-13 13:16 ` Lukasz Majewski 2015-05-13 6:36 ` [PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0 Anand Moon 2015-05-13 6:36 ` Anand Moon 2015-05-13 7:31 ` Krzysztof Kozlowski [this message] 2015-05-13 7:31 ` Krzysztof Kozlowski 2015-05-13 7:58 ` Anand Moon 2015-05-13 7:58 ` Anand Moon 2015-05-13 8:05 ` Krzysztof Kozlowski 2015-05-13 8:05 ` Krzysztof Kozlowski 2015-05-13 10:07 ` Anand Moon 2015-05-13 10:07 ` Anand Moon [not found] ` <CANAwSgTdQk6BGD4xxB6k=p=YOV+CHv_+Q_bSyrxiPsdXVps92g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-05-13 10:12 ` Krzysztof Kozlowski 2015-05-13 10:12 ` Krzysztof Kozlowski 2015-05-13 11:01 ` Anand Moon 2015-05-13 11:01 ` Anand Moon 2015-05-13 6:37 ` [PATCHv5 5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3 Anand Moon 2015-05-13 6:37 ` Anand Moon 2015-05-13 7:40 ` Krzysztof Kozlowski 2015-05-13 7:40 ` Krzysztof Kozlowski 2015-05-13 8:39 ` Anand Moon 2015-05-13 8:39 ` Anand Moon 2015-05-13 10:05 ` Krzysztof Kozlowski 2015-05-13 10:05 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJKOXPdKtMO3f8YzHXtuZ042jkFRL4wa978=TggSQk8FahubRg@mail.gmail.com' \ --to=k.kozlowski@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=edubezval@gmail.com \ --cc=kgene@kernel.org \ --cc=l.majewski@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux.amoon@gmail.com \ --cc=linux@arm.linux.org.uk \ --cc=linux@roeck-us.net \ --cc=m.reichl@fivetechno.de \ --cc=sjoerd.simons@collabora.co.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.