* [U-Boot] [PATCH] arndale: fix unknown status [not found] <CGME20190314004445epcas1p3ace241b1a00f3237790cb95e2d338794@epcas1p3.samsung.com> @ 2019-03-14 0:44 ` Minkyu Kang 2019-03-14 4:10 ` Minkyu Kang 0 siblings, 1 reply; 8+ messages in thread From: Minkyu Kang @ 2019-03-14 0:44 UTC (permalink / raw) To: u-boot set status to Maintained Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> --- board/samsung/arndale/MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS index 98ccaa4..aa64c7a 100644 --- a/board/samsung/arndale/MAINTAINERS +++ b/board/samsung/arndale/MAINTAINERS @@ -1,6 +1,6 @@ ARNDALE BOARD M: Krzysztof Kozlowski <krzk@kernel.org> -S: Odd Fixes +S: Maintained F: board/samsung/arndale/ F: include/configs/arndale.h F: configs/arndale_defconfig -- 1.9.1 -- Thanks, Minkyu Kang. ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arndale: fix unknown status 2019-03-14 0:44 ` [U-Boot] [PATCH] arndale: fix unknown status Minkyu Kang @ 2019-03-14 4:10 ` Minkyu Kang 2019-03-14 7:38 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Minkyu Kang @ 2019-03-14 4:10 UTC (permalink / raw) To: u-boot On 14/03/2019 09:44, Minkyu Kang wrote: > set status to Maintained > > Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > --- > board/samsung/arndale/MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS > index 98ccaa4..aa64c7a 100644 > --- a/board/samsung/arndale/MAINTAINERS > +++ b/board/samsung/arndale/MAINTAINERS > @@ -1,6 +1,6 @@ > ARNDALE BOARD > M: Krzysztof Kozlowski <krzk@kernel.org> > -S: Odd Fixes > +S: Maintained > F: board/samsung/arndale/ > F: include/configs/arndale.h > F: configs/arndale_defconfig > applied to u-boot-samsung. Thanks, Minkyu Kang. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arndale: fix unknown status 2019-03-14 4:10 ` Minkyu Kang @ 2019-03-14 7:38 ` Krzysztof Kozlowski 2019-03-14 8:15 ` Minkyu Kang 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2019-03-14 7:38 UTC (permalink / raw) To: u-boot On Thu, 14 Mar 2019 at 05:10, Minkyu Kang <mk7.kang@samsung.com> wrote: > > On 14/03/2019 09:44, Minkyu Kang wrote: > > set status to Maintained > > > > Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> > > Cc: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > board/samsung/arndale/MAINTAINERS | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS > > index 98ccaa4..aa64c7a 100644 > > --- a/board/samsung/arndale/MAINTAINERS > > +++ b/board/samsung/arndale/MAINTAINERS > > @@ -1,6 +1,6 @@ > > ARNDALE BOARD > > M: Krzysztof Kozlowski <krzk@kernel.org> > > -S: Odd Fixes > > +S: Maintained > > F: board/samsung/arndale/ > > F: include/configs/arndale.h > > F: configs/arndale_defconfig > > > > applied to u-boot-samsung. Hi, In the commit changing the maintainer I changed on purpose to Odd Fixes. Because the board is not actively maintained. It is not "unknown status", it is perfectly valid status. Why changing it to Maintained? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arndale: fix unknown status 2019-03-14 7:38 ` Krzysztof Kozlowski @ 2019-03-14 8:15 ` Minkyu Kang 2019-03-14 8:23 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Minkyu Kang @ 2019-03-14 8:15 UTC (permalink / raw) To: u-boot Hi, On 14/03/2019 16:38, Krzysztof Kozlowski wrote: > On Thu, 14 Mar 2019 at 05:10, Minkyu Kang <mk7.kang@samsung.com> wrote: >> >> On 14/03/2019 09:44, Minkyu Kang wrote: >>> set status to Maintained >>> >>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> >>> Cc: Krzysztof Kozlowski <krzk@kernel.org> >>> --- >>> board/samsung/arndale/MAINTAINERS | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS >>> index 98ccaa4..aa64c7a 100644 >>> --- a/board/samsung/arndale/MAINTAINERS >>> +++ b/board/samsung/arndale/MAINTAINERS >>> @@ -1,6 +1,6 @@ >>> ARNDALE BOARD >>> M: Krzysztof Kozlowski <krzk@kernel.org> >>> -S: Odd Fixes >>> +S: Maintained >>> F: board/samsung/arndale/ >>> F: include/configs/arndale.h >>> F: configs/arndale_defconfig >>> >> >> applied to u-boot-samsung. > > Hi, > > In the commit changing the maintainer I changed on purpose to Odd > Fixes. Because the board is not actively maintained. It is not > "unknown status", it is perfectly valid status. Why changing it to > Maintained? > $ ./tools/genboardscfg.py -f WARNING: Odd Fixes: unknown status for 'arndale' If you don't want to maintain then, it would be set to Orphan? Thanks, Minkyu Kang. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arndale: fix unknown status 2019-03-14 8:15 ` Minkyu Kang @ 2019-03-14 8:23 ` Krzysztof Kozlowski 2019-03-14 19:23 ` Tom Rini 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2019-03-14 8:23 UTC (permalink / raw) To: u-boot On Thu, 14 Mar 2019 at 09:15, Minkyu Kang <mk7.kang@samsung.com> wrote: > > Hi, > > On 14/03/2019 16:38, Krzysztof Kozlowski wrote: > > On Thu, 14 Mar 2019 at 05:10, Minkyu Kang <mk7.kang@samsung.com> wrote: > >> > >> On 14/03/2019 09:44, Minkyu Kang wrote: > >>> set status to Maintained > >>> > >>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> > >>> Cc: Krzysztof Kozlowski <krzk@kernel.org> > >>> --- > >>> board/samsung/arndale/MAINTAINERS | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS > >>> index 98ccaa4..aa64c7a 100644 > >>> --- a/board/samsung/arndale/MAINTAINERS > >>> +++ b/board/samsung/arndale/MAINTAINERS > >>> @@ -1,6 +1,6 @@ > >>> ARNDALE BOARD > >>> M: Krzysztof Kozlowski <krzk@kernel.org> > >>> -S: Odd Fixes > >>> +S: Maintained > >>> F: board/samsung/arndale/ > >>> F: include/configs/arndale.h > >>> F: configs/arndale_defconfig > >>> > >> > >> applied to u-boot-samsung. > > > > Hi, > > > > In the commit changing the maintainer I changed on purpose to Odd > > Fixes. Because the board is not actively maintained. It is not > > "unknown status", it is perfectly valid status. Why changing it to > > Maintained? > > > > $ ./tools/genboardscfg.py -f > WARNING: Odd Fixes: unknown status for 'arndale' > > If you don't want to maintain then, it would be set to Orphan? I think then the genboardscfg.py should be updated because "Odd fixer" is a valid entry from MAINTAINERS (although not popular). "Odd Fixes: It has a maintainer but they don't have time to do much other than throw the odd patch in. See below.." The board is pretty close to being orphaned but not yet. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arndale: fix unknown status 2019-03-14 8:23 ` Krzysztof Kozlowski @ 2019-03-14 19:23 ` Tom Rini 2019-03-15 13:52 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Tom Rini @ 2019-03-14 19:23 UTC (permalink / raw) To: u-boot On Thu, Mar 14, 2019 at 09:23:53AM +0100, Krzysztof Kozlowski wrote: > On Thu, 14 Mar 2019 at 09:15, Minkyu Kang <mk7.kang@samsung.com> wrote: > > > > Hi, > > > > On 14/03/2019 16:38, Krzysztof Kozlowski wrote: > > > On Thu, 14 Mar 2019 at 05:10, Minkyu Kang <mk7.kang@samsung.com> wrote: > > >> > > >> On 14/03/2019 09:44, Minkyu Kang wrote: > > >>> set status to Maintained > > >>> > > >>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> > > >>> Cc: Krzysztof Kozlowski <krzk@kernel.org> > > >>> --- > > >>> board/samsung/arndale/MAINTAINERS | 2 +- > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> > > >>> diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS > > >>> index 98ccaa4..aa64c7a 100644 > > >>> --- a/board/samsung/arndale/MAINTAINERS > > >>> +++ b/board/samsung/arndale/MAINTAINERS > > >>> @@ -1,6 +1,6 @@ > > >>> ARNDALE BOARD > > >>> M: Krzysztof Kozlowski <krzk@kernel.org> > > >>> -S: Odd Fixes > > >>> +S: Maintained > > >>> F: board/samsung/arndale/ > > >>> F: include/configs/arndale.h > > >>> F: configs/arndale_defconfig > > >>> > > >> > > >> applied to u-boot-samsung. > > > > > > Hi, > > > > > > In the commit changing the maintainer I changed on purpose to Odd > > > Fixes. Because the board is not actively maintained. It is not > > > "unknown status", it is perfectly valid status. Why changing it to > > > Maintained? > > > > > > > $ ./tools/genboardscfg.py -f > > WARNING: Odd Fixes: unknown status for 'arndale' > > > > If you don't want to maintain then, it would be set to Orphan? > > I think then the genboardscfg.py should be updated because "Odd fixer" > is a valid entry from MAINTAINERS (although not popular). > "Odd Fixes: It has a maintainer but they don't have time to do much > other than throw the odd patch in. See below.." > The board is pretty close to being orphaned but not yet. I'm taking your patch to the MAINTAINERS file now. That said, generally "odd fixes" are what's required of board maintainers, once the port is in. However, as we push forward on moving to various frameworks that should make life easier overall, over the long term, changes are needed that may be more than just an occasional fix. Looking at arndale right now for example: arm: w+ arndale +(arndale) ===================== WARNING ====================== +(arndale) This board uses CONFIG_DM_I2C_COMPAT. Please remove +(arndale) (possibly in a subsequent patch in your series) +(arndale) before sending patches to the mailing list. +(arndale) ==================================================== So, do you have time to look into that build time warning? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190314/1292c6b5/attachment.sig> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arndale: fix unknown status 2019-03-14 19:23 ` Tom Rini @ 2019-03-15 13:52 ` Krzysztof Kozlowski 2019-03-15 13:53 ` Tom Rini 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2019-03-15 13:52 UTC (permalink / raw) To: u-boot On Thu, 14 Mar 2019 at 20:24, Tom Rini <trini@konsulko.com> wrote: > I'm taking your patch to the MAINTAINERS file now. That said, generally > "odd fixes" are what's required of board maintainers, once the port is > in. However, as we push forward on moving to various frameworks that > should make life easier overall, over the long term, changes are needed > that may be more than just an occasional fix. Looking at arndale right > now for example: > arm: w+ arndale > +(arndale) ===================== WARNING ====================== > +(arndale) This board uses CONFIG_DM_I2C_COMPAT. Please remove > +(arndale) (possibly in a subsequent patch in your series) > +(arndale) before sending patches to the mailing list. > +(arndale) ==================================================== > > So, do you have time to look into that build time warning? Thanks! Sure, let me take a look. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arndale: fix unknown status 2019-03-15 13:52 ` Krzysztof Kozlowski @ 2019-03-15 13:53 ` Tom Rini 0 siblings, 0 replies; 8+ messages in thread From: Tom Rini @ 2019-03-15 13:53 UTC (permalink / raw) To: u-boot On Fri, Mar 15, 2019 at 02:52:12PM +0100, Krzysztof Kozlowski wrote: > On Thu, 14 Mar 2019 at 20:24, Tom Rini <trini@konsulko.com> wrote: > > I'm taking your patch to the MAINTAINERS file now. That said, generally > > "odd fixes" are what's required of board maintainers, once the port is > > in. However, as we push forward on moving to various frameworks that > > should make life easier overall, over the long term, changes are needed > > that may be more than just an occasional fix. Looking at arndale right > > now for example: > > arm: w+ arndale > > +(arndale) ===================== WARNING ====================== > > +(arndale) This board uses CONFIG_DM_I2C_COMPAT. Please remove > > +(arndale) (possibly in a subsequent patch in your series) > > +(arndale) before sending patches to the mailing list. > > +(arndale) ==================================================== > > > > So, do you have time to look into that build time warning? Thanks! > > Sure, let me take a look. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190315/82f61f42/attachment.sig> ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-15 13:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190314004445epcas1p3ace241b1a00f3237790cb95e2d338794@epcas1p3.samsung.com>
2019-03-14 0:44 ` [U-Boot] [PATCH] arndale: fix unknown status Minkyu Kang
2019-03-14 4:10 ` Minkyu Kang
2019-03-14 7:38 ` Krzysztof Kozlowski
2019-03-14 8:15 ` Minkyu Kang
2019-03-14 8:23 ` Krzysztof Kozlowski
2019-03-14 19:23 ` Tom Rini
2019-03-15 13:52 ` Krzysztof Kozlowski
2019-03-15 13:53 ` Tom Rini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.