From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux.amoon@gmail.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
ulf.hansson@linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCHv3 5/7] ARM: dts: exynos5422: use wp-gpio method to detect sd-card
Date: Fri, 21 Sep 2018 13:12:06 +0200 [thread overview]
Message-ID: <CAJKOXPdUVjG1xR-q-K98RQpqsWzw-emEv2_3x3CoS+XK8cye2Q@mail.gmail.com> (raw)
In-Reply-To: <20180920175826.1284-6-linux.amoon@gmail.com>
On Thu, 20 Sep 2018 at 19:59, Anand Moon <linux.amoon@gmail.com> wrote:
>
> add the Write Protect GPIO property for sdcard, to fix
> the warning message during boot time.
> of_get_named_gpiod_flags: can't parse 'wp-gpios' property of node '/soc/mmc@12220000[0]'
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> New patch to this series.
> If we keep the wp-gpio GPIO_ACTIVE_LOW sdcard boot into RO mode.
> ---
> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> index 03fe02ceae66..475c38bbc99e 100644
> --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> @@ -370,6 +370,7 @@
> cap-sd-highspeed;
> max-frequency = <200000000>;
> cd-gpios = <&gpc2 2 GPIO_ACTIVE_LOW>;
> + wp-gpios = <&gpc4 0 GPIO_ACTIVE_HIGH>;
Two issues here:
1. You need also proper pinctrl setting.
2. On schematics the WP is not connected... so how do you know that it
is active high? How did you test it? How do you want to test it on
microSD?
Best regards,
Krzysztof
> vmmc-supply = <&ldo19_reg>;
> vqmmc-supply = <&ldo13_reg>;
> sd-uhs-sdr50;
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: krzk@kernel.org (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 5/7] ARM: dts: exynos5422: use wp-gpio method to detect sd-card
Date: Fri, 21 Sep 2018 13:12:06 +0200 [thread overview]
Message-ID: <CAJKOXPdUVjG1xR-q-K98RQpqsWzw-emEv2_3x3CoS+XK8cye2Q@mail.gmail.com> (raw)
In-Reply-To: <20180920175826.1284-6-linux.amoon@gmail.com>
On Thu, 20 Sep 2018 at 19:59, Anand Moon <linux.amoon@gmail.com> wrote:
>
> add the Write Protect GPIO property for sdcard, to fix
> the warning message during boot time.
> of_get_named_gpiod_flags: can't parse 'wp-gpios' property of node '/soc/mmc at 12220000[0]'
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> New patch to this series.
> If we keep the wp-gpio GPIO_ACTIVE_LOW sdcard boot into RO mode.
> ---
> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> index 03fe02ceae66..475c38bbc99e 100644
> --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> @@ -370,6 +370,7 @@
> cap-sd-highspeed;
> max-frequency = <200000000>;
> cd-gpios = <&gpc2 2 GPIO_ACTIVE_LOW>;
> + wp-gpios = <&gpc4 0 GPIO_ACTIVE_HIGH>;
Two issues here:
1. You need also proper pinctrl setting.
2. On schematics the WP is not connected... so how do you know that it
is active high? How did you test it? How do you want to test it on
microSD?
Best regards,
Krzysztof
> vmmc-supply = <&ldo19_reg>;
> vqmmc-supply = <&ldo13_reg>;
> sd-uhs-sdr50;
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-09-21 11:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 17:58 [PATCHv3 0/7] Add support for UHS-I on Exynos5422 odroid boards Anand Moon
2018-09-20 17:58 ` Anand Moon
2018-09-20 17:58 ` [PATCHv3 1/7] ARM: dts: exynos5422: Added UHS-I bus speed support Anand Moon
2018-09-20 17:58 ` Anand Moon
2018-09-20 17:58 ` [PATCHv3 2/7] ARM: dts: exynos5422: fix regulator min values of LDO13 for Odroid XU3/XU4 Anand Moon
2018-09-20 17:58 ` Anand Moon
2018-09-20 17:58 ` [PATCHv3 3/7] ARM: dts: exynos5422: update maximum frequency for sdcard to 200MHz Anand Moon
2018-09-20 17:58 ` Anand Moon
2018-09-20 17:58 ` [PATCHv3 4/7] ARM: dts: exynos5422: use cd-gpio method to detect sd-card Anand Moon
2018-09-20 17:58 ` Anand Moon
2018-09-20 17:58 ` [PATCHv3 5/7] ARM: dts: exynos5422: use wp-gpio " Anand Moon
2018-09-20 17:58 ` Anand Moon
2018-09-21 11:12 ` Krzysztof Kozlowski [this message]
2018-09-21 11:12 ` Krzysztof Kozlowski
2018-09-21 11:12 ` Krzysztof Kozlowski
2018-09-21 12:31 ` Anand Moon
2018-09-21 12:31 ` Anand Moon
2018-09-21 12:31 ` Anand Moon
2018-09-21 21:09 ` Krzysztof Kozlowski
2018-09-21 21:09 ` Krzysztof Kozlowski
2018-09-22 7:55 ` Anand Moon
2018-09-22 7:55 ` Anand Moon
2018-09-20 17:58 ` [PATCHv3 6/7] ARM: dts: exynos5422: update maximum frequency for emmc to 200MHz Anand Moon
2018-09-20 17:58 ` Anand Moon
2018-09-20 17:58 ` [PATCHv3 7/7] mmc: dw_mmc-exynos: Add tuning for sdr and ddr timing for USH-I mode Anand Moon
2018-09-20 17:58 ` Anand Moon
2018-09-21 10:55 ` [PATCHv3 0/7] Add support for UHS-I on Exynos5422 odroid boards Krzysztof Kozlowski
2018-09-21 10:55 ` Krzysztof Kozlowski
2018-09-21 10:55 ` Krzysztof Kozlowski
2018-09-21 12:30 ` Anand Moon
2018-09-21 12:30 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPdUVjG1xR-q-K98RQpqsWzw-emEv2_3x3CoS+XK8cye2Q@mail.gmail.com \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.