All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, aford173@gmail.com,
	daniel.baluta@nxp.com, shengjiu.wang@nxp.com, peter.chen@nxp.com,
	alifer.wsdm@gmail.com, abel.vesa@nxp.com, yibin.gong@nxp.com,
	jun.li@nxp.com, l.stach@pengutronix.de,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux-imx@nxp.com
Subject: Re: [PATCH 2/3] arm64: dts: imx8mn: Correct WDOG_B pin configuration
Date: Mon, 12 Oct 2020 08:53:40 +0200	[thread overview]
Message-ID: <CAJKOXPeEnnOU_TYsO2svDCcZyMy7FPQyJkZzOWbDn7P8KhcZmg@mail.gmail.com> (raw)
In-Reply-To: <1602229667-13165-2-git-send-email-Anson.Huang@nxp.com>

On Fri, 9 Oct 2020 at 09:52, Anson Huang <Anson.Huang@nxp.com> wrote:
>
> Different revision of i.MX8MN EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MN boards.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi     | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

The same as patch #1 - you do more than just enable pull up.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: daniel.baluta@nxp.com, peter.chen@nxp.com, abel.vesa@nxp.com,
	devicetree@vger.kernel.org, festevam@gmail.com,
	s.hauer@pengutronix.de,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux-imx@nxp.com, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
	l.stach@pengutronix.de, shawnguo@kernel.org, yibin.gong@nxp.com,
	aford173@gmail.com, shengjiu.wang@nxp.com, alifer.wsdm@gmail.com,
	jun.li@nxp.com
Subject: Re: [PATCH 2/3] arm64: dts: imx8mn: Correct WDOG_B pin configuration
Date: Mon, 12 Oct 2020 08:53:40 +0200	[thread overview]
Message-ID: <CAJKOXPeEnnOU_TYsO2svDCcZyMy7FPQyJkZzOWbDn7P8KhcZmg@mail.gmail.com> (raw)
In-Reply-To: <1602229667-13165-2-git-send-email-Anson.Huang@nxp.com>

On Fri, 9 Oct 2020 at 09:52, Anson Huang <Anson.Huang@nxp.com> wrote:
>
> Different revision of i.MX8MN EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MN boards.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi     | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

The same as patch #1 - you do more than just enable pull up.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-10-12  6:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09  7:47 [PATCH 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration Anson Huang
2020-10-09  7:47 ` Anson Huang
2020-10-09  7:47 ` [PATCH 2/3] arm64: dts: imx8mn: " Anson Huang
2020-10-09  7:47   ` Anson Huang
2020-10-12  6:53   ` Krzysztof Kozlowski [this message]
2020-10-12  6:53     ` Krzysztof Kozlowski
2020-10-09  7:47 ` [PATCH 3/3] arm64: dts: imx8mp-evk: " Anson Huang
2020-10-09  7:47   ` Anson Huang
2020-10-12  6:52 ` [PATCH 1/3] arm64: dts: imx8mm: " Krzysztof Kozlowski
2020-10-12  6:52   ` Krzysztof Kozlowski
2020-10-12 12:38   ` Anson Huang
2020-10-12 12:38     ` Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJKOXPeEnnOU_TYsO2svDCcZyMy7FPQyJkZzOWbDn7P8KhcZmg@mail.gmail.com \
    --to=krzk@kernel.org \
    --cc=Anson.Huang@nxp.com \
    --cc=Linux-imx@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=aford173@gmail.com \
    --cc=alifer.wsdm@gmail.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=jun.li@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.