All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mars Chen <chenxiangrui@huaqin.corp-partner.google.com>
Cc: agross@kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [v2]arm64: dts: qcom: Add sc7180-gelarshie
Date: Thu, 7 Apr 2022 13:32:57 +0200	[thread overview]
Message-ID: <CAJKOXPf38LTFzjP0mDEu0wo3AmTPLgU_jv7t+TXxJTuVtoVkVw@mail.gmail.com> (raw)
In-Reply-To: <20220407075427.41141-1-chenxiangrui@huaqin.corp-partner.google.com>

On Thu, 7 Apr 2022 at 09:54, Mars Chen
<chenxiangrui@huaqin.corp-partner.google.com> wrote:
>
> Add device tree for Gelarshie, a trogdor variant
>
> Signed-off-by: Mars Chen <chenxiangrui@huaqin.corp-partner.google.com>

Your subject is incorrect. Please use `git format-patch -v2`. You
still did not provide a changelog (put under ---) against v1. You
still did not reply to my comments and did not implement them.
https://lore.kernel.org/linux-devicetree/a0eb6bf9-256a-29b1-2211-496df710f531@linaro.org/

If they are unclear, please respond to them, so I can clarify. However
you did not respond but resent without implementing them, so it looks
like you ignore the comments.

This is not a good process. :(

Please read again:
https://elixir.bootlin.com/linux/v5.18-rc1/source/Documentation/process/submitting-patches.rst#L307

I am sorry, but I have to NAK the patch till you respond to my comments.

Best regards,
Krzysztof

  reply	other threads:[~2022-04-07 11:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  7:54 [PATCH] [v2]arm64: dts: qcom: Add sc7180-gelarshie Mars Chen
2022-04-07 11:32 ` Krzysztof Kozlowski [this message]
2022-04-07 16:43 ` Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJKOXPf38LTFzjP0mDEu0wo3AmTPLgU_jv7t+TXxJTuVtoVkVw@mail.gmail.com \
    --to=krzk@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=chenxiangrui@huaqin.corp-partner.google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.