* [PATCH] ARM: dts: Use define for s3c-rtc clock id
@ 2015-03-30 15:21 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2015-03-30 15:21 UTC (permalink / raw)
To: Kukjin Kim, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Cc: Kyungmin Park, Marek Szyprowski, Markus Reichl, Krzysztof Kozlowski
Use a define instead of raw number as a ID for "rtc_src" clock.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg43136.html
---
arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 3905824cac58..d2cbc95364de 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -16,6 +16,7 @@
#include "exynos3250.dtsi"
#include <dt-bindings/input/input.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/clock/samsung,s2mps11.h>
/ {
model = "Samsung Rinato board";
@@ -605,7 +606,7 @@
};
&rtc {
- clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
+ clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
clock-names = "rtc", "rtc_src";
status = "okay";
};
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: Use define for s3c-rtc clock id
@ 2015-03-30 15:21 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2015-03-30 15:21 UTC (permalink / raw)
To: linux-arm-kernel
Use a define instead of raw number as a ID for "rtc_src" clock.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg43136.html
---
arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 3905824cac58..d2cbc95364de 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -16,6 +16,7 @@
#include "exynos3250.dtsi"
#include <dt-bindings/input/input.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/clock/samsung,s2mps11.h>
/ {
model = "Samsung Rinato board";
@@ -605,7 +606,7 @@
};
&rtc {
- clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
+ clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
clock-names = "rtc", "rtc_src";
status = "okay";
};
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id
2015-03-30 15:21 ` Krzysztof Kozlowski
@ 2015-03-31 4:05 ` Chanwoo Choi
-1 siblings, 0 replies; 12+ messages in thread
From: Chanwoo Choi @ 2015-03-31 4:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kukjin Kim, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Kyungmin Park, Marek Szyprowski, Markus Reichl
Hi,
On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
> Use a define instead of raw number as a ID for "rtc_src" clock.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg43136.html
> ---
> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
> index 3905824cac58..d2cbc95364de 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -16,6 +16,7 @@
> #include "exynos3250.dtsi"
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/clock/samsung,s2mps11.h>
>
> / {
> model = "Samsung Rinato board";
> @@ -605,7 +606,7 @@
> };
>
> &rtc {
> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
> clock-names = "rtc", "rtc_src";
> status = "okay";
> };
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: Use define for s3c-rtc clock id
@ 2015-03-31 4:05 ` Chanwoo Choi
0 siblings, 0 replies; 12+ messages in thread
From: Chanwoo Choi @ 2015-03-31 4:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
> Use a define instead of raw number as a ID for "rtc_src" clock.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
> http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg43136.html
> ---
> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
> index 3905824cac58..d2cbc95364de 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -16,6 +16,7 @@
> #include "exynos3250.dtsi"
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/clock/samsung,s2mps11.h>
>
> / {
> model = "Samsung Rinato board";
> @@ -605,7 +606,7 @@
> };
>
> &rtc {
> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
> clock-names = "rtc", "rtc_src";
> status = "okay";
> };
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id
2015-03-31 4:05 ` Chanwoo Choi
(?)
@ 2015-03-31 6:37 ` Javier Martinez Canillas
-1 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2015-03-31 6:37 UTC (permalink / raw)
To: Chanwoo Choi
Cc: Krzysztof Kozlowski, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, Linux Kernel, Kyungmin Park, Marek Szyprowski,
Markus Reichl
On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi,
>
> On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
>> Use a define instead of raw number as a ID for "rtc_src" clock.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> ---
>>
>> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
>> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg43136.html
>> ---
>> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
>> index 3905824cac58..d2cbc95364de 100644
>> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
>> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
>> @@ -16,6 +16,7 @@
>> #include "exynos3250.dtsi"
>> #include <dt-bindings/input/input.h>
>> #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/clock/samsung,s2mps11.h>
>>
>> / {
>> model = "Samsung Rinato board";
>> @@ -605,7 +606,7 @@
>> };
>>
>> &rtc {
>> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
>> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
>> clock-names = "rtc", "rtc_src";
>> status = "okay";
>> };
>>
>
> Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id
@ 2015-03-31 6:37 ` Javier Martinez Canillas
0 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2015-03-31 6:37 UTC (permalink / raw)
To: Chanwoo Choi
Cc: Krzysztof Kozlowski, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, Linux Kernel, Kyungmin Park, Marek Szyprowski,
Markus Reichl
On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi,
>
> On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
>> Use a define instead of raw number as a ID for "rtc_src" clock.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> ---
>>
>> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
>> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg43136.html
>> ---
>> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
>> index 3905824cac58..d2cbc95364de 100644
>> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
>> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
>> @@ -16,6 +16,7 @@
>> #include "exynos3250.dtsi"
>> #include <dt-bindings/input/input.h>
>> #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/clock/samsung,s2mps11.h>
>>
>> / {
>> model = "Samsung Rinato board";
>> @@ -605,7 +606,7 @@
>> };
>>
>> &rtc {
>> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
>> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
>> clock-names = "rtc", "rtc_src";
>> status = "okay";
>> };
>>
>
> Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: Use define for s3c-rtc clock id
@ 2015-03-31 6:37 ` Javier Martinez Canillas
0 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2015-03-31 6:37 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi,
>
> On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
>> Use a define instead of raw number as a ID for "rtc_src" clock.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> ---
>>
>> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
>> http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg43136.html
>> ---
>> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
>> index 3905824cac58..d2cbc95364de 100644
>> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
>> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
>> @@ -16,6 +16,7 @@
>> #include "exynos3250.dtsi"
>> #include <dt-bindings/input/input.h>
>> #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/clock/samsung,s2mps11.h>
>>
>> / {
>> model = "Samsung Rinato board";
>> @@ -605,7 +606,7 @@
>> };
>>
>> &rtc {
>> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
>> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
>> clock-names = "rtc", "rtc_src";
>> status = "okay";
>> };
>>
>
> Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] ARM: dts: Use define for s3c-rtc clock id
2015-03-31 6:37 ` Javier Martinez Canillas
@ 2015-03-31 6:55 ` Kukjin Kim
-1 siblings, 0 replies; 12+ messages in thread
From: Kukjin Kim @ 2015-03-31 6:55 UTC (permalink / raw)
To: 'Javier Martinez Canillas', 'Chanwoo Choi'
Cc: 'Krzysztof Kozlowski', 'Kukjin Kim',
devicetree, linux-arm-kernel, linux-samsung-soc,
'Linux Kernel', 'Kyungmin Park',
'Marek Szyprowski', 'Markus Reichl'
Javier Martinez Canillas wrote:
>
> On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> > Hi,
> >
> > On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
> >> Use a define instead of raw number as a ID for "rtc_src" clock.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >>
> >> ---
> >>
> >> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
> >> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg43136.html
> >> ---
> >> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
> >> index 3905824cac58..d2cbc95364de 100644
> >> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> >> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> >> @@ -16,6 +16,7 @@
> >> #include "exynos3250.dtsi"
> >> #include <dt-bindings/input/input.h>
> >> #include <dt-bindings/gpio/gpio.h>
> >> +#include <dt-bindings/clock/samsung,s2mps11.h>
> >>
> >> / {
> >> model = "Samsung Rinato board";
> >> @@ -605,7 +606,7 @@
> >> };
> >>
> >> &rtc {
> >> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
> >> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
> >> clock-names = "rtc", "rtc_src";
> >> status = "okay";
> >> };
> >>
> >
> > Looks good to me.
> >
> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> >
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
Thanks for you guys' review. Applied.
- Kukjin
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: Use define for s3c-rtc clock id
@ 2015-03-31 6:55 ` Kukjin Kim
0 siblings, 0 replies; 12+ messages in thread
From: Kukjin Kim @ 2015-03-31 6:55 UTC (permalink / raw)
To: linux-arm-kernel
Javier Martinez Canillas wrote:
>
> On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> > Hi,
> >
> > On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
> >> Use a define instead of raw number as a ID for "rtc_src" clock.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >>
> >> ---
> >>
> >> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
> >> http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg43136.html
> >> ---
> >> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
> >> index 3905824cac58..d2cbc95364de 100644
> >> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> >> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> >> @@ -16,6 +16,7 @@
> >> #include "exynos3250.dtsi"
> >> #include <dt-bindings/input/input.h>
> >> #include <dt-bindings/gpio/gpio.h>
> >> +#include <dt-bindings/clock/samsung,s2mps11.h>
> >>
> >> / {
> >> model = "Samsung Rinato board";
> >> @@ -605,7 +606,7 @@
> >> };
> >>
> >> &rtc {
> >> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
> >> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
> >> clock-names = "rtc", "rtc_src";
> >> status = "okay";
> >> };
> >>
> >
> > Looks good to me.
> >
> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> >
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
Thanks for you guys' review. Applied.
- Kukjin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id
2015-03-31 6:55 ` Kukjin Kim
(?)
@ 2015-04-02 10:16 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2015-04-02 10:16 UTC (permalink / raw)
To: Kukjin Kim
Cc: Javier Martinez Canillas, Chanwoo Choi, devicetree,
Krzysztof Kozlowski, linux-samsung-soc, Linux Kernel,
Markus Reichl, Kyungmin Park, linux-arm-kernel, Marek Szyprowski
2015-03-31 8:55 GMT+02:00 Kukjin Kim <kgene@kernel.org>:
> Javier Martinez Canillas wrote:
>>
>> On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> > Hi,
>> >
>> > On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
>> >> Use a define instead of raw number as a ID for "rtc_src" clock.
>> >>
>> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> >>
>> >> ---
>> >>
>> >> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
>> >> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg43136.html
>> >> ---
>> >> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
>> >> 1 file changed, 2 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> index 3905824cac58..d2cbc95364de 100644
>> >> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> @@ -16,6 +16,7 @@
>> >> #include "exynos3250.dtsi"
>> >> #include <dt-bindings/input/input.h>
>> >> #include <dt-bindings/gpio/gpio.h>
>> >> +#include <dt-bindings/clock/samsung,s2mps11.h>
>> >>
>> >> / {
>> >> model = "Samsung Rinato board";
>> >> @@ -605,7 +606,7 @@
>> >> };
>> >>
>> >> &rtc {
>> >> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
>> >> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
>> >> clock-names = "rtc", "rtc_src";
>> >> status = "okay";
>> >> };
>> >>
>> >
>> > Looks good to me.
>> >
>> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>> >
>>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>
> Thanks for you guys' review. Applied.
Thanks Kukjin! I forgot to do this also for exynos3250-monk board.
I'll send another patch for it but you may squash them if you want.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id
@ 2015-04-02 10:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2015-04-02 10:16 UTC (permalink / raw)
To: Kukjin Kim
Cc: Javier Martinez Canillas, Chanwoo Choi,
devicetree-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Linux Kernel,
Markus Reichl, Kyungmin Park,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Marek Szyprowski
2015-03-31 8:55 GMT+02:00 Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
> Javier Martinez Canillas wrote:
>>
>> On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>> > Hi,
>> >
>> > On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
>> >> Use a define instead of raw number as a ID for "rtc_src" clock.
>> >>
>> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> >>
>> >> ---
>> >>
>> >> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
>> >> http://www.mail-archive.com/linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg43136.html
>> >> ---
>> >> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
>> >> 1 file changed, 2 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> index 3905824cac58..d2cbc95364de 100644
>> >> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> @@ -16,6 +16,7 @@
>> >> #include "exynos3250.dtsi"
>> >> #include <dt-bindings/input/input.h>
>> >> #include <dt-bindings/gpio/gpio.h>
>> >> +#include <dt-bindings/clock/samsung,s2mps11.h>
>> >>
>> >> / {
>> >> model = "Samsung Rinato board";
>> >> @@ -605,7 +606,7 @@
>> >> };
>> >>
>> >> &rtc {
>> >> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
>> >> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
>> >> clock-names = "rtc", "rtc_src";
>> >> status = "okay";
>> >> };
>> >>
>> >
>> > Looks good to me.
>> >
>> > Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> >
>>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
>>
> Thanks for you guys' review. Applied.
Thanks Kukjin! I forgot to do this also for exynos3250-monk board.
I'll send another patch for it but you may squash them if you want.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: Use define for s3c-rtc clock id
@ 2015-04-02 10:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2015-04-02 10:16 UTC (permalink / raw)
To: linux-arm-kernel
2015-03-31 8:55 GMT+02:00 Kukjin Kim <kgene@kernel.org>:
> Javier Martinez Canillas wrote:
>>
>> On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> > Hi,
>> >
>> > On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
>> >> Use a define instead of raw number as a ID for "rtc_src" clock.
>> >>
>> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> >>
>> >> ---
>> >>
>> >> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
>> >> http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg43136.html
>> >> ---
>> >> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
>> >> 1 file changed, 2 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> index 3905824cac58..d2cbc95364de 100644
>> >> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> @@ -16,6 +16,7 @@
>> >> #include "exynos3250.dtsi"
>> >> #include <dt-bindings/input/input.h>
>> >> #include <dt-bindings/gpio/gpio.h>
>> >> +#include <dt-bindings/clock/samsung,s2mps11.h>
>> >>
>> >> / {
>> >> model = "Samsung Rinato board";
>> >> @@ -605,7 +606,7 @@
>> >> };
>> >>
>> >> &rtc {
>> >> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
>> >> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
>> >> clock-names = "rtc", "rtc_src";
>> >> status = "okay";
>> >> };
>> >>
>> >
>> > Looks good to me.
>> >
>> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>> >
>>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>
> Thanks for you guys' review. Applied.
Thanks Kukjin! I forgot to do this also for exynos3250-monk board.
I'll send another patch for it but you may squash them if you want.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2015-04-02 10:17 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-30 15:21 [PATCH] ARM: dts: Use define for s3c-rtc clock id Krzysztof Kozlowski
2015-03-30 15:21 ` Krzysztof Kozlowski
2015-03-31 4:05 ` Chanwoo Choi
2015-03-31 4:05 ` Chanwoo Choi
2015-03-31 6:37 ` Javier Martinez Canillas
2015-03-31 6:37 ` Javier Martinez Canillas
2015-03-31 6:37 ` Javier Martinez Canillas
2015-03-31 6:55 ` Kukjin Kim
2015-03-31 6:55 ` Kukjin Kim
2015-04-02 10:16 ` Krzysztof Kozlowski
2015-04-02 10:16 ` Krzysztof Kozlowski
2015-04-02 10:16 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.