[PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Guillaume Tucker]

The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
sequence.  There is no need to set it in the default register value,
this was done before support for it was implemented in the code.  It
is not set in the hardware initial value either.

Clean this up by removing this flag from the default l2c_aux_val, and
add it to the l2c_aux_mask to print an alert message if it was already
set before the kernel initialisation.

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---

Notes:
    v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN

 arch/arm/mach-exynos/exynos.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 36c37444485a..a96f3353a0c1 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -193,8 +193,8 @@ static void __init exynos_dt_fixup(void)
 }
 
 DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)")
-	.l2c_aux_val	= 0x3c400000,
-	.l2c_aux_mask	= 0xc20fffff,
+	.l2c_aux_val	= 0x38400000,
+	.l2c_aux_mask	= 0xc60fffff,
 	.smp		= smp_ops(exynos_smp_ops),
 	.map_io		= exynos_init_io,
 	.init_early	= exynos_firmware_init,
-- 
2.20.1

[PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Guillaume Tucker]

The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
sequence.  There is no need to set it in the default register value,
this was done before support for it was implemented in the code.  It
is not set in the hardware initial value either.

Clean this up by removing this flag from the default l2c_aux_val, and
add it to the l2c_aux_mask to print an alert message if it was already
set before the kernel initialisation.

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---

Notes:
    v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN

 arch/arm/mach-exynos/exynos.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 36c37444485a..a96f3353a0c1 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -193,8 +193,8 @@ static void __init exynos_dt_fixup(void)
 }
 
 DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)")
-	.l2c_aux_val	= 0x3c400000,
-	.l2c_aux_mask	= 0xc20fffff,
+	.l2c_aux_val	= 0x38400000,
+	.l2c_aux_mask	= 0xc60fffff,
 	.smp		= smp_ops(exynos_smp_ops),
 	.map_io		= exynos_init_io,
 	.init_early	= exynos_firmware_init,
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v2 2/4] ARM: l2c: fix prefetch bits init in L2X0_AUX_CTRL using DT values

[Guillaume Tucker]

The L310_PREFETCH_CTRL register bits 28 and 29 to enable data and
instruction prefetch respectively can also be accessed via the
L2X0_AUX_CTRL register.  They appear to be actually wired together in
hardware between the registers.  Changing them in the prefetch
register only will get undone when restoring the aux control register
later on.  For this reason, set these bits in both registers during
initialisation according to the devicetree property values.

Fixes: ec3bd0e68a67 ("ARM: 8391/1: l2c: add options to overwrite prefetching behavior")
Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---

Notes:
    v2: tweak commit message to show this is a fix

 arch/arm/mm/cache-l2x0.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index 12c26eb88afb..43d91bfd2360 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -1249,20 +1249,28 @@ static void __init l2c310_of_parse(const struct device_node *np,
 
 	ret = of_property_read_u32(np, "prefetch-data", &val);
 	if (ret == 0) {
-		if (val)
+		if (val) {
 			prefetch |= L310_PREFETCH_CTRL_DATA_PREFETCH;
-		else
+			*aux_val |= L310_PREFETCH_CTRL_DATA_PREFETCH;
+		} else {
 			prefetch &= ~L310_PREFETCH_CTRL_DATA_PREFETCH;
+			*aux_val &= ~L310_PREFETCH_CTRL_DATA_PREFETCH;
+		}
+		*aux_mask &= ~L310_PREFETCH_CTRL_DATA_PREFETCH;
 	} else if (ret != -EINVAL) {
 		pr_err("L2C-310 OF prefetch-data property value is missing\n");
 	}
 
 	ret = of_property_read_u32(np, "prefetch-instr", &val);
 	if (ret == 0) {
-		if (val)
+		if (val) {
 			prefetch |= L310_PREFETCH_CTRL_INSTR_PREFETCH;
-		else
+			*aux_val |= L310_PREFETCH_CTRL_INSTR_PREFETCH;
+		} else {
 			prefetch &= ~L310_PREFETCH_CTRL_INSTR_PREFETCH;
+			*aux_val &= ~L310_PREFETCH_CTRL_INSTR_PREFETCH;
+		}
+		*aux_mask &= ~L310_PREFETCH_CTRL_INSTR_PREFETCH;
 	} else if (ret != -EINVAL) {
 		pr_err("L2C-310 OF prefetch-instr property value is missing\n");
 	}
-- 
2.20.1

[PATCH v2 2/4] ARM: l2c: fix prefetch bits init in L2X0_AUX_CTRL using DT values

[Guillaume Tucker]

The L310_PREFETCH_CTRL register bits 28 and 29 to enable data and
instruction prefetch respectively can also be accessed via the
L2X0_AUX_CTRL register.  They appear to be actually wired together in
hardware between the registers.  Changing them in the prefetch
register only will get undone when restoring the aux control register
later on.  For this reason, set these bits in both registers during
initialisation according to the devicetree property values.

Fixes: ec3bd0e68a67 ("ARM: 8391/1: l2c: add options to overwrite prefetching behavior")
Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---

Notes:
    v2: tweak commit message to show this is a fix

 arch/arm/mm/cache-l2x0.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index 12c26eb88afb..43d91bfd2360 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -1249,20 +1249,28 @@ static void __init l2c310_of_parse(const struct device_node *np,
 
 	ret = of_property_read_u32(np, "prefetch-data", &val);
 	if (ret == 0) {
-		if (val)
+		if (val) {
 			prefetch |= L310_PREFETCH_CTRL_DATA_PREFETCH;
-		else
+			*aux_val |= L310_PREFETCH_CTRL_DATA_PREFETCH;
+		} else {
 			prefetch &= ~L310_PREFETCH_CTRL_DATA_PREFETCH;
+			*aux_val &= ~L310_PREFETCH_CTRL_DATA_PREFETCH;
+		}
+		*aux_mask &= ~L310_PREFETCH_CTRL_DATA_PREFETCH;
 	} else if (ret != -EINVAL) {
 		pr_err("L2C-310 OF prefetch-data property value is missing\n");
 	}
 
 	ret = of_property_read_u32(np, "prefetch-instr", &val);
 	if (ret == 0) {
-		if (val)
+		if (val) {
 			prefetch |= L310_PREFETCH_CTRL_INSTR_PREFETCH;
-		else
+			*aux_val |= L310_PREFETCH_CTRL_INSTR_PREFETCH;
+		} else {
 			prefetch &= ~L310_PREFETCH_CTRL_INSTR_PREFETCH;
+			*aux_val &= ~L310_PREFETCH_CTRL_INSTR_PREFETCH;
+		}
+		*aux_mask &= ~L310_PREFETCH_CTRL_INSTR_PREFETCH;
 	} else if (ret != -EINVAL) {
 		pr_err("L2C-310 OF prefetch-instr property value is missing\n");
 	}
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v2 3/4] ARM: dts: exynos: add prefetch properties for L2C-310 cache

[Guillaume Tucker]

Add the devicetree properties to enable instruction and data prefetch
on exynos4210 and exynos4412 which use the L2C-310 cache.  No other
Exynos chip appears to be using this L2 cache hardware.

This follows the default bits being set in the l2c_aux_val register
for the Exynos platform, which can now be cleared as a result.

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---

Notes:
    v2: split patch to include devicetree changes only

 arch/arm/boot/dts/exynos4210.dtsi | 2 ++
 arch/arm/boot/dts/exynos4412.dtsi | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index b4466232f0c1..7e0d253b26ef 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -102,6 +102,8 @@
 			reg = <0x10502000 0x1000>;
 			cache-unified;
 			cache-level = <2>;
+			prefetch-data = <1>;
+			prefetch-instr = <1>;
 			arm,tag-latency = <2 2 1>;
 			arm,data-latency = <2 2 1>;
 		};
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index 48868947373e..37efa247bf4d 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -218,6 +218,8 @@
 			reg = <0x10502000 0x1000>;
 			cache-unified;
 			cache-level = <2>;
+			prefetch-data = <1>;
+			prefetch-instr = <1>;
 			arm,tag-latency = <2 2 1>;
 			arm,data-latency = <3 2 1>;
 			arm,double-linefill = <1>;
-- 
2.20.1

[PATCH v2 3/4] ARM: dts: exynos: add prefetch properties for L2C-310 cache

[Guillaume Tucker]

Add the devicetree properties to enable instruction and data prefetch
on exynos4210 and exynos4412 which use the L2C-310 cache.  No other
Exynos chip appears to be using this L2 cache hardware.

This follows the default bits being set in the l2c_aux_val register
for the Exynos platform, which can now be cleared as a result.

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---

Notes:
    v2: split patch to include devicetree changes only

 arch/arm/boot/dts/exynos4210.dtsi | 2 ++
 arch/arm/boot/dts/exynos4412.dtsi | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index b4466232f0c1..7e0d253b26ef 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -102,6 +102,8 @@
 			reg = <0x10502000 0x1000>;
 			cache-unified;
 			cache-level = <2>;
+			prefetch-data = <1>;
+			prefetch-instr = <1>;
 			arm,tag-latency = <2 2 1>;
 			arm,data-latency = <2 2 1>;
 		};
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index 48868947373e..37efa247bf4d 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -218,6 +218,8 @@
 			reg = <0x10502000 0x1000>;
 			cache-unified;
 			cache-level = <2>;
+			prefetch-data = <1>;
+			prefetch-instr = <1>;
 			arm,tag-latency = <2 2 1>;
 			arm,data-latency = <3 2 1>;
 			arm,double-linefill = <1>;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v2 4/4] ARM: exynos: clear prefetch bits in default l2c_aux_val

[Guillaume Tucker]

Clear the L310_AUX_CTRL_DATA_PREFETCH and L310_AUX_CTRL_INSTR_PREFETCH
bits in the l2c_aux_val defaults for Exynos since they can now be set
using the standard l2c2x0 devicetree bindings.

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---

Notes:
    v2: split patch to only clear exynos platform register bits

 arch/arm/mach-exynos/exynos.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index a96f3353a0c1..0e906cc3a48e 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -193,8 +193,8 @@ static void __init exynos_dt_fixup(void)
 }
 
 DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)")
-	.l2c_aux_val	= 0x38400000,
-	.l2c_aux_mask	= 0xc60fffff,
+	.l2c_aux_val	= 0x08400000,
+	.l2c_aux_mask	= 0xf60fffff,
 	.smp		= smp_ops(exynos_smp_ops),
 	.map_io		= exynos_init_io,
 	.init_early	= exynos_firmware_init,
-- 
2.20.1

[PATCH v2 4/4] ARM: exynos: clear prefetch bits in default l2c_aux_val

[Guillaume Tucker]

Clear the L310_AUX_CTRL_DATA_PREFETCH and L310_AUX_CTRL_INSTR_PREFETCH
bits in the l2c_aux_val defaults for Exynos since they can now be set
using the standard l2c2x0 devicetree bindings.

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---

Notes:
    v2: split patch to only clear exynos platform register bits

 arch/arm/mach-exynos/exynos.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index a96f3353a0c1..0e906cc3a48e 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -193,8 +193,8 @@ static void __init exynos_dt_fixup(void)
 }
 
 DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)")
-	.l2c_aux_val	= 0x38400000,
-	.l2c_aux_mask	= 0xc60fffff,
+	.l2c_aux_val	= 0x08400000,
+	.l2c_aux_mask	= 0xf60fffff,
 	.smp		= smp_ops(exynos_smp_ops),
 	.map_io		= exynos_init_io,
 	.init_early	= exynos_firmware_init,
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Guillaume Tucker]

Hi Krzysztof, Russell,

On 10/08/2020 13:22, Guillaume Tucker wrote:
> The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
> sequence.  There is no need to set it in the default register value,
> this was done before support for it was implemented in the code.  It
> is not set in the hardware initial value either.
> 
> Clean this up by removing this flag from the default l2c_aux_val, and
> add it to the l2c_aux_mask to print an alert message if it was already
> set before the kernel initialisation.
> 
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> ---
> 
> Notes:
>     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
> 
>  arch/arm/mach-exynos/exynos.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I believe this v2 series has addressed all previous comments and
you were waiting for the 5.9 merge window to end.  The patches
all still apply cleanly on v5.9-rc3.  Do you want me to resend
the series anyway or is there anything else needed at this point?

Maybe one thing that wasn't completely clear in v1 was whether
patch 2/4 was the right approach.  I've explained the reason
behind it but didn't get a final reply from Russell[1].

Best wishes,
Guillaume


[1] https://lore.kernel.org/lkml/46fa1159-fcd6-b528-b8e8-2fba048236b2@collabora.com/


> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index 36c37444485a..a96f3353a0c1 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -193,8 +193,8 @@ static void __init exynos_dt_fixup(void)
>  }
>  
>  DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)")
> -	.l2c_aux_val	= 0x3c400000,
> -	.l2c_aux_mask	= 0xc20fffff,
> +	.l2c_aux_val	= 0x38400000,
> +	.l2c_aux_mask	= 0xc60fffff,
>  	.smp		= smp_ops(exynos_smp_ops),
>  	.map_io		= exynos_init_io,
>  	.init_early	= exynos_firmware_init,
> 

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Guillaume Tucker]

Hi Krzysztof, Russell,

On 10/08/2020 13:22, Guillaume Tucker wrote:
> The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
> sequence.  There is no need to set it in the default register value,
> this was done before support for it was implemented in the code.  It
> is not set in the hardware initial value either.
> 
> Clean this up by removing this flag from the default l2c_aux_val, and
> add it to the l2c_aux_mask to print an alert message if it was already
> set before the kernel initialisation.
> 
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> ---
> 
> Notes:
>     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
> 
>  arch/arm/mach-exynos/exynos.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I believe this v2 series has addressed all previous comments and
you were waiting for the 5.9 merge window to end.  The patches
all still apply cleanly on v5.9-rc3.  Do you want me to resend
the series anyway or is there anything else needed at this point?

Maybe one thing that wasn't completely clear in v1 was whether
patch 2/4 was the right approach.  I've explained the reason
behind it but didn't get a final reply from Russell[1].

Best wishes,
Guillaume


[1] https://lore.kernel.org/lkml/46fa1159-fcd6-b528-b8e8-2fba048236b2@collabora.com/


> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index 36c37444485a..a96f3353a0c1 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -193,8 +193,8 @@ static void __init exynos_dt_fixup(void)
>  }
>  
>  DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)")
> -	.l2c_aux_val	= 0x3c400000,
> -	.l2c_aux_mask	= 0xc20fffff,
> +	.l2c_aux_val	= 0x38400000,
> +	.l2c_aux_mask	= 0xc60fffff,
>  	.smp		= smp_ops(exynos_smp_ops),
>  	.map_io		= exynos_init_io,
>  	.init_early	= exynos_firmware_init,
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Krzysztof Kozlowski]

On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker
<guillaume.tucker@collabora.com> wrote:
>
> Hi Krzysztof, Russell,
>
> On 10/08/2020 13:22, Guillaume Tucker wrote:
> > The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
> > sequence.  There is no need to set it in the default register value,
> > this was done before support for it was implemented in the code.  It
> > is not set in the hardware initial value either.
> >
> > Clean this up by removing this flag from the default l2c_aux_val, and
> > add it to the l2c_aux_mask to print an alert message if it was already
> > set before the kernel initialisation.
> >
> > Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> > ---
> >
> > Notes:
> >     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
> >
> >  arch/arm/mach-exynos/exynos.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> I believe this v2 series has addressed all previous comments and
> you were waiting for the 5.9 merge window to end.  The patches
> all still apply cleanly on v5.9-rc3.  Do you want me to resend
> the series anyway or is there anything else needed at this point?
>
> Maybe one thing that wasn't completely clear in v1 was whether
> patch 2/4 was the right approach.  I've explained the reason
> behind it but didn't get a final reply from Russell[1].

I am sorry, my bad. I already applied this one and 3/4 (dts).
Apparently I forgot to reply with confirmation and Patchwork did not
notify you for some reason.

Patch 2/4 does not look like one for me so I would need ack from
Russell to take. Did you submit it to the ARM patches queue?
Patch 4/4 will wait for v5.10-rc1 as it depends on 1/4 and it is DTS patch.

Best regards,
Krzysztof

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Krzysztof Kozlowski]

On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker
<guillaume.tucker@collabora.com> wrote:
>
> Hi Krzysztof, Russell,
>
> On 10/08/2020 13:22, Guillaume Tucker wrote:
> > The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
> > sequence.  There is no need to set it in the default register value,
> > this was done before support for it was implemented in the code.  It
> > is not set in the hardware initial value either.
> >
> > Clean this up by removing this flag from the default l2c_aux_val, and
> > add it to the l2c_aux_mask to print an alert message if it was already
> > set before the kernel initialisation.
> >
> > Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> > ---
> >
> > Notes:
> >     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
> >
> >  arch/arm/mach-exynos/exynos.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> I believe this v2 series has addressed all previous comments and
> you were waiting for the 5.9 merge window to end.  The patches
> all still apply cleanly on v5.9-rc3.  Do you want me to resend
> the series anyway or is there anything else needed at this point?
>
> Maybe one thing that wasn't completely clear in v1 was whether
> patch 2/4 was the right approach.  I've explained the reason
> behind it but didn't get a final reply from Russell[1].

I am sorry, my bad. I already applied this one and 3/4 (dts).
Apparently I forgot to reply with confirmation and Patchwork did not
notify you for some reason.

Patch 2/4 does not look like one for me so I would need ack from
Russell to take. Did you submit it to the ARM patches queue?
Patch 4/4 will wait for v5.10-rc1 as it depends on 1/4 and it is DTS patch.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Krzysztof Kozlowski]

On Tue, 1 Sep 2020 at 15:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker
> <guillaume.tucker@collabora.com> wrote:
> >
> > Hi Krzysztof, Russell,
> >
> > On 10/08/2020 13:22, Guillaume Tucker wrote:
> > > The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
> > > sequence.  There is no need to set it in the default register value,
> > > this was done before support for it was implemented in the code.  It
> > > is not set in the hardware initial value either.
> > >
> > > Clean this up by removing this flag from the default l2c_aux_val, and
> > > add it to the l2c_aux_mask to print an alert message if it was already
> > > set before the kernel initialisation.
> > >
> > > Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> > > ---
> > >
> > > Notes:
> > >     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
> > >
> > >  arch/arm/mach-exynos/exynos.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > I believe this v2 series has addressed all previous comments and
> > you were waiting for the 5.9 merge window to end.  The patches
> > all still apply cleanly on v5.9-rc3.  Do you want me to resend
> > the series anyway or is there anything else needed at this point?
> >
> > Maybe one thing that wasn't completely clear in v1 was whether
> > patch 2/4 was the right approach.  I've explained the reason
> > behind it but didn't get a final reply from Russell[1].
>
> I am sorry, my bad. I already applied this one and 3/4 (dts).
> Apparently I forgot to reply with confirmation and Patchwork did not
> notify you for some reason.
>
> Patch 2/4 does not look like one for me so I would need ack from
> Russell to take. Did you submit it to the ARM patches queue?
> Patch 4/4 will wait for v5.10-rc1 as it depends on 1/4 and it is DTS patch.

Correct: Patch 4/4 will wait for v5.10 because it depends on the DTS patch.

Best regards,
Krzysztof

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Krzysztof Kozlowski]

On Tue, 1 Sep 2020 at 15:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker
> <guillaume.tucker@collabora.com> wrote:
> >
> > Hi Krzysztof, Russell,
> >
> > On 10/08/2020 13:22, Guillaume Tucker wrote:
> > > The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
> > > sequence.  There is no need to set it in the default register value,
> > > this was done before support for it was implemented in the code.  It
> > > is not set in the hardware initial value either.
> > >
> > > Clean this up by removing this flag from the default l2c_aux_val, and
> > > add it to the l2c_aux_mask to print an alert message if it was already
> > > set before the kernel initialisation.
> > >
> > > Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> > > ---
> > >
> > > Notes:
> > >     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
> > >
> > >  arch/arm/mach-exynos/exynos.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > I believe this v2 series has addressed all previous comments and
> > you were waiting for the 5.9 merge window to end.  The patches
> > all still apply cleanly on v5.9-rc3.  Do you want me to resend
> > the series anyway or is there anything else needed at this point?
> >
> > Maybe one thing that wasn't completely clear in v1 was whether
> > patch 2/4 was the right approach.  I've explained the reason
> > behind it but didn't get a final reply from Russell[1].
>
> I am sorry, my bad. I already applied this one and 3/4 (dts).
> Apparently I forgot to reply with confirmation and Patchwork did not
> notify you for some reason.
>
> Patch 2/4 does not look like one for me so I would need ack from
> Russell to take. Did you submit it to the ARM patches queue?
> Patch 4/4 will wait for v5.10-rc1 as it depends on 1/4 and it is DTS patch.

Correct: Patch 4/4 will wait for v5.10 because it depends on the DTS patch.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Guillaume Tucker]

On 01/09/2020 14:51, Krzysztof Kozlowski wrote:
> On Tue, 1 Sep 2020 at 15:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker
>> <guillaume.tucker@collabora.com> wrote:
>>>
>>> Hi Krzysztof, Russell,
>>>
>>> On 10/08/2020 13:22, Guillaume Tucker wrote:
>>>> The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
>>>> sequence.  There is no need to set it in the default register value,
>>>> this was done before support for it was implemented in the code.  It
>>>> is not set in the hardware initial value either.
>>>>
>>>> Clean this up by removing this flag from the default l2c_aux_val, and
>>>> add it to the l2c_aux_mask to print an alert message if it was already
>>>> set before the kernel initialisation.
>>>>
>>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>>>> ---
>>>>
>>>> Notes:
>>>>     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
>>>>
>>>>  arch/arm/mach-exynos/exynos.c | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> I believe this v2 series has addressed all previous comments and
>>> you were waiting for the 5.9 merge window to end.  The patches
>>> all still apply cleanly on v5.9-rc3.  Do you want me to resend
>>> the series anyway or is there anything else needed at this point?
>>>
>>> Maybe one thing that wasn't completely clear in v1 was whether
>>> patch 2/4 was the right approach.  I've explained the reason
>>> behind it but didn't get a final reply from Russell[1].
>>
>> I am sorry, my bad. I already applied this one and 3/4 (dts).
>> Apparently I forgot to reply with confirmation and Patchwork did not
>> notify you for some reason.

No problem, I see them in linux-next now.  Thanks!

>> Patch 2/4 does not look like one for me so I would need ack from
>> Russell to take. Did you submit it to the ARM patches queue?

I've CC-ed linux-arm-kernel@lists.infradead.org on the whole
series.  Did you mean anything else by the ARM patches queue?

>> Patch 4/4 will wait for v5.10-rc1 as it depends on 1/4 and it is DTS patch.
> 
> Correct: Patch 4/4 will wait for v5.10 because it depends on the DTS patch.

Sure, in fact patch 4/4 depends on the DTS one (3/4) and also on
the l2c fix (2/4) as otherwise prefetch would actually not be
enabled.  So it sounds like both remaining ones 2/4 and 4/4 are
actually now pending Russell's ack.

Best wishes,
Guillaume


[1] https://lore.kernel.org/lkml/46fa1159-fcd6-b528-b8e8-2fba048236b2@collabora.com/

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Guillaume Tucker]

On 01/09/2020 14:51, Krzysztof Kozlowski wrote:
> On Tue, 1 Sep 2020 at 15:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker
>> <guillaume.tucker@collabora.com> wrote:
>>>
>>> Hi Krzysztof, Russell,
>>>
>>> On 10/08/2020 13:22, Guillaume Tucker wrote:
>>>> The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
>>>> sequence.  There is no need to set it in the default register value,
>>>> this was done before support for it was implemented in the code.  It
>>>> is not set in the hardware initial value either.
>>>>
>>>> Clean this up by removing this flag from the default l2c_aux_val, and
>>>> add it to the l2c_aux_mask to print an alert message if it was already
>>>> set before the kernel initialisation.
>>>>
>>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>>>> ---
>>>>
>>>> Notes:
>>>>     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
>>>>
>>>>  arch/arm/mach-exynos/exynos.c | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> I believe this v2 series has addressed all previous comments and
>>> you were waiting for the 5.9 merge window to end.  The patches
>>> all still apply cleanly on v5.9-rc3.  Do you want me to resend
>>> the series anyway or is there anything else needed at this point?
>>>
>>> Maybe one thing that wasn't completely clear in v1 was whether
>>> patch 2/4 was the right approach.  I've explained the reason
>>> behind it but didn't get a final reply from Russell[1].
>>
>> I am sorry, my bad. I already applied this one and 3/4 (dts).
>> Apparently I forgot to reply with confirmation and Patchwork did not
>> notify you for some reason.

No problem, I see them in linux-next now.  Thanks!

>> Patch 2/4 does not look like one for me so I would need ack from
>> Russell to take. Did you submit it to the ARM patches queue?

I've CC-ed linux-arm-kernel@lists.infradead.org on the whole
series.  Did you mean anything else by the ARM patches queue?

>> Patch 4/4 will wait for v5.10-rc1 as it depends on 1/4 and it is DTS patch.
> 
> Correct: Patch 4/4 will wait for v5.10 because it depends on the DTS patch.

Sure, in fact patch 4/4 depends on the DTS one (3/4) and also on
the l2c fix (2/4) as otherwise prefetch would actually not be
enabled.  So it sounds like both remaining ones 2/4 and 4/4 are
actually now pending Russell's ack.

Best wishes,
Guillaume


[1] https://lore.kernel.org/lkml/46fa1159-fcd6-b528-b8e8-2fba048236b2@collabora.com/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Krzysztof Kozlowski]

On Tue, 1 Sep 2020 at 16:42, Guillaume Tucker
<guillaume.tucker@collabora.com> wrote:
>
> On 01/09/2020 14:51, Krzysztof Kozlowski wrote:
> > On Tue, 1 Sep 2020 at 15:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker
> >> <guillaume.tucker@collabora.com> wrote:
> >>>
> >>> Hi Krzysztof, Russell,
> >>>
> >>> On 10/08/2020 13:22, Guillaume Tucker wrote:
> >>>> The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
> >>>> sequence.  There is no need to set it in the default register value,
> >>>> this was done before support for it was implemented in the code.  It
> >>>> is not set in the hardware initial value either.
> >>>>
> >>>> Clean this up by removing this flag from the default l2c_aux_val, and
> >>>> add it to the l2c_aux_mask to print an alert message if it was already
> >>>> set before the kernel initialisation.
> >>>>
> >>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> >>>> ---
> >>>>
> >>>> Notes:
> >>>>     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
> >>>>
> >>>>  arch/arm/mach-exynos/exynos.c | 4 ++--
> >>>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> I believe this v2 series has addressed all previous comments and
> >>> you were waiting for the 5.9 merge window to end.  The patches
> >>> all still apply cleanly on v5.9-rc3.  Do you want me to resend
> >>> the series anyway or is there anything else needed at this point?
> >>>
> >>> Maybe one thing that wasn't completely clear in v1 was whether
> >>> patch 2/4 was the right approach.  I've explained the reason
> >>> behind it but didn't get a final reply from Russell[1].
> >>
> >> I am sorry, my bad. I already applied this one and 3/4 (dts).
> >> Apparently I forgot to reply with confirmation and Patchwork did not
> >> notify you for some reason.
>
> No problem, I see them in linux-next now.  Thanks!
>
> >> Patch 2/4 does not look like one for me so I would need ack from
> >> Russell to take. Did you submit it to the ARM patches queue?
>
> I've CC-ed linux-arm-kernel@lists.infradead.org on the whole
> series.  Did you mean anything else by the ARM patches queue?

Unless anything changed, so far all ARM-core related patches had to be
submitted to Russell's system. I didn't submit anything for 3 years so
maybe something changed...
https://www.arm.linux.org.uk/developer/patches/

Best regards,
Krzysztof

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Krzysztof Kozlowski]

On Tue, 1 Sep 2020 at 16:42, Guillaume Tucker
<guillaume.tucker@collabora.com> wrote:
>
> On 01/09/2020 14:51, Krzysztof Kozlowski wrote:
> > On Tue, 1 Sep 2020 at 15:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker
> >> <guillaume.tucker@collabora.com> wrote:
> >>>
> >>> Hi Krzysztof, Russell,
> >>>
> >>> On 10/08/2020 13:22, Guillaume Tucker wrote:
> >>>> The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
> >>>> sequence.  There is no need to set it in the default register value,
> >>>> this was done before support for it was implemented in the code.  It
> >>>> is not set in the hardware initial value either.
> >>>>
> >>>> Clean this up by removing this flag from the default l2c_aux_val, and
> >>>> add it to the l2c_aux_mask to print an alert message if it was already
> >>>> set before the kernel initialisation.
> >>>>
> >>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> >>>> ---
> >>>>
> >>>> Notes:
> >>>>     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
> >>>>
> >>>>  arch/arm/mach-exynos/exynos.c | 4 ++--
> >>>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> I believe this v2 series has addressed all previous comments and
> >>> you were waiting for the 5.9 merge window to end.  The patches
> >>> all still apply cleanly on v5.9-rc3.  Do you want me to resend
> >>> the series anyway or is there anything else needed at this point?
> >>>
> >>> Maybe one thing that wasn't completely clear in v1 was whether
> >>> patch 2/4 was the right approach.  I've explained the reason
> >>> behind it but didn't get a final reply from Russell[1].
> >>
> >> I am sorry, my bad. I already applied this one and 3/4 (dts).
> >> Apparently I forgot to reply with confirmation and Patchwork did not
> >> notify you for some reason.
>
> No problem, I see them in linux-next now.  Thanks!
>
> >> Patch 2/4 does not look like one for me so I would need ack from
> >> Russell to take. Did you submit it to the ARM patches queue?
>
> I've CC-ed linux-arm-kernel@lists.infradead.org on the whole
> series.  Did you mean anything else by the ARM patches queue?

Unless anything changed, so far all ARM-core related patches had to be
submitted to Russell's system. I didn't submit anything for 3 years so
maybe something changed...
https://www.arm.linux.org.uk/developer/patches/

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Guillaume Tucker]

On 01/09/2020 16:25, Krzysztof Kozlowski wrote:
> On Tue, 1 Sep 2020 at 16:42, Guillaume Tucker
> <guillaume.tucker@collabora.com> wrote:
>>
>> On 01/09/2020 14:51, Krzysztof Kozlowski wrote:
>>> On Tue, 1 Sep 2020 at 15:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>>
>>>> On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker
>>>> <guillaume.tucker@collabora.com> wrote:
>>>>>
>>>>> Hi Krzysztof, Russell,
>>>>>
>>>>> On 10/08/2020 13:22, Guillaume Tucker wrote:
>>>>>> The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
>>>>>> sequence.  There is no need to set it in the default register value,
>>>>>> this was done before support for it was implemented in the code.  It
>>>>>> is not set in the hardware initial value either.
>>>>>>
>>>>>> Clean this up by removing this flag from the default l2c_aux_val, and
>>>>>> add it to the l2c_aux_mask to print an alert message if it was already
>>>>>> set before the kernel initialisation.
>>>>>>
>>>>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>>>>>> ---
>>>>>>
>>>>>> Notes:
>>>>>>     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
>>>>>>
>>>>>>  arch/arm/mach-exynos/exynos.c | 4 ++--
>>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> I believe this v2 series has addressed all previous comments and
>>>>> you were waiting for the 5.9 merge window to end.  The patches
>>>>> all still apply cleanly on v5.9-rc3.  Do you want me to resend
>>>>> the series anyway or is there anything else needed at this point?
>>>>>
>>>>> Maybe one thing that wasn't completely clear in v1 was whether
>>>>> patch 2/4 was the right approach.  I've explained the reason
>>>>> behind it but didn't get a final reply from Russell[1].
>>>>
>>>> I am sorry, my bad. I already applied this one and 3/4 (dts).
>>>> Apparently I forgot to reply with confirmation and Patchwork did not
>>>> notify you for some reason.
>>
>> No problem, I see them in linux-next now.  Thanks!
>>
>>>> Patch 2/4 does not look like one for me so I would need ack from
>>>> Russell to take. Did you submit it to the ARM patches queue?
>>
>> I've CC-ed linux-arm-kernel@lists.infradead.org on the whole
>> series.  Did you mean anything else by the ARM patches queue?
> 
> Unless anything changed, so far all ARM-core related patches had to be
> submitted to Russell's system. I didn't submit anything for 3 years so
> maybe something changed...
> https://www.arm.linux.org.uk/developer/patches/

Ah yes, thanks.  I hadn't visited that website for ages...  The
patch 2/4 is there now:

  https://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=9007/1

Best wishes,
Guillaume

Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

[Guillaume Tucker]

On 01/09/2020 16:25, Krzysztof Kozlowski wrote:
> On Tue, 1 Sep 2020 at 16:42, Guillaume Tucker
> <guillaume.tucker@collabora.com> wrote:
>>
>> On 01/09/2020 14:51, Krzysztof Kozlowski wrote:
>>> On Tue, 1 Sep 2020 at 15:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>>
>>>> On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker
>>>> <guillaume.tucker@collabora.com> wrote:
>>>>>
>>>>> Hi Krzysztof, Russell,
>>>>>
>>>>> On 10/08/2020 13:22, Guillaume Tucker wrote:
>>>>>> The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable
>>>>>> sequence.  There is no need to set it in the default register value,
>>>>>> this was done before support for it was implemented in the code.  It
>>>>>> is not set in the hardware initial value either.
>>>>>>
>>>>>> Clean this up by removing this flag from the default l2c_aux_val, and
>>>>>> add it to the l2c_aux_mask to print an alert message if it was already
>>>>>> set before the kernel initialisation.
>>>>>>
>>>>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>>>>>> ---
>>>>>>
>>>>>> Notes:
>>>>>>     v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN
>>>>>>
>>>>>>  arch/arm/mach-exynos/exynos.c | 4 ++--
>>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> I believe this v2 series has addressed all previous comments and
>>>>> you were waiting for the 5.9 merge window to end.  The patches
>>>>> all still apply cleanly on v5.9-rc3.  Do you want me to resend
>>>>> the series anyway or is there anything else needed at this point?
>>>>>
>>>>> Maybe one thing that wasn't completely clear in v1 was whether
>>>>> patch 2/4 was the right approach.  I've explained the reason
>>>>> behind it but didn't get a final reply from Russell[1].
>>>>
>>>> I am sorry, my bad. I already applied this one and 3/4 (dts).
>>>> Apparently I forgot to reply with confirmation and Patchwork did not
>>>> notify you for some reason.
>>
>> No problem, I see them in linux-next now.  Thanks!
>>
>>>> Patch 2/4 does not look like one for me so I would need ack from
>>>> Russell to take. Did you submit it to the ARM patches queue?
>>
>> I've CC-ed linux-arm-kernel@lists.infradead.org on the whole
>> series.  Did you mean anything else by the ARM patches queue?
> 
> Unless anything changed, so far all ARM-core related patches had to be
> submitted to Russell's system. I didn't submit anything for 3 years so
> maybe something changed...
> https://www.arm.linux.org.uk/developer/patches/

Ah yes, thanks.  I hadn't visited that website for ages...  The
patch 2/4 is there now:

  https://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=9007/1

Best wishes,
Guillaume

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 4/4] ARM: exynos: clear prefetch bits in default l2c_aux_val

[Krzysztof Kozlowski]

On Mon, Aug 10, 2020 at 01:22:08PM +0100, Guillaume Tucker wrote:
> Clear the L310_AUX_CTRL_DATA_PREFETCH and L310_AUX_CTRL_INSTR_PREFETCH
> bits in the l2c_aux_val defaults for Exynos since they can now be set
> using the standard l2c2x0 devicetree bindings.
> 
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> ---
> 
> Notes:
>     v2: split patch to only clear exynos platform register bits
> 
>  arch/arm/mach-exynos/exynos.c | 4 ++--

Thanks, applied.

Best regards,
Krzysztof

Re: [PATCH v2 4/4] ARM: exynos: clear prefetch bits in default l2c_aux_val

[Krzysztof Kozlowski]

On Mon, Aug 10, 2020 at 01:22:08PM +0100, Guillaume Tucker wrote:
> Clear the L310_AUX_CTRL_DATA_PREFETCH and L310_AUX_CTRL_INSTR_PREFETCH
> bits in the l2c_aux_val defaults for Exynos since they can now be set
> using the standard l2c2x0 devicetree bindings.
> 
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> ---
> 
> Notes:
>     v2: split patch to only clear exynos platform register bits
> 
>  arch/arm/mach-exynos/exynos.c | 4 ++--

Thanks, applied.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel