* [PATCH] rtc: s5m: terminate s5m_rtc_id array with empty element
@ 2015-01-21 15:06 Andrey Ryabinin
2015-01-22 9:37 ` [rtc-linux] " Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Andrey Ryabinin @ 2015-01-21 15:06 UTC (permalink / raw)
To: linux-kernel, Alessandro Zummo, open list:REAL TIME CLOCK (...)
Cc: Andrey Ryabinin
Array of platform_device_id elements should be terminated
with empty element.
Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
---
drivers/rtc/rtc-s5m.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index b5e7c46..89ac1d5 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -832,6 +832,7 @@ static SIMPLE_DEV_PM_OPS(s5m_rtc_pm_ops, s5m_rtc_suspend, s5m_rtc_resume);
static const struct platform_device_id s5m_rtc_id[] = {
{ "s5m-rtc", S5M8767X },
{ "s2mps14-rtc", S2MPS14X },
+ { },
};
static struct platform_driver s5m_rtc_driver = {
--
2.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [rtc-linux] [PATCH] rtc: s5m: terminate s5m_rtc_id array with empty element
2015-01-21 15:06 [PATCH] rtc: s5m: terminate s5m_rtc_id array with empty element Andrey Ryabinin
@ 2015-01-22 9:37 ` Krzysztof Kozlowski
2015-01-22 12:01 ` Andrey Ryabinin
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-22 9:37 UTC (permalink / raw)
To: rtc-linux; +Cc: linux-kernel, Alessandro Zummo, Andrey Ryabinin
2015-01-21 16:06 GMT+01:00 Andrey Ryabinin <a.ryabinin@samsung.com>:
> Array of platform_device_id elements should be terminated
> with empty element.
>
> Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
> ---
> drivers/rtc/rtc-s5m.c | 1 +
> 1 file changed, 1 insertion(+)
Right, good catch.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Maybe also cc stable for fixing 5bccae6ec458 ("rtc: s5m-rtc: add
real-time clock driver for s5m8767")?
Best regards,
Krzysztof
>
> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
> index b5e7c46..89ac1d5 100644
> --- a/drivers/rtc/rtc-s5m.c
> +++ b/drivers/rtc/rtc-s5m.c
> @@ -832,6 +832,7 @@ static SIMPLE_DEV_PM_OPS(s5m_rtc_pm_ops, s5m_rtc_suspend, s5m_rtc_resume);
> static const struct platform_device_id s5m_rtc_id[] = {
> { "s5m-rtc", S5M8767X },
> { "s2mps14-rtc", S2MPS14X },
> + { },
> };
>
> static struct platform_driver s5m_rtc_driver = {
> --
> 2.2.1
>
> --
> --
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
> ---
> You received this message because you are subscribed to the Google Groups "rtc-linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [rtc-linux] [PATCH] rtc: s5m: terminate s5m_rtc_id array with empty element
2015-01-22 9:37 ` [rtc-linux] " Krzysztof Kozlowski
@ 2015-01-22 12:01 ` Andrey Ryabinin
0 siblings, 0 replies; 3+ messages in thread
From: Andrey Ryabinin @ 2015-01-22 12:01 UTC (permalink / raw)
To: Krzysztof Kozlowski, rtc-linux; +Cc: linux-kernel, Alessandro Zummo
On 01/22/2015 12:37 PM, Krzysztof Kozlowski wrote:
> 2015-01-21 16:06 GMT+01:00 Andrey Ryabinin <a.ryabinin@samsung.com>:
>> Array of platform_device_id elements should be terminated
>> with empty element.
>>
>> Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
>> ---
>> drivers/rtc/rtc-s5m.c | 1 +
>> 1 file changed, 1 insertion(+)
>
>
> Right, good catch.
>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Maybe also cc stable for fixing 5bccae6ec458 ("rtc: s5m-rtc: add
> real-time clock driver for s5m8767")?
>
Probably. I didn't add stable tag because, I have no idea what are runtime
effects of this bug, so I don't know whether this worth for stable or not.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-22 12:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-21 15:06 [PATCH] rtc: s5m: terminate s5m_rtc_id array with empty element Andrey Ryabinin
2015-01-22 9:37 ` [rtc-linux] " Krzysztof Kozlowski
2015-01-22 12:01 ` Andrey Ryabinin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.