From: Krzysztof Kozlowski <krzk@kernel.org> To: Marc Zyngier <marc.zyngier@arm.com> Cc: Alban Browaeys <alban.browaeys@gmail.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Atsushi Nemoto <anemo@mba.ocn.ne.jp>, Kukjin Kim <kgene@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Linux MIPS Mailing List <linux-mips@linux-mips.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Jon Hunter <jonathanh@nvidia.com>, Marek Szyprowski <m.szyprowski@samsung.com> Subject: Re: genirq: Setting trigger mode 0 for irq 11 failed (txx9_irq_set_type+0x0/0xb8) Date: Fri, 16 Sep 2016 15:16:39 +0200 [thread overview] Message-ID: <CAJKOXPfwk43hVmC8=2gt9ke6Az5bWAsV4AierWiYscKo6_aj3w@mail.gmail.com> (raw) In-Reply-To: <57DBEBC8.7000209@arm.com> On Fri, Sep 16, 2016 at 2:55 PM, Marc Zyngier <marc.zyngier@arm.com> wrote: > +Krzystof, Kukjin, > > On 16/09/16 12:03, Alban Browaeys wrote: >> Le vendredi 16 septembre 2016 à 08:51 +0100, Marc Zyngier a écrit : >>> Hi Alban, >>> >>> On 16/09/16 00:02, Alban Browaeys wrote: >>>> I am seeing this on arm odroid u2 devicetree : >>>> genirq: Setting trigger mode 0 for irq 16 failed >>>> (gic_set_type+0x0/0x64) >>> >>> Passing IRQ_TYPE_NONE to a cascading interrupt is risky at best... >>> Can you point me to the various DTs and their failing interrupts? >> >> mine is: >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412-odroidu3.dts >> >> I got a report of this issue to another odroid : >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412-odroidx2.dts >> >> >> >> they both get their settings from : >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412.dtsi >> >> relevant in the chain are: >> - combiner modified: >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4x12.dtsi#n460 > > How wonderful. This section is an utter pile of crap. Really. > Having 0 as the trigger is illegal, and the valid values are fully > documented in the GIC binding. No wonder things start breaking. +CC Marek Szyprowski, Yes, that is interesting pile. Lately we stomped into it as well... I started fixing this today but didn't finish it yet. > And that's from the following stuff: > > &pinctrl_0 { > compatible = "samsung,exynos4x12-pinctrl"; > reg = <0x11400000 0x1000>; > interrupts = <0 47 0>; > }; > > &pinctrl_1 { > compatible = "samsung,exynos4x12-pinctrl"; > reg = <0x11000000 0x1000>; > interrupts = <0 46 0>; > > wakup_eint: wakeup-interrupt-controller { > compatible = "samsung,exynos4210-wakeup-eint"; > interrupt-parent = <&gic>; > interrupts = <0 32 0>; > }; > }; > > [...] > > &pinctrl_3 { > compatible = "samsung,exynos4x12-pinctrl"; > reg = <0x106E0000 0x1000>; > interrupts = <0 72 0>; > }; > > which perpetuates this fine tradition... > > At that stage, I'm not sure I should care. Does the workaround make your > platform usable? The Samsung maintainers should really try and fix their > DT, because it is a miracle this has made it that far. Miracle or coincidence. :) Thanks Geert and Alban for bringing this up, I'll add also yours reported-by. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: krzk@kernel.org (Krzysztof Kozlowski) To: linux-arm-kernel@lists.infradead.org Subject: genirq: Setting trigger mode 0 for irq 11 failed (txx9_irq_set_type+0x0/0xb8) Date: Fri, 16 Sep 2016 15:16:39 +0200 [thread overview] Message-ID: <CAJKOXPfwk43hVmC8=2gt9ke6Az5bWAsV4AierWiYscKo6_aj3w@mail.gmail.com> (raw) In-Reply-To: <57DBEBC8.7000209@arm.com> On Fri, Sep 16, 2016 at 2:55 PM, Marc Zyngier <marc.zyngier@arm.com> wrote: > +Krzystof, Kukjin, > > On 16/09/16 12:03, Alban Browaeys wrote: >> Le vendredi 16 septembre 2016 ? 08:51 +0100, Marc Zyngier a ?crit : >>> Hi Alban, >>> >>> On 16/09/16 00:02, Alban Browaeys wrote: >>>> I am seeing this on arm odroid u2 devicetree : >>>> genirq: Setting trigger mode 0 for irq 16 failed >>>> (gic_set_type+0x0/0x64) >>> >>> Passing IRQ_TYPE_NONE to a cascading interrupt is risky at best... >>> Can you point me to the various DTs and their failing interrupts? >> >> mine is: >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412-odroidu3.dts >> >> I got a report of this issue to another odroid : >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412-odroidx2.dts >> >> >> >> they both get their settings from : >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412.dtsi >> >> relevant in the chain are: >> - combiner modified: >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4x12.dtsi#n460 > > How wonderful. This section is an utter pile of crap. Really. > Having 0 as the trigger is illegal, and the valid values are fully > documented in the GIC binding. No wonder things start breaking. +CC Marek Szyprowski, Yes, that is interesting pile. Lately we stomped into it as well... I started fixing this today but didn't finish it yet. > And that's from the following stuff: > > &pinctrl_0 { > compatible = "samsung,exynos4x12-pinctrl"; > reg = <0x11400000 0x1000>; > interrupts = <0 47 0>; > }; > > &pinctrl_1 { > compatible = "samsung,exynos4x12-pinctrl"; > reg = <0x11000000 0x1000>; > interrupts = <0 46 0>; > > wakup_eint: wakeup-interrupt-controller { > compatible = "samsung,exynos4210-wakeup-eint"; > interrupt-parent = <&gic>; > interrupts = <0 32 0>; > }; > }; > > [...] > > &pinctrl_3 { > compatible = "samsung,exynos4x12-pinctrl"; > reg = <0x106E0000 0x1000>; > interrupts = <0 72 0>; > }; > > which perpetuates this fine tradition... > > At that stage, I'm not sure I should care. Does the workaround make your > platform usable? The Samsung maintainers should really try and fix their > DT, because it is a miracle this has made it that far. Miracle or coincidence. :) Thanks Geert and Alban for bringing this up, I'll add also yours reported-by. Best regards, Krzysztof
next prev parent reply other threads:[~2016-09-16 13:16 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-14 19:25 genirq: Setting trigger mode 0 for irq 11 failed (txx9_irq_set_type+0x0/0xb8) Geert Uytterhoeven 2016-09-15 23:02 ` Alban Browaeys 2016-09-16 7:51 ` Marc Zyngier 2016-09-16 11:03 ` Alban Browaeys 2016-09-16 12:55 ` Marc Zyngier 2016-09-16 12:55 ` Marc Zyngier 2016-09-16 12:55 ` Marc Zyngier 2016-09-16 13:16 ` Krzysztof Kozlowski [this message] 2016-09-16 13:16 ` Krzysztof Kozlowski 2016-09-16 13:16 ` Krzysztof Kozlowski 2016-09-16 13:35 ` Alban Browaeys 2016-09-16 13:35 ` Alban Browaeys 2016-09-16 13:35 ` Alban Browaeys 2016-09-18 10:26 ` Geert Uytterhoeven 2016-09-19 8:25 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJKOXPfwk43hVmC8=2gt9ke6Az5bWAsV4AierWiYscKo6_aj3w@mail.gmail.com' \ --to=krzk@kernel.org \ --cc=alban.browaeys@gmail.com \ --cc=anemo@mba.ocn.ne.jp \ --cc=geert@linux-m68k.org \ --cc=jonathanh@nvidia.com \ --cc=kgene@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@linux-mips.org \ --cc=m.szyprowski@samsung.com \ --cc=marc.zyngier@arm.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.