From: Hsin-Yi Wang <hsinyi@chromium.org> To: Yang Yingliang <yangyingliang@huawei.com> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, xji@analogixsemi.com, robert.foss@linaro.org Subject: Re: [PATCH] drm/bridge: anx7625: add missing destroy_workqueue() in anx7625_i2c_probe() Date: Sun, 27 Mar 2022 03:07:13 +0800 [thread overview] Message-ID: <CAJMQK-hA+k8hsQiBq7v9QROQyDkrzy+J40b2uF4AcmrXDe0gKw@mail.gmail.com> (raw) In-Reply-To: <20220326073326.3389347-1-yangyingliang@huawei.com> On Sat, Mar 26, 2022 at 3:24 PM Yang Yingliang <yangyingliang@huawei.com> wrote: > > Add the missing destroy_workqueue() before return from > anx7625_i2c_probe() in the error handling case. > > Fixes: adca62ec370c ("drm/bridge: anx7625: Support reading edid through aux channel") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org> > drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 31ecf5626f1d..1895e3448c02 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -2654,7 +2654,7 @@ static int anx7625_i2c_probe(struct i2c_client *client, > if (ret) { > if (ret != -EPROBE_DEFER) > DRM_DEV_ERROR(dev, "fail to parse DT : %d\n", ret); > - return ret; > + goto free_wq; > } > > if (anx7625_register_i2c_dummy_clients(platform, client) != 0) { > @@ -2669,7 +2669,7 @@ static int anx7625_i2c_probe(struct i2c_client *client, > pm_suspend_ignore_children(dev, true); > ret = devm_add_action_or_reset(dev, anx7625_runtime_disable, dev); > if (ret) > - return ret; > + goto free_wq; > > if (!platform->pdata.low_power_mode) { > anx7625_disable_pd_protocol(platform); > -- > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org> To: Yang Yingliang <yangyingliang@huawei.com> Cc: robert.foss@linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, xji@analogixsemi.com Subject: Re: [PATCH] drm/bridge: anx7625: add missing destroy_workqueue() in anx7625_i2c_probe() Date: Sun, 27 Mar 2022 03:07:13 +0800 [thread overview] Message-ID: <CAJMQK-hA+k8hsQiBq7v9QROQyDkrzy+J40b2uF4AcmrXDe0gKw@mail.gmail.com> (raw) In-Reply-To: <20220326073326.3389347-1-yangyingliang@huawei.com> On Sat, Mar 26, 2022 at 3:24 PM Yang Yingliang <yangyingliang@huawei.com> wrote: > > Add the missing destroy_workqueue() before return from > anx7625_i2c_probe() in the error handling case. > > Fixes: adca62ec370c ("drm/bridge: anx7625: Support reading edid through aux channel") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org> > drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 31ecf5626f1d..1895e3448c02 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -2654,7 +2654,7 @@ static int anx7625_i2c_probe(struct i2c_client *client, > if (ret) { > if (ret != -EPROBE_DEFER) > DRM_DEV_ERROR(dev, "fail to parse DT : %d\n", ret); > - return ret; > + goto free_wq; > } > > if (anx7625_register_i2c_dummy_clients(platform, client) != 0) { > @@ -2669,7 +2669,7 @@ static int anx7625_i2c_probe(struct i2c_client *client, > pm_suspend_ignore_children(dev, true); > ret = devm_add_action_or_reset(dev, anx7625_runtime_disable, dev); > if (ret) > - return ret; > + goto free_wq; > > if (!platform->pdata.low_power_mode) { > anx7625_disable_pd_protocol(platform); > -- > 2.25.1 >
next prev parent reply other threads:[~2022-03-26 19:07 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-26 7:33 [PATCH] drm/bridge: anx7625: add missing destroy_workqueue() in anx7625_i2c_probe() Yang Yingliang 2022-03-26 7:33 ` Yang Yingliang 2022-03-26 19:07 ` Hsin-Yi Wang [this message] 2022-03-26 19:07 ` Hsin-Yi Wang 2022-03-31 12:05 ` Robert Foss 2022-03-31 12:05 ` Robert Foss
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJMQK-hA+k8hsQiBq7v9QROQyDkrzy+J40b2uF4AcmrXDe0gKw@mail.gmail.com \ --to=hsinyi@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robert.foss@linaro.org \ --cc=xji@analogixsemi.com \ --cc=yangyingliang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.