From: "Turquette, Mike" <mturquette@ti.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Russell King <linux@arm.linux.org.uk>,
patches@linaro.org, Rajendra Nayak <rnayak@ti.com>,
linux-kernel@vger.kernel.org,
Saravana Kannan <skannan@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
Olof Johansson <olof@lixom.net>,
linaro-dev@lists.linaro.org, arnd.bergmann@linaro.org,
Richard Zhao <richard.zhao@linaro.org>,
Shawn Guo <shawn.guo@freescale.com>
Subject: Re: [PATCH 13/13] clk: basic: improve parent_names & return errors
Date: Mon, 16 Apr 2012 16:11:24 -0700 [thread overview]
Message-ID: <CAJOA=zNW5zvG678sEzXvQ887DRwsXQAKFjzY7=HS434Vn0LC4g@mail.gmail.com> (raw)
In-Reply-To: <20120416205259.GI20478@pengutronix.de>
On Mon, Apr 16, 2012 at 1:52 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Wed, Apr 11, 2012 at 06:02:51PM -0700, Mike Turquette wrote:
>> This patch is the basic clk version of 'clk: core: copy parent_names &
>> return error codes'.
>>
>> The registration functions are changed to allow the core code to copy
>> the array of strings and allow platforms to declare those arrays as
>> __initdata.
>>
>> This patch also converts all of the basic clk registration functions to
>> return error codes which better aligns them with the existing clk.h api.
>>
>>
>> + */
>> struct clk *clk_register_divider(struct device *dev, const char *name,
>> const char *parent_name, unsigned long flags,
>> void __iomem *reg, u8 shift, u8 width,
>> u8 clk_divider_flags, spinlock_t *lock)
>> {
>> struct clk_divider *div;
>> - struct clk *clk;
>> + struct clk *clk = ERR_PTR(-ENOMEM);
>> + const char *parent_names[1];
>>
>> + /* allocate the divider */
>> div = kzalloc(sizeof(struct clk_divider), GFP_KERNEL);
>> -
>> if (!div) {
>> pr_err("%s: could not allocate divider clk\n", __func__);
>> return NULL;
>
> You missed a conversion to ERR_PTR here.
Thanks for the catch.
Mike
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@ti.com (Turquette, Mike)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/13] clk: basic: improve parent_names & return errors
Date: Mon, 16 Apr 2012 16:11:24 -0700 [thread overview]
Message-ID: <CAJOA=zNW5zvG678sEzXvQ887DRwsXQAKFjzY7=HS434Vn0LC4g@mail.gmail.com> (raw)
In-Reply-To: <20120416205259.GI20478@pengutronix.de>
On Mon, Apr 16, 2012 at 1:52 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Wed, Apr 11, 2012 at 06:02:51PM -0700, Mike Turquette wrote:
>> This patch is the basic clk version of 'clk: core: copy parent_names &
>> return error codes'.
>>
>> The registration functions are changed to allow the core code to copy
>> the array of strings and allow platforms to declare those arrays as
>> __initdata.
>>
>> This patch also converts all of the basic clk registration functions to
>> return error codes which better aligns them with the existing clk.h api.
>>
>>
>> + */
>> ?struct clk *clk_register_divider(struct device *dev, const char *name,
>> ? ? ? ? ? ? ? const char *parent_name, unsigned long flags,
>> ? ? ? ? ? ? ? void __iomem *reg, u8 shift, u8 width,
>> ? ? ? ? ? ? ? u8 clk_divider_flags, spinlock_t *lock)
>> ?{
>> ? ? ? struct clk_divider *div;
>> - ? ? struct clk *clk;
>> + ? ? struct clk *clk = ERR_PTR(-ENOMEM);
>> + ? ? const char *parent_names[1];
>>
>> + ? ? /* allocate the divider */
>> ? ? ? div = kzalloc(sizeof(struct clk_divider), GFP_KERNEL);
>> -
>> ? ? ? if (!div) {
>> ? ? ? ? ? ? ? pr_err("%s: could not allocate divider clk\n", __func__);
>> ? ? ? ? ? ? ? return NULL;
>
> You missed a conversion to ERR_PTR here.
Thanks for the catch.
Mike
> Sascha
>
> --
> Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ? ? ? ? ? ? ? ? ? ? ? ? ? |
> Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 ? ?|
> Amtsgericht Hildesheim, HRA 2686 ? ? ? ? ? | Fax: ? +49-5121-206917-5555 |
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-04-16 23:11 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 1:02 [PATCH 00/13] common clk framework misc fixes Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 1:02 ` [PATCH 01/13] clk: core: correct clk_set_rate kerneldoc Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 4:28 ` Viresh Kumar
2012-04-12 4:28 ` Viresh Kumar
2012-04-13 22:23 ` Turquette, Mike
2012-04-13 22:23 ` Turquette, Mike
2012-04-12 7:24 ` Andrew Lunn
2012-04-12 7:24 ` Andrew Lunn
2012-04-12 7:38 ` Amit Kucheria
2012-04-12 7:38 ` Amit Kucheria
2012-04-12 1:02 ` [PATCH 02/13] clk: core: remove dead code paths Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 6:14 ` Viresh Kumar
2012-04-12 6:14 ` Viresh Kumar
2012-04-13 22:27 ` Turquette, Mike
2012-04-13 22:27 ` Turquette, Mike
2012-04-12 1:02 ` [PATCH 03/13] clk: core: clk_calc_new_rates handles NULL parents Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 1:02 ` [PATCH 04/13] clk: core: enforce clk_ops consistency Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 6:17 ` Viresh Kumar
2012-04-12 6:17 ` Viresh Kumar
2012-04-12 1:02 ` [PATCH 05/13] clk: use kzalloc in clk_register_mux Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 6:18 ` Viresh Kumar
2012-04-12 6:18 ` Viresh Kumar
2012-04-12 1:02 ` [PATCH 06/13] clk: remove unnecessary EXPORT_SYMBOL_GPL Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 6:18 ` Viresh Kumar
2012-04-12 6:18 ` Viresh Kumar
2012-04-12 1:02 ` [PATCH 07/13] clk: add "const" for clk_ops of basic clks Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 6:19 ` Viresh Kumar
2012-04-12 6:19 ` Viresh Kumar
2012-04-12 1:02 ` [PATCH 08/13] clk: declare clk_ops of basic clks in clk-provider.h Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 6:20 ` Viresh Kumar
2012-04-12 6:20 ` Viresh Kumar
2012-04-12 1:02 ` [PATCH 09/13] clk: Make clk_get_rate() return 0 on error Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 6:21 ` Viresh Kumar
2012-04-12 6:21 ` Viresh Kumar
2012-04-12 1:02 ` [PATCH 10/13] clk: Remove comment for end of CONFIG_COMMON_CLK section Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 1:02 ` [PATCH 11/13] clk: Constify parent name arrays Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 1:02 ` [PATCH 12/13] clk: core: copy parent_names & return error codes Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-16 20:30 ` Sascha Hauer
2012-04-16 20:30 ` Sascha Hauer
2012-04-16 21:35 ` Turquette, Mike
2012-04-16 21:35 ` Turquette, Mike
2012-04-12 1:02 ` [PATCH 13/13] clk: basic: improve parent_names & return errors Mike Turquette
2012-04-12 1:02 ` Mike Turquette
2012-04-12 6:49 ` Shawn Guo
2012-04-12 6:49 ` Shawn Guo
2012-04-16 23:10 ` Turquette, Mike
2012-04-16 23:10 ` Turquette, Mike
2012-04-17 1:46 ` Shawn Guo
2012-04-17 1:46 ` Shawn Guo
2012-04-17 3:50 ` Turquette, Mike
2012-04-17 3:50 ` Turquette, Mike
2012-04-17 7:17 ` Shawn Guo
2012-04-17 7:17 ` Shawn Guo
2012-04-20 20:01 ` Saravana Kannan
2012-04-20 20:01 ` Saravana Kannan
2012-04-26 6:00 ` Saravana Kannan
2012-04-26 6:00 ` Saravana Kannan
2012-04-16 20:52 ` Sascha Hauer
2012-04-16 20:52 ` Sascha Hauer
2012-04-16 23:11 ` Turquette, Mike [this message]
2012-04-16 23:11 ` Turquette, Mike
2012-04-12 8:56 ` [PATCH 00/13] common clk framework misc fixes Sascha Hauer
2012-04-12 8:56 ` Sascha Hauer
2012-04-12 11:14 ` Arnd Bergmann
2012-04-12 11:14 ` Arnd Bergmann
2012-04-12 13:11 ` Shawn Guo
2012-04-12 13:11 ` Shawn Guo
2012-04-12 12:50 ` [PATCH 1/3] clk: always pass parent_rate into .round_rate Shawn Guo
2012-04-12 12:50 ` [PATCH 2/3] clk: pass parent_rate into .set_rate Shawn Guo
2012-04-18 1:05 ` Turquette, Mike
2012-04-12 12:50 ` [PATCH 3/3] clk: propagate round_rate for CLK_SET_RATE_PARENT case Shawn Guo
2012-04-18 1:07 ` Turquette, Mike
2012-04-18 1:05 ` [PATCH 1/3] clk: always pass parent_rate into .round_rate Turquette, Mike
2012-05-02 9:51 ` Sascha Hauer
2012-05-06 23:41 ` Turquette, Mike
2012-04-13 9:21 ` [PATCH 00/13] common clk framework misc fixes Mark Brown
2012-04-13 9:21 ` Mark Brown
2012-04-13 22:20 ` Turquette, Mike
2012-04-13 22:20 ` Turquette, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJOA=zNW5zvG678sEzXvQ887DRwsXQAKFjzY7=HS434Vn0LC4g@mail.gmail.com' \
--to=mturquette@ti.com \
--cc=andrew@lunn.ch \
--cc=arnd.bergmann@linaro.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=patches@linaro.org \
--cc=richard.zhao@linaro.org \
--cc=rnayak@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@freescale.com \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.