Re: [PATCH] Fix for out of range for THT 2p arcade controller

Re: [PATCH] Fix for out of range for THT 2p arcade controller

[Jiri Kosina]

On Thu, 9 Feb 2017, Peter Stein wrote:

> There is a new clone of the XIN MO arcade controller which has same issue
> with out of range like the original.
> This fix will solve the issue where 2 directions on the joystick are not
> recognized by the new THT 2P arcade controller with device ID 0x75e1.
> In details the new device ID is added the hid-id list and the hid-xinmo
> source code.
> 
> Signed-off-by: Peter Stein <peter@stuntstein.dk>

Peter,

thanks for the patch. Unfortunately your mail client completely corrupted 
the formatting (line breaks, whitespaces, ...). Could you please fix that 
up and resend?

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] Fix for out of range for THT 2p arcade controller

[Peter Stein]

Hi Jiri,

I am so sorry that I screw it up. I forgot to activate plain text in
gmail. I hope this time it is received in proper format.
BTW, some of the files that I have changes in, the indent is tabs
instead of spaces. Just so you know.


There is a new clone of the XIN MO arcade controller which has the
same issue with out of range like the original.
This fix will solve the issue where 2 directions on the joystick are
not recognized by the new THT 2P arcade controller with device ID
0x75e1.
In details the new device ID is added the hid-id list and the
hid-xinmo source code.

Signed-off-by: Peter Stein <peter@stuntstein.dk>

commit c16f015221d72f4ab11515a9b8bf0d3d14fbfd76
Author: Peter Stein <peter@stuntstein.dk>
Date:   Thu Feb 9 10:56:32 2017 -0800

    Fix for out of range for THT 2P arcade controller.

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 936960202cf4..24586876d43e 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2052,6 +2052,7 @@ static const struct hid_device_id
hid_have_special_driver[] = {
  { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
USB_DEVICE_ID_WALTOP_SIRIUS_BATTERY_FREE_TABLET) },
  { HID_USB_DEVICE(USB_VENDOR_ID_X_TENSIONS,
USB_DEVICE_ID_SPEEDLINK_VAD_CEZANNE) },
  { HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_THT_2P_ARCADE) },
  { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
  { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
  { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON,
USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index e37030624165..5e985046b255 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -1014,6 +1014,7 @@

 #define USB_VENDOR_ID_XIN_MO 0x16c0
 #define USB_DEVICE_ID_XIN_MO_DUAL_ARCADE 0x05e1
+#define USB_DEVICE_ID_THT_2P_ARCADE 0x75e1

 #define USB_VENDOR_ID_XIROKU 0x1477
 #define USB_DEVICE_ID_XIROKU_SPX 0x1006
diff --git a/drivers/hid/hid-xinmo.c b/drivers/hid/hid-xinmo.c
index 7df5227a7e61..9ad7731d2e10 100644
--- a/drivers/hid/hid-xinmo.c
+++ b/drivers/hid/hid-xinmo.c
@@ -46,6 +46,7 @@ static int xinmo_event(struct hid_device *hdev,
struct hid_field *field,

 static const struct hid_device_id xinmo_devices[] = {
  { HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_THT_2P_ARCADE) },
  { }
 };

Re: [PATCH] Fix for out of range for THT 2p arcade controller

[Jiri Kosina]

On Fri, 10 Feb 2017, Peter Stein wrote:

> I am so sorry that I screw it up. I forgot to activate plain text in
> gmail. I hope this time it is received in proper format.

Hi Peter,

unfortunately it's still line-wrapped.

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] Fix for out of range for THT 2p arcade controller

[Dmitry Torokhov]

On Tue, Feb 14, 2017 at 6:57 AM, Jiri Kosina <jikos@kernel.org> wrote:
> On Fri, 10 Feb 2017, Peter Stein wrote:
>
>> I am so sorry that I screw it up. I forgot to activate plain text in
>> gmail. I hope this time it is received in proper format.
>
> Hi Peter,
>
> unfortunately it's still line-wrapped.
>

Peter,

Pasting patch into gmail interface always corrupts it, even if you
select "plain text mode". The best way to send a patch is using "git
send-email". Stick the following in .git/config (or your ~/.gitconfig)

[sendemail]
        smtpserver = smtp.gmail.com
        smtpserverport = 587
        smtpencryption = tls
        smtpUser = <gmail user name>

Then you can do:

git send-email --annotate --smtpPass=<your gmail password> --to="list,
of, recepients" --cc="list, of, recepients" HEAD^..HEAD

to send the latest commit/patch. "--annotate" will allow you to edit
message(s) before sending.

Thanks.

-- 
Dmitry

[PATCH] Fix for out of range for THT 2P arcade controller.

[Peter Stein]

There is a new clone of the XIN MO arcade controller which has same issue with out of range like the original.
This fix will solve the issue where 2 directions on the joystick are not recognized by the new THT 2P arcade controller with device ID 0x75e1.
In details the new device ID is added the hid-id list and the hid-xinmo source code.

Signed-off-by: Peter Stein <peter@stuntstein.dk>
{sent from git}

---
 drivers/hid/hid-core.c  | 1 +
 drivers/hid/hid-ids.h   | 1 +
 drivers/hid/hid-xinmo.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 936960202cf4..24586876d43e 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2052,6 +2052,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP, USB_DEVICE_ID_WALTOP_SIRIUS_BATTERY_FREE_TABLET) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_X_TENSIONS, USB_DEVICE_ID_SPEEDLINK_VAD_CEZANNE) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_THT_2P_ARCADE) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index e37030624165..5e985046b255 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -1014,6 +1014,7 @@
 
 #define USB_VENDOR_ID_XIN_MO			0x16c0
 #define USB_DEVICE_ID_XIN_MO_DUAL_ARCADE	0x05e1
+#define USB_DEVICE_ID_THT_2P_ARCADE		0x75e1
 
 #define USB_VENDOR_ID_XIROKU		0x1477
 #define USB_DEVICE_ID_XIROKU_SPX	0x1006
diff --git a/drivers/hid/hid-xinmo.c b/drivers/hid/hid-xinmo.c
index 7df5227a7e61..9ad7731d2e10 100644
--- a/drivers/hid/hid-xinmo.c
+++ b/drivers/hid/hid-xinmo.c
@@ -46,6 +46,7 @@ static int xinmo_event(struct hid_device *hdev, struct hid_field *field,
 
 static const struct hid_device_id xinmo_devices[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_THT_2P_ARCADE) },
 	{ }
 };
 
-- 
2.7.4