Re: [Qemu-devel] [PULL 0/7] Net patches

Re: [Qemu-devel] [PULL 0/7] Net patches

[Stefan Hajnoczi]

On Wed, Feb 27, 2013 at 4:22 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> Tested that tap still works with the QEMU "vlan" feature.
>
> The following changes since commit ee24aaf356f44ca7c8fbef136a438c12091cffd0:
>
>   Merge remote-tracking branch 'kiszka/queues/slirp' into staging (2013-02-26 13:36:09 -0600)
>
> are available in the git repository at:
>
>
>   git://github.com/stefanha/qemu.git net
>
> for you to fetch changes up to af347aa5a521555f5342e67993eb717d4f542ba8:
>
>   qmp: netdev_add is like -netdev, not -net, fix documentation (2013-02-27 16:10:47 +0100)
>
> ----------------------------------------------------------------
> Jason Wang (2):
>       tap: forbid creating multiqueue tap when hub is used
>       net: reduce the unnecessary memory allocation of multiqueue
>
> Luigi Rizzo (2):
>       net: fix qemu_flush_queued_packets() in presence of a hub
>       net: fix unbounded NetQueue
>
> Markus Armbruster (1):
>       qmp: netdev_add is like -netdev, not -net, fix documentation
>
> Peter Lieven (1):
>       tap: set IFF_ONE_QUEUE per default
>
> Stefan Hajnoczi (1):
>       doc: document -netdev hubport
>
>  hmp-commands.hx   |  2 +-
>  hw/virtio-net.c   |  6 ++++--
>  include/net/net.h |  2 +-
>  net/hub.c         | 14 ++++++++++++++
>  net/hub.h         |  1 +
>  net/net.c         | 25 +++++++++++++++----------
>  net/queue.c       | 15 +++++++++++++++
>  net/tap-linux.c   | 10 ++++++----
>  net/tap-linux.h   |  9 +++++----
>  net/tap.c         |  7 +++++++
>  qemu-options.hx   | 11 ++++++++++-
>  qmp-commands.hx   |  2 +-
>  12 files changed, 80 insertions(+), 24 deletions(-)
>
> --
> 1.8.1.2
>

ping

Re: [Qemu-devel] [PULL 0/7] Net patches

[Anthony Liguori]

Stefan Hajnoczi <stefanha@gmail.com> writes:

> On Wed, Feb 27, 2013 at 4:22 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>> Tested that tap still works with the QEMU "vlan" feature.
>>
>> The following changes since commit ee24aaf356f44ca7c8fbef136a438c12091cffd0:
>>
>>   Merge remote-tracking branch 'kiszka/queues/slirp' into staging (2013-02-26 13:36:09 -0600)
>>
>> are available in the git repository at:
>>
>>
>>   git://github.com/stefanha/qemu.git net
>>
>> for you to fetch changes up to af347aa5a521555f5342e67993eb717d4f542ba8:
>>
>>   qmp: netdev_add is like -netdev, not -net, fix documentation (2013-02-27 16:10:47 +0100)
>>
>> ----------------------------------------------------------------
>> Jason Wang (2):
>>       tap: forbid creating multiqueue tap when hub is used
>>       net: reduce the unnecessary memory allocation of multiqueue
>>
>> Luigi Rizzo (2):
>>       net: fix qemu_flush_queued_packets() in presence of a hub
>>       net: fix unbounded NetQueue
>>
>> Markus Armbruster (1):
>>       qmp: netdev_add is like -netdev, not -net, fix documentation
>>
>> Peter Lieven (1):
>>       tap: set IFF_ONE_QUEUE per default
>>
>> Stefan Hajnoczi (1):
>>       doc: document -netdev hubport
>>
>>  hmp-commands.hx   |  2 +-
>>  hw/virtio-net.c   |  6 ++++--
>>  include/net/net.h |  2 +-
>>  net/hub.c         | 14 ++++++++++++++
>>  net/hub.h         |  1 +
>>  net/net.c         | 25 +++++++++++++++----------
>>  net/queue.c       | 15 +++++++++++++++
>>  net/tap-linux.c   | 10 ++++++----
>>  net/tap-linux.h   |  9 +++++----
>>  net/tap.c         |  7 +++++++
>>  qemu-options.hx   | 11 ++++++++++-
>>  qmp-commands.hx   |  2 +-
>>  12 files changed, 80 insertions(+), 24 deletions(-)
>>
>> --
>> 1.8.1.2
>>
>
> ping

Just pushed it 30 minutes ago or so.  Thanks.

Regards,

Anthony Liguori

Re: [Qemu-devel] [PULL 0/7] Net patches

[Jason Wang]

On 03/30/2016 12:39 AM, Peter Maydell wrote:
> On 25 March 2016 at 07:42, Jason Wang <jasowang@redhat.com> wrote:
>> The following changes since commit b68a80139e37e806f004237e55311ebc42151434:
>>
>>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into staging (2016-03-24 16:24:02 +0000)
>>
>> are available in the git repository at:
>>
>>   https://github.com/jasowang/qemu.git tags/net-pull-request
>>
>> for you to fetch changes up to e680f08328f6a05a43963c3e9db1b0cdc701ed9f:
>>
>>   Revert "e1000: fix hang of win2k12 shutdown with flood ping" (2016-03-25 10:39:43 +0800)
>>
>> ----------------------------------------------------------------
>>
>> - mirror/redirector which could mirror or redirct the traffic between
>>   netdev and chardev
>> - fix e1000 interrupt strom and remove previous hack
> Hi. I'm afraid this fails to compile:
>
> /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c: In function
> ‘filter_mirror_setup’:
> /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:242:9:
> error: implicit declaration of function ‘error_setg’
> [-Werror=implicit-function-declaration]
>          error_setg(errp, "filter filter mirror needs 'outdev' "
>          ^
> /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:242:9:
> error: nested extern declaration of ‘error_setg’
> [-Werror=nested-externs]
> /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:9:
> error: implicit declaration of function ‘error_set’
> [-Werror=implicit-function-declaration]
>          error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
>          ^
> /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:9:
> error: nested extern declaration of ‘error_set’
> [-Werror=nested-externs]
> /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:25:
> error: ‘ERROR_CLASS_DEVICE_NOT_FOUND’ undeclared (first use in this
> function)
>          error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
>                          ^
> /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:25:
> note: each undeclared identifier is reported only once for each
> function it appears in
> /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c: In function
> ‘filter_redirector_setup’:
> /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:281:29:
> error: ‘ERROR_CLASS_DEVICE_NOT_FOUND’ undeclared (first use in this
> function)
>              error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
>                              ^
> cc1: all warnings being treated as errors
>
> I think your commit has unfortunately clashed with the
> pull from Paolo that I've just applied that makes
> changes to our include files.

Right, will fix and send V2.

Thanks

>
> thanks
> -- PMM
>

Re: [Qemu-devel] [PULL 0/7] Net patches

[Peter Maydell]

On 25 March 2016 at 07:42, Jason Wang <jasowang@redhat.com> wrote:
> The following changes since commit b68a80139e37e806f004237e55311ebc42151434:
>
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into staging (2016-03-24 16:24:02 +0000)
>
> are available in the git repository at:
>
>   https://github.com/jasowang/qemu.git tags/net-pull-request
>
> for you to fetch changes up to e680f08328f6a05a43963c3e9db1b0cdc701ed9f:
>
>   Revert "e1000: fix hang of win2k12 shutdown with flood ping" (2016-03-25 10:39:43 +0800)
>
> ----------------------------------------------------------------
>
> - mirror/redirector which could mirror or redirct the traffic between
>   netdev and chardev
> - fix e1000 interrupt strom and remove previous hack

Hi. I'm afraid this fails to compile:

/home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c: In function
‘filter_mirror_setup’:
/home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:242:9:
error: implicit declaration of function ‘error_setg’
[-Werror=implicit-function-declaration]
         error_setg(errp, "filter filter mirror needs 'outdev' "
         ^
/home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:242:9:
error: nested extern declaration of ‘error_setg’
[-Werror=nested-externs]
/home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:9:
error: implicit declaration of function ‘error_set’
[-Werror=implicit-function-declaration]
         error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
         ^
/home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:9:
error: nested extern declaration of ‘error_set’
[-Werror=nested-externs]
/home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:25:
error: ‘ERROR_CLASS_DEVICE_NOT_FOUND’ undeclared (first use in this
function)
         error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
                         ^
/home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:25:
note: each undeclared identifier is reported only once for each
function it appears in
/home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c: In function
‘filter_redirector_setup’:
/home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:281:29:
error: ‘ERROR_CLASS_DEVICE_NOT_FOUND’ undeclared (first use in this
function)
             error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
                             ^
cc1: all warnings being treated as errors

I think your commit has unfortunately clashed with the
pull from Paolo that I've just applied that makes
changes to our include files.

thanks
-- PMM

[Qemu-devel] [PULL 0/7] Net patches

[Jason Wang]

The following changes since commit b68a80139e37e806f004237e55311ebc42151434:

  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into staging (2016-03-24 16:24:02 +0000)

are available in the git repository at:

  https://github.com/jasowang/qemu.git tags/net-pull-request

for you to fetch changes up to e680f08328f6a05a43963c3e9db1b0cdc701ed9f:

  Revert "e1000: fix hang of win2k12 shutdown with flood ping" (2016-03-25 10:39:43 +0800)

----------------------------------------------------------------

- mirror/redirector which could mirror or redirct the traffic between
  netdev and chardev
- fix e1000 interrupt strom and remove previous hack

----------------------------------------------------------------
Sameeh Jubran (2):
      e1000: Fixing interrupts pace.
      Revert "e1000: fix hang of win2k12 shutdown with flood ping"

Zhang Chen (5):
      net/filter-mirror:Add filter-mirror
      tests/test-filter-mirror:add filter-mirror unit test
      net/filter-mirror: Change filter_mirror_send interface
      net/filter-mirror: implement filter-redirector
      tests/test-filter-redirector: Add unit test for filter-redirector

 hw/net/e1000.c                 |  13 +-
 net/Makefile.objs              |   1 +
 net/filter-mirror.c            | 426 +++++++++++++++++++++++++++++++++++++++++
 qemu-options.hx                |  14 ++
 tests/.gitignore               |   2 +
 tests/Makefile                 |   4 +
 tests/test-filter-mirror.c     |  93 +++++++++
 tests/test-filter-redirector.c | 221 +++++++++++++++++++++
 vl.c                           |   4 +-
 9 files changed, 772 insertions(+), 6 deletions(-)
 create mode 100644 net/filter-mirror.c
 create mode 100644 tests/test-filter-mirror.c
 create mode 100644 tests/test-filter-redirector.c

Re: [Qemu-devel] [PULL 0/7] Net patches

[Peter Maydell]

On 2 September 2015 at 17:14, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b:
>
>   s390: fix softmmu compilation (2015-08-28 16:05:24 +0100)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/net-pull-request
>
> for you to fetch changes up to c5a93780453e6da919287c17e873c843544ef2a3:
>
>   ne2000: Drop ne2000_can_receive (2015-09-02 14:51:07 +0100)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/7] Net patches

[Stefan Hajnoczi]

The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b:

  s390: fix softmmu compilation (2015-08-28 16:05:24 +0100)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/net-pull-request

for you to fetch changes up to c5a93780453e6da919287c17e873c843544ef2a3:

  ne2000: Drop ne2000_can_receive (2015-09-02 14:51:07 +0100)

----------------------------------------------------------------

----------------------------------------------------------------

Fam Zheng (2):
  vmxnet3: Drop net_vmxnet3_info.can_receive
  ne2000: Drop ne2000_can_receive

Stefan Hajnoczi (3):
  rtl8139: remove duplicate net/eth.h definitions
  rtl8139: use net/eth.h macros instead of custom macros
  rtl8139: use ldl/stl wrapper for unaligned 32-bit access

Vladislav Yasevich (2):
  rtl8139: Fix receive buffer overflow check
  rtl8139: Do not consume the packet during overflow in standard mode.

 hw/net/ne2000-isa.c |   1 -
 hw/net/ne2000.c     |  10 -----
 hw/net/ne2000.h     |   1 -
 hw/net/rtl8139.c    | 111 +++++++++++++++-------------------------------------
 hw/net/vmxnet3.c    |   1 -
 5 files changed, 32 insertions(+), 92 deletions(-)

-- 
2.4.3

[Qemu-devel] [PULL 0/7] Net patches

[Stefan Hajnoczi]

The following changes since commit 30eaca3acdf17d7bcbd1213eb149c02037edfb0b:

  Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20140902-1' into staging (2014-09-02 10:26:10 +0100)

are available in the git repository at:


  git://github.com/stefanha/qemu.git tags/net-pull-request

for you to fetch changes up to 18ae0593f274c8a52f136bfd95729bf0e0d759f3:

  virtio-net: purge outstanding packets when starting vhost (2014-09-04 14:33:53 +0100)

----------------------------------------------------------------
Net patches

----------------------------------------------------------------
Jason Wang (1):
      net: don't use set/get_pointer() in set/get_netdev()

Michael S. Tsirkin (5):
      virtio-net: don't run bh on vm stopped
      virtio: don't call device on !vm_running
      net: invoke callback when purging queue
      net: complete all queued packets on VM stop
      virtio-net: purge outstanding packets when starting vhost

zhanghailiang (1):
      net: Forbid dealing with packets when VM is not running

 hw/core/qdev-properties-system.c | 71 ++++++++++++++++++++++------------------
 hw/net/virtio-net.c              | 29 ++++++++++++++--
 hw/virtio/virtio.c               |  9 ++++-
 net/net.c                        | 40 +++++++++++++++++++++-
 net/queue.c                      |  3 ++
 5 files changed, 115 insertions(+), 37 deletions(-)

-- 
1.9.3

[Qemu-devel] [PULL 0/7] Net patches

[Stefan Hajnoczi]

The big change here is the new vmxnet3 emulated NIC.

The following changes since commit fe6344a05fba26e16863fefcb823242e579b0991:

  Remove device_tree.o from hw/moxie/Makefile.objs. (2013-03-24 11:30:04 +0100)

are available in the git repository at:

  git://github.com/stefanha/qemu.git net

for you to fetch changes up to d32fcad366e5f45d33dab2ee4de0e5729439680b:

  net: increase buffer size to accommodate Jumbo frame pkts (2013-03-25 11:14:07 +0100)

----------------------------------------------------------------
Dmitry Fleytman (5):
      Checksum-related utility functions
      net: iovec checksum calculator
      Common definitions for VMWARE devices
      Packet abstraction for VMWARE network devices
      VMXNET3 device implementation

Scott Feldman (1):
      net: increase buffer size to accommodate Jumbo frame pkts

Stefan Hajnoczi (1):
      net: use socket_set_nodelay() for -netdev socket

 default-configs/pci.mak |    1 +
 hw/Makefile.objs        |    2 +
 hw/pci/pci.h            |    1 +
 hw/vmware_utils.h       |  143 +++
 hw/vmxnet3.c            | 2461 +++++++++++++++++++++++++++++++++++++++++++++++
 hw/vmxnet3.h            |  760 +++++++++++++++
 hw/vmxnet_debug.h       |  115 +++
 hw/vmxnet_rx_pkt.c      |  187 ++++
 hw/vmxnet_rx_pkt.h      |  174 ++++
 hw/vmxnet_tx_pkt.c      |  567 +++++++++++
 hw/vmxnet_tx_pkt.h      |  148 +++
 include/net/checksum.h  |   26 +-
 include/net/eth.h       |  347 +++++++
 include/net/net.h       |    5 +
 net/Makefile.objs       |    1 +
 net/checksum.c          |   42 +-
 net/eth.c               |  217 +++++
 net/net.c               |    2 +-
 net/socket.c            |    7 +-
 net/tap.c               |    7 +-
 net/vde.c               |    2 +-
 21 files changed, 5198 insertions(+), 17 deletions(-)
 create mode 100644 hw/vmware_utils.h
 create mode 100644 hw/vmxnet3.c
 create mode 100644 hw/vmxnet3.h
 create mode 100644 hw/vmxnet_debug.h
 create mode 100644 hw/vmxnet_rx_pkt.c
 create mode 100644 hw/vmxnet_rx_pkt.h
 create mode 100644 hw/vmxnet_tx_pkt.c
 create mode 100644 hw/vmxnet_tx_pkt.h
 create mode 100644 include/net/eth.h
 create mode 100644 net/eth.c

-- 
1.8.1.4