[Buildroot] [PATCH 1/1] Changed download links for libxml2 and libxslt

[Buildroot] [PATCH 1/1] Changed download links for libxml2 and libxslt

[Nityananda Padhan]

Those ftp links were unreachable. After those changes it worked.


Thanks
Neitin Nt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Changed-download-links-for-libxml2-and-libxslt.patch
Type: text/x-patch
Size: 1441 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190308/3bd78816/attachment.bin>

[Buildroot] [PATCH 1/1] Changed download links for libxml2 and libxslt

[Peter Seiderer]

Hello Nityananda,

On Fri, 8 Mar 2019 15:46:44 +0530, Nityananda Padhan <ntneitin@gmail.com> wrote:

> Those ftp links were unreachable. After those changes it worked.
> 

Thanks for the patch, but the ftp download here works fine (as does the http one)...,
maybe a problem at your company network/proxy?

Yes, http works under more circumstances...

> 
> Thanks
> Neitin Nt

Please send the patch inline (and not as attachment), see [1] for details...

> From 80548bd6111d9f8f8c60c12a643cbf7088342e11 Mon Sep 17 00:00:00 2001
> From: Nt Neitin <ntneitin@gmail.com>
> Date: Fri, 8 Mar 2019 15:22:29 +0530
> Subject: [PATCH 1/1] Changed download links for libxml2 and libxslt

Should be:

  package/libxml2: change download site to http

and

  package/libxslt: change download site to http

and only one change per patch....

> 
>  Changes to be committed:
> 	modified:   package/libxml2/libxml2.mk
> 	modified:   package/libxslt/libxslt.mk
> 
> Signed-off-by: Nt Neitin <ntneitin@gmail.com>

Signed of should be 'Signed-off-by: Your Real Name <your@email.address>',
in your case 'Nityananda Padhan <ntneitin@gmail.com>'?

Regards,
Peter

[1] https://buildroot.org/downloads/manual/manual.html#submitting-patches

> ---
>  package/libxml2/libxml2.mk | 2 +-
>  package/libxslt/libxslt.mk | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libxml2/libxml2.mk b/package/libxml2/libxml2.mk
> index 3b3714fff1..f4b4de090e 100644
> --- a/package/libxml2/libxml2.mk
> +++ b/package/libxml2/libxml2.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
> >  
>  LIBXML2_VERSION = 2.9.9
> -LIBXML2_SITE = ftp://xmlsoft.org/libxml2
> +LIBXML2_SITE = http://xmlsoft.org/sources
>  LIBXML2_INSTALL_STAGING = YES
>  LIBXML2_LICENSE = MIT
>  LIBXML2_LICENSE_FILES = COPYING
> diff --git a/package/libxslt/libxslt.mk b/package/libxslt/libxslt.mk
> index 5b1c0ae268..4632301b16 100644
> --- a/package/libxslt/libxslt.mk
> +++ b/package/libxslt/libxslt.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
>  
>  LIBXSLT_VERSION = 1.1.32
> -LIBXSLT_SITE = ftp://xmlsoft.org/libxslt
> +LIBXSLT_SITE = http://xmlsoft.org/sources
>  LIBXSLT_INSTALL_STAGING = YES
>  LIBXSLT_LICENSE = MIT
>  LIBXSLT_LICENSE_FILES = COPYING
> -- 
> 2.17.1

[Buildroot] [PATCH 1/1] Changed download links for libxml2 and libxslt

[Peter Seiderer]

Hello Nityananda,

thanks for the rework, patch looks good, but please keep buildroot at buildroot.org in CC...

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter

On Sat, 9 Mar 2019 18:58:48 +0530, Nityananda Padhan <ntneitin@gmail.com> wrote:

> From f0f7715ecb3c5e08a0c1d96f6844acbad8b294bf Mon Sep 17 00:00:00 2001
> From: Nityananda Padhan <ntneitin@gmail.com>
> Date: Sat, 9 Mar 2019 18:36:09 +0530
> Subject: [PATCH 1/2] package/libxml2: change download site to http
> 
> Changes to be committed:
> modified:   package/libxml2/libxml2.mk
> 
> Signed-off-by: Nityananda Padhan <ntneitin@gmail.com>
> ---
>  package/libxml2/libxml2.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libxml2/libxml2.mk b/package/libxml2/libxml2.mk
> index 3b3714fff1..f4b4de090e 100644
> --- a/package/libxml2/libxml2.mk
> +++ b/package/libxml2/libxml2.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
> 
>  LIBXML2_VERSION = 2.9.9
> -LIBXML2_SITE = ftp://xmlsoft.org/libxml2
> +LIBXML2_SITE = http://xmlsoft.org/sources
>  LIBXML2_INSTALL_STAGING = YES
>  LIBXML2_LICENSE = MIT
>  LIBXML2_LICENSE_FILES = COPYING

[Buildroot] [PATCH 1/1] Changed download links for libxml2 and libxslt

[Peter Seiderer]

Hello Nityananda,

thanks for the rework, patch looks good, but please keep buildroot at buildroot.org in CC...

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter

On Sat, 9 Mar 2019 18:59:16 +0530, Nityananda Padhan <ntneitin@gmail.com> wrote:

> From dc92f5d7088a9c1c5be0151f2736df900db35e70 Mon Sep 17 00:00:00 2001
> From: Nityananda Padhan <ntneitin@gmail.com>
> Date: Sat, 9 Mar 2019 18:50:05 +0530
> Subject: [PATCH 2/2] package/libxslt: change download site to http
> 
> Changes to be committed:
> modified:   package/libxslt/libxslt.mk
> 
> Signed-off-by: Nityananda Padhan <ntneitin@gmail.com>
> ---
>  package/libxslt/libxslt.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libxslt/libxslt.mk b/package/libxslt/libxslt.mk
> index 5b1c0ae268..4632301b16 100644
> --- a/package/libxslt/libxslt.mk
> +++ b/package/libxslt/libxslt.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
> 
>  LIBXSLT_VERSION = 1.1.32
> -LIBXSLT_SITE = ftp://xmlsoft.org/libxslt
> +LIBXSLT_SITE = http://xmlsoft.org/sources
>  LIBXSLT_INSTALL_STAGING = YES
>  LIBXSLT_LICENSE = MIT
>  LIBXSLT_LICENSE_FILES = COPYING

[Buildroot] [PATCH 1/1] Changed download links for libxml2 and libxslt

[Peter Seiderer]

Hello Nityananda,

On Sun, 10 Mar 2019 14:51:18 +0530, Nityananda Padhan <ntneitin@gmail.com> wrote:

> Do I have to send the Patch again with buildroot at buildroot.org as CC?

Not sure, but I think yes (and try to send the patches via git send-email as
described in [1]) to make sure the patches hit the buildroot patchwork ([2])
which is used by the buildroot maintainers/committers...

Your can add the Reviewed-by to the patches before sending...

Regards,
Peter

[1] https://buildroot.org/downloads/manual/manual.html#submitting-patches
[2] https://patchwork.ozlabs.org/project/buildroot/list/


> 
> On 10/03/2019, Peter Seiderer <ps.report@gmx.net> wrote:
> > Hello Nityananda,
> >
> > thanks for the rework, patch looks good, but please keep
> > buildroot at buildroot.org in CC...
> >
> > Reviewed-by: Peter Seiderer <ps.report@gmx.net>
> >
> > Regards,
> > Peter
> >
> > On Sat, 9 Mar 2019 18:59:16 +0530, Nityananda Padhan <ntneitin@gmail.com>
> > wrote:
> >  
> >> From dc92f5d7088a9c1c5be0151f2736df900db35e70 Mon Sep 17 00:00:00 2001
> >> From: Nityananda Padhan <ntneitin@gmail.com>
> >> Date: Sat, 9 Mar 2019 18:50:05 +0530
> >> Subject: [PATCH 2/2] package/libxslt: change download site to http
> >>
> >> Changes to be committed:
> >> modified:   package/libxslt/libxslt.mk
> >>
> >> Signed-off-by: Nityananda Padhan <ntneitin@gmail.com>
> >> ---
> >>  package/libxslt/libxslt.mk | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/package/libxslt/libxslt.mk b/package/libxslt/libxslt.mk
> >> index 5b1c0ae268..4632301b16 100644
> >> --- a/package/libxslt/libxslt.mk
> >> +++ b/package/libxslt/libxslt.mk
> >> @@ -5,7 +5,7 @@
> >>
> >> ################################################################################
> >>
> >>  LIBXSLT_VERSION = 1.1.32
> >> -LIBXSLT_SITE = ftp://xmlsoft.org/libxslt
> >> +LIBXSLT_SITE = http://xmlsoft.org/sources
> >>  LIBXSLT_INSTALL_STAGING = YES
> >>  LIBXSLT_LICENSE = MIT
> >>  LIBXSLT_LICENSE_FILES = COPYING  
> >
> >  

[Buildroot] [PATCH 1/1] Changed download links for libxml2 and libxslt

[Peter Korsgaard]

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Hello Nityananda,
 > thanks for the rework, patch looks good, but please keep buildroot at buildroot.org in CC...

 > Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] Changed download links for libxml2 and libxslt

[Peter Korsgaard]

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Hello Nityananda,
 > thanks for the rework, patch looks good, but please keep buildroot at buildroot.org in CC...

 > Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Committed, thanks.

-- 
Bye, Peter Korsgaard