* [PATCH] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS
@ 2021-01-25 22:48 Dorinda
2021-01-25 23:00 ` Dorinda
0 siblings, 1 reply; 4+ messages in thread
From: Dorinda @ 2021-01-25 22:48 UTC (permalink / raw)
To: openembedded-core; +Cc: dorindabassey
added a check to ensure that a user isn't building in PSEUDO_IGNORE_PATHS
Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
---
meta/classes/sanity.bbclass | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 2040b48595..78c0343f0d 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -703,6 +703,13 @@ def check_sanity_version_change(status, d):
if (tmpdirmode & stat.S_ISUID):
status.addresult("TMPDIR is setuid, please don't build in a setuid directory")
+ # Check that user isn't building in PSEUDO_IGNORE_PATHS
+ pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS', expand=True).split(",")
+ workdir = d.getVar('WORKDIR', expand=True)
+ for i in pseudoignorepaths:
+ if workdir.startswith(i):
+ status.addresult("you are building in a path under PSEUDO_IGNORE_PATHS, please remove this" + str(i) + "directory in \nParsed WORKDIR: " + str(workdir) + "\n")
+
# Some third-party software apparently relies on chmod etc. being suid root (!!)
import stat
suid_check_bins = "chown chmod mknod".split()
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS
2021-01-25 22:48 [PATCH] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS Dorinda
@ 2021-01-25 23:00 ` Dorinda
0 siblings, 0 replies; 4+ messages in thread
From: Dorinda @ 2021-01-25 23:00 UTC (permalink / raw)
To: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]
Apologies please disregard this code, the update I made against this patch
didn't reflect.
On Jan 25, 2021 23:48, "dorindabassey" <dorindabassey@gmail.com> wrote:
> added a check to ensure that a user isn't building in PSEUDO_IGNORE_PATHS
>
> Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
> ---
> meta/classes/sanity.bbclass | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 2040b48595..78c0343f0d 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -703,6 +703,13 @@ def check_sanity_version_change(status, d):
> if (tmpdirmode & stat.S_ISUID):
> status.addresult("TMPDIR is setuid, please don't build in a
> setuid directory")
>
> + # Check that user isn't building in PSEUDO_IGNORE_PATHS
> + pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS',
> expand=True).split(",")
> + workdir = d.getVar('WORKDIR', expand=True)
> + for i in pseudoignorepaths:
> + if workdir.startswith(i):
> + status.addresult("you are building in a path under
> PSEUDO_IGNORE_PATHS, please remove this" + str(i) + "directory in \nParsed
> WORKDIR: " + str(workdir) + "\n")
> +
> # Some third-party software apparently relies on chmod etc. being
> suid root (!!)
> import stat
> suid_check_bins = "chown chmod mknod".split()
> --
> 2.17.1
>
>
[-- Attachment #2: Type: text/html, Size: 1959 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS
@ 2021-01-25 23:08 Dorinda
0 siblings, 0 replies; 4+ messages in thread
From: Dorinda @ 2021-01-25 23:08 UTC (permalink / raw)
To: openembedded-core; +Cc: dorindabassey
If a user builds in a path in PSEUDO_IGNORE_PATHS, random failures are generated. Hence this patch adds a sanity check in sanity.bbclass to ensure that a user isn't building in PSEUDO_IGNORE_PATHS.
[YOCTO #14179]
Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
---
meta/classes/sanity.bbclass | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 2040b48595..14271c1ca9 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -703,6 +703,13 @@ def check_sanity_version_change(status, d):
if (tmpdirmode & stat.S_ISUID):
status.addresult("TMPDIR is setuid, please don't build in a setuid directory")
+ # Check that a user isn't building in a path in PSEUDO_IGNORE_PATHS
+ pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS', expand=True).split(",")
+ workdir = d.getVar('WORKDIR', expand=True)
+ for i in pseudoignorepaths:
+ if i and workdir.startswith(i):
+ status.addresult("You are building in a path in PSEUDO_IGNORE_PATHS: " + str(i) + " please don't build in this directory: " + str(workdir) + "\n")
+
# Some third-party software apparently relies on chmod etc. being suid root (!!)
import stat
suid_check_bins = "chown chmod mknod".split()
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS
@ 2021-01-26 0:53 Dorinda
0 siblings, 0 replies; 4+ messages in thread
From: Dorinda @ 2021-01-26 0:53 UTC (permalink / raw)
To: openembedded-core; +Cc: dorindabassey
If a user builds in a path in PSEUDO_IGNORE_PATHS, random failures are generated. Hence this patch adds a sanity check in sanity.bbclass to ensure that a user isn't building in PSEUDO_IGNORE_PATHS.
[YOCTO #14179]
Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
---
meta/classes/sanity.bbclass | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index e527c13746..c6842ff549 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -703,6 +703,13 @@ def check_sanity_version_change(status, d):
if (tmpdirmode & stat.S_ISUID):
status.addresult("TMPDIR is setuid, please don't build in a setuid directory")
+ # Check that a user isn't building in a path in PSEUDO_IGNORE_PATHS
+ pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS', expand=True).split(",")
+ workdir = d.getVar('WORKDIR', expand=True)
+ for i in pseudoignorepaths:
+ if i and workdir.startswith(i):
+ status.addresult("You are building in a path included in PSEUDO_IGNORE_PATHS " + str(i) + " please locate the build outside this path.\n")
+
# Some third-party software apparently relies on chmod etc. being suid root (!!)
import stat
suid_check_bins = "chown chmod mknod".split()
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-26 0:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 22:48 [PATCH] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS Dorinda
2021-01-25 23:00 ` Dorinda
2021-01-25 23:08 Dorinda
2021-01-26 0:53 Dorinda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.