[PATCH] package.bbclass: fix directories setuid and setgid bits

[PATCH] package.bbclass: fix directories setuid and setgid bits

[Jean-Tiare Le Bigot]

From: Joël Esponde <joel.esponde@easymile.com>

populate_packages relies on ``mkdir`` to both create a directory and set
its permissions. However, ``mkdir`` honors the ``umask`` value.
Therefore, some bits may be lost in the operation. In our case, the
setgid bit on the directories were lost.

This commit fixes this by having a distinct call to create the directory
and to set the permissions.

Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@easymile.com>
---
 meta/classes/package.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 20d72bba79..cd223a121e 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1216,7 +1216,8 @@ python populate_packages () {
                 src = os.path.join(src, p)
                 dest = os.path.join(dest, p)
                 fstat = cpath.stat(src)
-                os.mkdir(dest, fstat.st_mode)
+                os.mkdir(dest)
+                os.chmod(dest, fstat.st_mode)
                 os.chown(dest, fstat.st_uid, fstat.st_gid)
                 if p not in seen:
                     seen.append(p)
-- 
2.19.1

Re: [PATCH] package.bbclass: fix directories setuid and setgid bits

[Jean-Tiare Le Bigot]

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

Do you have any feedback on this patch ?

Thanks!

On Fri, 28 Jun 2019 at 12:14, Jean-Tiare Le Bigot <
jean-tiare.le-bigot@easymile.com> wrote:

> From: Joël Esponde <joel.esponde@easymile.com>
>
> populate_packages relies on ``mkdir`` to both create a directory and set
> its permissions. However, ``mkdir`` honors the ``umask`` value.
> Therefore, some bits may be lost in the operation. In our case, the
> setgid bit on the directories were lost.
>
> This commit fixes this by having a distinct call to create the directory
> and to set the permissions.
>
> Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@easymile.com>
> ---
>  meta/classes/package.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 20d72bba79..cd223a121e 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -1216,7 +1216,8 @@ python populate_packages () {
>                  src = os.path.join(src, p)
>                  dest = os.path.join(dest, p)
>                  fstat = cpath.stat(src)
> -                os.mkdir(dest, fstat.st_mode)
> +                os.mkdir(dest)
> +                os.chmod(dest, fstat.st_mode)
>                  os.chown(dest, fstat.st_uid, fstat.st_gid)
>                  if p not in seen:
>                      seen.append(p)
> --
> 2.19.1
>
>

-- 
Jean-Tiare Le Bigot

[-- Attachment #2: Type: text/html, Size: 2168 bytes --]

Re: [PATCH] package.bbclass: fix directories setuid and setgid bits

[Richard Purdie]

On Thu, 2019-07-18 at 13:57 +0200, Jean-Tiare Le Bigot wrote:
> Do you have any feedback on this patch ?
> 
> Thanks!

It merged a while ago:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=0df6cef5258ccd6bd137279aa610b6b1bce43640

Cheers,

Richard

Re: [PATCH] package.bbclass: fix directories setuid and setgid bits

[Jean-Tiare Le Bigot]

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

Oh ! Thanks. I was following
https://patchwork.openembedded.org/series/18376/# which is still "new".

Should I submit individual patches for backport to "thud" and "warrior"
branches ?

On Thu, 18 Jul 2019 at 14:28, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Thu, 2019-07-18 at 13:57 +0200, Jean-Tiare Le Bigot wrote:
> > Do you have any feedback on this patch ?
> >
> > Thanks!
>
> It merged a while ago:
>
>
> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=0df6cef5258ccd6bd137279aa610b6b1bce43640
>
> Cheers,
>
> Richard
>
>

-- 
Jean-Tiare Le Bigot

[-- Attachment #2: Type: text/html, Size: 1290 bytes --]

Re: [PATCH] package.bbclass: fix directories setuid and setgid bits

[Burton, Ross]

> Should I submit individual patches for backport to "thud" and "warrior" branches ?

Yes, please.

Ross

[PATCH] package.bbclass: fix directories setuid and setgid bits

[Jean-Tiare Le Bigot]

From: Joël Esponde <joel.esponde@easymile.com>

populate_packages relies on ``mkdir`` to both create a directory and set
its permissions. However, ``mkdir`` honors the ``umask`` value.
Therefore, some bits may be lost in the operation. In our case, the
setgid bit on the directories were lost.

This commit fixes this by having a distinct call to create the directory
and to set the permissions.

Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@easymile.com>
---
 meta/classes/package.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 20d72bba79..cd223a121e 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1216,7 +1216,8 @@ python populate_packages () {
                 src = os.path.join(src, p)
                 dest = os.path.join(dest, p)
                 fstat = cpath.stat(src)
-                os.mkdir(dest, fstat.st_mode)
+                os.mkdir(dest)
+                os.chmod(dest, fstat.st_mode)
                 os.chown(dest, fstat.st_uid, fstat.st_gid)
                 if p not in seen:
                     seen.append(p)
-- 
2.19.1

Re: [PATCH] package.bbclass: fix directories setuid and setgid bits

[Jean-Tiare Le Bigot]

Oh, sorry. Resending.

On Thu, 27 Jun 2019 at 11:06, Burton, Ross <ross.burton@intel.com> wrote:

> This should go to openembedded-core@lists.openembedded.org, not -devel.
>
> Ross
>
> On Thu, 27 Jun 2019 at 09:59, Jean-Tiare Le Bigot
> <jean-tiare.le-bigot@easymile.com> wrote:
> >
> > From: Joël Esponde <joel.esponde@easymile.com>
> >
> > populate_packages relies on ``mkdir`` to both create a directory and set
> > its permissions. However, ``mkdir`` honors the ``umask`` value.
> > Therefore, some bits may be lost in the operation. In our case, the
> > setgid bit on the directories were lost.
> >
> > This commit fixes this by having a distinct call to create the directory
> > and to set the permissions.
> >
> > Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@easymile.com>
> > ---
> >  meta/classes/package.bbclass | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> > index 20d72bba79..cd223a121e 100644
> > --- a/meta/classes/package.bbclass
> > +++ b/meta/classes/package.bbclass
> > @@ -1216,7 +1216,8 @@ python populate_packages () {
> >                  src = os.path.join(src, p)
> >                  dest = os.path.join(dest, p)
> >                  fstat = cpath.stat(src)
> > -                os.mkdir(dest, fstat.st_mode)
> > +                os.mkdir(dest)
> > +                os.chmod(dest, fstat.st_mode)
> >                  os.chown(dest, fstat.st_uid, fstat.st_gid)
> >                  if p not in seen:
> >                      seen.append(p)
> > --
> > 2.19.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


-- 
Jean-Tiare Le Bigot

Re: [PATCH] package.bbclass: fix directories setuid and setgid bits

[Burton, Ross]

This should go to openembedded-core@lists.openembedded.org, not -devel.

Ross

On Thu, 27 Jun 2019 at 09:59, Jean-Tiare Le Bigot
<jean-tiare.le-bigot@easymile.com> wrote:
>
> From: Joël Esponde <joel.esponde@easymile.com>
>
> populate_packages relies on ``mkdir`` to both create a directory and set
> its permissions. However, ``mkdir`` honors the ``umask`` value.
> Therefore, some bits may be lost in the operation. In our case, the
> setgid bit on the directories were lost.
>
> This commit fixes this by having a distinct call to create the directory
> and to set the permissions.
>
> Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@easymile.com>
> ---
>  meta/classes/package.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 20d72bba79..cd223a121e 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -1216,7 +1216,8 @@ python populate_packages () {
>                  src = os.path.join(src, p)
>                  dest = os.path.join(dest, p)
>                  fstat = cpath.stat(src)
> -                os.mkdir(dest, fstat.st_mode)
> +                os.mkdir(dest)
> +                os.chmod(dest, fstat.st_mode)
>                  os.chown(dest, fstat.st_uid, fstat.st_gid)
>                  if p not in seen:
>                      seen.append(p)
> --
> 2.19.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[PATCH] package.bbclass: fix directories setuid and setgid bits

[Jean-Tiare Le Bigot]

From: Joël Esponde <joel.esponde@easymile.com>

populate_packages relies on ``mkdir`` to both create a directory and set
its permissions. However, ``mkdir`` honors the ``umask`` value.
Therefore, some bits may be lost in the operation. In our case, the
setgid bit on the directories were lost.

This commit fixes this by having a distinct call to create the directory
and to set the permissions.

Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@easymile.com>
---
 meta/classes/package.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 20d72bba79..cd223a121e 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1216,7 +1216,8 @@ python populate_packages () {
                 src = os.path.join(src, p)
                 dest = os.path.join(dest, p)
                 fstat = cpath.stat(src)
-                os.mkdir(dest, fstat.st_mode)
+                os.mkdir(dest)
+                os.chmod(dest, fstat.st_mode)
                 os.chown(dest, fstat.st_uid, fstat.st_gid)
                 if p not in seen:
                     seen.append(p)
-- 
2.19.1