Re: [PATCH 1/2] base-files: profile: Do not assume that the 'command' command exists

From: "Burton, Ross" <ross.burton@intel.com>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] base-files: profile: Do not assume that the 'command' command exists
Date: Mon, 18 Sep 2017 14:08:03 +0100	[thread overview]
Message-ID: <CAJTo0LY=JnUkd7XMvkpNppc2drcSB8AF9dj_CyxHJRjixZ1uFA@mail.gmail.com> (raw)
In-Reply-To: <660382f7-55b7-39cc-ae2a-afab46301b3c@topic.nl>

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On 18 September 2017 at 12:31, Mike Looijmans <mike.looijmans@topic.nl>
wrote:

> This is basically the same change as I first sent a patch for in April, and
>> last pinged this Friday... The only real difference is that this one
>> misses
>> passing error output from resize to /dev/null (which it should do to
>> handle
>> the case where tty exists, but resize does not).
>>
>
> Yeah, indeed.
>

Apologies for missing that patch!

> Other problem is that "resize" outputs shell script on stdout to be
> executed, so the proper "total" invokation would be:
>
>   /dev/tty[A-z]*) eval `resize 2>/dev/null` ;;
>
> The "eval" part is missing in your version...

Who is going to submit the One True patch with all the fixes in?  I promise
to merge it.

Ross

[-- Attachment #2: Type: text/html, Size: 1447 bytes --]