[PATCH 1/1] gnutls: avoid accidentally using libseccomp

[PATCH 1/1] gnutls: avoid accidentally using libseccomp

[Joe Slater]

Specify whether to use libseccomp or not.  Do not
just let configure check for it.

Signed-off-by: Joe Slater <jslater@windriver.com>
---
 meta/recipes-support/gnutls/gnutls.inc |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
index 003dc55..14fcdca 100644
--- a/meta/recipes-support/gnutls/gnutls.inc
+++ b/meta/recipes-support/gnutls/gnutls.inc
@@ -21,6 +21,17 @@ SRC_URI = "ftp://ftp.gnutls.org/gcrypt/gnutls/v${SHRT_VER}/gnutls-${PV}.tar.xz"
 
 inherit autotools texinfo binconfig pkgconfig gettext lib_package gtk-doc
 
+# We cannot use PACKAGECONFIG for this since there is no controlling
+# configure option.
+#
+# To use seccomp, uncomment the two variables.  You must also
+# have CONFIG_SECCOMP enabled in the kernel.
+#
+#DEPENDS_append_class-target = " libseccomp"
+#lcl_LIBSECCOMP_class-target = "ac_cv_libseccomp=yes"
+
+lcl_LIBSECCOMP ?= "ac_cv_libseccomp=no"
+
 PACKAGECONFIG ??= "libidn zlib"
 
 PACKAGECONFIG[libidn] = "--with-idn,--without-idn,libidn"
@@ -38,6 +49,7 @@ EXTRA_OECONF = " \
     --enable-openssl-compatibility \
     --with-libpthread-prefix=${STAGING_DIR_HOST}${prefix} \
     --without-libunistring-prefix \
+    ${lcl_LIBSECCOMP} \
 "
 
 LDFLAGS_append_libc-musl = " -largp"
-- 
1.7.9.5

Re: [PATCH 1/1] gnutls: avoid accidentally using libseccomp

[Andre McCurdy]

On Tue, Jan 24, 2017 at 12:15 PM, Joe Slater <jslater@windriver.com> wrote:
> Specify whether to use libseccomp or not.  Do not
> just let configure check for it.
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
>  meta/recipes-support/gnutls/gnutls.inc |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
> index 003dc55..14fcdca 100644
> --- a/meta/recipes-support/gnutls/gnutls.inc
> +++ b/meta/recipes-support/gnutls/gnutls.inc
> @@ -21,6 +21,17 @@ SRC_URI = "ftp://ftp.gnutls.org/gcrypt/gnutls/v${SHRT_VER}/gnutls-${PV}.tar.xz"
>
>  inherit autotools texinfo binconfig pkgconfig gettext lib_package gtk-doc
>
> +# We cannot use PACKAGECONFIG for this since there is no controlling
> +# configure option.

A configure option is not a requirement for using PACKAGECONFIG. e.g.

  meta/recipes-devtools/apt/apt_1.2.12.bb:PACKAGECONFIG[lzma] =
"ac_cv_lib_lzma_lzma_easy_encoder=yes,ac_cv_lib_lzma_lzma_easy_encoder=no,xz"
  meta/recipes-devtools/apt/apt_1.2.12.bb:PACKAGECONFIG[bz2] =
"ac_cv_lib_bz2_BZ2_bzopen=yes,ac_cv_lib_bz2_BZ2_bzopen=no,bzip2"
  meta/recipes-devtools/apt/apt_1.2.12.bb:PACKAGECONFIG[lz4] =
"ac_cv_lib_lz4_LZ4F_createCompressionContext=yes,ac_cv_lib_lz4_LZ4F_createCompressionContext=no,lz4"
  meta/recipes-devtools/mtools/mtools_3.9.9.bb:PACKAGECONFIG[libbsd] =
"ac_cv_lib_bsd_main=yes,ac_cv_lib_bsd_main=no,libbsd"
  meta/recipes-devtools/mtools/mtools_4.0.18.bb:PACKAGECONFIG[libbsd]
= "ac_cv_lib_bsd_main=yes,ac_cv_lib_bsd_main=no,libbsd"
  meta/recipes-devtools/strace/strace_4.14.bb:PACKAGECONFIG[bluez] =
"ac_cv_header_bluetooth_bluetooth_h=yes,ac_cv_header_bluetooth_bluetooth_h=no,${BLUEZ}"
  meta/recipes-extended/screen/screen_4.4.0.bb:PACKAGECONFIG[utempter]
= "ac_cv_header_utempter_h=yes,ac_cv_header_utempter_h=no,libutempter,"
  meta/recipes-graphics/xorg-lib/libice_1.0.9.bb:PACKAGECONFIG[arc4] =
"ac_cv_lib_bsd_arc4random_buf=yes,ac_cv_lib_bsd_arc4random_buf=no,libbsd"
  meta/recipes-graphics/xorg-lib/libxdmcp_1.1.2.bb:PACKAGECONFIG[arc4]
= "ac_cv_lib_bsd_arc4random_buf=yes,ac_cv_lib_bsd_arc4random_buf=no,libbsd"

> +# To use seccomp, uncomment the two variables.  You must also
> +# have CONFIG_SECCOMP enabled in the kernel.
> +#
> +#DEPENDS_append_class-target = " libseccomp"
> +#lcl_LIBSECCOMP_class-target = "ac_cv_libseccomp=yes"
> +
> +lcl_LIBSECCOMP ?= "ac_cv_libseccomp=no"
> +
>  PACKAGECONFIG ??= "libidn zlib"
>
>  PACKAGECONFIG[libidn] = "--with-idn,--without-idn,libidn"
> @@ -38,6 +49,7 @@ EXTRA_OECONF = " \
>      --enable-openssl-compatibility \
>      --with-libpthread-prefix=${STAGING_DIR_HOST}${prefix} \
>      --without-libunistring-prefix \
> +    ${lcl_LIBSECCOMP} \
>  "
>
>  LDFLAGS_append_libc-musl = " -largp"
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 1/1] gnutls: avoid accidentally using libseccomp

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

On 24 January 2017 at 20:52, Andre McCurdy <armccurdy@gmail.com> wrote:

> A configure option is not a requirement for using PACKAGECONFIG. e.g.
>

Yes, this. Please rewrite to use a PACKAGECONFIG.

Ross

[-- Attachment #2: Type: text/html, Size: 617 bytes --]