* [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1
@ 2013-05-22 10:57 Bogdan Marinescu
2013-05-22 10:58 ` Phil Blundell
0 siblings, 1 reply; 9+ messages in thread
From: Bogdan Marinescu @ 2013-05-22 10:57 UTC (permalink / raw)
To: openembedded-core
guile needs to be able to convert strings from ISO-8859-1 in order
to work properly. This patch adds a runtime dependency to the required
convert package.
[YOCTO #4019]
Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
---
meta/recipes-devtools/guile/guile_2.0.9.bb | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/guile/guile_2.0.9.bb b/meta/recipes-devtools/guile/guile_2.0.9.bb
index 617f7ce..5afccd1 100644
--- a/meta/recipes-devtools/guile/guile_2.0.9.bb
+++ b/meta/recipes-devtools/guile/guile_2.0.9.bb
@@ -27,7 +27,7 @@ SRC_URI = "${GNU_MIRROR}/guile/guile-${PV}.tar.xz \
SRC_URI[md5sum] = "a69b575d4a633bdd9118f3a4a1e97766"
SRC_URI[sha256sum] = "f70a38c8d9751f442679bfe61852bba8545af4d4355d037630997c2f37f2895b"
-PR = "r0"
+PR = "r1"
inherit autotools gettext
BBCLASSEXTEND = "native"
@@ -36,6 +36,9 @@ DEPENDS = "libunistring bdwgc gmp libtool libffi"
# add guile-native only to the target recipe's DEPENDS
DEPENDS += "${@['guile-native libatomics-ops', ''][d.getVar('PN', True) != 'guile']}"
+RDEPENDS_${PN} = "glibc-gconv-iso8859-1"
+RDEPENDS_${PN}_class-native = ""
+
EXTRA_OECONF += "${@['--without-libltdl-prefix --without-libgmp-prefix', ''][bb.data.inherits_class('native',d)]}"
do_configure_prepend() {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1
2013-05-22 10:57 [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1 Bogdan Marinescu
@ 2013-05-22 10:58 ` Phil Blundell
2013-05-22 12:05 ` Burton, Ross
0 siblings, 1 reply; 9+ messages in thread
From: Phil Blundell @ 2013-05-22 10:58 UTC (permalink / raw)
To: Bogdan Marinescu; +Cc: openembedded-core
On Wed, 2013-05-22 at 13:57 +0300, Bogdan Marinescu wrote:
> +RDEPENDS_${PN} = "glibc-gconv-iso8859-1"
That will make it unbuildable with anything other than (e)glibc. Is
this ok?
p.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1
2013-05-22 10:58 ` Phil Blundell
@ 2013-05-22 12:05 ` Burton, Ross
2013-05-22 12:51 ` Phil Blundell
0 siblings, 1 reply; 9+ messages in thread
From: Burton, Ross @ 2013-05-22 12:05 UTC (permalink / raw)
To: Phil Blundell; +Cc: openembedded-core
On 22 May 2013 11:58, Phil Blundell <pb@pbcl.net> wrote:
> On Wed, 2013-05-22 at 13:57 +0300, Bogdan Marinescu wrote:
>> +RDEPENDS_${PN} = "glibc-gconv-iso8859-1"
>
> That will make it unbuildable with anything other than (e)glibc. Is
> this ok?
Presumably in this case libiconv will be used. Is there a standard
way of depending on a specific encoding from either eglibc or
libiconv?
Ross
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1
2013-05-22 12:05 ` Burton, Ross
@ 2013-05-22 12:51 ` Phil Blundell
2013-05-22 13:41 ` Burton, Ross
0 siblings, 1 reply; 9+ messages in thread
From: Phil Blundell @ 2013-05-22 12:51 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
On Wed, 2013-05-22 at 13:05 +0100, Burton, Ross wrote:
> On 22 May 2013 11:58, Phil Blundell <pb@pbcl.net> wrote:
> > On Wed, 2013-05-22 at 13:57 +0300, Bogdan Marinescu wrote:
> >> +RDEPENDS_${PN} = "glibc-gconv-iso8859-1"
> >
> > That will make it unbuildable with anything other than (e)glibc. Is
> > this ok?
>
> Presumably in this case libiconv will be used. Is there a standard
> way of depending on a specific encoding from either eglibc or
> libiconv?
I had thought we had virtual-gconv-ENCODING providers but apparently
that's not the case. So I think the answer at the moment is probably
no. I guess we should add something like that.
p.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1
2013-05-22 12:51 ` Phil Blundell
@ 2013-05-22 13:41 ` Burton, Ross
2013-05-28 14:14 ` Marinescu, Bogdan A
2013-05-29 9:41 ` Richard Purdie
0 siblings, 2 replies; 9+ messages in thread
From: Burton, Ross @ 2013-05-22 13:41 UTC (permalink / raw)
To: Phil Blundell; +Cc: openembedded-core
On 22 May 2013 13:51, Phil Blundell <pb@pbcl.net> wrote:
> I had thought we had virtual-gconv-ENCODING providers but apparently
> that's not the case. So I think the answer at the moment is probably
> no. I guess we should add something like that.
Agreed. Filed https://bugzilla.yoctoproject.org/show_bug.cgi?id=4530.
Ross
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1
2013-05-22 13:41 ` Burton, Ross
@ 2013-05-28 14:14 ` Marinescu, Bogdan A
2013-05-29 9:40 ` Burton, Ross
2013-05-29 9:41 ` Richard Purdie
1 sibling, 1 reply; 9+ messages in thread
From: Marinescu, Bogdan A @ 2013-05-28 14:14 UTC (permalink / raw)
To: Burton, Ross; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]
On Wed, May 22, 2013 at 4:41 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 22 May 2013 13:51, Phil Blundell <pb@pbcl.net> wrote:
> > I had thought we had virtual-gconv-ENCODING providers but apparently
> > that's not the case. So I think the answer at the moment is probably
> > no. I guess we should add something like that.
>
> Agreed. Filed https://bugzilla.yoctoproject.org/show_bug.cgi?id=4530.
>
So, if I understand correctly, this bug depends on the fix for #4530
(because the patch that I've sent isn't generic enough) ?
Thanks,
Bogdan
>
> Ross
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
[-- Attachment #2: Type: text/html, Size: 1931 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1
2013-05-28 14:14 ` Marinescu, Bogdan A
@ 2013-05-29 9:40 ` Burton, Ross
0 siblings, 0 replies; 9+ messages in thread
From: Burton, Ross @ 2013-05-29 9:40 UTC (permalink / raw)
To: Marinescu, Bogdan A; +Cc: Patches and discussions about the oe-core layer
On 28 May 2013 15:14, Marinescu, Bogdan A <bogdan.a.marinescu@intel.com> wrote:
> So, if I understand correctly, this bug depends on the fix for #4530
> (because the patch that I've sent isn't generic enough) ?
A short-term fix until 4530 is resolved would be to make the depends
recommends, as then they won't fail in a non-eglibc environment. When
virtual providers exist, we can make it a hard dependency.
Ross
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1
2013-05-22 13:41 ` Burton, Ross
2013-05-28 14:14 ` Marinescu, Bogdan A
@ 2013-05-29 9:41 ` Richard Purdie
2013-05-29 13:41 ` Marinescu, Bogdan A
1 sibling, 1 reply; 9+ messages in thread
From: Richard Purdie @ 2013-05-29 9:41 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
On Wed, 2013-05-22 at 14:41 +0100, Burton, Ross wrote:
> On 22 May 2013 13:51, Phil Blundell <pb@pbcl.net> wrote:
> > I had thought we had virtual-gconv-ENCODING providers but apparently
> > that's not the case. So I think the answer at the moment is probably
> > no. I guess we should add something like that.
>
> Agreed. Filed https://bugzilla.yoctoproject.org/show_bug.cgi?id=4530.
I'd really like to at least get the partial fix merged for this. How
about we make this a libc class override? We can use the target override
too, something like:
RDEPENDS_${PN}_append_libc-glibc_class-target = "glibc-gconv-iso8859-1"
should work?
We have the open bug to address the core provider issue.
Cheers,
Richard
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1
2013-05-29 9:41 ` Richard Purdie
@ 2013-05-29 13:41 ` Marinescu, Bogdan A
0 siblings, 0 replies; 9+ messages in thread
From: Marinescu, Bogdan A @ 2013-05-29 13:41 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]
On Wed, May 29, 2013 at 12:41 PM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2013-05-22 at 14:41 +0100, Burton, Ross wrote:
> > On 22 May 2013 13:51, Phil Blundell <pb@pbcl.net> wrote:
> > > I had thought we had virtual-gconv-ENCODING providers but apparently
> > > that's not the case. So I think the answer at the moment is probably
> > > no. I guess we should add something like that.
> >
> > Agreed. Filed https://bugzilla.yoctoproject.org/show_bug.cgi?id=4530.
>
> I'd really like to at least get the partial fix merged for this. How
> about we make this a libc class override? We can use the target override
> too, something like:
>
> RDEPENDS_${PN}_append_libc-glibc_class-target = "glibc-gconv-iso8859-1"
>
> should work?
>
This seems to be the best option for now, thanks for the suggestion. I've
sent a patch that implements this solution.
Thanks,
Bogdan
>
> We have the open bug to address the core provider issue.
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 2256 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-05-29 13:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-22 10:57 [PATCH v2] guile: added runtime dependency on glibc-gconv-iso8859-1 Bogdan Marinescu
2013-05-22 10:58 ` Phil Blundell
2013-05-22 12:05 ` Burton, Ross
2013-05-22 12:51 ` Phil Blundell
2013-05-22 13:41 ` Burton, Ross
2013-05-28 14:14 ` Marinescu, Bogdan A
2013-05-29 9:40 ` Burton, Ross
2013-05-29 9:41 ` Richard Purdie
2013-05-29 13:41 ` Marinescu, Bogdan A
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.