[PATCH] gtk+3: add librsvg to DEPENDS

[PATCH] gtk+3: add librsvg to DEPENDS

[Andreas Müller]

adwaita-icon-themes failes to create symbolic icons. In log.do_install when
calling gtk-encode-symbolic-svg there many complaints

| Can't load file: Unrecognized image file format

We fail her now due to:

commit 7f6c57635ff4e1edf7a46c49af34846ad0a4bf73
Author: Alexander Kanavin <alex.kanavin@gmail.com>
Date:   Wed Jan 30 11:59:25 2019 +0100

gtk+3: remove the gtk-icon-utils-native recipe

gtk-icon-utils-native had librsvg in its DEPENDS. We do not add librsvg-native
because same issue would occure for gtk-encode-symbolic-svg on target.

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-gnome/gtk+/gtk+3.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-gnome/gtk+/gtk+3.inc b/meta/recipes-gnome/gtk+/gtk+3.inc
index 77b6c31536..b58641a470 100644
--- a/meta/recipes-gnome/gtk+/gtk+3.inc
+++ b/meta/recipes-gnome/gtk+/gtk+3.inc
@@ -5,7 +5,7 @@ HOMEPAGE = "http://www.gtk.org"
 BUGTRACKER = "https://bugzilla.gnome.org/"
 SECTION = "libs"
 
-DEPENDS = "glib-2.0 cairo pango atk jpeg libpng gdk-pixbuf \
+DEPENDS = "glib-2.0 cairo pango atk jpeg libpng gdk-pixbuf librsvg \
            gdk-pixbuf-native"
 
 LICENSE = "LGPLv2 & LGPLv2+ & LGPLv2.1+"
-- 
2.20.1

Re: [PATCH] gtk+3: add librsvg to DEPENDS

[Burton, Ross]

But GTK+ doesn't depend on librsvg at all, and this is a failure in
adwaita-icon-theme.  Why doesn't the dependency belong on
adwaita-icon-theme?

Ross

On Tue, 26 Mar 2019 at 10:30, Andreas Müller <schnitzeltony@gmail.com> wrote:
>
> adwaita-icon-themes failes to create symbolic icons. In log.do_install when
> calling gtk-encode-symbolic-svg there many complaints
>
> | Can't load file: Unrecognized image file format
>
> We fail her now due to:
>
> commit 7f6c57635ff4e1edf7a46c49af34846ad0a4bf73
> Author: Alexander Kanavin <alex.kanavin@gmail.com>
> Date:   Wed Jan 30 11:59:25 2019 +0100
>
> gtk+3: remove the gtk-icon-utils-native recipe
>
> gtk-icon-utils-native had librsvg in its DEPENDS. We do not add librsvg-native
> because same issue would occure for gtk-encode-symbolic-svg on target.
>
> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> ---
>  meta/recipes-gnome/gtk+/gtk+3.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-gnome/gtk+/gtk+3.inc b/meta/recipes-gnome/gtk+/gtk+3.inc
> index 77b6c31536..b58641a470 100644
> --- a/meta/recipes-gnome/gtk+/gtk+3.inc
> +++ b/meta/recipes-gnome/gtk+/gtk+3.inc
> @@ -5,7 +5,7 @@ HOMEPAGE = "http://www.gtk.org"
>  BUGTRACKER = "https://bugzilla.gnome.org/"
>  SECTION = "libs"
>
> -DEPENDS = "glib-2.0 cairo pango atk jpeg libpng gdk-pixbuf \
> +DEPENDS = "glib-2.0 cairo pango atk jpeg libpng gdk-pixbuf librsvg \
>             gdk-pixbuf-native"
>
>  LICENSE = "LGPLv2 & LGPLv2+ & LGPLv2.1+"
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] gtk+3: add librsvg to DEPENDS

[Alexander Kanavin]

On Fri, 29 Mar 2019 at 13:04, Burton, Ross <ross.burton@intel.com> wrote:
>
> But GTK+ doesn't depend on librsvg at all, and this is a failure in
> adwaita-icon-theme.  Why doesn't the dependency belong on
> adwaita-icon-theme?

I believe adwaita runs some utility that gtk provides?

Alex

Re: [PATCH] gtk+3: add librsvg to DEPENDS

[Burton, Ross]

On Fri, 29 Mar 2019 at 12:11, Alexander Kanavin <alex.kanavin@gmail.com> wrote:
>
> On Fri, 29 Mar 2019 at 13:04, Burton, Ross <ross.burton@intel.com> wrote:
> >
> > But GTK+ doesn't depend on librsvg at all, and this is a failure in
> > adwaita-icon-theme.  Why doesn't the dependency belong on
> > adwaita-icon-theme?
>
> I believe adwaita runs some utility that gtk provides?

Sure, but gtk+ doesn't link to librsvg, so a DEPENDS isn't the correct fix.

Patch incoming.

Ross

Re: [PATCH] gtk+3: add librsvg to DEPENDS

[Andreas Müller]

On Fri, Mar 29, 2019 at 2:31 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Fri, 29 Mar 2019 at 12:11, Alexander Kanavin <alex.kanavin@gmail.com> wrote:
> >
> > On Fri, 29 Mar 2019 at 13:04, Burton, Ross <ross.burton@intel.com> wrote:
> > >
> > > But GTK+ doesn't depend on librsvg at all, and this is a failure in
> > > adwaita-icon-theme.  Why doesn't the dependency belong on
> > > adwaita-icon-theme?
> >
> > I believe adwaita runs some utility that gtk provides?
>
> Sure, but gtk+ doesn't link to librsvg, so a DEPENDS isn't the correct fix.
>
> Patch incoming.
>
Thought same. Are you sure that does not link - or can you explain how
DEPENDs fixed adwaita: If it does not link: How comes that librsvg
makes it into adwaita's native sysroot?

Andreas

Re: [PATCH] gtk+3: add librsvg to DEPENDS

[Burton, Ross]

On Fri, 29 Mar 2019 at 14:29, Andreas Müller <schnitzeltony@gmail.com> wrote:
> Thought same. Are you sure that does not link - or can you explain how
> DEPENDs fixed adwaita: If it does not link: How comes that librsvg
> makes it into adwaita's native sysroot?

I suspect historical about how the sysroot is populated for native
things, as until very recently RDEPENDS wasn't considered.

(oe-core c62520b63284927e177831c351fafa4d2768cb1f)

Ross

Re: [PATCH] gtk+3: add librsvg to DEPENDS

[Andreas Müller]

On Fri, Mar 29, 2019 at 3:34 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Fri, 29 Mar 2019 at 14:29, Andreas Müller <schnitzeltony@gmail.com> wrote:
> > Thought same. Are you sure that does not link - or can you explain how
> > DEPENDs fixed adwaita: If it does not link: How comes that librsvg
> > makes it into adwaita's native sysroot?
>
> I suspect historical about how the sysroot is populated for native
> things, as until very recently RDEPENDS wasn't considered.
>
> (oe-core c62520b63284927e177831c351fafa4d2768cb1f)
>
* Think I had this patch in my builds - whatever
* The patch you just sent: Doesn't adwaita-icon-theme need a rdepend
on librsvg then? If so it is another allarch rdepending on arch
recipe...

Andreas

Re: [PATCH] gtk+3: add librsvg to DEPENDS

[Burton, Ross]

On Fri, 29 Mar 2019 at 14:51, Andreas Müller <schnitzeltony@gmail.com> wrote:
> * The patch you just sent: Doesn't adwaita-icon-theme need a rdepend
> on librsvg then? If so it is another allarch rdepending on arch
> recipe...

RDEPEND? No.  The theme just contains PNGs and SVGs.

Ross

Re: [PATCH] gtk+3: add librsvg to DEPENDS

[Alexander Kanavin]

On Fri, 29 Mar 2019 at 15:34, Burton, Ross <ross.burton@intel.com> wrote:
>
> On Fri, 29 Mar 2019 at 14:29, Andreas Müller <schnitzeltony@gmail.com> wrote:
> > Thought same. Are you sure that does not link - or can you explain how
> > DEPENDs fixed adwaita: If it does not link: How comes that librsvg
> > makes it into adwaita's native sysroot?
>
> I suspect historical about how the sysroot is populated for native
> things, as until very recently RDEPENDS wasn't considered.
>
> (oe-core c62520b63284927e177831c351fafa4d2768cb1f)

There is something I struggle to understand about enabling RDEPENDS for native.

RDEPENDS is listing package names, not recipe names. Yet for native
recipes, the package list is empty, as set by the native.bbclass. How
is this supposed to work then?

A reproducer:

add
RDEPENDS_${PN} = 'libicuio' to libyaml recipe. (libicuio is a package
from icu recipe)

Then libyaml builds, but libyaml-native fails:

ERROR: Nothing RPROVIDES 'libicuio-native' (but
virtual:native:/home/alexander/development/poky/meta/recipes-support/libyaml/libyaml_0.2.2.bb
RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'libicuio-native' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['libicuio-native']
ERROR: Required build target 'libyaml-native' has no buildable providers.
Missing or unbuildable dependency chain was: ['libyaml-native',
'libicuio-native']

Should I file a bug?

Alex

Re: [PATCH] gtk+3: add librsvg to DEPENDS

[Andreas Müller]

On Fri, Mar 29, 2019 at 3:54 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Fri, 29 Mar 2019 at 14:51, Andreas Müller <schnitzeltony@gmail.com> wrote:
> > * The patch you just sent: Doesn't adwaita-icon-theme need a rdepend
> > on librsvg then? If so it is another allarch rdepending on arch
> > recipe...
>
> RDEPEND? No.  The theme just contains PNGs and SVGs.
>
> Ross
Ehm but .. no let's not continue this.

Hope adwaita-icon packs remain complete / have librsvg from elsewhere
in my images.

Andreas

Re: [PATCH] gtk+3: add librsvg to DEPENDS

[Burton, Ross]

On Fri, 29 Mar 2019 at 15:33, Andreas Müller <schnitzeltony@gmail.com> wrote:
> Hope adwaita-icon packs remain complete / have librsvg from elsewhere
> in my images.

The theme itself doesn't mean pulling in librsvg.  Whatever is using
the icons is responsible for that, so if you're using something GNOMEy
then that's gdk-pixbuf + librsvg.

Ross