All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2
@ 2018-02-01 22:10 Alejandro Enedino Hernandez Samaniego
  2018-02-01 22:32 ` ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2) Patchwork
  2018-02-02 23:17 ` [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2 Cal Sullivan
  0 siblings, 2 replies; 11+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2018-02-01 22:10 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandr@xilinx.com>
---
 meta/recipes-devtools/ninja/ninja_1.7.2.bb | 30 ------------------------------
 meta/recipes-devtools/ninja/ninja_1.8.2.bb | 30 ++++++++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 30 deletions(-)
 delete mode 100644 meta/recipes-devtools/ninja/ninja_1.7.2.bb
 create mode 100644 meta/recipes-devtools/ninja/ninja_1.8.2.bb

diff --git a/meta/recipes-devtools/ninja/ninja_1.7.2.bb b/meta/recipes-devtools/ninja/ninja_1.7.2.bb
deleted file mode 100644
index 4d3b272..0000000
--- a/meta/recipes-devtools/ninja/ninja_1.7.2.bb
+++ /dev/null
@@ -1,30 +0,0 @@
-SUMMARY = "Ninja is a small build system with a focus on speed."
-HOMEPAGE = "http://martine.github.com/ninja/"
-LICENSE = "Apache-2.0"
-LIC_FILES_CHKSUM = "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
-
-DEPENDS = "re2c-native ninja-native"
-
-SRCREV = "717b7b4a31db6027207588c0fb89c3ead384747b"
-
-SRC_URI = "git://github.com/martine/ninja.git;branch=release"
-UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
-
-S = "${WORKDIR}/git"
-
-do_configure[noexec] = "1"
-
-do_compile_class-native() {
-       ./configure.py --bootstrap
-}
-
-do_compile() {
-       ./configure.py
-       ninja
-}
-
-do_install() {
-       install -D -m 0755  ${S}/ninja ${D}${bindir}/ninja
-}
-
-BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-devtools/ninja/ninja_1.8.2.bb b/meta/recipes-devtools/ninja/ninja_1.8.2.bb
new file mode 100644
index 0000000..c6fcfef
--- /dev/null
+++ b/meta/recipes-devtools/ninja/ninja_1.8.2.bb
@@ -0,0 +1,30 @@
+SUMMARY = "Ninja is a small build system with a focus on speed."
+HOMEPAGE = "http://martine.github.com/ninja/"
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
+
+DEPENDS = "re2c-native ninja-native"
+
+SRCREV = "253e94c1fa511704baeb61cf69995bbf09ba435e"
+
+SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release"
+UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
+
+S = "${WORKDIR}/git"
+
+do_configure[noexec] = "1"
+
+do_compile_class-native() {
+       ./configure.py --bootstrap
+}
+
+do_compile() {
+       ./configure.py
+       ninja
+}
+
+do_install() {
+       install -D -m 0755  ${S}/ninja ${D}${bindir}/ninja
+}
+
+BBCLASSEXTEND = "native nativesdk"
--
2.7.4

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)
  2018-02-01 22:10 [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2 Alejandro Enedino Hernandez Samaniego
@ 2018-02-01 22:32 ` Patchwork
  2018-02-02 19:06   ` Alejandro Enedino Hernandez Samaniego
  2018-02-02 23:17 ` [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2 Cal Sullivan
  1 sibling, 1 reply; 11+ messages in thread
From: Patchwork @ 2018-02-01 22:32 UTC (permalink / raw)
  To: Alejandro Enedino Hernandez Samaniego; +Cc: openembedded-core

== Series Details ==

Series: ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)
Revision: 2
URL   : https://patchwork.openembedded.org/series/10780/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at a0988c3374)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)
  2018-02-01 22:32 ` ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2) Patchwork
@ 2018-02-02 19:06   ` Alejandro Enedino Hernandez Samaniego
  2018-02-02 20:58     ` Burton, Ross
  0 siblings, 1 reply; 11+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2018-02-02 19:06 UTC (permalink / raw)
  To: openembedded-core

This makes no sense to me, I rebased to master just before sending it.

-----Original Message-----
From: Patchwork [mailto:patchwork@patchwork.openembedded.org] 
Sent: Thursday, February 1, 2018 2:33 PM
To: Alejandro Enedino Hernandez Samaniego <alejandr@xilinx.com>
Cc: openembedded-core@lists.openembedded.org
Subject: ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)

== Series Details ==

Series: ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)
Revision: 2
URL   : https://patchwork.openembedded.org/series/10780/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at a0988c3374)



If you believe any of these test results are incorrect, please reply to the mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)
  2018-02-02 19:06   ` Alejandro Enedino Hernandez Samaniego
@ 2018-02-02 20:58     ` Burton, Ross
  2018-02-02 21:22       ` Alejandro Enedino Hernandez Samaniego
  0 siblings, 1 reply; 11+ messages in thread
From: Burton, Ross @ 2018-02-02 20:58 UTC (permalink / raw)
  To: Alejandro Enedino Hernandez Samaniego; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

On 2 February 2018 at 19:06, Alejandro Enedino Hernandez Samaniego <
alejandr@xilinx.com> wrote:

> This makes no sense to me, I rebased to master just before sending it.
>

Are you sure that the master you're rebasing is the actual upstream master?

Applying: ninja: Upgrade from 1.7.2 to major release 1.8.2
Using index info to reconstruct a base tree...
error: patch failed: meta/recipes-devtools/ninja/ninja_1.7.2.bb:1
error: meta/recipes-devtools/ninja/ninja_1.7.2.bb: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 ninja: Upgrade from 1.7.2 to major release 1.8.2

[-- Attachment #2: Type: text/html, Size: 1213 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)
  2018-02-02 20:58     ` Burton, Ross
@ 2018-02-02 21:22       ` Alejandro Enedino Hernandez Samaniego
  2018-02-02 21:28         ` Alejandro Enedino Hernandez Samaniego
  0 siblings, 1 reply; 11+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2018-02-02 21:22 UTC (permalink / raw)
  To: Burton, Ross; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

This is what I got:


$ git remote show origin
* remote origin
   Fetch URL: git://git.yoctoproject.org/poky
   Push  URL: git://git.yoctoproject.org/poky
   HEAD branch: master

latest commit:

bca260ef4dca87c11fc9d30b2b8a17664dc2d879 ninja: Upgrade from 1.7.2 to 
major release 1.8.2
385944254d0ef88bd6450a221a54cbcb40020b42 tcmode-default.inc: drop 
preferred version of gzip-native



On 02/02/2018 12:58 PM, Burton, Ross wrote:
> On 2 February 2018 at 19:06, Alejandro Enedino Hernandez Samaniego 
> <alejandr@xilinx.com <mailto:alejandr@xilinx.com>> wrote:
>
>     This makes no sense to me, I rebased to master just before sending it.
>
>
> Are you sure that the master you're rebasing is the actual upstream 
> master?
>
> Applying: ninja: Upgrade from 1.7.2 to major release 1.8.2
> Using index info to reconstruct a base tree...
> error: patch failed: meta/recipes-devtools/ninja/ninja_1.7.2.bb:1 
> <http://ninja_1.7.2.bb:1>
> error: meta/recipes-devtools/ninja/ninja_1.7.2.bb 
> <http://ninja_1.7.2.bb>: patch does not apply
> error: Did you hand edit your patch?
> It does not apply to blobs recorded in its index.
> Patch failed at 0001 ninja: Upgrade from 1.7.2 to major release 1.8.2
>


[-- Attachment #2: Type: text/html, Size: 2786 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)
  2018-02-02 21:22       ` Alejandro Enedino Hernandez Samaniego
@ 2018-02-02 21:28         ` Alejandro Enedino Hernandez Samaniego
  2018-02-02 21:34           ` Burton, Ross
  0 siblings, 1 reply; 11+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2018-02-02 21:28 UTC (permalink / raw)
  To: Burton, Ross; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]

I might be wrong but you can check it here as well:

https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=aehs29/ninja


On 02/02/2018 01:22 PM, Alejandro Enedino Hernandez Samaniego wrote:
>
> This is what I got:
>
>
> $ git remote show origin
> * remote origin
>   Fetch URL: git://git.yoctoproject.org/poky
>   Push  URL: git://git.yoctoproject.org/poky
>   HEAD branch: master
>
> latest commit:
>
> bca260ef4dca87c11fc9d30b2b8a17664dc2d879 ninja: Upgrade from 1.7.2 to 
> major release 1.8.2
> 385944254d0ef88bd6450a221a54cbcb40020b42 tcmode-default.inc: drop 
> preferred version of gzip-native
>
>
>
> On 02/02/2018 12:58 PM, Burton, Ross wrote:
>> On 2 February 2018 at 19:06, Alejandro Enedino Hernandez Samaniego 
>> <alejandr@xilinx.com <mailto:alejandr@xilinx.com>> wrote:
>>
>>     This makes no sense to me, I rebased to master just before
>>     sending it.
>>
>>
>> Are you sure that the master you're rebasing is the actual upstream 
>> master?
>>
>> Applying: ninja: Upgrade from 1.7.2 to major release 1.8.2
>> Using index info to reconstruct a base tree...
>> error: patch failed: meta/recipes-devtools/ninja/ninja_1.7.2.bb:1 
>> <http://ninja_1.7.2.bb:1>
>> error: meta/recipes-devtools/ninja/ninja_1.7.2.bb 
>> <http://ninja_1.7.2.bb>: patch does not apply
>> error: Did you hand edit your patch?
>> It does not apply to blobs recorded in its index.
>> Patch failed at 0001 ninja: Upgrade from 1.7.2 to major release 1.8.2
>>
>


[-- Attachment #2: Type: text/html, Size: 3448 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)
  2018-02-02 21:28         ` Alejandro Enedino Hernandez Samaniego
@ 2018-02-02 21:34           ` Burton, Ross
  2018-02-03  2:09             ` Alejandro Enedino Hernandez Samaniego
  0 siblings, 1 reply; 11+ messages in thread
From: Burton, Ross @ 2018-02-02 21:34 UTC (permalink / raw)
  To: Alejandro Enedino Hernandez Samaniego; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]

So I'm 99% sure this is Exchange tramping the mail and git not handling
that, as the patch is quoted-printable encoded.    I'll pick from the
branch :)

Ross

On 2 February 2018 at 21:28, Alejandro Enedino Hernandez Samaniego <
alejandro.enedino.hernandez-samaniego@xilinx.com> wrote:

> I might be wrong but you can check it here as well:
> https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/
> log/?h=aehs29/ninja
>
>
>
> On 02/02/2018 01:22 PM, Alejandro Enedino Hernandez Samaniego wrote:
>
> This is what I got:
>
>
> $ git remote show origin
> * remote origin
>   Fetch URL: git://git.yoctoproject.org/poky
>   Push  URL: git://git.yoctoproject.org/poky
>   HEAD branch: master
>
> latest commit:
>
> bca260ef4dca87c11fc9d30b2b8a17664dc2d879 ninja: Upgrade from 1.7.2 to
> major release 1.8.2
> 385944254d0ef88bd6450a221a54cbcb40020b42 tcmode-default.inc: drop
> preferred version of gzip-native
>
>
>
> On 02/02/2018 12:58 PM, Burton, Ross wrote:
>
> On 2 February 2018 at 19:06, Alejandro Enedino Hernandez Samaniego <
> alejandr@xilinx.com> wrote:
>
>> This makes no sense to me, I rebased to master just before sending it.
>>
>
> Are you sure that the master you're rebasing is the actual upstream master?
>
> Applying: ninja: Upgrade from 1.7.2 to major release 1.8.2
> Using index info to reconstruct a base tree...
> error: patch failed: meta/recipes-devtools/ninja/ninja_1.7.2.bb:1
> error: meta/recipes-devtools/ninja/ninja_1.7.2.bb: patch does not apply
> error: Did you hand edit your patch?
> It does not apply to blobs recorded in its index.
> Patch failed at 0001 ninja: Upgrade from 1.7.2 to major release 1.8.2
>
>
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 3956 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2
  2018-02-01 22:10 [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2 Alejandro Enedino Hernandez Samaniego
  2018-02-01 22:32 ` ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2) Patchwork
@ 2018-02-02 23:17 ` Cal Sullivan
  2018-02-03  2:08   ` Alejandro Enedino Hernandez Samaniego
  1 sibling, 1 reply; 11+ messages in thread
From: Cal Sullivan @ 2018-02-02 23:17 UTC (permalink / raw)
  To: Alejandro Enedino Hernandez Samaniego, openembedded-core



On 02/01/2018 02:10 PM, Alejandro Enedino Hernandez Samaniego wrote:
> Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandr@xilinx.com>
> ---
>   meta/recipes-devtools/ninja/ninja_1.7.2.bb | 30 ------------------------------
>   meta/recipes-devtools/ninja/ninja_1.8.2.bb | 30 ++++++++++++++++++++++++++++++
>   2 files changed, 30 insertions(+), 30 deletions(-)
>   delete mode 100644 meta/recipes-devtools/ninja/ninja_1.7.2.bb
>   create mode 100644 meta/recipes-devtools/ninja/ninja_1.8.2.bb
Adding the following to your .gitconfig will give you more readable 
patches for package upgrades:
[diff]
         renames = copies

It simplifies the delete -> creation to a rename, then shows what 
changed in the renamed file (SRC_URI and SRCREV).

Thanks,
Cal

>
> diff --git a/meta/recipes-devtools/ninja/ninja_1.7.2.bb b/meta/recipes-devtools/ninja/ninja_1.7.2.bb
> deleted file mode 100644
> index 4d3b272..0000000
> --- a/meta/recipes-devtools/ninja/ninja_1.7.2.bb
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -SUMMARY = "Ninja is a small build system with a focus on speed."
> -HOMEPAGE = "http://martine.github.com/ninja/"
> -LICENSE = "Apache-2.0"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
> -
> -DEPENDS = "re2c-native ninja-native"
> -
> -SRCREV = "717b7b4a31db6027207588c0fb89c3ead384747b"
> -
> -SRC_URI = "git://github.com/martine/ninja.git;branch=release"
> -UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
> -
> -S = "${WORKDIR}/git"
> -
> -do_configure[noexec] = "1"
> -
> -do_compile_class-native() {
> -       ./configure.py --bootstrap
> -}
> -
> -do_compile() {
> -       ./configure.py
> -       ninja
> -}
> -
> -do_install() {
> -       install -D -m 0755  ${S}/ninja ${D}${bindir}/ninja
> -}
> -
> -BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-devtools/ninja/ninja_1.8.2.bb b/meta/recipes-devtools/ninja/ninja_1.8.2.bb
> new file mode 100644
> index 0000000..c6fcfef
> --- /dev/null
> +++ b/meta/recipes-devtools/ninja/ninja_1.8.2.bb
> @@ -0,0 +1,30 @@
> +SUMMARY = "Ninja is a small build system with a focus on speed."
> +HOMEPAGE = "http://martine.github.com/ninja/"
> +LICENSE = "Apache-2.0"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
> +
> +DEPENDS = "re2c-native ninja-native"
> +
> +SRCREV = "253e94c1fa511704baeb61cf69995bbf09ba435e"
> +
> +SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release"
> +UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
> +
> +S = "${WORKDIR}/git"
> +
> +do_configure[noexec] = "1"
> +
> +do_compile_class-native() {
> +       ./configure.py --bootstrap
> +}
> +
> +do_compile() {
> +       ./configure.py
> +       ninja
> +}
> +
> +do_install() {
> +       install -D -m 0755  ${S}/ninja ${D}${bindir}/ninja
> +}
> +
> +BBCLASSEXTEND = "native nativesdk"
> --
> 2.7.4
>
> This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2
  2018-02-02 23:17 ` [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2 Cal Sullivan
@ 2018-02-03  2:08   ` Alejandro Enedino Hernandez Samaniego
  2018-02-03 10:22     ` Burton, Ross
  0 siblings, 1 reply; 11+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2018-02-03  2:08 UTC (permalink / raw)
  To: Cal Sullivan, openembedded-core

Hey Cal,

On 02/01/2018 02:10 PM, Alejandro Enedino Hernandez Samaniego wrote:
> Signed-off-by: Alejandro Enedino Hernandez Samaniego 
> <alejandr@xilinx.com>
> ---
>   meta/recipes-devtools/ninja/ninja_1.7.2.bb | 30 ------------------------------
>   meta/recipes-devtools/ninja/ninja_1.8.2.bb | 30 ++++++++++++++++++++++++++++++
>   2 files changed, 30 insertions(+), 30 deletions(-)
>   delete mode 100644 meta/recipes-devtools/ninja/ninja_1.7.2.bb
>   create mode 100644 meta/recipes-devtools/ninja/ninja_1.8.2.bb
Adding the following to your .gitconfig will give you more readable patches for package upgrades:
[diff]
         renames = copies

It simplifies the delete -> creation to a rename, then shows what changed in the renamed file (SRC_URI and SRCREV).

Thanks,
Cal

Good to hear from you!, I thought git mv automatically did that, I was actually surprised it didnt but I didn’t spend too much time on that either.
Thanks!

Alejandro

>
> diff --git a/meta/recipes-devtools/ninja/ninja_1.7.2.bb 
> b/meta/recipes-devtools/ninja/ninja_1.7.2.bb
> deleted file mode 100644
> index 4d3b272..0000000
> --- a/meta/recipes-devtools/ninja/ninja_1.7.2.bb
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -SUMMARY = "Ninja is a small build system with a focus on speed."
> -HOMEPAGE = "http://martine.github.com/ninja/"
> -LICENSE = "Apache-2.0"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
> -
> -DEPENDS = "re2c-native ninja-native"
> -
> -SRCREV = "717b7b4a31db6027207588c0fb89c3ead384747b"
> -
> -SRC_URI = "git://github.com/martine/ninja.git;branch=release"
> -UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
> -
> -S = "${WORKDIR}/git"
> -
> -do_configure[noexec] = "1"
> -
> -do_compile_class-native() {
> -       ./configure.py --bootstrap
> -}
> -
> -do_compile() {
> -       ./configure.py
> -       ninja
> -}
> -
> -do_install() {
> -       install -D -m 0755  ${S}/ninja ${D}${bindir}/ninja
> -}
> -
> -BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-devtools/ninja/ninja_1.8.2.bb 
> b/meta/recipes-devtools/ninja/ninja_1.8.2.bb
> new file mode 100644
> index 0000000..c6fcfef
> --- /dev/null
> +++ b/meta/recipes-devtools/ninja/ninja_1.8.2.bb
> @@ -0,0 +1,30 @@
> +SUMMARY = "Ninja is a small build system with a focus on speed."
> +HOMEPAGE = "http://martine.github.com/ninja/"
> +LICENSE = "Apache-2.0"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
> +
> +DEPENDS = "re2c-native ninja-native"
> +
> +SRCREV = "253e94c1fa511704baeb61cf69995bbf09ba435e"
> +
> +SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release"
> +UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
> +
> +S = "${WORKDIR}/git"
> +
> +do_configure[noexec] = "1"
> +
> +do_compile_class-native() {
> +       ./configure.py --bootstrap
> +}
> +
> +do_compile() {
> +       ./configure.py
> +       ninja
> +}
> +
> +do_install() {
> +       install -D -m 0755  ${S}/ninja ${D}${bindir}/ninja }
> +
> +BBCLASSEXTEND = "native nativesdk"
> --
> 2.7.4
>
> This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)
  2018-02-02 21:34           ` Burton, Ross
@ 2018-02-03  2:09             ` Alejandro Enedino Hernandez Samaniego
  0 siblings, 0 replies; 11+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2018-02-03  2:09 UTC (permalink / raw)
  To: Burton, Ross; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2154 bytes --]

Cool, thanks!

Alejandro

From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: Friday, February 2, 2018 1:35 PM
To: Alejandro Enedino Hernandez Samaniego <alejandr@xilinx.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2)

So I'm 99% sure this is Exchange tramping the mail and git not handling that, as the patch is quoted-printable encoded.    I'll pick from the branch :)

Ross

On 2 February 2018 at 21:28, Alejandro Enedino Hernandez Samaniego <alejandro.enedino.hernandez-samaniego@xilinx.com<mailto:alejandro.enedino.hernandez-samaniego@xilinx.com>> wrote:

I might be wrong but you can check it here as well:
https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=aehs29/ninja


On 02/02/2018 01:22 PM, Alejandro Enedino Hernandez Samaniego wrote:

This is what I got:



$ git remote show origin
* remote origin
  Fetch URL: git://git.yoctoproject.org/poky<http://git.yoctoproject.org/poky>
  Push  URL: git://git.yoctoproject.org/poky<http://git.yoctoproject.org/poky>
  HEAD branch: master

latest commit:

bca260ef4dca87c11fc9d30b2b8a17664dc2d879 ninja: Upgrade from 1.7.2 to major release 1.8.2
385944254d0ef88bd6450a221a54cbcb40020b42 tcmode-default.inc: drop preferred version of gzip-native



On 02/02/2018 12:58 PM, Burton, Ross wrote:
On 2 February 2018 at 19:06, Alejandro Enedino Hernandez Samaniego <alejandr@xilinx.com<mailto:alejandr@xilinx.com>> wrote:
This makes no sense to me, I rebased to master just before sending it.

Are you sure that the master you're rebasing is the actual upstream master?

Applying: ninja: Upgrade from 1.7.2 to major release 1.8.2
Using index info to reconstruct a base tree...
error: patch failed: meta/recipes-devtools/ninja/ninja_1.7.2.bb:1<http://ninja_1.7.2.bb:1>
error: meta/recipes-devtools/ninja/ninja_1.7.2.bb<http://ninja_1.7.2.bb>: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 ninja: Upgrade from 1.7.2 to major release 1.8.2






[-- Attachment #2: Type: text/html, Size: 7399 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2
  2018-02-03  2:08   ` Alejandro Enedino Hernandez Samaniego
@ 2018-02-03 10:22     ` Burton, Ross
  0 siblings, 0 replies; 11+ messages in thread
From: Burton, Ross @ 2018-02-03 10:22 UTC (permalink / raw)
  To: Alejandro Enedino Hernandez Samaniego; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

On 3 February 2018 at 02:08, Alejandro Enedino Hernandez Samaniego <
alejandr@xilinx.com> wrote:

> Good to hear from you!, I thought git mv automatically did that, I was
> actually surprised it didnt but I didn’t spend too much time on that either.
>

So 'git mv' is just a easy way of doing 'cp old new; git add new; git rm
old'.  The delete/creation -> rename magic is a heuristic at patch
generation time based on how similar files are when there is a
create/delete pair.

Ross

[-- Attachment #2: Type: text/html, Size: 838 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-02-03 10:23 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-01 22:10 [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2 Alejandro Enedino Hernandez Samaniego
2018-02-01 22:32 ` ✗ patchtest: failure for ninja: Upgrade from 1.7.2 to major release 1.8.2 (rev2) Patchwork
2018-02-02 19:06   ` Alejandro Enedino Hernandez Samaniego
2018-02-02 20:58     ` Burton, Ross
2018-02-02 21:22       ` Alejandro Enedino Hernandez Samaniego
2018-02-02 21:28         ` Alejandro Enedino Hernandez Samaniego
2018-02-02 21:34           ` Burton, Ross
2018-02-03  2:09             ` Alejandro Enedino Hernandez Samaniego
2018-02-02 23:17 ` [PATCH v2] ninja: Upgrade from 1.7.2 to major release 1.8.2 Cal Sullivan
2018-02-03  2:08   ` Alejandro Enedino Hernandez Samaniego
2018-02-03 10:22     ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.