[meta-oe][PATCH] Fix PACKAGES assignment for fftw

[meta-oe][PATCH] Fix PACKAGES assignment for fftw

[Vladan Jovanovic]

fftw recipe using wrong operator for modifying PACKAGES variable.
---
 meta-oe/recipes-support/fftw/fftw_3.3.6.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-oe/recipes-support/fftw/fftw_3.3.6.bb b/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
index ed14e16..e13684c 100644
--- a/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
+++ b/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
@@ -65,12 +65,12 @@ do_install() {
 }
 
 
-PACKAGES =+ "libfftw libfftwl libfftwf"
+PACKAGES += "libfftw libfftwl libfftwf"
 FILES_libfftw = "${libdir}/libfftw3.so.* ${libdir}/libfftw3_*.so.*"
 FILES_libfftwl = "${libdir}/libfftw3l.so.* ${libdir}/libfftw3l_*.so.*"
 FILES_libfftwf = "${libdir}/libfftw3f.so.* ${libdir}/libfftw3f_*.so.*"
 
-PACKAGES =+ "fftw-wisdom fftwl-wisdom fftwf-wisdom fftw-wisdom-to-conf"
+PACKAGES += "fftw-wisdom fftwl-wisdom fftwf-wisdom fftw-wisdom-to-conf"
 FILES_fftw-wisdom = "${bindir}/fftw-wisdom"
 FILES_fftwl-wisdom = "${bindir}/fftwl-wisdom"
 FILES_fftwf-wisdom = "${bindir}/fftwf-wisdom"
-- 
1.9.1

Re: [meta-oe][PATCH] Fix PACKAGES assignment for fftw

[Koen Kooi]

Op 23-11-17 om 14:25 schreef Vladan Jovanovic:
> fftw recipe using wrong operator for modifying PACKAGES variable.

Please explain what's wrong with it and show a buildhistory-diff between the 2 builds.


> ---
>  meta-oe/recipes-support/fftw/fftw_3.3.6.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-support/fftw/fftw_3.3.6.bb b/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> index ed14e16..e13684c 100644
> --- a/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> +++ b/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> @@ -65,12 +65,12 @@ do_install() {
>  }
>  
>  
> -PACKAGES =+ "libfftw libfftwl libfftwf"
> +PACKAGES += "libfftw libfftwl libfftwf"
>  FILES_libfftw = "${libdir}/libfftw3.so.* ${libdir}/libfftw3_*.so.*"
>  FILES_libfftwl = "${libdir}/libfftw3l.so.* ${libdir}/libfftw3l_*.so.*"
>  FILES_libfftwf = "${libdir}/libfftw3f.so.* ${libdir}/libfftw3f_*.so.*"
>  
> -PACKAGES =+ "fftw-wisdom fftwl-wisdom fftwf-wisdom fftw-wisdom-to-conf"
> +PACKAGES += "fftw-wisdom fftwl-wisdom fftwf-wisdom fftw-wisdom-to-conf"
>  FILES_fftw-wisdom = "${bindir}/fftw-wisdom"
>  FILES_fftwl-wisdom = "${bindir}/fftwl-wisdom"
>  FILES_fftwf-wisdom = "${bindir}/fftwf-wisdom"
> 

Re: [meta-oe][PATCH] Fix PACKAGES assignment for fftw

[Burton, Ross]

You should explain why its the wrong operator, as =+ is as valid as += is.

Ross

On 23 November 2017 at 13:25, Vladan Jovanovic <vladan.jovanovic@gmail.com>
wrote:

> fftw recipe using wrong operator for modifying PACKAGES variable.
> ---
>  meta-oe/recipes-support/fftw/fftw_3.3.6.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> b/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> index ed14e16..e13684c 100644
> --- a/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> +++ b/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> @@ -65,12 +65,12 @@ do_install() {
>  }
>
>
> -PACKAGES =+ "libfftw libfftwl libfftwf"
> +PACKAGES += "libfftw libfftwl libfftwf"
>  FILES_libfftw = "${libdir}/libfftw3.so.* ${libdir}/libfftw3_*.so.*"
>  FILES_libfftwl = "${libdir}/libfftw3l.so.* ${libdir}/libfftw3l_*.so.*"
>  FILES_libfftwf = "${libdir}/libfftw3f.so.* ${libdir}/libfftw3f_*.so.*"
>
> -PACKAGES =+ "fftw-wisdom fftwl-wisdom fftwf-wisdom fftw-wisdom-to-conf"
> +PACKAGES += "fftw-wisdom fftwl-wisdom fftwf-wisdom fftw-wisdom-to-conf"
>  FILES_fftw-wisdom = "${bindir}/fftw-wisdom"
>  FILES_fftwl-wisdom = "${bindir}/fftwl-wisdom"
>  FILES_fftwf-wisdom = "${bindir}/fftwf-wisdom"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-oe][PATCH] Fix PACKAGES assignment for fftw

[Andreas Müller]

On Thu, Nov 23, 2017 at 3:40 PM, Koen Kooi <koen@dominion.thruhere.net>
wrote:

> Op 23-11-17 om 14:25 schreef Vladan Jovanovic:
> > fftw recipe using wrong operator for modifying PACKAGES variable.
>
> Please explain what's wrong with it and show a buildhistory-diff between
> the 2 builds.
>
>
> > ---
> >  meta-oe/recipes-support/fftw/fftw_3.3.6.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> b/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> > index ed14e16..e13684c 100644
> > --- a/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> > +++ b/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> > @@ -65,12 +65,12 @@ do_install() {
> >  }
> >
> >
> > -PACKAGES =+ "libfftw libfftwl libfftwf"
> > +PACKAGES += "libfftw libfftwl libfftwf"
> >  FILES_libfftw = "${libdir}/libfftw3.so.* ${libdir}/libfftw3_*.so.*"
> >  FILES_libfftwl = "${libdir}/libfftw3l.so.* ${libdir}/libfftw3l_*.so.*"
> >  FILES_libfftwf = "${libdir}/libfftw3f.so.* ${libdir}/libfftw3f_*.so.*"
> >
> > -PACKAGES =+ "fftw-wisdom fftwl-wisdom fftwf-wisdom fftw-wisdom-to-conf"
> > +PACKAGES += "fftw-wisdom fftwl-wisdom fftwf-wisdom fftw-wisdom-to-conf"
> >  FILES_fftw-wisdom = "${bindir}/fftw-wisdom"
> >  FILES_fftwl-wisdom = "${bindir}/fftwl-wisdom"
> >  FILES_fftwf-wisdom = "${bindir}/fftwf-wisdom"
> >
>
>
> NAK: This breaks packaging: All libdir binaries go to fftw package. Split
was intended.

Andreas

Re: [meta-oe][PATCH] Fix PACKAGES assignment for fftw

[Vladan Jovanovic]

On Thu, Nov 23, 2017 at 4:43 PM, Burton, Ross <ross.burton@intel.com> wrote:

> You should explain why its the wrong operator, as =+ is as valid as += is.
>
>
I got build errors as shown below when trying to build fftw. Went away when
I changed the operator...

Vladan

ERROR: core-image-minimal-1.0-r0 do_rootfs: fftw not found in the feeds
(imx7dsabresd cortexa7t2hf-neon-mx7d cortexa7hf-neon-mx7d cortexa7hf-neon
cortexa7hf-vfp armv7vehf-neon armv7vehf-vfp armv7ahf-vfp armv6hf-vfp
armv5ehf-vfp armv5hf-vfp noarch any all) in
/home/vladan/fsl-release-bsp-4.9.11_1.0.0_ga/build-mx7d-x11/tmp/deploy/rpm.
ERROR: core-image-minimal-1.0-r0 do_rootfs: This is often caused by an
empty package declared in a recipe's PACKAGES variable. (Empty packages are
not constructed unless ALLOW_EMPTY_<pkg> = '1' is used.)
ERROR: core-image-minimal-1.0-r0 do_rootfs: Function failed: do_rootfs
ERROR: Logfile of failure stored in:
/home/vladan/fsl-release-bsp-4.9.11_1.0.0_ga/build-mx7d-x11/tmp/work/imx7dsabresd-poky-linux-gnueabi/core-image-minimal/1.0-r0/temp/log.do_rootfs.29692
ERROR: Task
(/home/vladan/fsl-release-bsp-4.9.11_1.0.0_ga/sources/poky/meta/recipes-core/images/core-image-minimal.bb:do_rootfs)
failed with exit code '1'

Re: [meta-oe][PATCH] Fix PACKAGES assignment for fftw

[Andreas Müller]

On Fri, Nov 24, 2017 at 11:24 AM, Vladan Jovanovic <
vladan.jovanovic@gmail.com> wrote:

> On Thu, Nov 23, 2017 at 4:43 PM, Burton, Ross <ross.burton@intel.com>
> wrote:
>
> > You should explain why its the wrong operator, as =+ is as valid as +=
> is.
> >
> >
> I got build errors as shown below when trying to build fftw. Went away when
> I changed the operator...
>
> Vladan
>
> ERROR: core-image-minimal-1.0-r0 do_rootfs: fftw not found in the feeds
> (imx7dsabresd cortexa7t2hf-neon-mx7d cortexa7hf-neon-mx7d cortexa7hf-neon
> cortexa7hf-vfp armv7vehf-neon armv7vehf-vfp armv7ahf-vfp armv6hf-vfp
> armv5ehf-vfp armv5hf-vfp noarch any all) in
> /home/vladan/fsl-release-bsp-4.9.11_1.0.0_ga/build-mx7d-
> x11/tmp/deploy/rpm.
> ERROR: core-image-minimal-1.0-r0 do_rootfs: This is often caused by an
> empty package declared in a recipe's PACKAGES variable. (Empty packages are
> not constructed unless ALLOW_EMPTY_<pkg> = '1' is used.)
> ERROR: core-image-minimal-1.0-r0 do_rootfs: Function failed: do_rootfs
> ERROR: Logfile of failure stored in:
> /home/vladan/fsl-release-bsp-4.9.11_1.0.0_ga/build-mx7d-
> x11/tmp/work/imx7dsabresd-poky-linux-gnueabi/core-image-
> minimal/1.0-r0/temp/log.do_rootfs.29692
> ERROR: Task
> (/home/vladan/fsl-release-bsp-4.9.11_1.0.0_ga/sources/poky/
> meta/recipes-core/images/core-image-minimal.bb:do_rootfs)
> failed with exit code '1'
>

fftw builds three different and independent packages
libfftw/libfftwl/libfftwf. Package fftw itself is empty and that is OK
(which version should be preferred?). So an ALLOW_EMPTY_${PN} in fftw would
not solve but wipe away that something in your image wants to install fftw
which does not make sense.

Usually it is not necessary to add fftw packages to your images: the
correct libraries are included into the image by link dependencies.

So I suggest you check where the package fftw is inserted in your image and
remove that.

Hope that helps

Andreas