[daisy][PATCH] gnome-desktop-testing: Fix build on uclibc

[daisy][PATCH] gnome-desktop-testing: Fix build on uclibc

[Khem Raj]

[YOCTO #6577]

Change-Id: Ia29fb963a7df4e77504993172f85851e0b540c7e
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 ...process.c-Enable-GNU-extensions-in-system.patch | 35 ++++++++++++++++++++++
 .../gnome-desktop-testing_2014.1.bb                |  4 ++-
 2 files changed, 38 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing/0001-gsystem-subprocess.c-Enable-GNU-extensions-in-system.patch

diff --git a/meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing/0001-gsystem-subprocess.c-Enable-GNU-extensions-in-system.patch b/meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing/0001-gsystem-subprocess.c-Enable-GNU-extensions-in-system.patch
new file mode 100644
index 0000000..840666f
--- /dev/null
+++ b/meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing/0001-gsystem-subprocess.c-Enable-GNU-extensions-in-system.patch
@@ -0,0 +1,35 @@
+From b1de2c6290bc0651fe87a8c4fb52e7a0a5fe6322 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Sun, 5 Oct 2014 16:01:49 -0700
+Subject: [PATCH] gsystem-subprocess.c: Enable GNU extensions in system  C
+ library
+
+This should export O_CLOEXEC where it is only
+available when _GNU_SOURCE is defined .e.g. uclibc based systems
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+Upstream-Status: Pending
+
+---
+ src/libgsystem/gsystem-subprocess.c | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/src/libgsystem/gsystem-subprocess.c b/src/libgsystem/gsystem-subprocess.c
+index a967896..a52a362 100644
+--- a/src/libgsystem/gsystem-subprocess.c
++++ b/src/libgsystem/gsystem-subprocess.c
+@@ -18,6 +18,10 @@
+ 
+ #include "config.h"
+ 
++#ifndef _GNU_SOURCE
++#define _GNU_SOURCE
++#endif
++
+ #define _GSYSTEM_NO_LOCAL_ALLOC
+ #include "libgsystem.h"
+ 
+-- 
+2.1.1
+
diff --git a/meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing_2014.1.bb b/meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing_2014.1.bb
index 146a02a..c688e9d 100644
--- a/meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing_2014.1.bb
+++ b/meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing_2014.1.bb
@@ -2,7 +2,9 @@ SUMMARY = "Test runner for GNOME-style installed tests"
 HOMEPAGE = "https://wiki.gnome.org/GnomeGoals/InstalledTests"
 LICENSE = "LGPLv2+"
 
-SRC_URI = "${GNOME_MIRROR}/${BPN}/${PV}/${BPN}-${PV}.tar.xz"
+SRC_URI = "${GNOME_MIRROR}/${BPN}/${PV}/${BPN}-${PV}.tar.xz \
+           file://0001-gsystem-subprocess.c-Enable-GNU-extensions-in-system.patch \
+          "
 SRC_URI[md5sum] = "a608ad72a77e23a1aecdfd8d07a94baf"
 SRC_URI[sha256sum] = "1a3eed73678dd22d09d6a7ec4f899557df3e8b4a802affa76d0f163b31286539"
 
-- 
2.1.1

Re: [daisy][PATCH] gnome-desktop-testing: Fix build on uclibc

[Burton, Ross]

On 6 October 2014 00:16, Khem Raj <raj.khem@gmail.com> wrote:
> +From b1de2c6290bc0651fe87a8c4fb52e7a0a5fe6322 Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Sun, 5 Oct 2014 16:01:49 -0700
> +Subject: [PATCH] gsystem-subprocess.c: Enable GNU extensions in system  C
> + library
> +
> +This should export O_CLOEXEC where it is only
> +available when _GNU_SOURCE is defined .e.g. uclibc based systems
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +
> +Upstream-Status: Pending

Shouldn't this be in master before backporting to daisy?

Ross

Re: [daisy][PATCH] gnome-desktop-testing: Fix build on uclibc

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

On Monday, October 6, 2014, Burton, Ross <ross.burton@intel.com> wrote:

> On 6 October 2014 00:16, Khem Raj <raj.khem@gmail.com <javascript:;>>
> wrote:
> > +From b1de2c6290bc0651fe87a8c4fb52e7a0a5fe6322 Mon Sep 17 00:00:00 2001
> > +From: Khem Raj <raj.khem@gmail.com <javascript:;>>
> > +Date: Sun, 5 Oct 2014 16:01:49 -0700
> > +Subject: [PATCH] gsystem-subprocess.c: Enable GNU extensions in system
> C
> > + library
> > +
> > +This should export O_CLOEXEC where it is only
> > +available when _GNU_SOURCE is defined .e.g. uclibc based systems
> > +
> > +Signed-off-by: Khem Raj <raj.khem@gmail.com <javascript:;>>
> > +
> > +Upstream-Status: Pending
>
> Shouldn't this be in master before backporting to daisy?


Yes. It should be in master too, I was not sure if same patch would be
needed on master when I sent this one when I sent this one

>
> Ross
>

[-- Attachment #2: Type: text/html, Size: 1513 bytes --]

Re: [daisy][PATCH] gnome-desktop-testing: Fix build on uclibc

[Burton, Ross]

On 6 October 2014 15:30, Khem Raj <raj.khem@gmail.com> wrote:
> Yes. It should be in master too, I was not sure if same patch would be
> needed on master when I sent this one when I sent this one

Both master and daisy have the same release of gnome-desktop-testing,
so please submit a patch to master that can then be backported to
daisy.

Ross

Re: [daisy][PATCH] gnome-desktop-testing: Fix build on uclibc

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

On Monday, October 6, 2014, Burton, Ross <ross.burton@intel.com> wrote:

> On 6 October 2014 15:30, Khem Raj <raj.khem@gmail.com <javascript:;>>
> wrote:
> > Yes. It should be in master too, I was not sure if same patch would be
> > needed on master when I sent this one when I sent this one
>
> Both master and daisy have the same release of gnome-desktop-testing,
> so please submit a patch to master that can then be backported to
> daisy.
>
> I dont understand. Doesn't Same patch apply to master


> Ross
>

[-- Attachment #2: Type: text/html, Size: 941 bytes --]

Re: [daisy][PATCH] gnome-desktop-testing: Fix build on uclibc

[Burton, Ross]

On 6 October 2014 21:15, Khem Raj <raj.khem@gmail.com> wrote:
> I dont understand. Doesn't Same patch apply to master

You know I looked at this earlier and thought it wouldn't apply.  Just
looked again and it was me mis-reading a patch (those - and + symbols
look so similar!).    Sorry for the confusion.

Ross