[meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Otavio Salvador]

The chmod was removing the executing bit from the directory and then
the native version was failing to build.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

 meta-python/recipes-devtools/python/python-idna.inc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/meta-python/recipes-devtools/python/python-idna.inc b/meta-python/recipes-devtools/python/python-idna.inc
index 436b58606..519812ddc 100644
--- a/meta-python/recipes-devtools/python/python-idna.inc
+++ b/meta-python/recipes-devtools/python/python-idna.inc
@@ -16,7 +16,3 @@ do_compile_prepend() {
 }
 
 BBCLASSEXTEND = "native nativesdk"
-
-do_install_append() {
-    chmod 664 -R ${D}${PYTHON_SITEPACKAGES_DIR}/*.egg-info/
-}
\ No newline at end of file
-- 
2.20.1

[meta-oe PATCH 2/2] python-idna: Upgrade 2.7 -> 2.8

[Otavio Salvador]

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

 meta-python/recipes-devtools/python/python-idna.inc           | 4 ++--
 .../python/{python-idna_2.7.bb => python-idna_2.8.bb}         | 0
 .../python/{python3-idna_2.7.bb => python3-idna_2.8.bb}       | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename meta-python/recipes-devtools/python/{python-idna_2.7.bb => python-idna_2.8.bb} (100%)
 rename meta-python/recipes-devtools/python/{python3-idna_2.7.bb => python3-idna_2.8.bb} (100%)

diff --git a/meta-python/recipes-devtools/python/python-idna.inc b/meta-python/recipes-devtools/python/python-idna.inc
index 519812ddc..13b0cdb62 100644
--- a/meta-python/recipes-devtools/python/python-idna.inc
+++ b/meta-python/recipes-devtools/python/python-idna.inc
@@ -3,8 +3,8 @@ HOMEPAGE = "https://github.com/kjd/idna"
 LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
 LIC_FILES_CHKSUM = "file://LICENSE.rst;md5=782775b32f96098512e283fb5d4546cd"
 
-SRC_URI[md5sum] = "0e5bb69018ddef1b9d95f681182be82c"
-SRC_URI[sha256sum] = "684a38a6f903c1d71d6d5fac066b58d7768af4de2b832e426ec79c30daa94a16"
+SRC_URI[md5sum] = "2e9ae0b4a0b26d1747c6127cdb060bc1"
+SRC_URI[sha256sum] = "c357b3f628cf53ae2c4c05627ecc484553142ca23264e593d327bcde5e9c3407"
 
 RDEPENDS_${PN}_class-target = "\
     ${PYTHON_PN}-codecs \
diff --git a/meta-python/recipes-devtools/python/python-idna_2.7.bb b/meta-python/recipes-devtools/python/python-idna_2.8.bb
similarity index 100%
rename from meta-python/recipes-devtools/python/python-idna_2.7.bb
rename to meta-python/recipes-devtools/python/python-idna_2.8.bb
diff --git a/meta-python/recipes-devtools/python/python3-idna_2.7.bb b/meta-python/recipes-devtools/python/python3-idna_2.8.bb
similarity index 100%
rename from meta-python/recipes-devtools/python/python3-idna_2.7.bb
rename to meta-python/recipes-devtools/python/python3-idna_2.8.bb
-- 
2.20.1

Re: [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Khem Raj]

On Mon, Feb 25, 2019 at 6:00 AM Otavio Salvador <otavio@ossystems.com.br> wrote:
>
> The chmod was removing the executing bit from the directory and then
> the native version was failing to build.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>
>  meta-python/recipes-devtools/python/python-idna.inc | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/meta-python/recipes-devtools/python/python-idna.inc b/meta-python/recipes-devtools/python/python-idna.inc
> index 436b58606..519812ddc 100644
> --- a/meta-python/recipes-devtools/python/python-idna.inc
> +++ b/meta-python/recipes-devtools/python/python-idna.inc
> @@ -16,7 +16,3 @@ do_compile_prepend() {
>  }
>
>  BBCLASSEXTEND = "native nativesdk"
> -
> -do_install_append() {
> -    chmod 664 -R ${D}${PYTHON_SITEPACKAGES_DIR}/*.egg-info/
> -}

this overturns a prior fix
https://git.openembedded.org/meta-openembedded/commit/?id=79bb01985260800f80b393e73b387543f86f9e62

I think it would be better to resolve the original issue before reverting
it or maybe just appy this for target recipe alone

> \ No newline at end of file
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Burton, Ross]

The original patch doesn't explain what it's doing and is clearly
going to remove executable bits from directories, which clearly isn't
right.

I'd say remove it, and *then* if it breaks again fix properly.

Ross

On Mon, 25 Feb 2019 at 15:07, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Feb 25, 2019 at 6:00 AM Otavio Salvador <otavio@ossystems.com.br> wrote:
> >
> > The chmod was removing the executing bit from the directory and then
> > the native version was failing to build.
> >
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > ---
> >
> >  meta-python/recipes-devtools/python/python-idna.inc | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/meta-python/recipes-devtools/python/python-idna.inc b/meta-python/recipes-devtools/python/python-idna.inc
> > index 436b58606..519812ddc 100644
> > --- a/meta-python/recipes-devtools/python/python-idna.inc
> > +++ b/meta-python/recipes-devtools/python/python-idna.inc
> > @@ -16,7 +16,3 @@ do_compile_prepend() {
> >  }
> >
> >  BBCLASSEXTEND = "native nativesdk"
> > -
> > -do_install_append() {
> > -    chmod 664 -R ${D}${PYTHON_SITEPACKAGES_DIR}/*.egg-info/
> > -}
>
> this overturns a prior fix
> https://git.openembedded.org/meta-openembedded/commit/?id=79bb01985260800f80b393e73b387543f86f9e62
>
> I think it would be better to resolve the original issue before reverting
> it or maybe just appy this for target recipe alone
>
> > \ No newline at end of file
> > --
> > 2.20.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Otavio Salvador]

On Mon, Feb 25, 2019 at 2:03 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> The original patch doesn't explain what it's doing and is clearly
> going to remove executable bits from directories, which clearly isn't
> right.
>
> I'd say remove it, and *then* if it breaks again fix properly.

I am with Ross here. It is a really ugly patch and if need, we need a
comment on the code and a proper reason to add it back.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

Re: [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Khem Raj]

On Mon, Feb 25, 2019 at 10:38 AM Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
>
> On Mon, Feb 25, 2019 at 2:03 PM Burton, Ross <ross.burton@intel.com> wrote:
> >
> > The original patch doesn't explain what it's doing and is clearly
> > going to remove executable bits from directories, which clearly isn't
> > right.
> >
> > I'd say remove it, and *then* if it breaks again fix properly.
>
> I am with Ross here. It is a really ugly patch and if need, we need a
> comment on the code and a proper reason to add it back.
>

+Maxime for information on the original patch

Re: [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Khem Raj]

Otavio

Can you resend this patch series, its missing in patchwork, so
hopefully, it will catch it this time.

On Mon, Feb 25, 2019 at 11:05 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Feb 25, 2019 at 10:38 AM Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
> >
> > On Mon, Feb 25, 2019 at 2:03 PM Burton, Ross <ross.burton@intel.com> wrote:
> > >
> > > The original patch doesn't explain what it's doing and is clearly
> > > going to remove executable bits from directories, which clearly isn't
> > > right.
> > >
> > > I'd say remove it, and *then* if it breaks again fix properly.
> >
> > I am with Ross here. It is a really ugly patch and if need, we need a
> > comment on the code and a proper reason to add it back.
> >
>
> +Maxime for information on the original patch

Re: [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Otavio Salvador]

On Fri, Mar 1, 2019 at 12:56 PM Khem Raj <raj.khem@gmail.com> wrote:
> Can you resend this patch series, its missing in patchwork, so
> hopefully, it will catch it this time.

Resent.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

Re: [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Tim Orling]

On Fri, Mar 1, 2019 at 8:55 AM Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:

> On Fri, Mar 1, 2019 at 12:56 PM Khem Raj <raj.khem@gmail.com> wrote:
> > Can you resend this patch series, its missing in patchwork, so
> > hopefully, it will catch it this time.



>
It might be the ‘+x’ in the subject line. I’ve seen other patches with
“non-standard” characters be missed...


> Resent.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Khem Raj]

On Fri, Mar 1, 2019 at 9:03 AM Tim Orling <ticotimo@gmail.com> wrote:
>
>
>
> On Fri, Mar 1, 2019 at 8:55 AM Otavio Salvador <otavio.salvador@ossystems.com.br> wrote:
>>
>> On Fri, Mar 1, 2019 at 12:56 PM Khem Raj <raj.khem@gmail.com> wrote:
>> > Can you resend this patch series, its missing in patchwork, so
>> > hopefully, it will catch it this time.
>
>
>>
>
> It might be the ‘+x’ in the subject line. I’ve seen other patches with “non-standard” characters be missed...
>

it still is missing. Maybe just send a github pull.

>>
>> Resent.
>>
>> --
>> Otavio Salvador                             O.S. Systems
>> http://www.ossystems.com.br        http://code.ossystems.com.br
>> Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Khem Raj]

Hi Maxime,

I think we need to understand it a bit better, eg. should we need to 
change the mode for directories or just files. I Think it deserves a new 
patch, I am going to apply Otavio's patch and then you can try if that
does not work then lets fix it by changing perms for files.

On 3/1/19 8:38 AM, Maxime BORGES wrote:
> For reference:
> 
> https://github.com/openembedded/meta-openembedded/pull/92#issue-216348464
> 
> ------------------------------------------------------------------------
> *De :* Khem Raj <raj.khem@gmail.com>
> *Envoyé :* vendredi 1 mars 2019 16:56:31
> *À :* Otavio Salvador; Maxime BORGES
> *Cc :* Burton, Ross; Otavio Salvador; Meta-OpenEmbedded Mailing listing
> *Objet :* Re: [oe] [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' 
> from `.egg-info/` directory
> Otavio
> 
> Can you resend this patch series, its missing in patchwork, so
> hopefully, it will catch it this time.
> 
> On Mon, Feb 25, 2019 at 11:05 AM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Mon, Feb 25, 2019 at 10:38 AM Otavio Salvador
>> <otavio.salvador@ossystems.com.br> wrote:
>> >
>> > On Mon, Feb 25, 2019 at 2:03 PM Burton, Ross <ross.burton@intel.com> wrote:
>> > >
>> > > The original patch doesn't explain what it's doing and is clearly
>> > > going to remove executable bits from directories, which clearly isn't
>> > > right.
>> > >
>> > > I'd say remove it, and *then* if it breaks again fix properly.
>> >
>> > I am with Ross here. It is a really ugly patch and if need, we need a
>> > comment on the code and a proper reason to add it back.
>> >
>>
>> +Maxime for information on the original patch

[meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Otavio Salvador]

The chmod was removing the executing bit from the directory and then
the native version was failing to build.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

 meta-python/recipes-devtools/python/python-idna.inc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/meta-python/recipes-devtools/python/python-idna.inc b/meta-python/recipes-devtools/python/python-idna.inc
index 436b58606..519812ddc 100644
--- a/meta-python/recipes-devtools/python/python-idna.inc
+++ b/meta-python/recipes-devtools/python/python-idna.inc
@@ -16,7 +16,3 @@ do_compile_prepend() {
 }
 
 BBCLASSEXTEND = "native nativesdk"
-
-do_install_append() {
-    chmod 664 -R ${D}${PYTHON_SITEPACKAGES_DIR}/*.egg-info/
-}
\ No newline at end of file
-- 
2.21.0

[meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

[Otavio Salvador]

The chmod was removing the executing bit from the directory and then
the native version was failing to build.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

 meta-python/recipes-devtools/python/python-idna.inc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/meta-python/recipes-devtools/python/python-idna.inc b/meta-python/recipes-devtools/python/python-idna.inc
index 436b58606..519812ddc 100644
--- a/meta-python/recipes-devtools/python/python-idna.inc
+++ b/meta-python/recipes-devtools/python/python-idna.inc
@@ -16,7 +16,3 @@ do_compile_prepend() {
 }
 
 BBCLASSEXTEND = "native nativesdk"
-
-do_install_append() {
-    chmod 664 -R ${D}${PYTHON_SITEPACKAGES_DIR}/*.egg-info/
-}
\ No newline at end of file
-- 
2.20.1