* [RFC meta-gnome][PATCH 01/16] sassc: add recipes for libsass-native and sassc-native.
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
@ 2018-10-29 16:40 ` brendank310
2018-10-30 12:10 ` Burton, Ross
2018-10-29 16:40 ` [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell brendank310
` (16 subsequent siblings)
17 siblings, 1 reply; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:40 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../recipes-gnome/gnome3/libsass-native_3.5.4.bb | 16 ++++++++++++++++
.../recipes-gnome/gnome3/sassc-native_3.5.0.bb | 15 +++++++++++++++
2 files changed, 31 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/libsass-native_3.5.4.bb
create mode 100644 meta-gnome/recipes-gnome/gnome3/sassc-native_3.5.0.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/libsass-native_3.5.4.bb b/meta-gnome/recipes-gnome/gnome3/libsass-native_3.5.4.bb
new file mode 100644
index 000000000..37a25f085
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/libsass-native_3.5.4.bb
@@ -0,0 +1,16 @@
+DESCRIPTION = "A C/C++ implementation of a Sass compiler"
+LICENSE = "MIT"
+DEPENDS = " atk glib-2.0 gettext-native "
+
+LIC_FILES_CHKSUM = "file://LICENSE;md5=2f8a76980411a3f1f1480b141ce06744"
+
+SRC_URI = "https://github.com/sass/${BPN}/archive/${PV}.tar.gz \
+ "
+
+SRC_URI[md5sum] = "4af3f4ffd3e8cac1cb1c90ebc2dd41b2"
+SRC_URI[sha256sum] = "5f61cbcddaf8e6ef7a725fcfa5d05297becd7843960f245197ebb655ff868770"
+
+S = "${WORKDIR}/${BPN}-${PV}"
+
+inherit autotools pkgconfig native
+
diff --git a/meta-gnome/recipes-gnome/gnome3/sassc-native_3.5.0.bb b/meta-gnome/recipes-gnome/gnome3/sassc-native_3.5.0.bb
new file mode 100644
index 000000000..5ba15e194
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/sassc-native_3.5.0.bb
@@ -0,0 +1,15 @@
+DESCRIPTION = "libsass command line driver."
+LICENSE = "MIT"
+DEPENDS = " libsass-native "
+
+LIC_FILES_CHKSUM = "file://LICENSE;md5=2f8a76980411a3f1f1480b141ce06744"
+
+SRC_URI = "https://github.com/sass/${BPN}/archive/${PV}.tar.gz \
+ "
+SRC_URI[md5sum] = "f5c6aeb4e98c96d093f20295fc490f2c"
+SRC_URI[sha256sum] = "26f54e31924b83dd706bc77df5f8f5553a84d51365f0e3c566df8de027918042"
+
+S = "${WORKDIR}/${BPN}-${PV}"
+
+inherit autotools pkgconfig distro_features_check native
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 01/16] sassc: add recipes for libsass-native and sassc-native.
2018-10-29 16:40 ` [RFC meta-gnome][PATCH 01/16] sassc: add recipes for libsass-native and sassc-native brendank310
@ 2018-10-30 12:10 ` Burton, Ross
0 siblings, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 12:10 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> +SRC_URI = "https://github.com/sass/${BPN}/archive/${PV}.tar.gz \
> + "
> +SRC_URI[md5sum] = "4af3f4ffd3e8cac1cb1c90ebc2dd41b2"
> +SRC_URI[sha256sum] = "5f61cbcddaf8e6ef7a725fcfa5d05297becd7843960f245197ebb655ff868770"
These tarballs are dynamically generated using git-archive so can
change over time. As the maintainers are not uploading their own
static tarballs, you'll have to use git to fetch these.
> +S = "${WORKDIR}/${BPN}-${PV}"
This is the default.
> +inherit autotools pkgconfig native
Instead of having sassc-native and inheriting native, it's better to
have a sassc.bb and BBCLASSEXTEND=native to get native and target
recipes. Bonus points for test-building the nativesdk variant too.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
2018-10-29 16:40 ` [RFC meta-gnome][PATCH 01/16] sassc: add recipes for libsass-native and sassc-native brendank310
@ 2018-10-29 16:40 ` brendank310
2018-10-29 22:33 ` Andreas Müller
` (2 more replies)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 03/16] gjs: add a recipe for gjs (Gnome JavaScript engine) brendank310
` (15 subsequent siblings)
17 siblings, 3 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:40 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../ibus/0001-strip-out-dbus-build-dep.patch | 29 ++++++++++++
...0002-decorate-automake-for-valaflags.patch | 46 +++++++++++++++++++
.../recipes-gnome/gnome3/ibus_1.5.19.bb | 41 +++++++++++++++++
3 files changed, 116 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch
create mode 100644 meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch
create mode 100644 meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch b/meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch
new file mode 100644
index 000000000..43197615d
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch
@@ -0,0 +1,29 @@
+ibus: Don't run dbus tests within the build.
+
+ Prevent a test requiring spawning a dbus session from running
+ during the build.
+
+ Upstream-status: Inappropriate [disable-feature]
+
+ Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
+
+diff --git a/data/dconf/make-dconf-override-db.sh b/data/dconf/make-dconf-override-db.sh
+index 9c650e9..d7320c3 100755
+--- a/data/dconf/make-dconf-override-db.sh
++++ b/data/dconf/make-dconf-override-db.sh
+@@ -12,10 +12,6 @@ export XDG_CACHE_HOME="$TMPDIR/cache"
+ export GSETTINGS_SCHEMA_DIR="$TMPDIR/schemas"
+ mkdir -p $XDG_CONFIG_HOME $XDG_CACHE_HOME $GSETTINGS_SCHEMA_DIR
+
+-eval `dbus-launch --sh-syntax`
+-
+-trap 'rm -rf $TMPDIR; kill $DBUS_SESSION_BUS_PID' ERR
+-
+ # in case that schema is not installed on the system
+ glib-compile-schemas --targetdir "$GSETTINGS_SCHEMA_DIR" "$PWD"
+
+@@ -47,4 +43,3 @@ done
+
+ rm -rf $TMPDIR
+
+-kill $DBUS_SESSION_BUS_PID
diff --git a/meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch b/meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch
new file mode 100644
index 000000000..b15fec1d4
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch
@@ -0,0 +1,46 @@
+ibus: Add automake decorations to sed in appropriate paths
+
+ Multiple vapidir paths are required to build ibus correctly,
+ so decorations are added to the automake files to allow for
+ sed'ing the appropriate path during do_configure_prepend.
+
+ Upstream-status: Inappropriate [configuration]
+
+ Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
+
+diff --git a/engine/Makefile.am b/engine/Makefile.am
+index 86f0e2b..7e922b5 100644
+--- a/engine/Makefile.am
++++ b/engine/Makefile.am
+@@ -53,6 +53,7 @@ AM_VALAFLAGS = \
+ --vapidir=$(top_builddir)/bindings/vala \
+ --pkg=ibus-1.0 \
+ --target-glib="$(VALA_TARGET_GLIB_VERSION)" \
++ @EXTRA_AM_VALAFLAGS@ \
+ $(NULL)
+
+ libexec_PROGRAMS = \
+diff --git a/tools/Makefile.am b/tools/Makefile.am
+index 5c18d3d..fe727c1 100644
+--- a/tools/Makefile.am
++++ b/tools/Makefile.am
+@@ -61,6 +61,7 @@ AM_VALAFLAGS = \
+ --pkg=posix \
+ --pkg=config \
+ --target-glib="$(VALA_TARGET_GLIB_VERSION)" \
++ @EXTRA_AM_VALAFLAGS@ \
+ $(NULL)
+
+ bin_PROGRAMS = ibus
+diff --git a/ui/gtk3/Makefile.am b/ui/gtk3/Makefile.am
+index aaba7a4..ba48175 100644
+--- a/ui/gtk3/Makefile.am
++++ b/ui/gtk3/Makefile.am
+@@ -80,6 +80,7 @@ AM_VALAFLAGS = \
+ --pkg=xi \
+ --pkg=gdk-wayland \
+ --target-glib="$(VALA_TARGET_GLIB_VERSION)" \
++ @EXTRA_AM_VALAFLAGS@ \
+ $(NULL)
+
+ if ENABLE_LIBNOTIFY
diff --git a/meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb b/meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb
new file mode 100644
index 000000000..ce609fda0
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb
@@ -0,0 +1,41 @@
+DESCRIPTION = "Intelligent Input Bus for Linux/Unix"
+LICENSE = "LGPLv2.1"
+DEPENDS = "prelink \
+ glib-2.0 \
+ gsettings-desktop-schemas \
+ json-glib \
+ gnome-desktop3 \
+ gettext-native \
+ intltool-native \
+ dconf \
+ libnotify \
+ gconf-native \
+ gtk+ \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
+
+SRC_URI = " \
+ https://github.com/ibus/ibus/releases/download/${PV}/${PN}-${PV}.tar.gz \
+ file://0001-strip-out-dbus-build-dep.patch \
+ file://0002-decorate-automake-for-valaflags.patch \
+ "
+
+SRC_URI[md5sum] = "a2be6f200dd9ada2501474a6877a73ef"
+SRC_URI[sha256sum] = "4b66c798dab093f0fa738e5c10688d395a463287d13678c208a81051af5d2429"
+S = "${WORKDIR}/${PN}-${PV}"
+
+inherit autotools pkgconfig gtk-doc distro_features_check vala gobject-introspection
+
+FILES_${PN} += "${datadir}"
+FILES_${PN} += "${libdir}"
+
+EXTRA_OECONF += " --disable-emoji-dict --disable-unicode-dict --disable-tests "
+
+do_configure_prepend() {
+ touch ${S}/ChangeLog
+ sed -i "s^@EXTRA_AM_VALAFLAGS@^--vapidir=${RECIPE_SYSROOT_NATIVE}${datadir}/vala-0.38/vapi --vapidir=${B}/bindings/vala --pkg gio-2.0^g" ${S}/tools/Makefile.am
+ sed -i "s^@EXTRA_AM_VALAFLAGS@^--vapidir=${RECIPE_SYSROOT_NATIVE}${datadir}/vala-0.38/vapi --vapidir=${B}/bindings/vala --pkg gio-2.0^g" ${S}/engine/Makefile.am
+ sed -i "s^@EXTRA_AM_VALAFLAGS@^--vapidir=${RECIPE_SYSROOT_NATIVE}${datadir}/vala-0.38/vapi --vapidir=${B}/bindings/vala --pkg gio-2.0^g" ${S}/ui/gtk3/Makefile.am
+}
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell
2018-10-29 16:40 ` [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell brendank310
@ 2018-10-29 22:33 ` Andreas Müller
2018-10-30 2:38 ` Khem Raj
2018-10-30 11:24 ` Burton, Ross
2 siblings, 0 replies; 64+ messages in thread
From: Andreas Müller @ 2018-10-29 22:33 UTC (permalink / raw)
To: brendank310; +Cc: openembeded-devel
On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../ibus/0001-strip-out-dbus-build-dep.patch | 29 ++++++++++++
> ...0002-decorate-automake-for-valaflags.patch | 46 +++++++++++++++++++
> .../recipes-gnome/gnome3/ibus_1.5.19.bb | 41 +++++++++++++++++
> 3 files changed, 116 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch
> create mode 100644 meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch
> create mode 100644 meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch b/meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch
> new file mode 100644
> index 000000000..43197615d
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch
> @@ -0,0 +1,29 @@
> +ibus: Don't run dbus tests within the build.
> +
> + Prevent a test requiring spawning a dbus session from running
> + during the build.
> +
> + Upstream-status: Inappropriate [disable-feature]
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/data/dconf/make-dconf-override-db.sh b/data/dconf/make-dconf-override-db.sh
> +index 9c650e9..d7320c3 100755
> +--- a/data/dconf/make-dconf-override-db.sh
> ++++ b/data/dconf/make-dconf-override-db.sh
> +@@ -12,10 +12,6 @@ export XDG_CACHE_HOME="$TMPDIR/cache"
> + export GSETTINGS_SCHEMA_DIR="$TMPDIR/schemas"
> + mkdir -p $XDG_CONFIG_HOME $XDG_CACHE_HOME $GSETTINGS_SCHEMA_DIR
> +
> +-eval `dbus-launch --sh-syntax`
> +-
> +-trap 'rm -rf $TMPDIR; kill $DBUS_SESSION_BUS_PID' ERR
> +-
> + # in case that schema is not installed on the system
> + glib-compile-schemas --targetdir "$GSETTINGS_SCHEMA_DIR" "$PWD"
> +
> +@@ -47,4 +43,3 @@ done
> +
> + rm -rf $TMPDIR
> +
> +-kill $DBUS_SESSION_BUS_PID
> diff --git a/meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch b/meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch
> new file mode 100644
> index 000000000..b15fec1d4
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch
> @@ -0,0 +1,46 @@
> +ibus: Add automake decorations to sed in appropriate paths
> +
> + Multiple vapidir paths are required to build ibus correctly,
> + so decorations are added to the automake files to allow for
> + sed'ing the appropriate path during do_configure_prepend.
> +
> + Upstream-status: Inappropriate [configuration]
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/engine/Makefile.am b/engine/Makefile.am
> +index 86f0e2b..7e922b5 100644
> +--- a/engine/Makefile.am
> ++++ b/engine/Makefile.am
> +@@ -53,6 +53,7 @@ AM_VALAFLAGS = \
> + --vapidir=$(top_builddir)/bindings/vala \
> + --pkg=ibus-1.0 \
> + --target-glib="$(VALA_TARGET_GLIB_VERSION)" \
> ++ @EXTRA_AM_VALAFLAGS@ \
> + $(NULL)
> +
> + libexec_PROGRAMS = \
> +diff --git a/tools/Makefile.am b/tools/Makefile.am
> +index 5c18d3d..fe727c1 100644
> +--- a/tools/Makefile.am
> ++++ b/tools/Makefile.am
> +@@ -61,6 +61,7 @@ AM_VALAFLAGS = \
> + --pkg=posix \
> + --pkg=config \
> + --target-glib="$(VALA_TARGET_GLIB_VERSION)" \
> ++ @EXTRA_AM_VALAFLAGS@ \
> + $(NULL)
> +
> + bin_PROGRAMS = ibus
> +diff --git a/ui/gtk3/Makefile.am b/ui/gtk3/Makefile.am
> +index aaba7a4..ba48175 100644
> +--- a/ui/gtk3/Makefile.am
> ++++ b/ui/gtk3/Makefile.am
> +@@ -80,6 +80,7 @@ AM_VALAFLAGS = \
> + --pkg=xi \
> + --pkg=gdk-wayland \
> + --target-glib="$(VALA_TARGET_GLIB_VERSION)" \
> ++ @EXTRA_AM_VALAFLAGS@ \
> + $(NULL)
> +
> + if ENABLE_LIBNOTIFY
> diff --git a/meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb b/meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb
> new file mode 100644
> index 000000000..ce609fda0
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb
> @@ -0,0 +1,41 @@
> +DESCRIPTION = "Intelligent Input Bus for Linux/Unix"
> +LICENSE = "LGPLv2.1"
> +DEPENDS = "prelink \
> + glib-2.0 \
> + gsettings-desktop-schemas \
> + json-glib \
> + gnome-desktop3 \
> + gettext-native \
> + intltool-native \
> + dconf \
> + libnotify \
> + gconf-native \
> + gtk+ \
> + "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
> +
> +SRC_URI = " \
> + https://github.com/ibus/ibus/releases/download/${PV}/${PN}-${PV}.tar.gz \
> + file://0001-strip-out-dbus-build-dep.patch \
> + file://0002-decorate-automake-for-valaflags.patch \
> + "
> +
> +SRC_URI[md5sum] = "a2be6f200dd9ada2501474a6877a73ef"
> +SRC_URI[sha256sum] = "4b66c798dab093f0fa738e5c10688d395a463287d13678c208a81051af5d2429"
> +S = "${WORKDIR}/${PN}-${PV}"
> +
> +inherit autotools pkgconfig gtk-doc distro_features_check vala gobject-introspection
> +
> +FILES_${PN} += "${datadir}"
> +FILES_${PN} += "${libdir}"
> +
> +EXTRA_OECONF += " --disable-emoji-dict --disable-unicode-dict --disable-tests "
> +
> +do_configure_prepend() {
> + touch ${S}/ChangeLog
> + sed -i "s^@EXTRA_AM_VALAFLAGS@^--vapidir=${RECIPE_SYSROOT_NATIVE}${datadir}/vala-0.38/vapi --vapidir=${B}/bindings/vala --pkg gio-2.0^g" ${S}/tools/Makefile.am
> + sed -i "s^@EXTRA_AM_VALAFLAGS@^--vapidir=${RECIPE_SYSROOT_NATIVE}${datadir}/vala-0.38/vapi --vapidir=${B}/bindings/vala --pkg gio-2.0^g" ${S}/engine/Makefile.am
> + sed -i "s^@EXTRA_AM_VALAFLAGS@^--vapidir=${RECIPE_SYSROOT_NATIVE}${datadir}/vala-0.38/vapi --vapidir=${B}/bindings/vala --pkg gio-2.0^g" ${S}/ui/gtk3/Makefile.am
> +}
> +
We have vala-0.42 on master. Maybe you want to create a variable for
this to avoid redundancies - or better some auto script magic?
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell
2018-10-29 16:40 ` [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell brendank310
2018-10-29 22:33 ` Andreas Müller
@ 2018-10-30 2:38 ` Khem Raj
2018-10-30 11:24 ` Burton, Ross
2 siblings, 0 replies; 64+ messages in thread
From: Khem Raj @ 2018-10-30 2:38 UTC (permalink / raw)
To: brendank310; +Cc: schnitzeltony, openembedded-devel
On Mon, Oct 29, 2018 at 9:41 AM brendank310 <brendank310@gmail.com> wrote:
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../ibus/0001-strip-out-dbus-build-dep.patch | 29 ++++++++++++
> ...0002-decorate-automake-for-valaflags.patch | 46 +++++++++++++++++++
> .../recipes-gnome/gnome3/ibus_1.5.19.bb | 41 +++++++++++++++++
> 3 files changed, 116 insertions(+)
> create mode 100644
> meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch
> create mode 100644
> meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch
> create mode 100644 meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb
>
> diff --git
> a/meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch
> b/meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch
> new file mode 100644
> index 000000000..43197615d
> --- /dev/null
> +++
> b/meta-gnome/recipes-gnome/gnome3/ibus/0001-strip-out-dbus-build-dep.patch
> @@ -0,0 +1,29 @@
> +ibus: Don't run dbus tests within the build.
> +
> + Prevent a test requiring spawning a dbus session from running
> + during the build.
> +
> + Upstream-status: Inappropriate [disable-feature]
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/data/dconf/make-dconf-override-db.sh
> b/data/dconf/make-dconf-override-db.sh
> +index 9c650e9..d7320c3 100755
> +--- a/data/dconf/make-dconf-override-db.sh
> ++++ b/data/dconf/make-dconf-override-db.sh
> +@@ -12,10 +12,6 @@ export XDG_CACHE_HOME="$TMPDIR/cache"
> + export GSETTINGS_SCHEMA_DIR="$TMPDIR/schemas"
> + mkdir -p $XDG_CONFIG_HOME $XDG_CACHE_HOME $GSETTINGS_SCHEMA_DIR
> +
> +-eval `dbus-launch --sh-syntax`
> +-
> +-trap 'rm -rf $TMPDIR; kill $DBUS_SESSION_BUS_PID' ERR
> +-
> + # in case that schema is not installed on the system
> + glib-compile-schemas --targetdir "$GSETTINGS_SCHEMA_DIR" "$PWD"
> +
> +@@ -47,4 +43,3 @@ done
> +
> + rm -rf $TMPDIR
> +
> +-kill $DBUS_SESSION_BUS_PID
> diff --git
> a/meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch
> b/meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch
> new file mode 100644
> index 000000000..b15fec1d4
> --- /dev/null
> +++
> b/meta-gnome/recipes-gnome/gnome3/ibus/0002-decorate-automake-for-valaflags.patch
> @@ -0,0 +1,46 @@
> +ibus: Add automake decorations to sed in appropriate paths
> +
> + Multiple vapidir paths are required to build ibus correctly,
> + so decorations are added to the automake files to allow for
> + sed'ing the appropriate path during do_configure_prepend.
> +
> + Upstream-status: Inappropriate [configuration]
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/engine/Makefile.am b/engine/Makefile.am
> +index 86f0e2b..7e922b5 100644
> +--- a/engine/Makefile.am
> ++++ b/engine/Makefile.am
> +@@ -53,6 +53,7 @@ AM_VALAFLAGS = \
> + --vapidir=$(top_builddir)/bindings/vala \
> + --pkg=ibus-1.0 \
> + --target-glib="$(VALA_TARGET_GLIB_VERSION)" \
> ++ @EXTRA_AM_VALAFLAGS@ \
> + $(NULL)
> +
> + libexec_PROGRAMS = \
> +diff --git a/tools/Makefile.am b/tools/Makefile.am
> +index 5c18d3d..fe727c1 100644
> +--- a/tools/Makefile.am
> ++++ b/tools/Makefile.am
> +@@ -61,6 +61,7 @@ AM_VALAFLAGS = \
> + --pkg=posix \
> + --pkg=config \
> + --target-glib="$(VALA_TARGET_GLIB_VERSION)" \
> ++ @EXTRA_AM_VALAFLAGS@ \
> + $(NULL)
> +
> + bin_PROGRAMS = ibus
> +diff --git a/ui/gtk3/Makefile.am b/ui/gtk3/Makefile.am
> +index aaba7a4..ba48175 100644
> +--- a/ui/gtk3/Makefile.am
> ++++ b/ui/gtk3/Makefile.am
> +@@ -80,6 +80,7 @@ AM_VALAFLAGS = \
> + --pkg=xi \
> + --pkg=gdk-wayland \
> + --target-glib="$(VALA_TARGET_GLIB_VERSION)" \
> ++ @EXTRA_AM_VALAFLAGS@ \
> + $(NULL)
> +
> + if ENABLE_LIBNOTIFY
> diff --git a/meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb
> b/meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb
> new file mode 100644
> index 000000000..ce609fda0
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/ibus_1.5.19.bb
> @@ -0,0 +1,41 @@
> +DESCRIPTION = "Intelligent Input Bus for Linux/Unix"
> +LICENSE = "LGPLv2.1"
> +DEPENDS = "
prelink \
> + glib-2.0 \
Depndending on prelink seems interesting
Can you describe what does it do here since prelink is a distro feature I
would prefer this to be controlled by that knob
>
> + gsettings-desktop-schemas \
> + json-glib \
> + gnome-desktop3 \
> + gettext-native \
Can we inherit gettext for this ?
>
> + intltool-native \
> + dconf \
> + libnotify \
> + gconf-native \
> + gtk+ \
> + "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
> +
> +SRC_URI = " \
> +
> https://github.com/ibus/ibus/releases/download/${PV}/${PN}-${PV}.tar.gz \
> + file://0001-strip-out-dbus-build-dep.patch \
> + file://0002-decorate-automake-for-valaflags.patch \
> + "
> +
> +SRC_URI[md5sum] = "a2be6f200dd9ada2501474a6877a73ef"
> +SRC_URI[sha256sum] =
> "4b66c798dab093f0fa738e5c10688d395a463287d13678c208a81051af5d2429"
> +S = "${WORKDIR}/${PN}-${PV}"
> +
> +inherit autotools pkgconfig gtk-doc distro_features_check vala
> gobject-introspection
> +
> +FILES_${PN} += "${datadir}"
> +FILES_${PN} += "${libdir}"
> +
> +EXTRA_OECONF += " --disable-emoji-dict --disable-unicode-dict
> --disable-tests "
> +
> +do_configure_prepend() {
> + touch ${S}/ChangeLog
> + sed -i "s^@EXTRA_AM_VALAFLAGS@^--vapidir=${RECIPE_SYSROOT_NATIVE}${datadir}/vala-0.38/vapi
> --vapidir=${B}/bindings/vala --pkg gio-2.0^g" ${S}/tools/Makefile.am
> + sed -i "s^@EXTRA_AM_VALAFLAGS@^--vapidir=${RECIPE_SYSROOT_NATIVE}${datadir}/vala-0.38/vapi
> --vapidir=${B}/bindings/vala --pkg gio-2.0^g" ${S}/engine/Makefile.am
> + sed -i "s^@EXTRA_AM_VALAFLAGS@^--vapidir=${RECIPE_SYSROOT_NATIVE}${datadir}/vala-0.38/vapi
> --vapidir=${B}/bindings/vala --pkg gio-2.0^g" ${S}/ui/gtk3/Makefile.am
> +}
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell
2018-10-29 16:40 ` [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell brendank310
2018-10-29 22:33 ` Andreas Müller
2018-10-30 2:38 ` Khem Raj
@ 2018-10-30 11:24 ` Burton, Ross
2018-11-08 17:27 ` Brendan Kerrigan
2 siblings, 1 reply; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 11:24 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:41, brendank310 <brendank310@gmail.com> wrote:
> +DESCRIPTION = "Intelligent Input Bus for Linux/Unix"
> +LICENSE = "LGPLv2.1"
> +DEPENDS = "prelink \
> + gtk+ \
> + "
It depends on gtk+2?
> +S = "${WORKDIR}/${PN}-${PV}"
This is the default.
> +inherit autotools pkgconfig gtk-doc distro_features_check vala gobject-introspection
distro_features_check isn't being used.
> +FILES_${PN} += "${libdir}"
Definitely wrong.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell
2018-10-30 11:24 ` Burton, Ross
@ 2018-11-08 17:27 ` Brendan Kerrigan
2018-11-08 18:32 ` Khem Raj
` (2 more replies)
0 siblings, 3 replies; 64+ messages in thread
From: Brendan Kerrigan @ 2018-11-08 17:27 UTC (permalink / raw)
To: ross.burton; +Cc: Andreas Müller, openembedded-devel
Yeah it does have a build time dependency on gtk+2. I've made the other
changes, though I still have two libraries that are in subdirectories of
libdir that are giving me an installed vs. shipped QA warning. Is it
appropriate to do a more specific packaging within libdir (e.g. FILES_${PN}
+= "${libdir}/subdir/subdir.so") or should I take a different approach?
Thanks,
Brendan
On Tue, Oct 30, 2018 at 7:25 AM Burton, Ross <ross.burton@intel.com> wrote:
> On Mon, 29 Oct 2018 at 16:41, brendank310 <brendank310@gmail.com> wrote:
> > +DESCRIPTION = "Intelligent Input Bus for Linux/Unix"
> > +LICENSE = "LGPLv2.1"
> > +DEPENDS = "prelink \
> > + gtk+ \
> > + "
>
> It depends on gtk+2?
>
> > +S = "${WORKDIR}/${PN}-${PV}"
>
> This is the default.
>
> > +inherit autotools pkgconfig gtk-doc distro_features_check vala
> gobject-introspection
>
> distro_features_check isn't being used.
>
> > +FILES_${PN} += "${libdir}"
>
> Definitely wrong.
>
> Ross
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell
2018-11-08 17:27 ` Brendan Kerrigan
@ 2018-11-08 18:32 ` Khem Raj
2018-11-08 23:12 ` Burton, Ross
2018-11-08 23:13 ` Burton, Ross
2 siblings, 0 replies; 64+ messages in thread
From: Khem Raj @ 2018-11-08 18:32 UTC (permalink / raw)
To: Brendan Kerrigan; +Cc: Andreas Müller, openembedded-devel
On Thu, Nov 8, 2018 at 9:28 AM Brendan Kerrigan <brendank310@gmail.com>
wrote:
> Yeah it does have a build time dependency on gtk+2. I've made the other
> changes, though I still have two libraries that are in subdirectories of
> libdir that are giving me an installed vs. shipped QA warning. Is it
> appropriate to do a more specific packaging within libdir (e.g. FILES_${PN}
> += "${libdir}/subdir/subdir.so") or should I take a different approach?
>
Are they plugins ? If so you can add them to new package like PN-plugins
otherwise this approach is ok
>
> Thanks,
> Brendan
>
> On Tue, Oct 30, 2018 at 7:25 AM Burton, Ross <ross.burton@intel.com>
> wrote:
>
> > On Mon, 29 Oct 2018 at 16:41, brendank310 <brendank310@gmail.com> wrote:
> > > +DESCRIPTION = "Intelligent Input Bus for Linux/Unix"
> > > +LICENSE = "LGPLv2.1"
> > > +DEPENDS = "prelink \
> > > + gtk+ \
> > > + "
> >
> > It depends on gtk+2?
> >
> > > +S = "${WORKDIR}/${PN}-${PV}"
> >
> > This is the default.
> >
> > > +inherit autotools pkgconfig gtk-doc distro_features_check vala
> > gobject-introspection
> >
> > distro_features_check isn't being used.
> >
> > > +FILES_${PN} += "${libdir}"
> >
> > Definitely wrong.
> >
> > Ross
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell
2018-11-08 17:27 ` Brendan Kerrigan
2018-11-08 18:32 ` Khem Raj
@ 2018-11-08 23:12 ` Burton, Ross
2018-11-08 23:13 ` Burton, Ross
2 siblings, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-11-08 23:12 UTC (permalink / raw)
To: Brendan Kerrigan; +Cc: Andreas Müller, OpenEmbedded Devel List
On Thu, 8 Nov 2018 at 17:28, Brendan Kerrigan <brendank310@gmail.com> wrote:
> Yeah it does have a build time dependency on gtk+2. I've made the other changes, though I still have two libraries that are in subdirectories of libdir that are giving me an installed vs. shipped QA warning. Is it appropriate to do a more specific packaging within libdir (e.g. FILES_${PN} += "${libdir}/subdir/subdir.so") or should I take a different approach?
If they're plugins/modules then for clarity do FILES_${PN} +=
${libdir}/subdir/, because if a proper library is ever added the
packaging will totally break.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell
2018-11-08 17:27 ` Brendan Kerrigan
2018-11-08 18:32 ` Khem Raj
2018-11-08 23:12 ` Burton, Ross
@ 2018-11-08 23:13 ` Burton, Ross
2 siblings, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-11-08 23:13 UTC (permalink / raw)
To: Brendan Kerrigan; +Cc: Andreas Müller, OpenEmbedded Devel List
On Thu, 8 Nov 2018 at 17:28, Brendan Kerrigan <brendank310@gmail.com> wrote:
> Yeah it does have a build time dependency on gtk+2.
There's a --disable-gtk2, I'd recommend either just passing that or
for bonus points having a disabled packageconfig to enable/disable
gtk2. GTK+2 is well dead now, so we shouldn't be building it out of
the box.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 03/16] gjs: add a recipe for gjs (Gnome JavaScript engine)
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
2018-10-29 16:40 ` [RFC meta-gnome][PATCH 01/16] sassc: add recipes for libsass-native and sassc-native brendank310
2018-10-29 16:40 ` [RFC meta-gnome][PATCH 02/16] ibus: add recipe for ibus to support gnome-settings-daemon and gnome-shell brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-29 18:07 ` Burton, Ross
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 04/16] accountsservice: add recipe for Accounts Service brendank310
` (14 subsequent siblings)
17 siblings, 1 reply; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Currently this hacks up gjs a little bit and relies on a
specific SRCREV to sidestep the need for mozjs60 support
(use mozjs52 instead).
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../gnome3/gjs/0001-fix-override-allow.patch | 75 +++++++++++++++++++
meta-gnome/recipes-gnome/gnome3/gjs_git.bb | 30 ++++++++
2 files changed, 105 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/gjs/0001-fix-override-allow.patch
create mode 100644 meta-gnome/recipes-gnome/gnome3/gjs_git.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/gjs/0001-fix-override-allow.patch b/meta-gnome/recipes-gnome/gnome3/gjs/0001-fix-override-allow.patch
new file mode 100644
index 000000000..fc152db1d
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gjs/0001-fix-override-allow.patch
@@ -0,0 +1,75 @@
+gjs: Fix broken override GInterface properties
+
+ [gjs Ticket #186] -- https://gitlab.gnome.org/GNOME/gjs/issues/186
+
+ Overriding introspected GObjectInterface properties
+
+ Signed-off-by: Philip Chimento <philip.chimento@gmail.com>
+
+ The patch was imported from the gjs git server
+ (git://gitlab.gnome.org/GNOME/gjs) with a commit id of
+ 322ffab6b0b24ab0ce36079642021d969b081730.
+
+ Upstream-status: Backport
+
+ This recipe can move to tracking a more appropriate revision
+ once a recipe for building mozjs60 is created, and then this
+ patch can be dropped.
+
+ Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
+diff --git a/gi/object.cpp b/gi/object.cpp
+index 2b2265da..70032736 100644
+--- a/gi/object.cpp
++++ b/gi/object.cpp
+@@ -717,7 +717,11 @@ bool ObjectPrototype::lazy_define_gobject_property(JSContext* cx,
+ JS::RootedValue private_id(cx, JS::StringValue(JSID_TO_STRING(id)));
+ if (!gjs_define_property_dynamic(
+ cx, obj, name, "gobject_prop", &ObjectBase::prop_getter,
+- &ObjectBase::prop_setter, private_id, GJS_MODULE_PROP_FLAGS))
++ &ObjectBase::prop_setter, private_id,
++ // Make property configurable so that interface properties can be
++ // overridden by GObject.ParamSpec.override in the class that
++ // implements them
++ GJS_MODULE_PROP_FLAGS & ~JSPROP_PERMANENT))
+ return false;
+
+ *resolved = true;
+diff --git a/installed-tests/js/testGObjectInterface.js b/installed-tests/js/testGObjectInterface.js
+index 9eab9746..daefb683 100644
+--- a/installed-tests/js/testGObjectInterface.js
++++ b/installed-tests/js/testGObjectInterface.js
+@@ -84,6 +84,22 @@ const ImplementationOfTwoInterfaces = GObject.registerClass({
+ }
+ });
+
++const ImplementationOfIntrospectedInterface = GObject.registerClass({
++ Implements: [Gio.Action],
++ Properties: {
++ 'enabled': GObject.ParamSpec.override('enabled', Gio.Action),
++ 'name': GObject.ParamSpec.override('name', Gio.Action),
++ 'state': GObject.ParamSpec.override('state', Gio.Action),
++ 'state-type': GObject.ParamSpec.override('state-type', Gio.Action),
++ 'parameter-type': GObject.ParamSpec.override('parameter-type',
++ Gio.Action)
++ }
++}, class ImplementationOfIntrospectedInterface extends GObject.Object {
++ get name() {
++ return 'inaction';
++ }
++});
++
+ describe('GObject interface', function () {
+ it('cannot be instantiated', function () {
+ expect(() => new AGObjectInterface()).toThrow();
+@@ -247,6 +263,11 @@ describe('GObject interface', function () {
+ 253, 'testGObjectMustOverrideInterfaceProperties');
+ });
+
++ it('can have introspected properties overriden', function() {
++ let obj = new ImplementationOfIntrospectedInterface();
++ expect(obj.name).toEqual('inaction');
++ });
++
+ it('can be implemented by a class as well as its parent class', function () {
+ const SubObject = GObject.registerClass(
+ class SubObject extends GObjectImplementingGObjectInterface {});
diff --git a/meta-gnome/recipes-gnome/gnome3/gjs_git.bb b/meta-gnome/recipes-gnome/gnome3/gjs_git.bb
new file mode 100644
index 000000000..db62f507f
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gjs_git.bb
@@ -0,0 +1,30 @@
+DESCRIPTION = "GNOME JavaScript engine"
+LICENSE = "MIT|LGPLv2+"
+DEPENDS = " \
+ glib-2.0 \
+ gsettings-desktop-schemas \
+ mozjs \
+ cairo \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=beb29cf17fabe736f0639b09ee6e76fa"
+
+SRC_URI = "git://gitlab.gnome.org/GNOME/gjs.git;protocol=http;branch=master \
+ file://0001-fix-override-allow.patch \
+ "
+
+# Last pre-mozjs60 merge commit. Once mozjs is upreved from 52->60,
+# we can select a more sane version.
+SRCREV="f2a8ca3dcfee06e03ae344932537951bc4d7739c"
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig gobject-introspection
+EXTRA_OECONF += " --without-dbus-tests "
+
+FILES_${PN} += "${datadir}"
+
+do_configure_prepend() {
+ export GI_DATADIR="${RECIPE_SYSROOT_NATIVE}${datadir}/gobject-introspection-1.0"
+ sed -i 's#mozjs-17#mozjs-52#g' ${S}/configure.ac
+}
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 03/16] gjs: add a recipe for gjs (Gnome JavaScript engine)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 03/16] gjs: add a recipe for gjs (Gnome JavaScript engine) brendank310
@ 2018-10-29 18:07 ` Burton, Ross
2018-10-29 18:28 ` Brendan Kerrigan
0 siblings, 1 reply; 64+ messages in thread
From: Burton, Ross @ 2018-10-29 18:07 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> +do_configure_prepend() {
> + export GI_DATADIR="${RECIPE_SYSROOT_NATIVE}${datadir}/gobject-introspection-1.0"
> + sed -i 's#mozjs-17#mozjs-52#g' ${S}/configure.ac
> +}
Personally I prefer patches to sed in do_configure, as nobody will
notice when the sed isn't required anymore and the point of the change
isn't always obvious.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 03/16] gjs: add a recipe for gjs (Gnome JavaScript engine)
2018-10-29 18:07 ` Burton, Ross
@ 2018-10-29 18:28 ` Brendan Kerrigan
0 siblings, 0 replies; 64+ messages in thread
From: Brendan Kerrigan @ 2018-10-29 18:28 UTC (permalink / raw)
To: ross.burton; +Cc: Andreas Müller, openembedded-devel
Sounds good I will refresh that change into a patch.
Thanks,
Brendan
On Mon, Oct 29, 2018 at 2:07 PM Burton, Ross <ross.burton@intel.com> wrote:
> On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
>
> > +do_configure_prepend() {
> > + export
> GI_DATADIR="${RECIPE_SYSROOT_NATIVE}${datadir}/gobject-introspection-1.0"
> > + sed -i 's#mozjs-17#mozjs-52#g' ${S}/configure.ac
> > +}
>
> Personally I prefer patches to sed in do_configure, as nobody will
> notice when the sed isn't required anymore and the point of the change
> isn't always obvious.
>
> Ross
>
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 04/16] accountsservice: add recipe for Accounts Service
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (2 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 03/16] gjs: add a recipe for gjs (Gnome JavaScript engine) brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-29 22:43 ` Andreas Müller
2018-10-30 11:30 ` Burton, Ross
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System brendank310
` (13 subsequent siblings)
17 siblings, 2 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../accountsservice/0001-strip-out-intl.patch | 104 ++++++++++++++++++
.../gnome3/accountsservice_git.bb | 24 ++++
2 files changed, 128 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch
create mode 100644 meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch b/meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch
new file mode 100644
index 000000000..622b3335d
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch
@@ -0,0 +1,104 @@
+accountsservice: Remove internationalization
+
+ The i18n internationalization fails within the OE
+ environment.
+
+ Upstream-Status: Inappropriate [disable-feature]
+
+ Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
+
+diff --git a/data/meson.build b/data/meson.build
+index 4987937..6274e5d 100644
+--- a/data/meson.build
++++ b/data/meson.build
+@@ -28,15 +28,6 @@ configure_file(
+
+ policy = act_namespace.to_lower() + '.policy'
+
+-i18n.merge_file(
+- policy,
+- input: policy + '.in',
+- output: policy,
+- po_dir: po_dir,
+- install: true,
+- install_dir: policy_dir,
+-)
+-
+ if install_systemd_unit_dir
+ service = 'accounts-daemon.service'
+
+diff --git a/meson.build b/meson.build
+index 77b6a3f..7da5d5d 100644
+--- a/meson.build
++++ b/meson.build
+@@ -25,8 +25,6 @@ act_pkgincludedir = join_paths(act_includedir, act_api_name)
+
+ act_namespace = 'org.freedesktop.Accounts'
+
+-act_gettext = 'accounts-service'
+-
+ soversion = 0
+ current = 0
+ revision = 0
+@@ -35,11 +33,9 @@ libversion = '@0@.@1@.@2@'.format(soversion, current, revision)
+ act_buildtype = get_option('buildtype')
+
+ gnome = import('gnome')
+-i18n = import('i18n')
+ pkg = import('pkgconfig')
+
+ data_dir = join_paths(meson.current_source_dir(), 'data')
+-po_dir = join_paths(meson.current_source_dir(), 'po')
+
+ top_inc = include_directories('.')
+
+@@ -52,9 +48,6 @@ config_h.set_quoted('VERSION', act_version)
+ config_h.set('_DEFAULT_SOURCE', true)
+ config_h.set('_GNU_SOURCE', true)
+
+-# i18n
+-config_h.set_quoted('GETTEXT_PACKAGE', act_gettext)
+-
+ # headers
+ check_headers = [
+ 'paths.h',
+@@ -182,7 +175,6 @@ config_h.set('WITH_SYSTEMD', enable_systemd or enable_elogind)
+
+ subdir('data')
+ subdir('src')
+-subdir('po')
+
+ enable_docbook = get_option('docbook')
+ if enable_docbook
+diff --git a/src/libaccountsservice/act-user-manager.c b/src/libaccountsservice/act-user-manager.c
+index 12be9cb..712db6c 100644
+--- a/src/libaccountsservice/act-user-manager.c
++++ b/src/libaccountsservice/act-user-manager.c
+@@ -35,7 +35,6 @@
+ #endif /* HAVE_PATHS_H */
+
+ #include <glib.h>
+-#include <glib/gi18n-lib.h>
+ #include <glib/gstdio.h>
+ #include <glib-object.h>
+ #include <gio/gio.h>
+diff --git a/src/main.c b/src/main.c
+index 9caec7f..acbd422 100644
+--- a/src/main.c
++++ b/src/main.c
+@@ -155,7 +155,6 @@ main (int argc, char *argv[])
+ };
+
+ setlocale (LC_ALL, "");
+- bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8");
+
+ #if !GLIB_CHECK_VERSION (2, 35, 3)
+ g_type_init ();
+@@ -167,7 +166,6 @@ main (int argc, char *argv[])
+ }
+
+ context = g_option_context_new ("");
+- g_option_context_set_translation_domain (context, GETTEXT_PACKAGE);
+ g_option_context_set_summary (context, _("Provides D-Bus interfaces for querying and manipulating\nuser account information."));
+ g_option_context_add_main_entries (context, entries, NULL);
+ if (!g_option_context_parse (context, &argc, &argv, &error)) {
diff --git a/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb b/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
new file mode 100644
index 000000000..a019a8c6d
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
@@ -0,0 +1,24 @@
+DESCRIPTION = "Accounts Service"
+LICENSE = "GPLv3"
+DEPENDS = " \
+ glib-2.0 \
+ gsettings-desktop-schemas \
+ polkit \
+ dbus \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
+
+SRC_URI = "git://anongit.freedesktop.org/accountsservice.git;protocol=git;branch=master \
+ file://0001-strip-out-intl.patch \
+ "
+
+FILES_${PN} += "${systemd_system_unitdir}"
+FILES_${PN} += "${datadir}"
+FILES_${PN} += "${libdir}"
+
+SRCREV="${AUTOREV}"
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson gobject-introspection
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 04/16] accountsservice: add recipe for Accounts Service
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 04/16] accountsservice: add recipe for Accounts Service brendank310
@ 2018-10-29 22:43 ` Andreas Müller
2018-10-30 11:48 ` Martin Jansa
2018-10-30 11:30 ` Burton, Ross
1 sibling, 1 reply; 64+ messages in thread
From: Andreas Müller @ 2018-10-29 22:43 UTC (permalink / raw)
To: brendank310; +Cc: openembeded-devel
On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../accountsservice/0001-strip-out-intl.patch | 104 ++++++++++++++++++
> .../gnome3/accountsservice_git.bb | 24 ++++
> 2 files changed, 128 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch
> create mode 100644 meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch b/meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch
> new file mode 100644
> index 000000000..622b3335d
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch
> @@ -0,0 +1,104 @@
> +accountsservice: Remove internationalization
> +
> + The i18n internationalization fails within the OE
> + environment.
> +
> + Upstream-Status: Inappropriate [disable-feature]
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/data/meson.build b/data/meson.build
> +index 4987937..6274e5d 100644
> +--- a/data/meson.build
> ++++ b/data/meson.build
> +@@ -28,15 +28,6 @@ configure_file(
> +
> + policy = act_namespace.to_lower() + '.policy'
> +
> +-i18n.merge_file(
> +- policy,
> +- input: policy + '.in',
> +- output: policy,
> +- po_dir: po_dir,
> +- install: true,
> +- install_dir: policy_dir,
> +-)
> +-
> + if install_systemd_unit_dir
> + service = 'accounts-daemon.service'
> +
> +diff --git a/meson.build b/meson.build
> +index 77b6a3f..7da5d5d 100644
> +--- a/meson.build
> ++++ b/meson.build
> +@@ -25,8 +25,6 @@ act_pkgincludedir = join_paths(act_includedir, act_api_name)
> +
> + act_namespace = 'org.freedesktop.Accounts'
> +
> +-act_gettext = 'accounts-service'
> +-
> + soversion = 0
> + current = 0
> + revision = 0
> +@@ -35,11 +33,9 @@ libversion = '@0@.@1@.@2@'.format(soversion, current, revision)
> + act_buildtype = get_option('buildtype')
> +
> + gnome = import('gnome')
> +-i18n = import('i18n')
> + pkg = import('pkgconfig')
> +
> + data_dir = join_paths(meson.current_source_dir(), 'data')
> +-po_dir = join_paths(meson.current_source_dir(), 'po')
> +
> + top_inc = include_directories('.')
> +
> +@@ -52,9 +48,6 @@ config_h.set_quoted('VERSION', act_version)
> + config_h.set('_DEFAULT_SOURCE', true)
> + config_h.set('_GNU_SOURCE', true)
> +
> +-# i18n
> +-config_h.set_quoted('GETTEXT_PACKAGE', act_gettext)
> +-
> + # headers
> + check_headers = [
> + 'paths.h',
> +@@ -182,7 +175,6 @@ config_h.set('WITH_SYSTEMD', enable_systemd or enable_elogind)
> +
> + subdir('data')
> + subdir('src')
> +-subdir('po')
> +
> + enable_docbook = get_option('docbook')
> + if enable_docbook
> +diff --git a/src/libaccountsservice/act-user-manager.c b/src/libaccountsservice/act-user-manager.c
> +index 12be9cb..712db6c 100644
> +--- a/src/libaccountsservice/act-user-manager.c
> ++++ b/src/libaccountsservice/act-user-manager.c
> +@@ -35,7 +35,6 @@
> + #endif /* HAVE_PATHS_H */
> +
> + #include <glib.h>
> +-#include <glib/gi18n-lib.h>
> + #include <glib/gstdio.h>
> + #include <glib-object.h>
> + #include <gio/gio.h>
> +diff --git a/src/main.c b/src/main.c
> +index 9caec7f..acbd422 100644
> +--- a/src/main.c
> ++++ b/src/main.c
> +@@ -155,7 +155,6 @@ main (int argc, char *argv[])
> + };
> +
> + setlocale (LC_ALL, "");
> +- bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8");
> +
> + #if !GLIB_CHECK_VERSION (2, 35, 3)
> + g_type_init ();
> +@@ -167,7 +166,6 @@ main (int argc, char *argv[])
> + }
> +
> + context = g_option_context_new ("");
> +- g_option_context_set_translation_domain (context, GETTEXT_PACKAGE);
> + g_option_context_set_summary (context, _("Provides D-Bus interfaces for querying and manipulating\nuser account information."));
> + g_option_context_add_main_entries (context, entries, NULL);
> + if (!g_option_context_parse (context, &argc, &argv, &error)) {
> diff --git a/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb b/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
> new file mode 100644
> index 000000000..a019a8c6d
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
> @@ -0,0 +1,24 @@
> +DESCRIPTION = "Accounts Service"
> +LICENSE = "GPLv3"
> +DEPENDS = " \
> + glib-2.0 \
> + gsettings-desktop-schemas \
> + polkit \
> + dbus \
> + "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> +
> +SRC_URI = "git://anongit.freedesktop.org/accountsservice.git;protocol=git;branch=master \
> + file://0001-strip-out-intl.patch \
> + "
> +
> +FILES_${PN} += "${systemd_system_unitdir}"
> +FILES_${PN} += "${datadir}"
^ I hate styleguide nitpickers :) - but please put this into one
statement and to the end of the recipe.
> +FILES_${PN} += "${libdir}"
^ Is this required?
> +
> +SRCREV="${AUTOREV}"
^ No AUTOREV - set a commid ID
> +S = "${WORKDIR}/git"
> +
> +inherit pkgconfig meson gobject-introspection
> +
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 04/16] accountsservice: add recipe for Accounts Service
2018-10-29 22:43 ` Andreas Müller
@ 2018-10-30 11:48 ` Martin Jansa
0 siblings, 0 replies; 64+ messages in thread
From: Martin Jansa @ 2018-10-30 11:48 UTC (permalink / raw)
To: Andreas Müller; +Cc: openembeded-devel
[-- Attachment #1: Type: text/plain, Size: 6426 bytes --]
On Mon, Oct 29, 2018 at 11:43:09PM +0100, Andreas Müller wrote:
> On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
> >
> > From: Brendan Kerrigan <kerriganb@ainfosec.com>
> >
> > Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> > ---
> > .../accountsservice/0001-strip-out-intl.patch | 104 ++++++++++++++++++
> > .../gnome3/accountsservice_git.bb | 24 ++++
> > 2 files changed, 128 insertions(+)
> > create mode 100644 meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch
> > create mode 100644 meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
> >
> > diff --git a/meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch b/meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch
> > new file mode 100644
> > index 000000000..622b3335d
> > --- /dev/null
> > +++ b/meta-gnome/recipes-gnome/gnome3/accountsservice/0001-strip-out-intl.patch
> > @@ -0,0 +1,104 @@
> > +accountsservice: Remove internationalization
> > +
> > + The i18n internationalization fails within the OE
> > + environment.
> > +
> > + Upstream-Status: Inappropriate [disable-feature]
> > +
> > + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> > +
> > +diff --git a/data/meson.build b/data/meson.build
> > +index 4987937..6274e5d 100644
> > +--- a/data/meson.build
> > ++++ b/data/meson.build
> > +@@ -28,15 +28,6 @@ configure_file(
> > +
> > + policy = act_namespace.to_lower() + '.policy'
> > +
> > +-i18n.merge_file(
> > +- policy,
> > +- input: policy + '.in',
> > +- output: policy,
> > +- po_dir: po_dir,
> > +- install: true,
> > +- install_dir: policy_dir,
> > +-)
> > +-
> > + if install_systemd_unit_dir
> > + service = 'accounts-daemon.service'
> > +
> > +diff --git a/meson.build b/meson.build
> > +index 77b6a3f..7da5d5d 100644
> > +--- a/meson.build
> > ++++ b/meson.build
> > +@@ -25,8 +25,6 @@ act_pkgincludedir = join_paths(act_includedir, act_api_name)
> > +
> > + act_namespace = 'org.freedesktop.Accounts'
> > +
> > +-act_gettext = 'accounts-service'
> > +-
> > + soversion = 0
> > + current = 0
> > + revision = 0
> > +@@ -35,11 +33,9 @@ libversion = '@0@.@1@.@2@'.format(soversion, current, revision)
> > + act_buildtype = get_option('buildtype')
> > +
> > + gnome = import('gnome')
> > +-i18n = import('i18n')
> > + pkg = import('pkgconfig')
> > +
> > + data_dir = join_paths(meson.current_source_dir(), 'data')
> > +-po_dir = join_paths(meson.current_source_dir(), 'po')
> > +
> > + top_inc = include_directories('.')
> > +
> > +@@ -52,9 +48,6 @@ config_h.set_quoted('VERSION', act_version)
> > + config_h.set('_DEFAULT_SOURCE', true)
> > + config_h.set('_GNU_SOURCE', true)
> > +
> > +-# i18n
> > +-config_h.set_quoted('GETTEXT_PACKAGE', act_gettext)
> > +-
> > + # headers
> > + check_headers = [
> > + 'paths.h',
> > +@@ -182,7 +175,6 @@ config_h.set('WITH_SYSTEMD', enable_systemd or enable_elogind)
> > +
> > + subdir('data')
> > + subdir('src')
> > +-subdir('po')
> > +
> > + enable_docbook = get_option('docbook')
> > + if enable_docbook
> > +diff --git a/src/libaccountsservice/act-user-manager.c b/src/libaccountsservice/act-user-manager.c
> > +index 12be9cb..712db6c 100644
> > +--- a/src/libaccountsservice/act-user-manager.c
> > ++++ b/src/libaccountsservice/act-user-manager.c
> > +@@ -35,7 +35,6 @@
> > + #endif /* HAVE_PATHS_H */
> > +
> > + #include <glib.h>
> > +-#include <glib/gi18n-lib.h>
> > + #include <glib/gstdio.h>
> > + #include <glib-object.h>
> > + #include <gio/gio.h>
> > +diff --git a/src/main.c b/src/main.c
> > +index 9caec7f..acbd422 100644
> > +--- a/src/main.c
> > ++++ b/src/main.c
> > +@@ -155,7 +155,6 @@ main (int argc, char *argv[])
> > + };
> > +
> > + setlocale (LC_ALL, "");
> > +- bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8");
> > +
> > + #if !GLIB_CHECK_VERSION (2, 35, 3)
> > + g_type_init ();
> > +@@ -167,7 +166,6 @@ main (int argc, char *argv[])
> > + }
> > +
> > + context = g_option_context_new ("");
> > +- g_option_context_set_translation_domain (context, GETTEXT_PACKAGE);
> > + g_option_context_set_summary (context, _("Provides D-Bus interfaces for querying and manipulating\nuser account information."));
> > + g_option_context_add_main_entries (context, entries, NULL);
> > + if (!g_option_context_parse (context, &argc, &argv, &error)) {
> > diff --git a/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb b/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
> > new file mode 100644
> > index 000000000..a019a8c6d
> > --- /dev/null
> > +++ b/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
> > @@ -0,0 +1,24 @@
> > +DESCRIPTION = "Accounts Service"
> > +LICENSE = "GPLv3"
> > +DEPENDS = " \
> > + glib-2.0 \
> > + gsettings-desktop-schemas \
> > + polkit \
> > + dbus \
> > + "
> > +
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> > +
> > +SRC_URI = "git://anongit.freedesktop.org/accountsservice.git;protocol=git;branch=master \
protocol=git and branch=master are default, please drop them.
> > + file://0001-strip-out-intl.patch \
> > + "
> > +
> > +FILES_${PN} += "${systemd_system_unitdir}"
> > +FILES_${PN} += "${datadir}"
> ^ I hate styleguide nitpickers :) - but please put this into one
> statement and to the end of the recipe.
Please while doing these styleguide changes, please use 4 spaces for
indentation *everywhere* and the closing " for multiline variables
should be first character on separate line (not indented).
This does apply to other changes in this patch series as well.
> > +FILES_${PN} += "${libdir}"
> ^ Is this required?
> > +
> > +SRCREV="${AUTOREV}"
> ^ No AUTOREV - set a commid ID
And set PV to something meaningful while doing that.
> > +S = "${WORKDIR}/git"
> > +
> > +inherit pkgconfig meson gobject-introspection
> > +
> > --
> > 2.17.1
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 64+ messages in thread
* Re: [RFC meta-gnome][PATCH 04/16] accountsservice: add recipe for Accounts Service
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 04/16] accountsservice: add recipe for Accounts Service brendank310
2018-10-29 22:43 ` Andreas Müller
@ 2018-10-30 11:30 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 11:30 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> +accountsservice: Remove internationalization
> +
> + The i18n internationalization fails within the OE
> + environment.
Probably because you don't depend on gettext-native.
> + context = g_option_context_new ("");
> +- g_option_context_set_translation_domain (context, GETTEXT_PACKAGE);
> + g_option_context_set_summary (context, _("Provides D-Bus interfaces for querying and manipulating\nuser account information."));
> + g_option_context_add_main_entries (context, entries, NULL);
> + if (!g_option_context_parse (context, &argc, &argv, &error)) {
> diff --git a/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb b/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
> new file mode 100644
> index 000000000..a019a8c6d
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/accountsservice_git.bb
> @@ -0,0 +1,24 @@
> +DESCRIPTION = "Accounts Service"
> +LICENSE = "GPLv3"
> +DEPENDS = " \
> + glib-2.0 \
> + gsettings-desktop-schemas \
> + polkit \
> + dbus \
> + "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> +
> +SRC_URI = "git://anongit.freedesktop.org/accountsservice.git;protocol=git;branch=master \
That's a mirror of
https://gitlab.freedesktop.org/accountsservice/accountsservice.
Also tarballs are at https://www.freedesktop.org/software/accountsservice/.
> + file://0001-strip-out-intl.patch \
> + "
> +
> +FILES_${PN} += "${systemd_system_unitdir}"
Use the systemd class instead.
> +FILES_${PN} += "${libdir}"
As discussed.
> +SRCREV="${AUTOREV}"
As discussed.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (3 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 04/16] accountsservice: add recipe for Accounts Service brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-29 22:46 ` Andreas Müller
` (2 more replies)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 06/16] gnome-settings-daemon: add recipe for gnome-settings-daemon brendank310
` (12 subsequent siblings)
17 siblings, 3 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb | 14 ++++++++++++++
1 file changed, 14 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
new file mode 100644
index 000000000..29947ae76
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
@@ -0,0 +1,14 @@
+DESCRIPTION = "Little Color Management System"
+LICENSE = "MIT"
+#DEPENDS = " glib-2.0 gettext-native "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=6c786c3b7a4afbd3c990f1b81261d516"
+
+SRC_URI = "https://sourceforge.net/projects/lcms/files/lcms/${PV}/${PN}-${PV}.tar.gz \
+ "
+
+SRC_URI[md5sum] = "8de1b7724f578d2995c8fdfa35c3ad0e"
+SRC_URI[sha256sum] = "48c6fdf98396fa245ed86e622028caf49b96fa22f3e5734f853f806fbc8e7d20"
+
+inherit autotools pkgconfig distro_features_check
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System brendank310
@ 2018-10-29 22:46 ` Andreas Müller
2018-10-30 2:41 ` Khem Raj
2018-10-30 11:22 ` Burton, Ross
2 siblings, 0 replies; 64+ messages in thread
From: Andreas Müller @ 2018-10-29 22:46 UTC (permalink / raw)
To: brendank310; +Cc: openembeded-devel
On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
> new file mode 100644
> index 000000000..29947ae76
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
> @@ -0,0 +1,14 @@
> +DESCRIPTION = "Little Color Management System"
> +LICENSE = "MIT"
> +#DEPENDS = " glib-2.0 gettext-native "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=6c786c3b7a4afbd3c990f1b81261d516"
> +
> +SRC_URI = "https://sourceforge.net/projects/lcms/files/lcms/${PV}/${PN}-${PV}.tar.gz \
> + "
> +
> +SRC_URI[md5sum] = "8de1b7724f578d2995c8fdfa35c3ad0e"
> +SRC_URI[sha256sum] = "48c6fdf98396fa245ed86e622028caf49b96fa22f3e5734f853f806fbc8e7d20"
> +
> +inherit autotools pkgconfig distro_features_check
> +
There is a lcms 2.7 in meta-oe - what about upddating that?
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System brendank310
2018-10-29 22:46 ` Andreas Müller
@ 2018-10-30 2:41 ` Khem Raj
2018-10-30 11:22 ` Burton, Ross
2 siblings, 0 replies; 64+ messages in thread
From: Khem Raj @ 2018-10-30 2:41 UTC (permalink / raw)
To: brendank310; +Cc: schnitzeltony, openembedded-devel
On Mon, Oct 29, 2018 at 9:42 AM brendank310 <brendank310@gmail.com> wrote:
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
> b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
> new file mode 100644
> index 000000000..29947ae76
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
> @@ -0,0 +1,14 @@
> +DESCRIPTION = "Little Color Management System"
> +LICENSE = "MIT"
> +#DEPENDS = " glib-2.0 gettext-native "
> +
We can delete this if commented out
>
> +LIC_FILES_CHKSUM = "file://COPYING;md5=6c786c3b7a4afbd3c990f1b81261d516"
> +
> +SRC_URI = "
> https://sourceforge.net/projects/lcms/files/lcms/${PV}/${PN}-${PV}.tar.gz
> \
> + "
> +
> +SRC_URI[md5sum] = "8de1b7724f578d2995c8fdfa35c3ad0e"
> +SRC_URI[sha256sum] =
> "48c6fdf98396fa245ed86e622028caf49b96fa22f3e5734f853f806fbc8e7d20"
> +
> +inherit autotools pkgconfig distro_features_check
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System brendank310
2018-10-29 22:46 ` Andreas Müller
2018-10-30 2:41 ` Khem Raj
@ 2018-10-30 11:22 ` Burton, Ross
2018-10-30 15:03 ` Brendan Kerrigan
2 siblings, 1 reply; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 11:22 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> +inherit autotools pkgconfig distro_features_check
distro_features_check isn't being used.
But mainly, just update the existing recipe.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* Re: [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System
2018-10-30 11:22 ` Burton, Ross
@ 2018-10-30 15:03 ` Brendan Kerrigan
2018-10-30 21:07 ` Khem Raj
2018-10-30 23:08 ` Andreas Müller
0 siblings, 2 replies; 64+ messages in thread
From: Brendan Kerrigan @ 2018-10-30 15:03 UTC (permalink / raw)
To: ross.burton; +Cc: Andreas Müller, openembedded-devel
Sounds good, I hadn't seen that. Should the existing lcms recipe be renamed
to lcms2? Most distros seem to package it as such and it'd also simplify
the recipe a bit (the PN would align with the tarball and source directory
name).
On Tue, Oct 30, 2018 at 7:23 AM Burton, Ross <ross.burton@intel.com> wrote:
> On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> > +inherit autotools pkgconfig distro_features_check
>
> distro_features_check isn't being used.
>
> But mainly, just update the existing recipe.
>
> Ross
>
^ permalink raw reply [flat|nested] 64+ messages in thread
* Re: [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System
2018-10-30 15:03 ` Brendan Kerrigan
@ 2018-10-30 21:07 ` Khem Raj
2018-10-30 23:08 ` Andreas Müller
1 sibling, 0 replies; 64+ messages in thread
From: Khem Raj @ 2018-10-30 21:07 UTC (permalink / raw)
To: Brendan Kerrigan; +Cc: Andreas Müller, openembeded-devel
On Tue, Oct 30, 2018 at 9:04 AM Brendan Kerrigan <brendank310@gmail.com> wrote:
>
> Sounds good, I hadn't seen that. Should the existing lcms recipe be renamed
> to lcms2? Most distros seem to package it as such and it'd also simplify
> the recipe a bit (the PN would align with the tarball and source directory
> name).
>
as long as we maintain upgrade path for binary feeds I would think its ok.
> On Tue, Oct 30, 2018 at 7:23 AM Burton, Ross <ross.burton@intel.com> wrote:
>
> > On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> > > +inherit autotools pkgconfig distro_features_check
> >
> > distro_features_check isn't being used.
> >
> > But mainly, just update the existing recipe.
> >
> > Ross
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 64+ messages in thread
* Re: [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System
2018-10-30 15:03 ` Brendan Kerrigan
2018-10-30 21:07 ` Khem Raj
@ 2018-10-30 23:08 ` Andreas Müller
1 sibling, 0 replies; 64+ messages in thread
From: Andreas Müller @ 2018-10-30 23:08 UTC (permalink / raw)
To: Brendan Kerrigan; +Cc: openembeded-devel
On Tue, Oct 30, 2018 at 4:04 PM Brendan Kerrigan <brendank310@gmail.com> wrote:
>
> Sounds good, I hadn't seen that. Should the existing lcms recipe be renamed to lcms2? Most distros seem to package it as such and it'd also simplify the recipe a bit (the PN would align with the tarball and source directory name).
>
If you want ro rename don't forget to set PROVIDES / RRPROVIDES /
RREPLACES / RCONFLICTS - otherwise you break recipes depending on lcms
(there are many) or package feeds. I wouldn't do that.
Andreas
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 06/16] gnome-settings-daemon: add recipe for gnome-settings-daemon
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (4 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 05/16] lcms2: add recipe for Little Color Management System brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-30 2:53 ` Khem Raj
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 07/16] geocode-glib: add recipe for geocode-glib library brendank310
` (11 subsequent siblings)
17 siblings, 1 reply; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
| 52 +++++++++++++++++++
.../gnome3/gnome-settings-daemon_git.bb | 43 +++++++++++++++
2 files changed, 95 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon/0001-remove-extraneous-plugins.patch
create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon_git.bb
--git a/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon/0001-remove-extraneous-plugins.patch b/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon/0001-remove-extraneous-plugins.patch
new file mode 100644
index 000000000..6f5599058
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon/0001-remove-extraneous-plugins.patch
@@ -0,0 +1,52 @@
+gnome-settings-daemon: Disable plugins, dependencies, and compiler errors
+
+ * Disable 'no-deprecated-declaration' to allow build to complete
+ * Remove colord as a dependency
+ * Remove unused plugins
+
+ Upstream-status: Inappropriate [configuration]
+
+ Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
+
+diff --git a/meson.build b/meson.build
+index d2121623..15fcc88d 100644
+--- a/meson.build
++++ b/meson.build
+@@ -54,7 +54,7 @@ endforeach
+
+ # compiler flags
+ common_flags = ['-DHAVE_CONFIG_H']
+-compiler_flags = []
++compiler_flags = ['-Wno-deprecated-declarations']
+
+ if gsd_buildtype.contains('debug')
+ common_flags += ['-DG_ENABLE_DEBUG']
+@@ -82,7 +82,6 @@ endif
+
+ add_project_arguments(common_flags + compiler_flags, language: 'c')
+
+-colord_dep = dependency('colord', version: '>= 1.0.2')
+ geocode_glib_dep = dependency('geocode-glib-1.0', version: '>= 3.10.0')
+ gio_dep = dependency('gio-2.0', version: '>= 2.53.0')
+ gio_unix_dep = dependency('gio-unix-2.0')
+diff --git a/plugins/meson.build b/plugins/meson.build
+index 3db69da7..accb7b90 100644
+--- a/plugins/meson.build
++++ b/plugins/meson.build
+@@ -1,16 +1,11 @@
+ enabled_plugins = [
+ ['a11y-settings', 'A11ySettings'],
+ ['clipboard', 'Clipboard'],
+- ['color', 'Color'],
+ ['datetime', 'Datetime'],
+ ['dummy', ''],
+- ['power', 'Power'],
+ ['housekeeping', 'Housekeeping'],
+ ['keyboard', 'Keyboard'],
+- ['media-keys', 'MediaKeys'],
+ ['mouse', 'Mouse'],
+- ['screensaver-proxy', 'ScreensaverProxy'],
+- ['sharing', 'Sharing'],
+ ['sound', 'Sound'],
+ ['xsettings', 'XSettings']
+ ]
diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon_git.bb b/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon_git.bb
new file mode 100644
index 000000000..167db3bd2
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon_git.bb
@@ -0,0 +1,43 @@
+DESCRIPTION = "GNOME Settings Daemon"
+LICENSE = "GPLv2"
+DEPENDS = " \
+ libcanberra \
+ prelink \
+ glib-2.0 \
+ gsettings-desktop-schemas \
+ gnome-desktop3 \
+ wayland \
+ wayland-protocols \
+ gettext-native \
+ polkit \
+ upower \
+ libnotify \
+ geocode-glib \
+ libgweather \
+ lcms2 \
+ libwacom \
+ networkmanager \
+ geoclue \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
+
+SRC_URI = "git://gitlab.gnome.org/GNOME/gnome-settings-daemon.git;protocol=http;branch=gnome-3-30 \
+ file://0001-remove-extraneous-plugins.patch \
+ "
+
+SRCREV="${AUTOREV}"
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson gobject-introspection
+
+EXTRA_OEMESON += " -Denable-gtk-doc=false -Dcups=false "
+
+FILES_${PN} += "${datadir}"
+FILES_${PN} += "${libdir}"
+
+do_configure_prepend() {
+ # Fixup the gsettings version
+ sed -i 's^3.27.90^3.24.1^g' ${S}/meson.build
+}
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 06/16] gnome-settings-daemon: add recipe for gnome-settings-daemon
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 06/16] gnome-settings-daemon: add recipe for gnome-settings-daemon brendank310
@ 2018-10-30 2:53 ` Khem Raj
0 siblings, 0 replies; 64+ messages in thread
From: Khem Raj @ 2018-10-30 2:53 UTC (permalink / raw)
To: brendank310; +Cc: schnitzeltony, openembedded-devel
On Mon, Oct 29, 2018 at 9:42 AM brendank310 <brendank310@gmail.com> wrote:
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../0001-remove-extraneous-plugins.patch | 52 +++++++++++++++++++
> .../gnome3/gnome-settings-daemon_git.bb | 43 +++++++++++++++
> 2 files changed, 95 insertions(+)
> create mode 100644
> meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon/0001-remove-extraneous-plugins.patch
> create mode 100644 meta-gnome/recipes-gnome/gnome3/
> gnome-settings-daemon_git.bb
>
> diff --git
> a/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon/0001-remove-extraneous-plugins.patch
> b/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon/0001-remove-extraneous-plugins.patch
> new file mode 100644
> index 000000000..6f5599058
> --- /dev/null
> +++
> b/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon/0001-remove-extraneous-plugins.patch
> @@ -0,0 +1,52 @@
> +gnome-settings-daemon: Disable plugins, dependencies, and compiler errors
> +
> + * Disable 'no-deprecated-declaration' to allow build to complete
> + * Remove colord as a dependency
> + * Remove unused plugins
> +
> + Upstream-status: Inappropriate [configuration]
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/meson.build b/meson.build
> +index d2121623..15fcc88d 100644
> +--- a/meson.build
> ++++ b/meson.build
> +@@ -54,7 +54,7 @@ endforeach
> +
> + # compiler flags
> + common_flags = ['-DHAVE_CONFIG_H']
> +-compiler_flags = []
> ++compiler_flags = ['-Wno-deprecated-declarations']
> +
> + if gsd_buildtype.contains('debug')
> + common_flags += ['-DG_ENABLE_DEBUG']
> +@@ -82,7 +82,6 @@ endif
> +
> + add_project_arguments(common_flags + compiler_flags, language: 'c')
> +
> +-colord_dep = dependency('colord', version: '>= 1.0.2')
> + geocode_glib_dep = dependency('geocode-glib-1.0', version: '>= 3.10.0')
> + gio_dep = dependency('gio-2.0', version: '>= 2.53.0')
> + gio_unix_dep = dependency('gio-unix-2.0')
> +diff --git a/plugins/meson.build b/plugins/meson.build
> +index 3db69da7..accb7b90 100644
> +--- a/plugins/meson.build
> ++++ b/plugins/meson.build
> +@@ -1,16 +1,11 @@
> + enabled_plugins = [
> + ['a11y-settings', 'A11ySettings'],
> + ['clipboard', 'Clipboard'],
> +- ['color', 'Color'],
> + ['datetime', 'Datetime'],
> + ['dummy', ''],
> +- ['power', 'Power'],
> + ['housekeeping', 'Housekeeping'],
> + ['keyboard', 'Keyboard'],
> +- ['media-keys', 'MediaKeys'],
> + ['mouse', 'Mouse'],
> +- ['screensaver-proxy', 'ScreensaverProxy'],
> +- ['sharing', 'Sharing'],
> + ['sound', 'Sound'],
> + ['xsettings', 'XSettings']
> + ]
> diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon_git.bb
> b/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon_git.bb
> new file mode 100644
> index 000000000..167db3bd2
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gnome-settings-daemon_git.bb
> @@ -0,0 +1,43 @@
> +DESCRIPTION = "GNOME Settings Daemon"
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> + libcanberra \
> + prelink \
> + glib-2.0 \
> + gsettings-desktop-schemas \
> + gnome-desktop3 \
> + wayland \
> + wayland-protocols \
> + gettext-native \
> + polkit \
> + upower \
> + libnotify \
> + geocode-glib \
> + libgweather \
> + lcms2 \
> + libwacom \
> + networkmanager \
> + geoclue \
> + "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
> +
> +SRC_URI = "git://
> gitlab.gnome.org/GNOME/gnome-settings-daemon.git;protocol=http;branch=gnome-3-30
> \
> + file://0001-remove-extraneous-plugins.patch \
> + "
> +
> +SRCREV="${AUTOREV}"
>
No AUTOREV as we discussed earlier
+S = "${WORKDIR}/git"
> +
> +inherit pkgconfig meson gobject-introspection
> +
> +EXTRA_OEMESON += " -Denable-gtk-doc=false -Dcups=false "
> +
> +FILES_${PN} += "${datadir}"
> +FILES_${PN} += "${libdir}"
> +
> +do_configure_prepend() {
> + # Fixup the gsettings version
> + sed -i 's^3.27.90^3.24.1^g' ${S}/meson.build
> +}
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 07/16] geocode-glib: add recipe for geocode-glib library
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (5 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 06/16] gnome-settings-daemon: add recipe for gnome-settings-daemon brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-30 2:52 ` Khem Raj
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 08/16] libgweather: add recipe for libgweather brendank310
` (10 subsequent siblings)
17 siblings, 1 reply; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../recipes-gnome/gnome3/geocode-glib_git.bb | 21 +++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb b/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
new file mode 100644
index 000000000..73332e374
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
@@ -0,0 +1,21 @@
+DESCRIPTION = "Geocode Library for glib"
+LICENSE = "GPLv2"
+DEPENDS = " \
+ glib-2.0 \
+ json-glib \
+ libsoup-2.4 \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=55ca817ccb7d5b5b66355690e9abc605"
+
+SRC_URI = "git://gitlab.gnome.org/GNOME/geocode-glib.git;protocol=http;branch=master;tag=3.26.0 \
+ "
+
+EXTRA_OEMESON += " -Denable-installed-tests=false -Denable-gtk-doc=false "
+
+FILES_${PN} += "${datadir}"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson gobject-introspection
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 07/16] geocode-glib: add recipe for geocode-glib library
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 07/16] geocode-glib: add recipe for geocode-glib library brendank310
@ 2018-10-30 2:52 ` Khem Raj
2018-10-30 11:16 ` Burton, Ross
0 siblings, 1 reply; 64+ messages in thread
From: Khem Raj @ 2018-10-30 2:52 UTC (permalink / raw)
To: brendank310; +Cc: schnitzeltony, openembedded-devel
On Mon, Oct 29, 2018 at 9:42 AM brendank310 <brendank310@gmail.com> wrote:
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../recipes-gnome/gnome3/geocode-glib_git.bb | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
> b/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
> new file mode 100644
> index 000000000..73332e374
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
> @@ -0,0 +1,21 @@
> +DESCRIPTION = "Geocode Library for glib"
> +LICENSE = "GPLv2"
The checksum seems to be operating on a COPYING.LIB can you confirm its not
LGPL but rather GPL
>
> +DEPENDS = " \
> + glib-2.0 \
> + json-glib \
> + libsoup-2.4 \
> + "
> +
> +LIC_FILES_CHKSUM =
> "file://COPYING.LIB;md5=55ca817ccb7d5b5b66355690e9abc605"
> +
> +SRC_URI = "git://
> gitlab.gnome.org/GNOME/geocode-glib.git;protocol=http;branch=master;tag=3.26.0
> \
> + "
> +
hmm tags are floating kind of commits so they would result in checking
remote repo on every fetch task it would be better to use a hard coded SHA
>
> +EXTRA_OEMESON += " -Denable-installed-tests=false -Denable-gtk-doc=false "
> +
> +FILES_${PN} += "${datadir}"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit pkgconfig meson gobject-introspection
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 08/16] libgweather: add recipe for libgweather
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (6 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 07/16] geocode-glib: add recipe for geocode-glib library brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-30 2:49 ` Khem Raj
2018-10-30 11:18 ` Burton, Ross
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 09/16] gdm: add recipe for gdm (Gnome Desktop Manager) brendank310
` (9 subsequent siblings)
17 siblings, 2 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../recipes-gnome/gnome3/libgweather_git.bb | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb b/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
new file mode 100644
index 000000000..29ee2c90d
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
@@ -0,0 +1,23 @@
+DESCRIPTION = "GNOME Weather Library"
+LICENSE = "GPLv2"
+DEPENDS = " \
+ gtk+3 \
+ glib-2.0 \
+ libsoup-2.4 \
+ libxml2 \
+ geocode-glib \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+SRC_URI = "git://gitlab.gnome.org/GNOME/libgweather.git;protocol=http;branch=gnome-3-28 \
+ "
+
+FILES_${PN} += "${datadir}"
+FILES_${PN} += "${libdir}"
+
+SRCREV="${AUTOREV}"
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson gobject-introspection
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 08/16] libgweather: add recipe for libgweather
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 08/16] libgweather: add recipe for libgweather brendank310
@ 2018-10-30 2:49 ` Khem Raj
2018-10-30 11:18 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Khem Raj @ 2018-10-30 2:49 UTC (permalink / raw)
To: brendank310; +Cc: schnitzeltony, openembedded-devel
On Mon, Oct 29, 2018 at 9:42 AM brendank310 <brendank310@gmail.com> wrote:
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../recipes-gnome/gnome3/libgweather_git.bb | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
> b/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
> new file mode 100644
> index 000000000..29ee2c90d
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
> @@ -0,0 +1,23 @@
> +DESCRIPTION = "GNOME Weather Library"
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> + gtk+3 \
> + glib-2.0 \
> + libsoup-2.4 \
> + libxml2 \
> + geocode-glib \
> + "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +SRC_URI = "git://
> gitlab.gnome.org/GNOME/libgweather.git;protocol=http;branch=gnome-3-28 \
> + "
> +
> +FILES_${PN} += "${datadir}"
> +FILES_${PN} += "${libdir}"
> +
Does is make sense to package these libraries separately? I ask because if
they are used by other packages then it will not need to pull whole package
> +SRCREV="${AUTOREV}"
> +S = "${WORKDIR}/git"
> +
> +inherit pkgconfig meson gobject-introspection
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 08/16] libgweather: add recipe for libgweather
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 08/16] libgweather: add recipe for libgweather brendank310
2018-10-30 2:49 ` Khem Raj
@ 2018-10-30 11:18 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 11:18 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> +SRC_URI = "git://gitlab.gnome.org/GNOME/libgweather.git;protocol=http;branch=gnome-3-28 \
Why not tarball (small, checksumed, easier to mirror)
> +FILES_${PN} += "${libdir}"
This breaks library packaging.
> +SRCREV="${AUTOREV}"
Never use this in mainline recipes.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 09/16] gdm: add recipe for gdm (Gnome Desktop Manager)
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (7 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 08/16] libgweather: add recipe for libgweather brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-29 22:51 ` Andreas Müller
2018-10-30 11:33 ` Burton, Ross
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 10/16] dconf-native: add dconf-native recipe brendank310
` (8 subsequent siblings)
17 siblings, 2 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
meta-gnome/recipes-gnome/gnome3/gdm_git.bb | 33 ++++++++++++++++++++++
1 file changed, 33 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/gdm_git.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/gdm_git.bb b/meta-gnome/recipes-gnome/gnome3/gdm_git.bb
new file mode 100644
index 000000000..752aad13e
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gdm_git.bb
@@ -0,0 +1,33 @@
+DESCRIPTION = "GNOME Desktop Manager"
+LICENSE = "GPLv2"
+DEPENDS = " \
+ libcanberra \
+ glib-2.0 \
+ gtk+3 \
+ accountsservice \
+ plymouth \
+ gconf-native \
+ dconf-native \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+SRC_URI = "git://gitlab.gnome.org/GNOME/gdm.git;protocol=http;branch=master;tag=3.30.1 \
+ "
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig distro_features_check gobject-introspection gettext
+
+FILES_${PN} += "${systemd_system_unitdir}"
+FILES_${PN} += "${libdir}"
+FILES_${PN} += "${datadir}"
+
+do_configure_prepend() {
+ install -d ${S}/build-aux
+ sed -i '/AC_CHECK_FILE/d' ${S}/configure.ac
+}
+
+do_install_append() {
+ rm -rf ${D}/var/run
+}
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 09/16] gdm: add recipe for gdm (Gnome Desktop Manager)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 09/16] gdm: add recipe for gdm (Gnome Desktop Manager) brendank310
@ 2018-10-29 22:51 ` Andreas Müller
2018-10-30 11:33 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Andreas Müller @ 2018-10-29 22:51 UTC (permalink / raw)
To: brendank310; +Cc: openembeded-devel
On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> meta-gnome/recipes-gnome/gnome3/gdm_git.bb | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/gnome3/gdm_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/gdm_git.bb b/meta-gnome/recipes-gnome/gnome3/gdm_git.bb
> new file mode 100644
> index 000000000..752aad13e
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gdm_git.bb
> @@ -0,0 +1,33 @@
> +DESCRIPTION = "GNOME Desktop Manager"
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> + libcanberra \
> + glib-2.0 \
> + gtk+3 \
> + accountsservice \
> + plymouth \
> + gconf-native \
> + dconf-native \
> + "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +SRC_URI = "git://gitlab.gnome.org/GNOME/gdm.git;protocol=http;branch=master;tag=3.30.1 \
> + "
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools pkgconfig distro_features_check gobject-introspection gettext
> +
> +FILES_${PN} += "${systemd_system_unitdir}"
> +FILES_${PN} += "${libdir}"
> +FILES_${PN} += "${datadir}"
^ Same as mentioned before
> +
> +do_configure_prepend() {
> + install -d ${S}/build-aux
> + sed -i '/AC_CHECK_FILE/d' ${S}/configure.ac
> +}
> +
> +do_install_append() {
> + rm -rf ${D}/var/run
> +}
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 09/16] gdm: add recipe for gdm (Gnome Desktop Manager)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 09/16] gdm: add recipe for gdm (Gnome Desktop Manager) brendank310
2018-10-29 22:51 ` Andreas Müller
@ 2018-10-30 11:33 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 11:33 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> +SRC_URI = "git://gitlab.gnome.org/GNOME/gdm.git;protocol=http;branch=master;tag=3.30.1 \
Tarball.
> +FILES_${PN} += "${systemd_system_unitdir}"
Use systemd class.
> +FILES_${PN} += "${libdir}"
Breaks library packaging.
> +do_configure_prepend() {
> + install -d ${S}/build-aux
> + sed -i '/AC_CHECK_FILE/d' ${S}/configure.ac
Why? If this is needed then do it as a patch.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 10/16] dconf-native: add dconf-native recipe
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (8 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 09/16] gdm: add recipe for gdm (Gnome Desktop Manager) brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-29 18:06 ` Burton, Ross
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 11/16] libwacom: add recipe for libwacom brendank310
` (7 subsequent siblings)
17 siblings, 1 reply; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
gdm recipe requires a native dconf tool.
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../dconf/dconf-native_0.28.0.bb | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
diff --git a/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb b/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
new file mode 100644
index 000000000..ee78fbb66
--- /dev/null
+++ b/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
@@ -0,0 +1,19 @@
+SUMMARY = "configuation database system"
+LICENSE = "LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1"
+SECTION = "x11/gnome"
+
+SRC_URI[archive.md5sum] = "81faa8e68e5ea71ff0ee75050fc0759c"
+SRC_URI[archive.sha256sum] = "61d3b3865ef58b729c3b39aa0979f886c014aa8362f93dcfc74bf5648ed9c742"
+
+DEPENDS = "dbus glib-2.0 intltool-native"
+
+GNOMEBASEBUILDCLASS = "meson"
+
+inherit gnomebase gsettings bash-completion vala native
+
+FILES_${PN} += " \
+ ${datadir}/dbus-1 \
+ ${libdir}/gio/modules/*.so \
+ ${bindir}/dconf \
+"
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 10/16] dconf-native: add dconf-native recipe
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 10/16] dconf-native: add dconf-native recipe brendank310
@ 2018-10-29 18:06 ` Burton, Ross
2018-10-29 18:27 ` Brendan Kerrigan
0 siblings, 1 reply; 64+ messages in thread
From: Burton, Ross @ 2018-10-29 18:06 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
There's already a dconf in meta-gnome, so just add
BBCLASSEXTEND="native nativesdk".
Ross
On Mon, 29 Oct 2018 at 16:43, brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> gdm recipe requires a native dconf tool.
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../dconf/dconf-native_0.28.0.bb | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
>
> diff --git a/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb b/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
> new file mode 100644
> index 000000000..ee78fbb66
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
> @@ -0,0 +1,19 @@
> +SUMMARY = "configuation database system"
> +LICENSE = "LGPLv2.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1"
> +SECTION = "x11/gnome"
> +
> +SRC_URI[archive.md5sum] = "81faa8e68e5ea71ff0ee75050fc0759c"
> +SRC_URI[archive.sha256sum] = "61d3b3865ef58b729c3b39aa0979f886c014aa8362f93dcfc74bf5648ed9c742"
> +
> +DEPENDS = "dbus glib-2.0 intltool-native"
> +
> +GNOMEBASEBUILDCLASS = "meson"
> +
> +inherit gnomebase gsettings bash-completion vala native
> +
> +FILES_${PN} += " \
> + ${datadir}/dbus-1 \
> + ${libdir}/gio/modules/*.so \
> + ${bindir}/dconf \
> +"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 10/16] dconf-native: add dconf-native recipe
2018-10-29 18:06 ` Burton, Ross
@ 2018-10-29 18:27 ` Brendan Kerrigan
2018-10-29 19:30 ` Khem Raj
0 siblings, 1 reply; 64+ messages in thread
From: Brendan Kerrigan @ 2018-10-29 18:27 UTC (permalink / raw)
To: ross.burton; +Cc: Andreas Müller, openembedded-devel
I had initially tried to get the native recipe integrated into it, by
inheriting the native class but was unable to get that to work. Using the
above, I get the following:
ERROR: Required build target 'gdm' has no buildable providers.
Missing or unbuildable dependency chain was: ['gdm', 'dconf-native',
'glib-2.0-utils-native']
Any thoughts on how to resolve this? Should I also be providing a
glib-2.0-utils-native package?
Thanks,
Brendan
On Mon, Oct 29, 2018 at 2:06 PM Burton, Ross <ross.burton@intel.com> wrote:
> There's already a dconf in meta-gnome, so just add
> BBCLASSEXTEND="native nativesdk".
>
> Ross
> On Mon, 29 Oct 2018 at 16:43, brendank310 <brendank310@gmail.com> wrote:
> >
> > From: Brendan Kerrigan <kerriganb@ainfosec.com>
> >
> > gdm recipe requires a native dconf tool.
> >
> > Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> > ---
> > .../dconf/dconf-native_0.28.0.bb | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> > create mode 100644 meta-gnome/recipes-gnome/dconf/
> dconf-native_0.28.0.bb
> >
> > diff --git a/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
> b/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
> > new file mode 100644
> > index 000000000..ee78fbb66
> > --- /dev/null
> > +++ b/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
> > @@ -0,0 +1,19 @@
> > +SUMMARY = "configuation database system"
> > +LICENSE = "LGPLv2.1"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1"
> > +SECTION = "x11/gnome"
> > +
> > +SRC_URI[archive.md5sum] = "81faa8e68e5ea71ff0ee75050fc0759c"
> > +SRC_URI[archive.sha256sum] =
> "61d3b3865ef58b729c3b39aa0979f886c014aa8362f93dcfc74bf5648ed9c742"
> > +
> > +DEPENDS = "dbus glib-2.0 intltool-native"
> > +
> > +GNOMEBASEBUILDCLASS = "meson"
> > +
> > +inherit gnomebase gsettings bash-completion vala native
> > +
> > +FILES_${PN} += " \
> > + ${datadir}/dbus-1 \
> > + ${libdir}/gio/modules/*.so \
> > + ${bindir}/dconf \
> > +"
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 10/16] dconf-native: add dconf-native recipe
2018-10-29 18:27 ` Brendan Kerrigan
@ 2018-10-29 19:30 ` Khem Raj
2018-10-29 21:17 ` Burton, Ross
0 siblings, 1 reply; 64+ messages in thread
From: Khem Raj @ 2018-10-29 19:30 UTC (permalink / raw)
To: Brendan Kerrigan; +Cc: Andreas Müller, openembedded-devel
On Mon, Oct 29, 2018 at 11:27 AM Brendan Kerrigan <brendank310@gmail.com>
wrote:
> I had initially tried to get the native recipe integrated into it, by
> inheriting the native class but was unable to get that to work. Using the
> above, I get the following:
>
> ERROR: Required build target 'gdm' has no buildable providers.
> Missing or unbuildable dependency chain was: ['gdm', 'dconf-native',
> 'glib-2.0-utils-native']
>
> Any thoughts on how to resolve this? Should I also be providing a
> glib-2.0-utils-native package?
>
Just add that dependency to target only recipe via class-target override
perhaps
>
> Thanks,
> Brendan
>
> On Mon, Oct 29, 2018 at 2:06 PM Burton, Ross <ross.burton@intel.com>
> wrote:
>
> > There's already a dconf in meta-gnome, so just add
> > BBCLASSEXTEND="native nativesdk".
> >
> > Ross
> > On Mon, 29 Oct 2018 at 16:43, brendank310 <brendank310@gmail.com> wrote:
> > >
> > > From: Brendan Kerrigan <kerriganb@ainfosec.com>
> > >
> > > gdm recipe requires a native dconf tool.
> > >
> > > Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> > > ---
> > > .../dconf/dconf-native_0.28.0.bb | 19
> +++++++++++++++++++
> > > 1 file changed, 19 insertions(+)
> > > create mode 100644 meta-gnome/recipes-gnome/dconf/
> > dconf-native_0.28.0.bb
> > >
> > > diff --git a/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
> > b/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
> > > new file mode 100644
> > > index 000000000..ee78fbb66
> > > --- /dev/null
> > > +++ b/meta-gnome/recipes-gnome/dconf/dconf-native_0.28.0.bb
> > > @@ -0,0 +1,19 @@
> > > +SUMMARY = "configuation database system"
> > > +LICENSE = "LGPLv2.1"
> > > +LIC_FILES_CHKSUM =
> "file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1"
> > > +SECTION = "x11/gnome"
> > > +
> > > +SRC_URI[archive.md5sum] = "81faa8e68e5ea71ff0ee75050fc0759c"
> > > +SRC_URI[archive.sha256sum] =
> > "61d3b3865ef58b729c3b39aa0979f886c014aa8362f93dcfc74bf5648ed9c742"
> > > +
> > > +DEPENDS = "dbus glib-2.0 intltool-native"
> > > +
> > > +GNOMEBASEBUILDCLASS = "meson"
> > > +
> > > +inherit gnomebase gsettings bash-completion vala native
> > > +
> > > +FILES_${PN} += " \
> > > + ${datadir}/dbus-1 \
> > > + ${libdir}/gio/modules/*.so \
> > > + ${bindir}/dconf \
> > > +"
> > > --
> > > 2.17.1
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 10/16] dconf-native: add dconf-native recipe
2018-10-29 19:30 ` Khem Raj
@ 2018-10-29 21:17 ` Burton, Ross
0 siblings, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-29 21:17 UTC (permalink / raw)
To: Khem Raj; +Cc: OpenEmbedded Devel List, Andreas Müller
On Mon, 29 Oct 2018 at 19:30, Khem Raj <raj.khem@gmail.com> wrote:
>> I had initially tried to get the native recipe integrated into it, by
>> inheriting the native class but was unable to get that to work. Using the
>> above, I get the following:
>>
>> ERROR: Required build target 'gdm' has no buildable providers.
>> Missing or unbuildable dependency chain was: ['gdm', 'dconf-native',
>> 'glib-2.0-utils-native']
>>
>> Any thoughts on how to resolve this? Should I also be providing a
>> glib-2.0-utils-native package?
I'm assuming you meant BBCLASSEXTEND and not an explicit inherit native.
> Just add that dependency to target only recipe via class-target override perhaps
To clarify, the dependency comes from the gsettings.bbclass. This
dependency should be target-only, so use a class-target override.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 11/16] libwacom: add recipe for libwacom
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (9 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 10/16] dconf-native: add dconf-native recipe brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 12/16] mutter: add recipe for mutter window manager brendank310
` (6 subsequent siblings)
17 siblings, 0 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
meta-gnome/recipes-gnome/gnome3/libwacom_git.bb | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/libwacom_git.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/libwacom_git.bb b/meta-gnome/recipes-gnome/gnome3/libwacom_git.bb
new file mode 100644
index 000000000..e60b76965
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/libwacom_git.bb
@@ -0,0 +1,17 @@
+DESCRIPTION = "libwacom"
+LICENSE = "MIT"
+DEPENDS = " \
+ glib-2.0 \
+ libgudev \
+ libxml2 \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=40a21fffb367c82f39fd91a3b137c36e"
+
+SRC_URI = "git://github.com/linuxwacom/libwacom.git;protocol=http;branch=master;tag=libwacom-0.31 \
+ "
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig distro_features_check
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* [RFC meta-gnome][PATCH 12/16] mutter: add recipe for mutter window manager
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (10 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 11/16] libwacom: add recipe for libwacom brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-30 2:47 ` Khem Raj
2018-10-30 11:21 ` Burton, Ross
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 13/16] gnome-shell: add recipe for gnome-shell brendank310
` (5 subsequent siblings)
17 siblings, 2 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../mutter/0001-disable-zenity-check.patch | 27 ++++++++
...spection-variables-with-correct-path.patch | 63 +++++++++++++++++++
.../0003-packageconfig-variable-fixup.patch | 29 +++++++++
.../mutter/0004-fix-broken-includes.patch | 37 +++++++++++
meta-gnome/recipes-gnome/gnome3/mutter_git.bb | 59 +++++++++++++++++
5 files changed, 215 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/mutter/0001-disable-zenity-check.patch
create mode 100644 meta-gnome/recipes-gnome/gnome3/mutter/0002-fixup-introspection-variables-with-correct-path.patch
create mode 100644 meta-gnome/recipes-gnome/gnome3/mutter/0003-packageconfig-variable-fixup.patch
create mode 100644 meta-gnome/recipes-gnome/gnome3/mutter/0004-fix-broken-includes.patch
create mode 100644 meta-gnome/recipes-gnome/gnome3/mutter_git.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/mutter/0001-disable-zenity-check.patch b/meta-gnome/recipes-gnome/gnome3/mutter/0001-disable-zenity-check.patch
new file mode 100644
index 000000000..a37aec276
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/mutter/0001-disable-zenity-check.patch
@@ -0,0 +1,27 @@
+mutter: Disable check for zenity
+
+ Disable autoconf check for zenity, no need graphical dialog boxes.
+
+ Upstream-status: Inappropriate [disable-feature]
+
+ Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
+
+diff --git a/configure.ac b/configure.ac
+index ef92f5ecb..5eede9e63 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -427,11 +427,6 @@ fi
+
+ AM_CONDITIONAL(HAVE_SM, test "$found_sm" = "yes")
+
+-AC_PATH_PROG(ZENITY, zenity, no)
+-if test x"$ZENITY" = xno; then
+- AC_MSG_ERROR([zenity not found in your path - needed for dialogs])
+-fi
+-
+ AC_ARG_ENABLE(debug,
+ [ --enable-debug enable debugging],,
+ enable_debug=no)
+--
+2.17.1
+
diff --git a/meta-gnome/recipes-gnome/gnome3/mutter/0002-fixup-introspection-variables-with-correct-path.patch b/meta-gnome/recipes-gnome/gnome3/mutter/0002-fixup-introspection-variables-with-correct-path.patch
new file mode 100644
index 000000000..07c1f371a
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/mutter/0002-fixup-introspection-variables-with-correct-path.patch
@@ -0,0 +1,63 @@
+mutter: Fixup introspection paths
+
+ Fixup the introspection paths to enable correct results with
+ gobject-introspection.
+
+ Upstream-status: Innappropriate [embedded specific]
+
+ Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
+
+diff --git a/clutter/build/autotools/introspection.m4 b/clutter/build/autotools/introspection.m4
+index d89c3d907..d2c60de4d 100644
+--- a/clutter/build/autotools/introspection.m4
++++ b/clutter/build/autotools/introspection.m4
+@@ -56,14 +56,14 @@ m4_define([_GOBJECT_INTROSPECTION_CHECK_INTERNAL],
+ INTROSPECTION_GIRDIR=
+ INTROSPECTION_TYPELIBDIR=
+ if test "x$found_introspection" = "xyes"; then
+- INTROSPECTION_SCANNER=`$PKG_CONFIG --variable=g_ir_scanner gobject-introspection-1.0`
+- INTROSPECTION_COMPILER=`$PKG_CONFIG --variable=g_ir_compiler gobject-introspection-1.0`
+- INTROSPECTION_GENERATE=`$PKG_CONFIG --variable=g_ir_generate gobject-introspection-1.0`
+- INTROSPECTION_GIRDIR=`$PKG_CONFIG --variable=girdir gobject-introspection-1.0`
+- INTROSPECTION_TYPELIBDIR="$($PKG_CONFIG --variable=typelibdir gobject-introspection-1.0)"
++ INTROSPECTION_SCANNER=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=g_ir_scanner gobject-introspection-1.0`
++ INTROSPECTION_COMPILER=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=g_ir_compiler gobject-introspection-1.0`
++ INTROSPECTION_GENERATE=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=g_ir_generate gobject-introspection-1.0`
++ INTROSPECTION_GIRDIR=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=girdir gobject-introspection-1.0`
++ INTROSPECTION_TYPELIBDIR=$PKG_CONFIG_SYSROOT_DIR"$($PKG_CONFIG --variable=typelibdir gobject-introspection-1.0)"
+ INTROSPECTION_CFLAGS=`$PKG_CONFIG --cflags gobject-introspection-1.0`
+ INTROSPECTION_LIBS=`$PKG_CONFIG --libs gobject-introspection-1.0`
+- INTROSPECTION_MAKEFILE=`$PKG_CONFIG --variable=datadir gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection
++ INTROSPECTION_MAKEFILE=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=datadir gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection
+ fi
+ AC_SUBST(INTROSPECTION_SCANNER)
+ AC_SUBST(INTROSPECTION_COMPILER)
+diff --git a/cogl/build/autotools/introspection.m4 b/cogl/build/autotools/introspection.m4
+index 589721c5a..683ebdcc6 100644
+--- a/cogl/build/autotools/introspection.m4
++++ b/cogl/build/autotools/introspection.m4
+@@ -54,14 +54,14 @@ m4_define([_GOBJECT_INTROSPECTION_CHECK_INTERNAL],
+ INTROSPECTION_GIRDIR=
+ INTROSPECTION_TYPELIBDIR=
+ if test "x$found_introspection" = "xyes"; then
+- INTROSPECTION_SCANNER=`$PKG_CONFIG --variable=g_ir_scanner gobject-introspection-1.0`
+- INTROSPECTION_COMPILER=`$PKG_CONFIG --variable=g_ir_compiler gobject-introspection-1.0`
+- INTROSPECTION_GENERATE=`$PKG_CONFIG --variable=g_ir_generate gobject-introspection-1.0`
+- INTROSPECTION_GIRDIR=`$PKG_CONFIG --variable=girdir gobject-introspection-1.0`
+- INTROSPECTION_TYPELIBDIR="$($PKG_CONFIG --variable=typelibdir gobject-introspection-1.0)"
++ INTROSPECTION_SCANNER=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=g_ir_scanner gobject-introspection-1.0`
++ INTROSPECTION_COMPILER=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=g_ir_compiler gobject-introspection-1.0`
++ INTROSPECTION_GENERATE=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=g_ir_generate gobject-introspection-1.0`
++ INTROSPECTION_GIRDIR=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=girdir gobject-introspection-1.0`
++ INTROSPECTION_TYPELIBDIR=$PKG_CONFIG_SYSROOT_DIR"$($PKG_CONFIG --variable=typelibdir gobject-introspection-1.0)"
+ INTROSPECTION_CFLAGS=`$PKG_CONFIG --cflags gobject-introspection-1.0`
+- INTROSPECTION_LIBS=`$PKG_CONFIG --libs gobject-introspection-1.0`
+- INTROSPECTION_MAKEFILE=`$PKG_CONFIG --variable=datadir gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection
++ INTROSPECTION_LIBS=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --libs gobject-introspection-1.0`
++ INTROSPECTION_MAKEFILE=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=datadir gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection
+ fi
+ AC_SUBST(INTROSPECTION_SCANNER)
+ AC_SUBST(INTROSPECTION_COMPILER)
+--
+2.17.1
+
diff --git a/meta-gnome/recipes-gnome/gnome3/mutter/0003-packageconfig-variable-fixup.patch b/meta-gnome/recipes-gnome/gnome3/mutter/0003-packageconfig-variable-fixup.patch
new file mode 100644
index 000000000..1e44218a6
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/mutter/0003-packageconfig-variable-fixup.patch
@@ -0,0 +1,29 @@
+mutter: Fixup pkgconfig variables
+
+ Pkgconfig variables relating to the paths of datadirs, and
+ gir, typelib.
+
+ Upstream-status: Innappropriate [embedded-specific]
+
+ Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
+
+diff --git a/src/libmutter.pc.in b/src/libmutter.pc.in
+index d2e837f4a..0c8db1a66 100644
+--- a/src/libmutter.pc.in
++++ b/src/libmutter.pc.in
+@@ -2,8 +2,10 @@ prefix=@prefix@
+ exec_prefix=@exec_prefix@
+ libdir=@libdir@
+ includedir=@includedir@
+-girdir=@libdir@/mutter
+-typelibdir=@libdir@/mutter
++datarootdir=${prefix}/share
++datadir=${datarootdir}
++girdir=${datadir}/gir-1.0
++typelibdir=${libdir}/mutter
+ apiversion=@LIBMUTTER_API_VERSION@
+
+ Name: libmutter
+--
+2.17.1
+
diff --git a/meta-gnome/recipes-gnome/gnome3/mutter/0004-fix-broken-includes.patch b/meta-gnome/recipes-gnome/gnome3/mutter/0004-fix-broken-includes.patch
new file mode 100644
index 000000000..2a7580653
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/mutter/0004-fix-broken-includes.patch
@@ -0,0 +1,37 @@
+mutter: Fix broken includes for xcursor
+
+ Add missing include for the xcursor header to required
+ files.
+
+ Upstream-status: Pending
+
+ Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
+
+diff --git a/src/core/display.c b/src/core/display.c
+index f6b4d5b9f..3930f1c32 100644
+--- a/src/core/display.c
++++ b/src/core/display.c
+@@ -54,6 +54,7 @@
+ #include <meta/meta-backend.h>
+ #include "backends/meta-cursor-sprite-xcursor.h"
+ #include "backends/meta-logical-monitor.h"
++#include "backends/meta-cursor-sprite-xcursor.h"
+ #include "backends/native/meta-backend-native.h"
+ #include "backends/x11/meta-backend-x11.h"
+ #include "backends/meta-stage-private.h"
+diff --git a/src/x11/meta-x11-display.c b/src/x11/meta-x11-display.c
+index 83f7dfbae..36ea95b91 100644
+--- a/src/x11/meta-x11-display.c
++++ b/src/x11/meta-x11-display.c
+@@ -55,6 +55,8 @@
+ #include "backends/meta-logical-monitor.h"
+ #include "backends/meta-settings-private.h"
+ #include "backends/x11/meta-backend-x11.h"
++#include "backends/meta-cursor-sprite-xcursor.h"
++
+ #include "core/frame.h"
+ #include "core/meta-workspace-manager-private.h"
+ #include "core/util-private.h"
+--
+2.17.1
+
diff --git a/meta-gnome/recipes-gnome/gnome3/mutter_git.bb b/meta-gnome/recipes-gnome/gnome3/mutter_git.bb
new file mode 100644
index 000000000..b2065f224
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/mutter_git.bb
@@ -0,0 +1,59 @@
+DESCRIPTION = "Mutter (Gnome 3 window manager)"
+LICENSE = "GPLv2"
+DEPENDS = " \
+ glib-2.0 \
+ gsettings-desktop-schemas \
+ wayland-native \
+ wayland-protocols \
+ libxinerama \
+ libinput \
+ gtk+3 \
+ gnome-desktop3 \
+ libxcursor \
+ libxkbfile \
+ cogl-1.0 \
+ clutter-1.0 \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+SRC_URI = " \
+ git://gitlab.gnome.org/GNOME/mutter.git;protocol=http;branch=master \
+ file://0001-disable-zenity-check.patch \
+ file://0002-fixup-introspection-variables-with-correct-path.patch \
+ file://0003-packageconfig-variable-fixup.patch \
+ file://0004-fix-broken-includes.patch \
+ "
+
+SRCREV="${AUTOREV}"
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig distro_features_check gobject-introspection gettext
+
+FILES_${PN} += "${datadir}"
+
+do_configure_prepend() {
+ # Autotools expects config.rpath to be with in the source tree
+ install -d ${S}/build-aux
+ cp ${STAGING_DIR_NATIVE}${datadir}/gettext/config.rpath ${S}/build-aux/config.rpath
+
+ # There are several Werrors that trip when building with Wayland enabled:
+ # -Wno-error=implicit-function-declaration -Wno-error=nested-externs -Wno-error=int-conversion
+ # and setting those as no-error does not seem to get picked up (it does appear in the compilation
+ # command
+ sed -i 's^-Werror -Wno-error=deprecated-declarations^-Wno-error=deprecated-declarations^g' ${S}/configure.ac
+}
+
+do_compile_prepend() {
+ export GIR_EXTRA_LIBS_PATH="${B}/cogl/cogl/.libs:${B}/cogl/cogl-pango/.libs:${B}/cogl/cogl-path/.libs:${B}/clutter/clutter/.libs"
+}
+
+do_install_append() {
+ install -d ${D}/${datadir}/gir-1.0
+ install ${B}/src/Meta-3.gir ${D}/${datadir}/gir-1.0
+ install ${B}/cogl/cogl/Cogl-3.gir ${D}/${datadir}/gir-1.0
+ install ${B}/cogl/cogl-pango/CoglPango-3.gir ${D}/${datadir}/gir-1.0
+ install ${B}/clutter/clutter/Cally-3.gir ${D}/${datadir}/gir-1.0
+ install ${B}/clutter/clutter/ClutterX11-3.gir ${D}/${datadir}/gir-1.0
+ install ${B}/clutter/clutter/Clutter-3.gir ${D}/${datadir}/gir-1.0
+}
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 12/16] mutter: add recipe for mutter window manager
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 12/16] mutter: add recipe for mutter window manager brendank310
@ 2018-10-30 2:47 ` Khem Raj
2018-10-30 11:21 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Khem Raj @ 2018-10-30 2:47 UTC (permalink / raw)
To: brendank310; +Cc: schnitzeltony, openembedded-devel
On Mon, Oct 29, 2018 at 9:43 AM brendank310 <brendank310@gmail.com> wrote:
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../mutter/0001-disable-zenity-check.patch | 27 ++++++++
> ...spection-variables-with-correct-path.patch | 63 +++++++++++++++++++
> .../0003-packageconfig-variable-fixup.patch | 29 +++++++++
> .../mutter/0004-fix-broken-includes.patch | 37 +++++++++++
> meta-gnome/recipes-gnome/gnome3/mutter_git.bb | 59 +++++++++++++++++
> 5 files changed, 215 insertions(+)
> create mode 100644
> meta-gnome/recipes-gnome/gnome3/mutter/0001-disable-zenity-check.patch
> create mode 100644
> meta-gnome/recipes-gnome/gnome3/mutter/0002-fixup-introspection-variables-with-correct-path.patch
> create mode 100644
> meta-gnome/recipes-gnome/gnome3/mutter/0003-packageconfig-variable-fixup.patch
> create mode 100644
> meta-gnome/recipes-gnome/gnome3/mutter/0004-fix-broken-includes.patch
> create mode 100644 meta-gnome/recipes-gnome/gnome3/mutter_git.bb
>
> diff --git
> a/meta-gnome/recipes-gnome/gnome3/mutter/0001-disable-zenity-check.patch
> b/meta-gnome/recipes-gnome/gnome3/mutter/0001-disable-zenity-check.patch
> new file mode 100644
> index 000000000..a37aec276
> --- /dev/null
> +++
> b/meta-gnome/recipes-gnome/gnome3/mutter/0001-disable-zenity-check.patch
> @@ -0,0 +1,27 @@
> +mutter: Disable check for zenity
> +
> + Disable autoconf check for zenity, no need graphical dialog boxes.
> +
> + Upstream-status: Inappropriate [disable-feature]
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/configure.ac b/configure.ac
> +index ef92f5ecb..5eede9e63 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -427,11 +427,6 @@ fi
> +
> + AM_CONDITIONAL(HAVE_SM, test "$found_sm" = "yes")
> +
> +-AC_PATH_PROG(ZENITY, zenity, no)
> +-if test x"$ZENITY" = xno; then
> +- AC_MSG_ERROR([zenity not found in your path - needed for dialogs])
> +-fi
> +-
> + AC_ARG_ENABLE(debug,
> + [ --enable-debug enable debugging],,
> + enable_debug=no)
> +--
> +2.17.1
> +
> diff --git
> a/meta-gnome/recipes-gnome/gnome3/mutter/0002-fixup-introspection-variables-with-correct-path.patch
> b/meta-gnome/recipes-gnome/gnome3/mutter/0002-fixup-introspection-variables-with-correct-path.patch
> new file mode 100644
> index 000000000..07c1f371a
> --- /dev/null
> +++
> b/meta-gnome/recipes-gnome/gnome3/mutter/0002-fixup-introspection-variables-with-correct-path.patch
> @@ -0,0 +1,63 @@
> +mutter: Fixup introspection paths
> +
> + Fixup the introspection paths to enable correct results with
> + gobject-introspection.
> +
> + Upstream-status: Innappropriate [embedded specific]
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/clutter/build/autotools/introspection.m4
> b/clutter/build/autotools/introspection.m4
> +index d89c3d907..d2c60de4d 100644
> +--- a/clutter/build/autotools/introspection.m4
> ++++ b/clutter/build/autotools/introspection.m4
> +@@ -56,14 +56,14 @@ m4_define([_GOBJECT_INTROSPECTION_CHECK_INTERNAL],
> + INTROSPECTION_GIRDIR=
> + INTROSPECTION_TYPELIBDIR=
> + if test "x$found_introspection" = "xyes"; then
> +- INTROSPECTION_SCANNER=`$PKG_CONFIG --variable=g_ir_scanner
> gobject-introspection-1.0`
> +- INTROSPECTION_COMPILER=`$PKG_CONFIG --variable=g_ir_compiler
> gobject-introspection-1.0`
> +- INTROSPECTION_GENERATE=`$PKG_CONFIG --variable=g_ir_generate
> gobject-introspection-1.0`
> +- INTROSPECTION_GIRDIR=`$PKG_CONFIG --variable=girdir
> gobject-introspection-1.0`
> +- INTROSPECTION_TYPELIBDIR="$($PKG_CONFIG --variable=typelibdir
> gobject-introspection-1.0)"
> ++ INTROSPECTION_SCANNER=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG
> --variable=g_ir_scanner gobject-introspection-1.0`
> ++ INTROSPECTION_COMPILER=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG
> --variable=g_ir_compiler gobject-introspection-1.0`
> ++ INTROSPECTION_GENERATE=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG
> --variable=g_ir_generate gobject-introspection-1.0`
> ++ INTROSPECTION_GIRDIR=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG
> --variable=girdir gobject-introspection-1.0`
> ++ INTROSPECTION_TYPELIBDIR=$PKG_CONFIG_SYSROOT_DIR"$($PKG_CONFIG
> --variable=typelibdir gobject-introspection-1.0)"
> + INTROSPECTION_CFLAGS=`$PKG_CONFIG --cflags
> gobject-introspection-1.0`
> + INTROSPECTION_LIBS=`$PKG_CONFIG --libs gobject-introspection-1.0`
> +- INTROSPECTION_MAKEFILE=`$PKG_CONFIG --variable=datadir
> gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection
> ++ INTROSPECTION_MAKEFILE=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG
> --variable=datadir
> gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection
> + fi
> + AC_SUBST(INTROSPECTION_SCANNER)
> + AC_SUBST(INTROSPECTION_COMPILER)
> +diff --git a/cogl/build/autotools/introspection.m4
> b/cogl/build/autotools/introspection.m4
> +index 589721c5a..683ebdcc6 100644
> +--- a/cogl/build/autotools/introspection.m4
> ++++ b/cogl/build/autotools/introspection.m4
> +@@ -54,14 +54,14 @@ m4_define([_GOBJECT_INTROSPECTION_CHECK_INTERNAL],
> + INTROSPECTION_GIRDIR=
> + INTROSPECTION_TYPELIBDIR=
> + if test "x$found_introspection" = "xyes"; then
> +- INTROSPECTION_SCANNER=`$PKG_CONFIG --variable=g_ir_scanner
> gobject-introspection-1.0`
> +- INTROSPECTION_COMPILER=`$PKG_CONFIG --variable=g_ir_compiler
> gobject-introspection-1.0`
> +- INTROSPECTION_GENERATE=`$PKG_CONFIG --variable=g_ir_generate
> gobject-introspection-1.0`
> +- INTROSPECTION_GIRDIR=`$PKG_CONFIG --variable=girdir
> gobject-introspection-1.0`
> +- INTROSPECTION_TYPELIBDIR="$($PKG_CONFIG --variable=typelibdir
> gobject-introspection-1.0)"
> ++ INTROSPECTION_SCANNER=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG
> --variable=g_ir_scanner gobject-introspection-1.0`
> ++ INTROSPECTION_COMPILER=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG
> --variable=g_ir_compiler gobject-introspection-1.0`
> ++ INTROSPECTION_GENERATE=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG
> --variable=g_ir_generate gobject-introspection-1.0`
> ++ INTROSPECTION_GIRDIR=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG
> --variable=girdir gobject-introspection-1.0`
> ++ INTROSPECTION_TYPELIBDIR=$PKG_CONFIG_SYSROOT_DIR"$($PKG_CONFIG
> --variable=typelibdir gobject-introspection-1.0)"
> + INTROSPECTION_CFLAGS=`$PKG_CONFIG --cflags
> gobject-introspection-1.0`
> +- INTROSPECTION_LIBS=`$PKG_CONFIG --libs gobject-introspection-1.0`
> +- INTROSPECTION_MAKEFILE=`$PKG_CONFIG --variable=datadir
> gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection
> ++ INTROSPECTION_LIBS=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --libs
> gobject-introspection-1.0`
> ++ INTROSPECTION_MAKEFILE=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG
> --variable=datadir
> gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection
> + fi
> + AC_SUBST(INTROSPECTION_SCANNER)
> + AC_SUBST(INTROSPECTION_COMPILER)
> +--
> +2.17.1
> +
> diff --git
> a/meta-gnome/recipes-gnome/gnome3/mutter/0003-packageconfig-variable-fixup.patch
> b/meta-gnome/recipes-gnome/gnome3/mutter/0003-packageconfig-variable-fixup.patch
> new file mode 100644
> index 000000000..1e44218a6
> --- /dev/null
> +++
> b/meta-gnome/recipes-gnome/gnome3/mutter/0003-packageconfig-variable-fixup.patch
> @@ -0,0 +1,29 @@
> +mutter: Fixup pkgconfig variables
> +
> + Pkgconfig variables relating to the paths of datadirs, and
> + gir, typelib.
> +
> + Upstream-status: Innappropriate [embedded-specific]
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/src/libmutter.pc.in b/src/libmutter.pc.in
> +index d2e837f4a..0c8db1a66 100644
> +--- a/src/libmutter.pc.in
> ++++ b/src/libmutter.pc.in
> +@@ -2,8 +2,10 @@ prefix=@prefix@
> + exec_prefix=@exec_prefix@
> + libdir=@libdir@
> + includedir=@includedir@
> +-girdir=@libdir@/mutter
> +-typelibdir=@libdir@/mutter
> ++datarootdir=${prefix}/share
> ++datadir=${datarootdir}
> ++girdir=${datadir}/gir-1.0
> ++typelibdir=${libdir}/mutter
> + apiversion=@LIBMUTTER_API_VERSION@
> +
> + Name: libmutter
> +--
> +2.17.1
> +
> diff --git
> a/meta-gnome/recipes-gnome/gnome3/mutter/0004-fix-broken-includes.patch
> b/meta-gnome/recipes-gnome/gnome3/mutter/0004-fix-broken-includes.patch
> new file mode 100644
> index 000000000..2a7580653
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/mutter/0004-fix-broken-includes.patch
> @@ -0,0 +1,37 @@
> +mutter: Fix broken includes for xcursor
> +
> + Add missing include for the xcursor header to required
> + files.
> +
> + Upstream-status: Pending
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/src/core/display.c b/src/core/display.c
> +index f6b4d5b9f..3930f1c32 100644
> +--- a/src/core/display.c
> ++++ b/src/core/display.c
> +@@ -54,6 +54,7 @@
> + #include <meta/meta-backend.h>
> + #include "backends/meta-cursor-sprite-xcursor.h"
> + #include "backends/meta-logical-monitor.h"
> ++#include "backends/meta-cursor-sprite-xcursor.h"
> + #include "backends/native/meta-backend-native.h"
> + #include "backends/x11/meta-backend-x11.h"
> + #include "backends/meta-stage-private.h"
> +diff --git a/src/x11/meta-x11-display.c b/src/x11/meta-x11-display.c
> +index 83f7dfbae..36ea95b91 100644
> +--- a/src/x11/meta-x11-display.c
> ++++ b/src/x11/meta-x11-display.c
> +@@ -55,6 +55,8 @@
> + #include "backends/meta-logical-monitor.h"
> + #include "backends/meta-settings-private.h"
> + #include "backends/x11/meta-backend-x11.h"
> ++#include "backends/meta-cursor-sprite-xcursor.h"
> ++
> + #include "core/frame.h"
> + #include "core/meta-workspace-manager-private.h"
> + #include "core/util-private.h"
> +--
> +2.17.1
> +
> diff --git a/meta-gnome/recipes-gnome/gnome3/mutter_git.bb
> b/meta-gnome/recipes-gnome/gnome3/mutter_git.bb
> new file mode 100644
> index 000000000..b2065f224
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/mutter_git.bb
> @@ -0,0 +1,59 @@
> +DESCRIPTION = "Mutter (Gnome 3 window manager)"
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> + glib-2.0 \
> + gsettings-desktop-schemas \
> + wayland-native \
> + wayland-protocols \
Same as last comment we need to use distro feature to include it
>
> + libxinerama \
> + libinput \
> + gtk+3 \
> + gnome-desktop3 \
> + libxcursor \
> + libxkbfile \
> + cogl-1.0 \
> + clutter-1.0 \
> + "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +SRC_URI = " \
> + git://
> gitlab.gnome.org/GNOME/mutter.git;protocol=http;branch=master \
> + file://0001-disable-zenity-check.patch \
> +
> file://0002-fixup-introspection-variables-with-correct-path.patch \
> + file://0003-packageconfig-variable-fixup.patch \
> + file://0004-fix-broken-includes.patch \
> + "
> +
> +SRCREV="${AUTOREV}"
>
We need to use a hard coded locked down Sha value here for consistency
across builds
+S = "${WORKDIR}/git"
> +
> +inherit autotools pkgconfig distro_features_check gobject-introspection
> gettext
> +
> +FILES_${PN} += "${datadir}"
> +
> +do_configure_prepend() {
> + # Autotools expects config.rpath to be with in the source tree
> + install -d ${S}/build-aux
> + cp ${STAGING_DIR_NATIVE}${datadir}/gettext/config.rpath
> ${S}/build-aux/config.rpath
> +
> + # There are several Werrors that trip when building with Wayland
> enabled:
> + # -Wno-error=implicit-function-declaration
> -Wno-error=nested-externs -Wno-error=int-conversion
> + # and setting those as no-error does not seem to get picked up (it
> does appear in the compilation
> + # command
> + sed -i 's^-Werror
> -Wno-error=deprecated-declarations^-Wno-error=deprecated-declarations^g'
> ${S}/configure.ac
> +}
> +
> +do_compile_prepend() {
> + export
> GIR_EXTRA_LIBS_PATH="${B}/cogl/cogl/.libs:${B}/cogl/cogl-pango/.libs:${B}/cogl/cogl-path/.libs:${B}/clutter/clutter/.libs"
> +}
> +
> +do_install_append() {
> + install -d ${D}/${datadir}/gir-1.0
> + install ${B}/src/Meta-3.gir ${D}/${datadir}/gir-1.0
> + install ${B}/cogl/cogl/Cogl-3.gir ${D}/${datadir}/gir-1.0
> + install ${B}/cogl/cogl-pango/CoglPango-3.gir
> ${D}/${datadir}/gir-1.0
> + install ${B}/clutter/clutter/Cally-3.gir ${D}/${datadir}/gir-1.0
> + install ${B}/clutter/clutter/ClutterX11-3.gir
> ${D}/${datadir}/gir-1.0
> + install ${B}/clutter/clutter/Clutter-3.gir ${D}/${datadir}/gir-1.0
> +}
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 12/16] mutter: add recipe for mutter window manager
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 12/16] mutter: add recipe for mutter window manager brendank310
2018-10-30 2:47 ` Khem Raj
@ 2018-10-30 11:21 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 11:21 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:43, brendank310 <brendank310@gmail.com> wrote:
> +do_install_append() {
> + install -d ${D}/${datadir}/gir-1.0
> + install ${B}/src/Meta-3.gir ${D}/${datadir}/gir-1.0
> + install ${B}/cogl/cogl/Cogl-3.gir ${D}/${datadir}/gir-1.0
> + install ${B}/cogl/cogl-pango/CoglPango-3.gir ${D}/${datadir}/gir-1.0
> + install ${B}/clutter/clutter/Cally-3.gir ${D}/${datadir}/gir-1.0
> + install ${B}/clutter/clutter/ClutterX11-3.gir ${D}/${datadir}/gir-1.0
> + install ${B}/clutter/clutter/Clutter-3.gir ${D}/${datadir}/gir-1.0
> +}
Why is this needed?
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 13/16] gnome-shell: add recipe for gnome-shell.
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (11 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 12/16] mutter: add recipe for mutter window manager brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-30 2:44 ` Khem Raj
2018-10-30 11:20 ` Burton, Ross
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 14/16] packagegroup-gnome3-base: add packagegroup for installing gnome3/gnome-shell brendank310
` (4 subsequent siblings)
17 siblings, 2 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../gnome-shell/0001-dont-detect-python.patch | 24 ++++++++++
.../recipes-gnome/gnome3/gnome-shell_git.bb | 46 +++++++++++++++++++
2 files changed, 70 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-shell/0001-dont-detect-python.patch
create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-shell_git.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-shell/0001-dont-detect-python.patch b/meta-gnome/recipes-gnome/gnome3/gnome-shell/0001-dont-detect-python.patch
new file mode 100644
index 000000000..50d874061
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gnome-shell/0001-dont-detect-python.patch
@@ -0,0 +1,24 @@
+gnome-shell: Add decoration to tweak python3 path
+
+ The python detection used in the meson script doesn't
+ resolve correctly. Add a decoration to allow the
+ do_configure_prepend to sed in the correct path for
+ python3-native.
+
+ Upstream-status: Innappropriate [embedded-specific]
+
+ Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
+
+diff --git a/src/meson.build b/src/meson.build
+index 178e05899..d3d8df97b 100644
+--- a/src/meson.build
++++ b/src/meson.build
+@@ -13,7 +13,7 @@ script_data.set('libdir', libdir)
+ script_data.set('libexecdir', libexecdir)
+ script_data.set('pkgdatadir', pkgdatadir)
+ script_data.set('pkglibdir', pkglibdir)
+-script_data.set('PYTHON', python.path())
++script_data.set('PYTHON', '@PYTHON3_PATH@')
+ script_data.set('VERSION', meson.project_version())
+
+ foreach tool : ['gnome-shell-extension-tool', 'gnome-shell-perf-tool']
diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-shell_git.bb b/meta-gnome/recipes-gnome/gnome3/gnome-shell_git.bb
new file mode 100644
index 000000000..d8f8a4c77
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gnome-shell_git.bb
@@ -0,0 +1,46 @@
+DESCRIPTION = "GNOME Shell"
+LICENSE = "GPLv2"
+DEPENDS = " \
+ glib-2.0 \
+ gsettings-desktop-schemas \
+ gjs \
+ gdm \
+ gnome-desktop3 \
+ mutter \
+ wayland \
+ wayland-protocols \
+ evolution-data-server \
+ libcroco \
+ polkit \
+ gnome-bluetooth \
+ gstreamer \
+ keybinder \
+ gnome-settings-daemon \
+ ibus \
+ librsvg \
+ sassc-native \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+SRC_URI = "git://gitlab.gnome.org/GNOME/gnome-shell.git;protocol=http;branch=master;tag=3.30.1 \
+ file://0001-dont-detect-python.patch \
+ "
+
+RDEPENDS_gnome-shell += " python3-core python3-pygobject gnome-settings-daemon gnome-bluetooth gdm "
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson gobject-introspection gettext
+
+EXTRA_OEMESON += " -Dman=false -Dnetworkmanager=false "
+
+FILES_${PN} += "${datadir}"
+FILES_${PN} += "${libdir}"
+FILES_${PN} += "${bindir}"
+
+do_configure_prepend() {
+ # Fixup the gsettings version
+ sed -i 's^3.27.90^3.24.1^g' ${S}/meson.build
+ sed -i "s^@PYTHON3_PATH@^${RECIPE_SYSROOT_NATIVE}/${bindir}/python3^g" ${S}/meson.build
+}
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 13/16] gnome-shell: add recipe for gnome-shell.
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 13/16] gnome-shell: add recipe for gnome-shell brendank310
@ 2018-10-30 2:44 ` Khem Raj
2018-10-30 11:20 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Khem Raj @ 2018-10-30 2:44 UTC (permalink / raw)
To: brendank310; +Cc: schnitzeltony, openembedded-devel
On Mon, Oct 29, 2018 at 9:43 AM brendank310 <brendank310@gmail.com> wrote:
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../gnome-shell/0001-dont-detect-python.patch | 24 ++++++++++
> .../recipes-gnome/gnome3/gnome-shell_git.bb | 46 +++++++++++++++++++
> 2 files changed, 70 insertions(+)
> create mode 100644
> meta-gnome/recipes-gnome/gnome3/gnome-shell/0001-dont-detect-python.patch
> create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-shell_git.bb
>
> diff --git
> a/meta-gnome/recipes-gnome/gnome3/gnome-shell/0001-dont-detect-python.patch
> b/meta-gnome/recipes-gnome/gnome3/gnome-shell/0001-dont-detect-python.patch
> new file mode 100644
> index 000000000..50d874061
> --- /dev/null
> +++
> b/meta-gnome/recipes-gnome/gnome3/gnome-shell/0001-dont-detect-python.patch
> @@ -0,0 +1,24 @@
> +gnome-shell: Add decoration to tweak python3 path
> +
> + The python detection used in the meson script doesn't
> + resolve correctly. Add a decoration to allow the
> + do_configure_prepend to sed in the correct path for
> + python3-native.
> +
> + Upstream-status: Innappropriate [embedded-specific]
> +
> + Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> +
> +diff --git a/src/meson.build b/src/meson.build
> +index 178e05899..d3d8df97b 100644
> +--- a/src/meson.build
> ++++ b/src/meson.build
> +@@ -13,7 +13,7 @@ script_data.set('libdir', libdir)
> + script_data.set('libexecdir', libexecdir)
> + script_data.set('pkgdatadir', pkgdatadir)
> + script_data.set('pkglibdir', pkglibdir)
> +-script_data.set('PYTHON', python.path())
> ++script_data.set('PYTHON', '@PYTHON3_PATH@')
> + script_data.set('VERSION', meson.project_version())
> +
> + foreach tool : ['gnome-shell-extension-tool', 'gnome-shell-perf-tool']
> diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-shell_git.bb
> b/meta-gnome/recipes-gnome/gnome3/gnome-shell_git.bb
> new file mode 100644
> index 000000000..d8f8a4c77
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gnome-shell_git.bb
> @@ -0,0 +1,46 @@
> +DESCRIPTION = "GNOME Shell"
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> + glib-2.0 \
> + gsettings-desktop-schemas \
> + gjs \
> + gdm \
> + gnome-desktop3 \
> + mutter \
> + wayland \
> + wayland-protocols \
Wayland is a distro feature so we need to control these depends with that
knob
>
> + evolution-data-server \
> + libcroco \
> + polkit \
> + gnome-bluetooth \
> + gstreamer \
> + keybinder \
> + gnome-settings-daemon \
> + ibus \
> + librsvg \
> + sassc-native \
> + "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +SRC_URI = "git://
> gitlab.gnome.org/GNOME/gnome-shell.git;protocol=http;branch=master;tag=3.30.1
> \
> + file://0001-dont-detect-python.patch \
> + "
> +
> +RDEPENDS_gnome-shell += " python3-core python3-pygobject
> gnome-settings-daemon gnome-bluetooth gdm "
> +S = "${WORKDIR}/git"
> +
> +inherit pkgconfig meson gobject-introspection gettext
> +
> +EXTRA_OEMESON += " -Dman=false -Dnetworkmanager=false "
> +
> +FILES_${PN} += "${datadir}"
> +FILES_${PN} += "${libdir}"
> +FILES_${PN} += "${bindir}"
> +
> +do_configure_prepend() {
> + # Fixup the gsettings version
> + sed -i 's^3.27.90^3.24.1^g' ${S}/meson.build
> + sed -i "s^@PYTHON3_PATH@^${RECIPE_SYSROOT_NATIVE}/${bindir}/python3^g"
> ${S}/meson.build
> +}
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 13/16] gnome-shell: add recipe for gnome-shell.
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 13/16] gnome-shell: add recipe for gnome-shell brendank310
2018-10-30 2:44 ` Khem Raj
@ 2018-10-30 11:20 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 11:20 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:43, brendank310 <brendank310@gmail.com> wrote:
> +SRC_URI = "git://gitlab.gnome.org/GNOME/gnome-shell.git;protocol=http;branch=master;tag=3.30.1 \
> + file://0001-dont-detect-python.patch \
> + "
Tarball is preferred.
> +RDEPENDS_gnome-shell += " python3-core python3-pygobject gnome-settings-daemon gnome-bluetooth gdm "
Use ${PN} instead of gnome-shell so this works for multilib.
> +EXTRA_OEMESON += " -Dman=false -Dnetworkmanager=false "
Respecting the api-documentation DISTRO_FEATURE would be good here.
See manpages.bbclass.
> +FILES_${PN} += "${libdir}"
Almost definitely wrong.
> +FILES_${PN} += "${bindir}"
This is in FILES by default.
> +do_configure_prepend() {
> + # Fixup the gsettings version
> + sed -i 's^3.27.90^3.24.1^g' ${S}/meson.build
Do this as a patch so we can see *why*.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 14/16] packagegroup-gnome3-base: add packagegroup for installing gnome3/gnome-shell
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (12 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 13/16] gnome-shell: add recipe for gnome-shell brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-29 23:03 ` Andreas Müller
` (2 more replies)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 15/16] gnome-shell-extensions: add recipe for gnome-shell-extensions brendank310
` (3 subsequent siblings)
17 siblings, 3 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../packagegroups/packagegroup-gnome3-base.bb | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
diff --git a/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb b/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
new file mode 100644
index 000000000..8484087b8
--- /dev/null
+++ b/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
@@ -0,0 +1,27 @@
+SUMMARY = "All packages required for a base install of Gnome Shell"
+SECTION = "x11/wm"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
+PR = "r0"
+
+inherit packagegroup distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "x11"
+
+RDEPENDS_${PN} = " \
+ packagegroup-core-x11 \
+ xinit \
+ atk \
+ at-spi2-core \
+ at-spi2-atk \
+ cairo \
+ gnome-shell \
+ gnome-bluetooth \
+ upower \
+ pulseaudio \
+ librsvg \
+ ibus \
+ gnome-desktop3 \
+ accountsservice \
+ gnome-settings-daemon \
+"
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 14/16] packagegroup-gnome3-base: add packagegroup for installing gnome3/gnome-shell
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 14/16] packagegroup-gnome3-base: add packagegroup for installing gnome3/gnome-shell brendank310
@ 2018-10-29 23:03 ` Andreas Müller
2018-10-30 11:32 ` Burton, Ross
2018-10-30 12:00 ` Burton, Ross
2 siblings, 0 replies; 64+ messages in thread
From: Andreas Müller @ 2018-10-29 23:03 UTC (permalink / raw)
To: brendank310; +Cc: openembeded-devel
On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../packagegroups/packagegroup-gnome3-base.bb | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
>
> diff --git a/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb b/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
> new file mode 100644
> index 000000000..8484087b8
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
> @@ -0,0 +1,27 @@
> +SUMMARY = "All packages required for a base install of Gnome Shell"
> +SECTION = "x11/wm"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
> +PR = "r0"
^ Please remove - we have auto-pr
> +
> +inherit packagegroup distro_features_check
> +
> +REQUIRED_DISTRO_FEATURES = "x11"
> +
> +RDEPENDS_${PN} = " \
> + packagegroup-core-x11 \
> + xinit \
> + atk \
> + at-spi2-core \
> + at-spi2-atk \
> + cairo \
> + gnome-shell \
> + gnome-bluetooth \
> + upower \
> + pulseaudio \
> + librsvg \
> + ibus \
> + gnome-desktop3 \
> + accountsservice \
> + gnome-settings-daemon \
> +"
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 14/16] packagegroup-gnome3-base: add packagegroup for installing gnome3/gnome-shell
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 14/16] packagegroup-gnome3-base: add packagegroup for installing gnome3/gnome-shell brendank310
2018-10-29 23:03 ` Andreas Müller
@ 2018-10-30 11:32 ` Burton, Ross
2018-10-30 12:00 ` Burton, Ross
2 siblings, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 11:32 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:43, brendank310 <brendank310@gmail.com> wrote:
> +inherit packagegroup distro_features_check
> +
> +REQUIRED_DISTRO_FEATURES = "x11"
Everyone running GNOME 3 on Wayland will be surprised by this. This
packagegroup should be *just* GNOME and then the image using it can
decide whether to pull in X11 or Weston.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* Re: [RFC meta-gnome][PATCH 14/16] packagegroup-gnome3-base: add packagegroup for installing gnome3/gnome-shell
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 14/16] packagegroup-gnome3-base: add packagegroup for installing gnome3/gnome-shell brendank310
2018-10-29 23:03 ` Andreas Müller
2018-10-30 11:32 ` Burton, Ross
@ 2018-10-30 12:00 ` Burton, Ross
2 siblings, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 12:00 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:43, brendank310 <brendank310@gmail.com> wrote:
> +LICENSE = "MIT"
Implied by packagegroup.bbclass.
> +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
Not required.
> +RDEPENDS_${PN} = " \
> + packagegroup-core-x11 \
> + xinit \
> + atk \
> + at-spi2-core \
> + at-spi2-atk \
> + cairo \
> + gnome-shell \
> + gnome-bluetooth \
> + upower \
> + pulseaudio \
> + librsvg \
> + ibus \
> + gnome-desktop3 \
> + accountsservice \
> + gnome-settings-daemon \
> +"
A large proportion of those are libraries that will be pulled in
automatically (atk, cairo, librsvg, etc). These can be removed.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 15/16] gnome-shell-extensions: add recipe for gnome-shell-extensions
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (13 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 14/16] packagegroup-gnome3-base: add packagegroup for installing gnome3/gnome-shell brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-29 23:06 ` Andreas Müller
2018-10-30 11:31 ` Burton, Ross
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool brendank310
` (2 subsequent siblings)
17 siblings, 2 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../gnome3/gnome-shell-extensions_git.bb | 40 +++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-shell-extensions_git.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-shell-extensions_git.bb b/meta-gnome/recipes-gnome/gnome3/gnome-shell-extensions_git.bb
new file mode 100644
index 000000000..8c02195d9
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gnome-shell-extensions_git.bb
@@ -0,0 +1,40 @@
+DESCRIPTION = "GNOME Shell Extensions"
+LICENSE = "GPLv2"
+DEPENDS = " \
+ glib-2.0 \
+ gsettings-desktop-schemas \
+ gjs \
+ gnome-desktop3 \
+ gdm \
+ mutter \
+ wayland \
+ wayland-protocols \
+ evolution-data-server \
+ libcroco \
+ polkit \
+ gnome-bluetooth \
+ gstreamer \
+ keybinder \
+ gnome-settings-daemon \
+ ibus \
+ librsvg \
+ python3 \
+ sassc-native \
+ "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=4cb3a392cbf81a9e685ec13b88c4c101"
+
+SRC_URI = " \
+ git://gitlab.gnome.org/GNOME/gnome-shell-extensions.git;protocol=http;branch=master;tag=3.30.1 \
+ "
+
+RDEPENDS_gnome-shell = " \
+ gnome-shell \
+ "
+S = "${WORKDIR}/git"
+
+EXTRA_OEMESON += " -Dextension_set=all "
+
+FILES_${PN} += "${datadir}"
+
+inherit pkgconfig meson gobject-introspection gettext
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 15/16] gnome-shell-extensions: add recipe for gnome-shell-extensions
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 15/16] gnome-shell-extensions: add recipe for gnome-shell-extensions brendank310
@ 2018-10-29 23:06 ` Andreas Müller
2018-10-30 11:31 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Andreas Müller @ 2018-10-29 23:06 UTC (permalink / raw)
To: brendank310; +Cc: openembeded-devel
On Mon, Oct 29, 2018 at 5:42 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../gnome3/gnome-shell-extensions_git.bb | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-shell-extensions_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-shell-extensions_git.bb b/meta-gnome/recipes-gnome/gnome3/gnome-shell-extensions_git.bb
> new file mode 100644
> index 000000000..8c02195d9
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gnome-shell-extensions_git.bb
> @@ -0,0 +1,40 @@
> +DESCRIPTION = "GNOME Shell Extensions"
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> + glib-2.0 \
> + gsettings-desktop-schemas \
> + gjs \
> + gnome-desktop3 \
> + gdm \
> + mutter \
> + wayland \
> + wayland-protocols \
> + evolution-data-server \
> + libcroco \
> + polkit \
> + gnome-bluetooth \
> + gstreamer \
> + keybinder \
> + gnome-settings-daemon \
> + ibus \
> + librsvg \
> + python3 \
> + sassc-native \
> + "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=4cb3a392cbf81a9e685ec13b88c4c101"
> +
> +SRC_URI = " \
> + git://gitlab.gnome.org/GNOME/gnome-shell-extensions.git;protocol=http;branch=master;tag=3.30.1 \
> + "
> +
> +RDEPENDS_gnome-shell = " \
> + gnome-shell \
> + "
^ I think it should be RDEPENDS_gnome-shell-extensions
> +S = "${WORKDIR}/git"
> +
> +EXTRA_OEMESON += " -Dextension_set=all "
> +
> +FILES_${PN} += "${datadir}"
^ Put this at the end of the recipe please
> +
> +inherit pkgconfig meson gobject-introspection gettext
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 15/16] gnome-shell-extensions: add recipe for gnome-shell-extensions
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 15/16] gnome-shell-extensions: add recipe for gnome-shell-extensions brendank310
2018-10-29 23:06 ` Andreas Müller
@ 2018-10-30 11:31 ` Burton, Ross
1 sibling, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 11:31 UTC (permalink / raw)
To: brendank310; +Cc: Andreas Müller, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 16:43, brendank310 <brendank310@gmail.com> wrote:
> +SRC_URI = " \
> + git://gitlab.gnome.org/GNOME/gnome-shell-extensions.git;protocol=http;branch=master;tag=3.30.1 \
> + "
Use tarball.
> +RDEPENDS_gnome-shell = " \
> + gnome-shell \
> + "
This is why you use ${PN} ;)
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (14 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 15/16] gnome-shell-extensions: add recipe for gnome-shell-extensions brendank310
@ 2018-10-29 16:41 ` brendank310
2018-10-29 23:09 ` Andreas Müller
2018-10-30 2:32 ` Khem Raj
2018-10-29 22:34 ` [RFC meta-gnome][PATCH 00/16] Add gnome-shell support Andreas Müller
2018-11-06 20:11 ` Alexander Kanavin
17 siblings, 2 replies; 64+ messages in thread
From: brendank310 @ 2018-10-29 16:41 UTC (permalink / raw)
To: openembedded-devel; +Cc: schnitzeltony
From: Brendan Kerrigan <kerriganb@ainfosec.com>
Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
.../recipes-gnome/gnome3/gnome-tweaks_git.bb | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
new file mode 100644
index 000000000..fe305c922
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
@@ -0,0 +1,19 @@
+DESCRIPTION = "GNOME Tweaks"
+LICENSE = "GPLv2"
+DEPENDS = " \
+ gnome-shell \
+ "
+
+LIC_FILES_CHKSUM = "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"
+
+SRC_URI = "git://gitlab.gnome.org/GNOME/gnome-tweaks.git;protocol=http;branch=master;tag=3.30.1 \
+ "
+
+S = "${WORKDIR}/git"
+
+FILES_${PN} += "${libdir}"
+FILES_${PN} += "${datadir}"
+
+inherit pkgconfig meson gobject-introspection gettext
+
+
--
2.17.1
^ permalink raw reply related [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool brendank310
@ 2018-10-29 23:09 ` Andreas Müller
2018-10-30 2:32 ` Khem Raj
1 sibling, 0 replies; 64+ messages in thread
From: Andreas Müller @ 2018-10-29 23:09 UTC (permalink / raw)
To: brendank310; +Cc: openembeded-devel
On Mon, Oct 29, 2018 at 5:42 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../recipes-gnome/gnome3/gnome-tweaks_git.bb | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> new file mode 100644
> index 000000000..fe305c922
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "GNOME Tweaks"
^ Maybe I have missed this in other patches: SUMMARY is default short
description
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> + gnome-shell \
> + "
> +
> +LIC_FILES_CHKSUM = "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"
> +
> +SRC_URI = "git://gitlab.gnome.org/GNOME/gnome-tweaks.git;protocol=http;branch=master;tag=3.30.1 \
> + "
> +
> +S = "${WORKDIR}/git"
> +
> +FILES_${PN} += "${libdir}"
> +FILES_${PN} += "${datadir}"
^ again libdir necessary? / one staetment / end of recipe
> +
> +inherit pkgconfig meson gobject-introspection gettext
> +
> +
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool brendank310
2018-10-29 23:09 ` Andreas Müller
@ 2018-10-30 2:32 ` Khem Raj
2018-10-30 11:54 ` Burton, Ross
1 sibling, 1 reply; 64+ messages in thread
From: Khem Raj @ 2018-10-30 2:32 UTC (permalink / raw)
To: brendank310; +Cc: schnitzeltony, openembedded-devel
On Mon, Oct 29, 2018 at 9:43 AM brendank310 <brendank310@gmail.com> wrote:
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
> .../recipes-gnome/gnome3/gnome-tweaks_git.bb | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> new file mode 100644
> index 000000000..fe305c922
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "GNOME Tweaks"
> +LICENSE = "GPLv2"
This seems should be GPL-3.0 as that’s what
Being checksummed few lines below
>
> +DEPENDS = " \
> + gnome-shell \
> + "
> +
> +LIC_FILES_CHKSUM =
> "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"
> +
> +SRC_URI = "git://
> gitlab.gnome.org/GNOME/gnome-tweaks.git;protocol=http;branch=master;tag=3.30.1
> \
> + "
> +
> +S = "${WORKDIR}/git"
> +
> +FILES_${PN} += "${libdir}"
> +FILES_${PN} += "${datadir}"
> +
> +inherit pkgconfig meson gobject-introspection gettext
> +
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool
2018-10-30 2:32 ` Khem Raj
@ 2018-10-30 11:54 ` Burton, Ross
0 siblings, 0 replies; 64+ messages in thread
From: Burton, Ross @ 2018-10-30 11:54 UTC (permalink / raw)
To: Khem Raj; +Cc: OpenEmbedded Devel List, Andreas Müller
On Tue, 30 Oct 2018 at 03:43, Khem Raj <raj.khem@gmail.com> wrote:
> > +LICENSE = "GPLv2"
> This seems should be GPL-3.0 as that’s what
> Being checksummed few lines below
> > +LIC_FILES_CHKSUM =
> > "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"
There's also a CCO license file in there which should be referred to
in LICENSE and checksummed.
Ross
^ permalink raw reply [flat|nested] 64+ messages in thread
* Re: [RFC meta-gnome][PATCH 00/16] Add gnome-shell support
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (15 preceding siblings ...)
2018-10-29 16:41 ` [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool brendank310
@ 2018-10-29 22:34 ` Andreas Müller
2018-10-31 13:17 ` Brendan Kerrigan
2018-11-06 20:11 ` Alexander Kanavin
17 siblings, 1 reply; 64+ messages in thread
From: Andreas Müller @ 2018-10-29 22:34 UTC (permalink / raw)
To: brendank310; +Cc: openembeded-devel
On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
>
> This adds gnome3/gnome-shell support (and required dependencies)
> to meta-gnome.
>
> Please review the following changes for suitability for inclusion. If you have
> any objections or suggestions for improvement, please respond to the patches. If
> you agree with the changes, please provide your Acked-by.
>
> The following changes since commit f1511d254632a34c1deb51f4bf8b8c21e7423f51:
>
Thanks for doing this! Hope to get it build/run-tested soon -
currently I am shaping my layers for thud and poky-users.
Did not look much into details but I have one question: Many recipes
still use autotools and GNOME's target will be meson. Is there a
reason that most of the recipes use autotools?
Regards
Andreas
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 00/16] Add gnome-shell support
2018-10-29 22:34 ` [RFC meta-gnome][PATCH 00/16] Add gnome-shell support Andreas Müller
@ 2018-10-31 13:17 ` Brendan Kerrigan
2018-10-31 13:30 ` Andreas Müller
0 siblings, 1 reply; 64+ messages in thread
From: Brendan Kerrigan @ 2018-10-31 13:17 UTC (permalink / raw)
To: schnitzeltony; +Cc: openembedded-devel
Yeah the recipes still using autotools were not utilizing meson at the time
the work was started. If some of the projects have migrated in the mean
time, it makes sense to do that work now. At this point I think it makes
sense to split this into two pull requests, the first set of patches will
uprev existing recipes (e.g. lcms, dconf to support native, etc), and a
follow on reflow of the additional recipes for supporting gnome-shell with
the comments addressed. I expect to be able to post a v2 by early next week
as I have other commitments that have taken priority. Thanks for all the
comments so far.
Brendan
On Mon, Oct 29, 2018 at 6:34 PM Andreas Müller <schnitzeltony@gmail.com>
wrote:
> On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
> >
> > This adds gnome3/gnome-shell support (and required dependencies)
> > to meta-gnome.
> >
> > Please review the following changes for suitability for inclusion. If
> you have
> > any objections or suggestions for improvement, please respond to the
> patches. If
> > you agree with the changes, please provide your Acked-by.
> >
> > The following changes since commit
> f1511d254632a34c1deb51f4bf8b8c21e7423f51:
> >
> Thanks for doing this! Hope to get it build/run-tested soon -
> currently I am shaping my layers for thud and poky-users.
>
> Did not look much into details but I have one question: Many recipes
> still use autotools and GNOME's target will be meson. Is there a
> reason that most of the recipes use autotools?
>
> Regards
>
> Andreas
>
^ permalink raw reply [flat|nested] 64+ messages in thread
* Re: [RFC meta-gnome][PATCH 00/16] Add gnome-shell support
2018-10-31 13:17 ` Brendan Kerrigan
@ 2018-10-31 13:30 ` Andreas Müller
0 siblings, 0 replies; 64+ messages in thread
From: Andreas Müller @ 2018-10-31 13:30 UTC (permalink / raw)
To: Brendan Kerrigan; +Cc: openembeded-devel
On Wed, Oct 31, 2018 at 2:17 PM Brendan Kerrigan <brendank310@gmail.com> wrote:
>
> Yeah the recipes still using autotools were not utilizing meson at the time the work was started. If some of the projects have migrated in the mean time, it makes sense to do that work now. At this point I think it makes sense to split this into two pull requests, the first set of patches will uprev existing recipes (e.g. lcms, dconf to support native, etc), and a follow on reflow of the additional recipes for supporting gnome-shell with the comments addressed. I expect to be able to post a v2 by early next week as I have other commitments that have taken priority. Thanks for all the comments so far.
>
> Brendan
postponing meson sounds reasonable - we've put a heavy load on your
TODO already :)
Thanks again for gnome3ing - I am excited to see how it performs.
Andreas
^ permalink raw reply [flat|nested] 64+ messages in thread
* Re: [RFC meta-gnome][PATCH 00/16] Add gnome-shell support
2018-10-29 16:40 [RFC meta-gnome][PATCH 00/16] Add gnome-shell support brendank310
` (16 preceding siblings ...)
2018-10-29 22:34 ` [RFC meta-gnome][PATCH 00/16] Add gnome-shell support Andreas Müller
@ 2018-11-06 20:11 ` Alexander Kanavin
2018-11-07 20:24 ` Khem Raj
17 siblings, 1 reply; 64+ messages in thread
From: Alexander Kanavin @ 2018-11-06 20:11 UTC (permalink / raw)
To: brendank310; +Cc: schnitzeltony, OpenEmbedded Devel List
On Mon, 29 Oct 2018 at 17:41, brendank310 <brendank310@gmail.com> wrote:
> This adds gnome3/gnome-shell support (and required dependencies)
> to meta-gnome.
It may be somewhat far-fetched, but how about taking this into oe-core
and retiring matchbox and sato?
Alex
^ permalink raw reply [flat|nested] 64+ messages in thread* Re: [RFC meta-gnome][PATCH 00/16] Add gnome-shell support
2018-11-06 20:11 ` Alexander Kanavin
@ 2018-11-07 20:24 ` Khem Raj
0 siblings, 0 replies; 64+ messages in thread
From: Khem Raj @ 2018-11-07 20:24 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: openembeded-devel, Andreas Müller
On Tue, Nov 6, 2018 at 12:12 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> On Mon, 29 Oct 2018 at 17:41, brendank310 <brendank310@gmail.com> wrote:
> > This adds gnome3/gnome-shell support (and required dependencies)
> > to meta-gnome.
>
> It may be somewhat far-fetched, but how about taking this into oe-core
> and retiring matchbox and sato?
I would rather suggest to include QT5 if we want to include more
modern framework and may be something like LXQT as a light DM on top.
Many OE deployments that I know if OE use QT,
I think community would benefit a lot from most common use-case being in OE-Core
but I am for anything thats more modern
^ permalink raw reply [flat|nested] 64+ messages in thread