[PATCH] bitbake.conf: add unzip to HOSTTOOLS

[PATCH] bitbake.conf: add unzip to HOSTTOOLS

[Andreas Müller]

fixes do_unpack for *.zip-files:

| /bin/sh: unzip: command not found

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index af3937a..1ea0dea 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -461,7 +461,7 @@ HOSTTOOLS += " \
     mktemp mv nm objcopy objdump od patch perl pod2man printf pwd python \
     python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh sleep \
     sort split stat strings strip tail tar tee test touch tr true uname uniq \
-    wc wget which xargs \
+    unzip wc wget which xargs \
 "
 
 # Tools needed to run testimage runtime image testing
-- 
2.9.3

Re: [PATCH] bitbake.conf: add unzip to HOSTTOOLS

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

On Thu, Apr 13, 2017 at 8:44 AM, Andreas Müller <
schnitzeltony@googlemail.com> wrote:

> fixes do_unpack for *.zip-files:
>
> | /bin/sh: unzip: command not found
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>  meta/conf/bitbake.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index af3937a..1ea0dea 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -461,7 +461,7 @@ HOSTTOOLS += " \
>      mktemp mv nm objcopy objdump od patch perl pod2man printf pwd python \
>      python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh
> sleep \
>      sort split stat strings strip tail tar tee test touch tr true uname
> uniq \
> -    wc wget which xargs \
> +    unzip wc wget which xargs \
>  "
>

unzip-native is already added to the depends of do_unpack in base.bbclass..
there should be no need to use an unzip on the host at all.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1732 bytes --]

Re: [PATCH] bitbake.conf: add unzip to HOSTTOOLS

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]

Some recipes like firefox depend on unzip even outside the do_unpack task:
https://github.com/OSSystems/meta-browser/commit/1e9c2d21cd4757b8d2352c2ff5aa72f3409d59f9
https://github.com/OSSystems/meta-browser/commit/bd2c39ddba00a3e0171e30ee4a4585b56122990a

but I agree these cases should be fixed by DEPENDS in the recipes which
need it instead of adding unzip globally for all.

On Thu, Apr 13, 2017 at 5:47 PM, Christopher Larson <kergoth@gmail.com>
wrote:

>
> On Thu, Apr 13, 2017 at 8:44 AM, Andreas Müller <
> schnitzeltony@googlemail.com> wrote:
>
>> fixes do_unpack for *.zip-files:
>>
>> | /bin/sh: unzip: command not found
>>
>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>> ---
>>  meta/conf/bitbake.conf | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index af3937a..1ea0dea 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -461,7 +461,7 @@ HOSTTOOLS += " \
>>      mktemp mv nm objcopy objdump od patch perl pod2man printf pwd python
>> \
>>      python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh
>> sleep \
>>      sort split stat strings strip tail tar tee test touch tr true uname
>> uniq \
>> -    wc wget which xargs \
>> +    unzip wc wget which xargs \
>>  "
>>
>
> unzip-native is already added to the depends of do_unpack in
> base.bbclass.. there should be no need to use an unzip on the host at all.
> --
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Senior Software Engineer, Mentor Graphics
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

[-- Attachment #2: Type: text/html, Size: 3348 bytes --]

Re: [PATCH] bitbake.conf: add unzip to HOSTTOOLS

[Andreas Müller]

On Thu, Apr 13, 2017 at 5:49 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> Some recipes like firefox depend on unzip even outside the do_unpack task:
> https://github.com/OSSystems/meta-browser/commit/1e9c2d21cd4757b8d2352c2ff5aa72f3409d59f9
> https://github.com/OSSystems/meta-browser/commit/bd2c39ddba00a3e0171e30ee4a4585b56122990a
>
> but I agree these cases should be fixed by DEPENDS in the recipes which need
> it instead of adding unzip globally for all.
>
> On Thu, Apr 13, 2017 at 5:47 PM, Christopher Larson <kergoth@gmail.com>
> wrote:
>>
>>
>> On Thu, Apr 13, 2017 at 8:44 AM, Andreas Müller
>> <schnitzeltony@googlemail.com> wrote:
>>>
>>> fixes do_unpack for *.zip-files:
>>>
>>> | /bin/sh: unzip: command not found
>>>
>>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>>> ---
>>>  meta/conf/bitbake.conf | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>>> index af3937a..1ea0dea 100644
>>> --- a/meta/conf/bitbake.conf
>>> +++ b/meta/conf/bitbake.conf
>>> @@ -461,7 +461,7 @@ HOSTTOOLS += " \
>>>      mktemp mv nm objcopy objdump od patch perl pod2man printf pwd python
>>> \
>>>      python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh
>>> sleep \
>>>      sort split stat strings strip tail tar tee test touch tr true uname
>>> uniq \
>>> -    wc wget which xargs \
>>> +    unzip wc wget which xargs \
>>>  "
>>
>>
>> unzip-native is already added to the depends of do_unpack in
>> base.bbclass.. there should be no need to use an unzip on the host at all.
OK - but why do I see this error in do_unpack?

Andreas

Re: [PATCH] bitbake.conf: add unzip to HOSTTOOLS

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

On 13 April 2017 at 16:53, Andreas Müller <schnitzeltony@googlemail.com>
wrote:

> OK - but why do I see this error in do_unpack?
>

What recipe and task?

Ross

[-- Attachment #2: Type: text/html, Size: 573 bytes --]

Re: [PATCH] bitbake.conf: add unzip to HOSTTOOLS

[Andreas Müller]

On Thu, Apr 13, 2017 at 5:57 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 13 April 2017 at 16:53, Andreas Müller <schnitzeltony@googlemail.com>
> wrote:
>>
>> OK - but why do I see this error in do_unpack?
>
>
> What recipe and task?
>
> Ross
>
It is not that simple and it drives me mad (as usual :)

Failing recipes were [1-2]. They failed in task (do_)unpack.

For unknown reasons case [1] (polyphone) works fine now. OK - I pulled
oe-core again (40 commits) - this is what I usually do when things
fail but I cannot see what commit has mended the issue for case [1].

Case [2] could be fixed by
do_unpack[depends] += "p7zip-native:do_populate_sysroot"

So I hope my do_unpack trouble is gone. Thanks for taking care and
ignore the patch I sent.

Andreas

[1] https://github.com/schnitzeltony/meta-qt5-extra/blob/master/recipes-misc/recipes-multimedia/polyphone/polyphone_1.8.bb
[2] https://github.com/schnitzeltony/meta-retro/blob/master/recipes-games/dxx-rebirth/d1x-rebirth_v0.58.1.bb

Re: [PATCH] bitbake.conf: add unzip to HOSTTOOLS

[Andre McCurdy]

On Thu, Apr 13, 2017 at 1:34 PM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Thu, Apr 13, 2017 at 5:57 PM, Burton, Ross <ross.burton@intel.com> wrote:
>> On 13 April 2017 at 16:53, Andreas Müller <schnitzeltony@googlemail.com>
>> wrote:
>>>
>>> OK - but why do I see this error in do_unpack?
>>
>> What recipe and task?
>>
>> Ross
>>
> It is not that simple and it drives me mad (as usual :)
>
> Failing recipes were [1-2]. They failed in task (do_)unpack.

[1] SRC_URI = " \
    http://.../latest/download;downloadfilename=polyphone-1-8-src.zip \

base.bbclass tests the end of the URI path, not downloadfilename, so
it's not going to detect this dependency correctly.

[2] SRC_URI = " \
    http://.../hires-sounds.7z;name=sound \

base.bbclass doesn't test for .7z extensions, so won't detect this
dependency either.

In both cases, the fix should probably go in base.bbclass.

> For unknown reasons case [1] (polyphone) works fine now. OK - I pulled
> oe-core again (40 commits) - this is what I usually do when things
> fail but I cannot see what commit has mended the issue for case [1].
>
> Case [2] could be fixed by
> do_unpack[depends] += "p7zip-native:do_populate_sysroot"
>
> So I hope my do_unpack trouble is gone. Thanks for taking care and
> ignore the patch I sent.
>
> Andreas
>
> [1] https://github.com/schnitzeltony/meta-qt5-extra/blob/master/recipes-misc/recipes-multimedia/polyphone/polyphone_1.8.bb
> [2] https://github.com/schnitzeltony/meta-retro/blob/master/recipes-games/dxx-rebirth/d1x-rebirth_v0.58.1.bb
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] bitbake.conf: add unzip to HOSTTOOLS

[Andreas Müller]

On Thu, Apr 13, 2017 at 10:58 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Thu, Apr 13, 2017 at 1:34 PM, Andreas Müller
> <schnitzeltony@googlemail.com> wrote:
>> On Thu, Apr 13, 2017 at 5:57 PM, Burton, Ross <ross.burton@intel.com> wrote:
>>> On 13 April 2017 at 16:53, Andreas Müller <schnitzeltony@googlemail.com>
>>> wrote:
>>>>
>>>> OK - but why do I see this error in do_unpack?
>>>
>>> What recipe and task?
>>>
>>> Ross
>>>
>> It is not that simple and it drives me mad (as usual :)
>>
>> Failing recipes were [1-2]. They failed in task (do_)unpack.
>
> [1] SRC_URI = " \
>     http://.../latest/download;downloadfilename=polyphone-1-8-src.zip \
>
> base.bbclass tests the end of the URI path, not downloadfilename, so
> it's not going to detect this dependency correctly.
Yes I thought same but why does it work now? log.do_unpack says

| NOTE: Unpacking /home/superandy/data/download/polyphone-1-8-src.zip
to /home/superandy/tmp/oe-core-glibc/work/cortexa7t2hf-neon-vfpv4-angstrom-linux-gnueabi/polyphone/1.8-r0/
>
> [2] SRC_URI = " \
>     http://.../hires-sounds.7z;name=sound \
>
> base.bbclass doesn't test for .7z extensions, so won't detect this
> dependency either.
>
Correct - but note that 7z extractor p7zip-native is not (yet) in oe-core.

> In both cases, the fix should probably go in base.bbclass.
>
Andreas

Re: [PATCH] bitbake.conf: add unzip to HOSTTOOLS

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

On 13 April 2017 at 22:09, Andreas Müller <schnitzeltony@googlemail.com>
wrote:

> > base.bbclass doesn't test for .7z extensions, so won't detect this
> > dependency either.
> >
> Correct - but note that 7z extractor p7zip-native is not (yet) in oe-core.
>

There's plenty of prior for base.bbclass supporting extractors/fetchers
that are not in oe-core, so a quick patch to fix this would be totally
acceptable.

Ross

[-- Attachment #2: Type: text/html, Size: 827 bytes --]

Re: [PATCH] bitbake.conf: add unzip to HOSTTOOLS

[Paul Eggleton]

On Friday, 14 April 2017 8:34:27 AM NZST Andreas Müller wrote:
> On Thu, Apr 13, 2017 at 5:57 PM, Burton, Ross <ross.burton@intel.com> wrote:
> > On 13 April 2017 at 16:53, Andreas Müller <schnitzeltony@googlemail.com>
> > 
> > wrote:
> >> OK - but why do I see this error in do_unpack?
> > 
> > What recipe and task?
> > 
> > Ross
> 
> It is not that simple and it drives me mad (as usual :)
> 
> Failing recipes were [1-2]. They failed in task (do_)unpack.
> 
> For unknown reasons case [1] (polyphone) works fine now. OK - I pulled
> oe-core again (40 commits) - this is what I usually do when things
> fail but I cannot see what commit has mended the issue for case [1].

There was this fix which may have resolved the issue (it mentions svn,
but the fix wasn't specific to that):

http://cgit.openembedded.org/openembedded-core/commit/?id=b32fbfc85b14059f0bfdeeffe2c52f8d3c20f276

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre