* [PATCH v2] util-linux: make blkdiscard a separate package
@ 2017-03-28 22:45 Stefan Agner
2017-03-29 15:41 ` Burton, Ross
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Agner @ 2017-03-28 22:45 UTC (permalink / raw)
To: openembedded-core; +Cc: Stefan Agner
From: Stefan Agner <stefan.agner@toradex.com>
Busybox doesn't provide a similar tool so having it in a
separate package allows to use it in addition to busybox
without having to include all of util-linux.
Before it was part of the top level util-linux package.
Now it is a separate package util-linux-blkdiscard but the
top level package still RRECOMMENDS it so for most users
nothing should change.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
---
meta/recipes-core/util-linux/util-linux.inc | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
index 63302a9..c07417f 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -30,8 +30,8 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfd
util-linux-swaponoff util-linux-losetup util-linux-umount \
util-linux-mount util-linux-readprofile util-linux-uuidd \
util-linux-uuidgen util-linux-lscpu util-linux-fsck.cramfs util-linux-fsck \
- util-linux-blkid util-linux-mkfs util-linux-mcookie util-linux-reset \
- util-linux-lsblk util-linux-mkfs.cramfs util-linux-fstrim \
+ util-linux-blkdiscard util-linux-blkid util-linux-mkfs util-linux-mcookie \
+ util-linux-reset util-linux-lsblk util-linux-mkfs.cramfs util-linux-fstrim \
util-linux-partx util-linux-hwclock util-linux-mountpoint \
util-linux-findfs util-linux-getopt util-linux-sulogin util-linux-prlimit"
PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'pylibmount', 'util-linux-pylibmount', '', d)}"
@@ -112,6 +112,8 @@ FILES_util-linux-blkid = "${base_sbindir}/blkid*"
RCONFLICTS_util-linux-blkid = "e2fsprogs-blkid"
RREPLACES_util-linux-blkid = "e2fsprogs-blkid"
+FILES_util-linux-blkdiscard = "${sbindir}/blkdiscard"
+
# reset calls 'tput'
RDEPENDS_util-linux-reset += "ncurses"
@@ -120,7 +122,7 @@ RDEPENDS_util-linux-runuser += "libpam"
RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin util-linux-lsblk"
RDEPENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'util-linux-runuser', '', d)}"
-RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util-linux-mountpoint util-linux-prlimit"
+RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util-linux-mountpoint util-linux-prlimit util-linux-blkdiscard"
RRECOMMENDS_${PN}_class-native = ""
RRECOMMENDS_${PN}_class-nativesdk = ""
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] util-linux: make blkdiscard a separate package
2017-03-28 22:45 [PATCH v2] util-linux: make blkdiscard a separate package Stefan Agner
@ 2017-03-29 15:41 ` Burton, Ross
2017-03-29 17:42 ` Stefan Agner
0 siblings, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2017-03-29 15:41 UTC (permalink / raw)
To: Stefan Agner; +Cc: Stefan Agner, OE-core
[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]
On 28 March 2017 at 23:45, Stefan Agner <stefan@agner.ch> wrote:
> @@ -30,8 +30,8 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk
> util-linux-cfdisk util-linux-sfd
> util-linux-swaponoff util-linux-losetup util-linux-umount \
> util-linux-mount util-linux-readprofile util-linux-uuidd \
> util-linux-uuidgen util-linux-lscpu util-linux-fsck.cramfs
> util-linux-fsck \
> - util-linux-blkid util-linux-mkfs util-linux-mcookie
> util-linux-reset \
> - util-linux-lsblk util-linux-mkfs.cramfs util-linux-fstrim \
> + util-linux-blkdiscard util-linux-blkid util-linux-mkfs
> util-linux-mcookie \
> + util-linux-reset util-linux-lsblk util-linux-mkfs.cramfs
> util-linux-fstrim \
> util-linux-partx util-linux-hwclock util-linux-mountpoint \
> util-linux-findfs util-linux-getopt util-linux-sulogin
> util-linux-prlimit"
>
We're growing a lot of packages containing a single binary. Would it be
sensible to group them into "file system tools", "process tools", etc?
Ross
[-- Attachment #2: Type: text/html, Size: 1631 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] util-linux: make blkdiscard a separate package
2017-03-29 15:41 ` Burton, Ross
@ 2017-03-29 17:42 ` Stefan Agner
2017-03-30 8:27 ` Jussi Kukkonen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Agner @ 2017-03-29 17:42 UTC (permalink / raw)
To: Burton, Ross; +Cc: Stefan Agner, OE-core
[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]
On 2017-03-29 08:41, Burton, Ross wrote:
> On 28 March 2017 at 23:45, Stefan Agner <stefan@agner.ch> wrote:
>
>> @@ -30,8 +30,8 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfd
>> util-linux-swaponoff util-linux-losetup util-linux-umount \
>> util-linux-mount util-linux-readprofile util-linux-uuidd \
>> util-linux-uuidgen util-linux-lscpu util-linux-fsck.cramfs util-linux-fsck \
>> - util-linux-blkid util-linux-mkfs util-linux-mcookie util-linux-reset \
>> - util-linux-lsblk util-linux-mkfs.cramfs util-linux-fstrim \
>> + util-linux-blkdiscard util-linux-blkid util-linux-mkfs util-linux-mcookie \
>> + util-linux-reset util-linux-lsblk util-linux-mkfs.cramfs util-linux-fstrim \
>> util-linux-partx util-linux-hwclock util-linux-mountpoint \
>> util-linux-findfs util-linux-getopt util-linux-sulogin util-linux-prlimit"
>
> We're growing a lot of packages containing a single binary. Would it be sensible to group them into "file system tools", "process tools", etc?
Not sure if such a high level grouping is helpful. Just because an image
uses one fs utility, does not mean the others are used too. There might
be some potential on a lower level (e.g. util-linux-mkfs.cramfs and
util-linux-fsck.cramfs).
Is having lots of single binary packages an issue? I guess package
management data adds some space overhead? In my case, I build a image
without package metadata, so I guess there is no overhead for the final
image (for the final image).
Best regards,
Stefan
[-- Attachment #2: Type: text/html, Size: 2820 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] util-linux: make blkdiscard a separate package
2017-03-29 17:42 ` Stefan Agner
@ 2017-03-30 8:27 ` Jussi Kukkonen
0 siblings, 0 replies; 4+ messages in thread
From: Jussi Kukkonen @ 2017-03-30 8:27 UTC (permalink / raw)
To: Stefan Agner; +Cc: Stefan Agner, OE-core
[-- Attachment #1: Type: text/plain, Size: 2366 bytes --]
On 29 March 2017 at 20:42, Stefan Agner <stefan@agner.ch> wrote:
> On 2017-03-29 08:41, Burton, Ross wrote:
>
>
> On 28 March 2017 at 23:45, Stefan Agner <stefan@agner.ch> wrote:
>
>> @@ -30,8 +30,8 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk
>> util-linux-cfdisk util-linux-sfd
>> util-linux-swaponoff util-linux-losetup util-linux-umount \
>> util-linux-mount util-linux-readprofile util-linux-uuidd \
>> util-linux-uuidgen util-linux-lscpu util-linux-fsck.cramfs
>> util-linux-fsck \
>> - util-linux-blkid util-linux-mkfs util-linux-mcookie
>> util-linux-reset \
>> - util-linux-lsblk util-linux-mkfs.cramfs util-linux-fstrim \
>> + util-linux-blkdiscard util-linux-blkid util-linux-mkfs
>> util-linux-mcookie \
>> + util-linux-reset util-linux-lsblk util-linux-mkfs.cramfs
>> util-linux-fstrim \
>> util-linux-partx util-linux-hwclock util-linux-mountpoint \
>> util-linux-findfs util-linux-getopt util-linux-sulogin
>> util-linux-prlimit"
>>
>
> We're growing a lot of packages containing a single binary. Would it be
> sensible to group them into "file system tools", "process tools", etc?
>
> Not sure if such a high level grouping is helpful. Just because an
> image uses one fs utility, does not mean the others are used too. There
> might be some potential on a lower level (e.g. util-linux-mkfs.cramfs and
> util-linux-fsck.cramfs).
>
> Is having lots of single binary packages an issue? I guess package
> management data adds some space overhead? In my case, I build a image
> without package metadata, so I guess there is no overhead for the final
> image (for the final image).
>
I have no hard data on this but we are struggling with oe-selftests taking
too long (we're talking 4-10 hour runs and personally I think we should be
running many more tests than we currently do).
The time it takes to boot an image and run the test won't be affected by
this patch, but I'm guessing it does increase the packaging and rootfs
generation time by a little bit. Multiply that by the number of images we
build and add it to all the other "little bits" of time...
Would be nice to have some hard data on this though -- I don't really know
if this is the place to optimize.
Jussi
[-- Attachment #2: Type: text/html, Size: 3496 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-30 8:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 22:45 [PATCH v2] util-linux: make blkdiscard a separate package Stefan Agner
2017-03-29 15:41 ` Burton, Ross
2017-03-29 17:42 ` Stefan Agner
2017-03-30 8:27 ` Jussi Kukkonen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.