[PATCH] sqlite3_3: Update to 3.25.2

[PATCH] sqlite3_3: Update to 3.25.2

[Jens Rehsack]

Update SQLite3 from 3.23.1 to 3.25.2 for UPSERT, window
functions and improved ALTER TABLE support.

For a detailed list of changes since 3.23.1, see
* https://www.sqlite.org/releaselog/3_25_2.html
* https://www.sqlite.org/releaselog/3_24_0.html

Signed-off-by: Jens Rehsack <sno@netbsd.org>
---
 meta/recipes-support/sqlite/sqlite3_3.23.1.bb | 10 ----------
 meta/recipes-support/sqlite/sqlite3_3.25.2.bb | 10 ++++++++++
 2 files changed, 10 insertions(+), 10 deletions(-)
 delete mode 100644 meta/recipes-support/sqlite/sqlite3_3.23.1.bb
 create mode 100644 meta/recipes-support/sqlite/sqlite3_3.25.2.bb

diff --git a/meta/recipes-support/sqlite/sqlite3_3.23.1.bb b/meta/recipes-support/sqlite/sqlite3_3.23.1.bb
deleted file mode 100644
index 3755761d76..0000000000
--- a/meta/recipes-support/sqlite/sqlite3_3.23.1.bb
+++ /dev/null
@@ -1,10 +0,0 @@
-require sqlite3.inc
-
-LICENSE = "PD"
-LIC_FILES_CHKSUM = "file://sqlite3.h;endline=11;md5=786d3dc581eff03f4fd9e4a77ed00c66"
-
-SRC_URI = "\
-  http://www.sqlite.org/2018/sqlite-autoconf-${SQLITE_PV}.tar.gz \
-  "
-SRC_URI[md5sum] = "99a51b40a66872872a91c92f6d0134fa"
-SRC_URI[sha256sum] = "92842b283e5e744eff5da29ed3c69391de7368fccc4d0ee6bf62490ce555ef25"
diff --git a/meta/recipes-support/sqlite/sqlite3_3.25.2.bb b/meta/recipes-support/sqlite/sqlite3_3.25.2.bb
new file mode 100644
index 0000000000..31c9a6f2d2
--- /dev/null
+++ b/meta/recipes-support/sqlite/sqlite3_3.25.2.bb
@@ -0,0 +1,10 @@
+require sqlite3.inc
+
+LICENSE = "PD"
+LIC_FILES_CHKSUM = "file://sqlite3.h;endline=11;md5=786d3dc581eff03f4fd9e4a77ed00c66"
+
+SRC_URI = "\
+  http://www.sqlite.org/2018/sqlite-autoconf-${SQLITE_PV}.tar.gz \
+  "
+SRC_URI[md5sum] = "bfade31d59f58badc51aeaa6ae26a5de"
+SRC_URI[sha256sum] = "da9a1484423d524d3ac793af518cdf870c8255d209e369bd6a193e9f9d0e3181"
-- 
2.17.1

Re: [PATCH] sqlite3_3: Update to 3.25.2

[Richard Purdie]

On Sat, 2018-11-03 at 14:12 +0100, Jens Rehsack wrote:
> Update SQLite3 from 3.23.1 to 3.25.2 for UPSERT, window
> functions and improved ALTER TABLE support.
> 
> For a detailed list of changes since 3.23.1, see
> * https://www.sqlite.org/releaselog/3_25_2.html
> * https://www.sqlite.org/releaselog/3_24_0.html
> 
> Signed-off-by: Jens Rehsack <sno@netbsd.org>
> ---
>  meta/recipes-support/sqlite/sqlite3_3.23.1.bb | 10 ----------
>  meta/recipes-support/sqlite/sqlite3_3.25.2.bb | 10 ++++++++++
>  2 files changed, 10 insertions(+), 10 deletions(-)
>  delete mode 100644 meta/recipes-support/sqlite/sqlite3_3.23.1.bb
>  create mode 100644 meta/recipes-support/sqlite/sqlite3_3.25.2.bb

How was this tested? pseudo-native fails to build with this:

https://autobuilder.yoctoproject.org/typhoon/#/builders/34/builds/161/steps/7/logs/step1b

and many other similar failures.

Cheers,

Richard

Re: [PATCH] sqlite3_3: Update to 3.25.2

[Jens Rehsack]

[-- Attachment #1.1: Type: text/plain, Size: 1356 bytes --]



> Am 05.11.2018 um 12:39 schrieb Richard Purdie <richard.purdie@linuxfoundation.org>:
> 
> On Sat, 2018-11-03 at 14:12 +0100, Jens Rehsack wrote:
>> Update SQLite3 from 3.23.1 to 3.25.2 for UPSERT, window
>> functions and improved ALTER TABLE support.
>> 
>> For a detailed list of changes since 3.23.1, see
>> * https://www.sqlite.org/releaselog/3_25_2.html
>> * https://www.sqlite.org/releaselog/3_24_0.html
>> 
>> Signed-off-by: Jens Rehsack <sno@netbsd.org>
>> ---
>> meta/recipes-support/sqlite/sqlite3_3.23.1.bb | 10 ----------
>> meta/recipes-support/sqlite/sqlite3_3.25.2.bb | 10 ++++++++++
>> 2 files changed, 10 insertions(+), 10 deletions(-)
>> delete mode 100644 meta/recipes-support/sqlite/sqlite3_3.23.1.bb
>> create mode 100644 meta/recipes-support/sqlite/sqlite3_3.25.2.bb
> 
> How was this tested? pseudo-native fails to build with this:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/34/builds/161/steps/7/logs/step1b
> 
> and many other similar failures.


My local test environment fails with lots of other failure due master updates.
So my only test at the very moment was to compile python3-sqlite and dbd-sqlite-perl
and continue fixing other issues before coming to create an image :(

I'll send a v2 as soon as I get around to it ;)

Cheers
--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #1.2: Type: text/html, Size: 3273 bytes --]

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

Re: [PATCH] sqlite3_3: Update to 3.25.2

[Burton, Ross]

Mining the list archive shows that we keep on getting sqlite upgrades
which fail like this.  Maxin reported that it was due to the
full-text-search code enabling itself and failing to build, so one
solution is to explicitly turn it off.

Ross
On Mon, 5 Nov 2018 at 11:39, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Sat, 2018-11-03 at 14:12 +0100, Jens Rehsack wrote:
> > Update SQLite3 from 3.23.1 to 3.25.2 for UPSERT, window
> > functions and improved ALTER TABLE support.
> >
> > For a detailed list of changes since 3.23.1, see
> > * https://www.sqlite.org/releaselog/3_25_2.html
> > * https://www.sqlite.org/releaselog/3_24_0.html
> >
> > Signed-off-by: Jens Rehsack <sno@netbsd.org>
> > ---
> >  meta/recipes-support/sqlite/sqlite3_3.23.1.bb | 10 ----------
> >  meta/recipes-support/sqlite/sqlite3_3.25.2.bb | 10 ++++++++++
> >  2 files changed, 10 insertions(+), 10 deletions(-)
> >  delete mode 100644 meta/recipes-support/sqlite/sqlite3_3.23.1.bb
> >  create mode 100644 meta/recipes-support/sqlite/sqlite3_3.25.2.bb
>
> How was this tested? pseudo-native fails to build with this:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/34/builds/161/steps/7/logs/step1b
>
> and many other similar failures.
>
> Cheers,
>
> Richard
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] sqlite3_3: Update to 3.25.2

[Burton, Ross]

On Mon, 5 Nov 2018 at 11:43, Burton, Ross <ross.burton@intel.com> wrote:
> Mining the list archive shows that we keep on getting sqlite upgrades
> which fail like this.  Maxin reported that it was due to the
> full-text-search code enabling itself and failing to build, so one
> solution is to explicitly turn it off.

Did some digging.

FTS5 is enabled by default, this needs log() from libm.  If enabled,
AC_SEARCH_LIBS is used to find log() and libm.so, and this bonus
dependency that is needed if statically linking is recorded in
sqlite3.pc.  Pseudo then builds, statically links to pseudo, but also
hard-codes the link line instead of using pkgconfig so this -lm isn't
added, resulting in a link failure on upgrade.

So that explains why the autobuilder explodes when this upgrade
happens, but doesn't explain how it builds for everyone who submits
the upgrade...

Ross

Re: [PATCH] sqlite3_3: Update to 3.25.2

[Jens Rehsack]

[-- Attachment #1.1: Type: text/plain, Size: 1470 bytes --]



> Am 05.11.2018 um 17:11 schrieb Burton, Ross <ross.burton@intel.com>:
> 
> On Mon, 5 Nov 2018 at 11:43, Burton, Ross <ross.burton@intel.com> wrote:
>> Mining the list archive shows that we keep on getting sqlite upgrades
>> which fail like this.  Maxin reported that it was due to the
>> full-text-search code enabling itself and failing to build, so one
>> solution is to explicitly turn it off.
> 
> Did some digging.
> 
> FTS5 is enabled by default, this needs log() from libm.  If enabled,
> AC_SEARCH_LIBS is used to find log() and libm.so, and this bonus
> dependency that is needed if statically linking is recorded in
> sqlite3.pc.  Pseudo then builds, statically links to pseudo, but also
> hard-codes the link line instead of using pkgconfig so this -lm isn't
> added, resulting in a link failure on upgrade.
> 
> So that explains why the autobuilder explodes when this upgrade
> happens, but doesn't explain how it builds for everyone who submits
> the upgrade...


Thanks for the analysis. I have some minor quirks with meta-cpan I
have to fix since my last full-build for BBB in Sept 2018 - and my locally
overwritten fstab generator for recovery/app partitions fails nowadays
I have to analyze.

I think at least end of the week I can build target images again, get
more test opportunities and fixup sqlite3 and python3 and submit some
other stuff I found in meantime ;)

Cheers
--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #1.2: Type: text/html, Size: 3177 bytes --]

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

Re: [PATCH] sqlite3_3: Update to 3.25.2

[Burton, Ross]

On Mon, 5 Nov 2018 at 16:11, Burton, Ross <ross.burton@intel.com> wrote:
> On Mon, 5 Nov 2018 at 11:43, Burton, Ross <ross.burton@intel.com> wrote:
> > Mining the list archive shows that we keep on getting sqlite upgrades
> > which fail like this.  Maxin reported that it was due to the
> > full-text-search code enabling itself and failing to build, so one
> > solution is to explicitly turn it off.
>
> Did some digging.
>
> FTS5 is enabled by default, this needs log() from libm.  If enabled,
> AC_SEARCH_LIBS is used to find log() and libm.so, and this bonus
> dependency that is needed if statically linking is recorded in
> sqlite3.pc.  Pseudo then builds, statically links to pseudo, but also
> hard-codes the link line instead of using pkgconfig so this -lm isn't
> added, resulting in a link failure on upgrade.
>
> So that explains why the autobuilder explodes when this upgrade
> happens, but doesn't explain how it builds for everyone who submits
> the upgrade...

This patch I can confirm makes pseudo build:

-PACKAGECONFIG ?= ""
+PACKAGECONFIG ?= "fts5"
 PACKAGECONFIG_class-native = ""

 PACKAGECONFIG[editline] = "--enable-editline,--disable-editline,libedit"
 PACKAGECONFIG[readline] =
"--enable-readline,--disable-readline,readline ncurses"
+PACKAGECONFIG[fts5] = "--enable-fts5,--disable-fts5"

But that's a little ugly.  The alternative is more invasive and would
involve teaching pseudo to use pkgconfig to find sqlite3, but I'm not
convinced we want to add pkg-config-native to the depends on pseudo,
so I'm wondering if the third way is to just make pseudo always link
to libm.so.

Ross

Re: [PATCH] sqlite3_3: Update to 3.25.2

[Jens Rehsack]

[-- Attachment #1: Type: text/plain, Size: 1967 bytes --]



> Am 05.11.2018 um 17:21 schrieb Burton, Ross <ross.burton@intel.com>:
> 
> On Mon, 5 Nov 2018 at 16:11, Burton, Ross <ross.burton@intel.com> wrote:
>> On Mon, 5 Nov 2018 at 11:43, Burton, Ross <ross.burton@intel.com> wrote:
>>> Mining the list archive shows that we keep on getting sqlite upgrades
>>> which fail like this.  Maxin reported that it was due to the
>>> full-text-search code enabling itself and failing to build, so one
>>> solution is to explicitly turn it off.
>> 
>> Did some digging.
>> 
>> FTS5 is enabled by default, this needs log() from libm.  If enabled,
>> AC_SEARCH_LIBS is used to find log() and libm.so, and this bonus
>> dependency that is needed if statically linking is recorded in
>> sqlite3.pc.  Pseudo then builds, statically links to pseudo, but also
>> hard-codes the link line instead of using pkgconfig so this -lm isn't
>> added, resulting in a link failure on upgrade.
>> 
>> So that explains why the autobuilder explodes when this upgrade
>> happens, but doesn't explain how it builds for everyone who submits
>> the upgrade...
> 
> This patch I can confirm makes pseudo build:
> 
> -PACKAGECONFIG ?= ""
> +PACKAGECONFIG ?= "fts5"
> PACKAGECONFIG_class-native = ""
> 
> PACKAGECONFIG[editline] = "--enable-editline,--disable-editline,libedit"
> PACKAGECONFIG[readline] =
> "--enable-readline,--disable-readline,readline ncurses"
> +PACKAGECONFIG[fts5] = "--enable-fts5,--disable-fts5"

Excellent \o/

> But that's a little ugly.  The alternative is more invasive and would
> involve teaching pseudo to use pkgconfig to find sqlite3, but I'm not
> convinced we want to add pkg-config-native to the depends on pseudo,
> so I'm wondering if the third way is to just make pseudo always link
> to libm.so.

I don't find that ugly (maybe because I don't understand enough about pseudo) ;)

Will use the chance to dig a bit into it :D

Cheers
--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 849 bytes --]