[PATCH V3] gcc: Do not use --with-linker-hash-style if LINKER_HASH_STYLE is empty

[PATCH V3] gcc: Do not use --with-linker-hash-style if LINKER_HASH_STYLE is empty

[Khem Raj]

We allow to set LINKER_HASH_STYLE to be empty so this would fail
since --with-linker-hash-style needs an argument and cant be empty

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
Changes in v3:
- Fix typo in gcc option

Changes in v2:
- Use inline if statement instead of old syntax

 meta/recipes-devtools/gcc/gcc-7.3.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gcc/gcc-7.3.inc b/meta/recipes-devtools/gcc/gcc-7.3.inc
index d56d2c5e06..a80926216b 100644
--- a/meta/recipes-devtools/gcc/gcc-7.3.inc
+++ b/meta/recipes-devtools/gcc/gcc-7.3.inc
@@ -100,7 +100,7 @@ EXTRA_OECONF_BASE = "\
     --disable-bootstrap \
     --disable-libmudflap \
     --with-system-zlib \
-    --with-linker-hash-style=${LINKER_HASH_STYLE} \
+    ${@'--with-linker-hash-style=${LINKER_HASH_STYLE}' if '${LINKER_HASH_STYLE}' else ''} \
     --enable-linker-build-id \
     --with-ppl=no \
     --with-cloog=no \
-- 
2.16.2

Re: [PATCH V3] gcc: Do not use --with-linker-hash-style if LINKER_HASH_STYLE is empty

[Andre McCurdy]

On Fri, Mar 16, 2018 at 2:41 PM, Khem Raj <raj.khem@gmail.com> wrote:
> We allow to set LINKER_HASH_STYLE to be empty so this would fail
> since --with-linker-hash-style needs an argument and cant be empty
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> Changes in v3:
> - Fix typo in gcc option
>
> Changes in v2:
> - Use inline if statement instead of old syntax
>
>  meta/recipes-devtools/gcc/gcc-7.3.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-7.3.inc b/meta/recipes-devtools/gcc/gcc-7.3.inc
> index d56d2c5e06..a80926216b 100644
> --- a/meta/recipes-devtools/gcc/gcc-7.3.inc
> +++ b/meta/recipes-devtools/gcc/gcc-7.3.inc
> @@ -100,7 +100,7 @@ EXTRA_OECONF_BASE = "\
>      --disable-bootstrap \
>      --disable-libmudflap \
>      --with-system-zlib \
> -    --with-linker-hash-style=${LINKER_HASH_STYLE} \
> +    ${@'--with-linker-hash-style=${LINKER_HASH_STYLE}' if '${LINKER_HASH_STYLE}' else ''} \

What are the rules about when to use d.getVar('FOO') -vs- when to use
${FOO} in python fragments like this?

>      --enable-linker-build-id \
>      --with-ppl=no \
>      --with-cloog=no \
> --
> 2.16.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH V3] gcc: Do not use --with-linker-hash-style if LINKER_HASH_STYLE is empty

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

On 16 March 2018 at 21:43, Andre McCurdy <armccurdy@gmail.com> wrote:

> On Fri, Mar 16, 2018 at 2:41 PM, Khem Raj <raj.khem@gmail.com> wrote:
> > We allow to set LINKER_HASH_STYLE to be empty so this would fail
> > since --with-linker-hash-style needs an argument and cant be empty
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > Changes in v3:
> > - Fix typo in gcc option
> >
> > Changes in v2:
> > - Use inline if statement instead of old syntax
> >
> >  meta/recipes-devtools/gcc/gcc-7.3.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-devtools/gcc/gcc-7.3.inc
> b/meta/recipes-devtools/gcc/gcc-7.3.inc
> > index d56d2c5e06..a80926216b 100644
> > --- a/meta/recipes-devtools/gcc/gcc-7.3.inc
> > +++ b/meta/recipes-devtools/gcc/gcc-7.3.inc
> > @@ -100,7 +100,7 @@ EXTRA_OECONF_BASE = "\
> >      --disable-bootstrap \
> >      --disable-libmudflap \
> >      --with-system-zlib \
> > -    --with-linker-hash-style=${LINKER_HASH_STYLE} \
> > +    ${@'--with-linker-hash-style=${LINKER_HASH_STYLE}' if
> '${LINKER_HASH_STYLE}' else ''} \
>
> What are the rules about when to use d.getVar('FOO') -vs- when to use
> ${FOO} in python fragments like this?


I just had to test this in another recipe to verify it does what you expect.

${FOO} isn't expanded anymore in python functions, but it does get expanded
inside python expansions.

Ross

[-- Attachment #2: Type: text/html, Size: 2118 bytes --]