* [PATCH v2 0/7] python/python3: add tk support
@ 2018-11-08 6:08 mingli.yu
2018-11-08 6:08 ` [PATCH v2 1/7] python: " mingli.yu
` (7 more replies)
0 siblings, 8 replies; 27+ messages in thread
From: mingli.yu @ 2018-11-08 6:08 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod, openembedded-core
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 1/7] python: add tk support
2018-11-08 6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
@ 2018-11-08 6:08 ` mingli.yu
2018-11-14 9:38 ` [PATCH v3] " mingli.yu
2018-11-08 6:08 ` [PATCH 2/7] python3: " mingli.yu
` (6 subsequent siblings)
7 siblings, 1 reply; 27+ messages in thread
From: mingli.yu @ 2018-11-08 6:08 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
Add support to enable tk via PACKGECONFIG.
before the patch:
# python
Python 2.7.15 (default, Nov 8 2018, 04:53:50)
[GCC 8.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import Tkinter
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib64/python2.7/lib-tk/Tkinter.py", line 39, in <module>
import _tkinter # If this fails your Python may not be configured for Tk
ImportError: No module named _tkinter
>>>
After the patch, if enable tk in PACKGECONFIG, then
# python
Python 2.7.15 (default, Oct 25 2018, 08:12:45)
[GCC 8.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import Tkinter
>>>
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
meta/recipes-devtools/python/python_2.7.15.bb | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/python/python_2.7.15.bb b/meta/recipes-devtools/python/python_2.7.15.bb
index dd969d8..5c4fee0 100644
--- a/meta/recipes-devtools/python/python_2.7.15.bb
+++ b/meta/recipes-devtools/python/python_2.7.15.bb
@@ -21,7 +21,7 @@ SRC_URI += "\
file://setuptweaks.patch \
file://check-if-target-is-64b-not-host.patch \
file://search_db_h_in_inc_dirs_and_avoid_warning.patch \
- file://avoid_warning_about_tkinter.patch \
+ ${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
file://avoid_warning_for_sunos_specific_module.patch \
file://python-2.7.3-remove-bsdb-rpath.patch \
file://run-ptest \
@@ -45,6 +45,7 @@ EXTRA_OECONF += "ac_cv_file__dev_ptmx=yes ac_cv_file__dev_ptc=no"
PACKAGECONFIG ??= "bdb"
PACKAGECONFIG[bdb] = ",,db"
+PACKAGECONFIG[tk] = ",,tk"
do_configure_append() {
rm -f ${S}/Makefile.orig
@@ -204,6 +205,7 @@ python(){
packages = d.getVar('PACKAGES').split()
pn = d.getVar('PN')
+ pkgconfig = d.getVar('PACKAGECONFIG')
newpackages=[]
@@ -219,6 +221,8 @@ python(){
d.setVar('FILES_' + pypackage, '')
for value in python_manifest[key]['files']:
d.appendVar('FILES_' + pypackage, ' ' + value)
+ if "tkinter" in pypackage and "tk" in pkgconfig:
+ d.appendVar('FILES_' + pypackage, ' ' + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter.so")
if include_pycs == '1':
if value.endswith('.py'):
d.appendVar('FILES_' + pypackage, ' ' + value + 'c')
@@ -228,6 +232,8 @@ python(){
if '${PN}' in value:
value=value.split('-')[1]
d.appendVar('RDEPENDS_' + pypackage, ' ' + pn + '-' + value)
+ if "tkinter" in pypackage and "tk" in pkgconfig:
+ d.appendVar('RDEPENDS_' + pypackage, ' ' + 'tk')
d.setVar('SUMMARY_' + pypackage, python_manifest[key]['summary'])
# Prepending so to avoid python-misc getting everything
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 2/7] python3: add tk support
2018-11-08 6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
2018-11-08 6:08 ` [PATCH v2 1/7] python: " mingli.yu
@ 2018-11-08 6:08 ` mingli.yu
2018-11-08 13:49 ` Burton, Ross
2018-11-14 9:36 ` [PATCH v2] " mingli.yu
2018-11-08 6:08 ` [PATCH 3/7] libxt: extend to nativesdk mingli.yu
` (5 subsequent siblings)
7 siblings, 2 replies; 27+ messages in thread
From: mingli.yu @ 2018-11-08 6:08 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
Add support to enable tk via PACKAGECONFIG.
before this patch:
# python3
Python 3.5.6 (default, Nov 8 2018, 04:53:45)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tkinter
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib64/python3.5/tkinter/__init__.py", line 35, in <module>
import _tkinter # If this fails your Python may not be configured for Tk
ImportError: No module named '_tkinter'
>>>
After this patch, if enable tk in PACKAGECONFIG, then
# python3
Python 3.5.6 (default, Nov 8 2018, 03:15:52)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tkinter
>>>
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
meta/recipes-devtools/python/python3_3.5.6.bb | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb b/meta/recipes-devtools/python/python3_3.5.6.bb
index 31f8ead..93a780d 100644
--- a/meta/recipes-devtools/python/python3_3.5.6.bb
+++ b/meta/recipes-devtools/python/python3_3.5.6.bb
@@ -21,7 +21,7 @@ ${DISTRO_SRC_URI} \
SRC_URI += "\
file://03-fix-tkinter-detection.patch \
- file://avoid_warning_about_tkinter.patch \
+ ${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
file://cgi_py.patch \
file://host_include_contamination.patch \
file://python-3.3-multilib.patch \
@@ -82,6 +82,7 @@ PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES', 'qemu-userm
PACKAGECONFIG[readline] = ",,readline"
# Use profile guided optimisation by running PyBench inside qemu-user
PACKAGECONFIG[pgo] = "--enable-optimizations"
+PACKAGECONFIG[tk] = ",,tk"
do_configure_append() {
rm -f ${S}/Makefile.orig
@@ -270,6 +271,7 @@ python(){
packages = d.getVar('PACKAGES').split()
pn = d.getVar('PN')
+ pkgconfig = d.getVar('PACKAGECONFIG')
newpackages=[]
for key in python_manifest:
@@ -284,6 +286,8 @@ python(){
d.setVar('FILES_' + pypackage, '')
for value in python_manifest[key]['files']:
d.appendVar('FILES_' + pypackage, ' ' + value)
+ if "tkinter" in pypackage and "tk" in pkgconfig:
+ d.appendVar('FILES_' + pypackage, ' ' + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so")
# Add cached files
if include_pycs == '1':
@@ -295,6 +299,8 @@ python(){
if '${PN}' in value:
value=value.split('-')[1]
d.appendVar('RDEPENDS_' + pypackage, ' ' + pn + '-' + value)
+ if "tkinter" in pypackage and "tk" in pkgconfig:
+ d.appendVar('RDEPENDS_' + pypackage, ' ' + 'tk')
d.setVar('SUMMARY_' + pypackage, python_manifest[key]['summary'])
# Prepending so to avoid python-misc getting everything
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 3/7] libxt: extend to nativesdk
2018-11-08 6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
2018-11-08 6:08 ` [PATCH v2 1/7] python: " mingli.yu
2018-11-08 6:08 ` [PATCH 2/7] python3: " mingli.yu
@ 2018-11-08 6:08 ` mingli.yu
2018-11-08 6:08 ` [PATCH 4/7] libxft: " mingli.yu
` (4 subsequent siblings)
7 siblings, 0 replies; 27+ messages in thread
From: mingli.yu @ 2018-11-08 6:08 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
After enable tk via PACKAGECONFIG for python3,
there comes below error:
Missing or unbuildable dependency chain was: ['buildtools-tarball', 'nativesdk-python3-pytz', 'nativesdk-python3', 'nativesdk-tk', 'nativesdk-libxt']
Extend libxt to nativesdk to fix this issue.
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
meta/recipes-graphics/xorg-lib/libxt_1.1.5.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/xorg-lib/libxt_1.1.5.bb b/meta/recipes-graphics/xorg-lib/libxt_1.1.5.bb
index f8d94a2..23d9db4 100644
--- a/meta/recipes-graphics/xorg-lib/libxt_1.1.5.bb
+++ b/meta/recipes-graphics/xorg-lib/libxt_1.1.5.bb
@@ -27,7 +27,7 @@ SRC_URI += "file://libxt_fix_for_x32.patch \
file://0001-libXt-util-don-t-link-makestrs-with-target-cflags.patch \
"
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
EXTRA_OECONF += "--disable-xkb"
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 4/7] libxft: extend to nativesdk
2018-11-08 6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
` (2 preceding siblings ...)
2018-11-08 6:08 ` [PATCH 3/7] libxt: extend to nativesdk mingli.yu
@ 2018-11-08 6:08 ` mingli.yu
2018-11-08 6:08 ` [PATCH 5/7] fontconfig: " mingli.yu
` (3 subsequent siblings)
7 siblings, 0 replies; 27+ messages in thread
From: mingli.yu @ 2018-11-08 6:08 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
After enable tk via PACKAGECONFIG for python3,
there comes below error:
Missing or unbuildable dependency chain was: ['buildtools-tarball', 'nativesdk-python3-testtools', 'nativesdk-python3-pbr', 'nativesdk-python3', 'nativesdk-tk', 'nativesdk-xft']
Extend libxft to nativesdk to fix this issue as
PROVIDES = "xft" in libxft recipe.
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
meta/recipes-graphics/xorg-lib/libxft_2.3.2.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/xorg-lib/libxft_2.3.2.bb b/meta/recipes-graphics/xorg-lib/libxft_2.3.2.bb
index b454781..4565ae2 100644
--- a/meta/recipes-graphics/xorg-lib/libxft_2.3.2.bb
+++ b/meta/recipes-graphics/xorg-lib/libxft_2.3.2.bb
@@ -25,7 +25,7 @@ SRC_URI[sha256sum] = "f5a3c824761df351ca91827ac221090943ef28b248573486050de89f4b
XORG_PN = "libXft"
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
python () {
if d.getVar('DEBIAN_NAMES'):
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 5/7] fontconfig: extend to nativesdk
2018-11-08 6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
` (3 preceding siblings ...)
2018-11-08 6:08 ` [PATCH 4/7] libxft: " mingli.yu
@ 2018-11-08 6:08 ` mingli.yu
2018-11-08 6:08 ` [PATCH 6/7] libsm: " mingli.yu
` (2 subsequent siblings)
7 siblings, 0 replies; 27+ messages in thread
From: mingli.yu @ 2018-11-08 6:08 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
After enable tk via PACKAGECONFIG for python3,
there comes below error:
Missing or unbuildable dependency chain was: ['nativesdk-packagegroup-sdk-host', 'nativesdk-opkg', 'nativesdk-libsolv', 'nativesdk-rpm', 'nativesdk-python3', 'nativesdk-tk', 'nativesdk-xft', 'nativesdk-fontconfig']
Extend fontconfig to nativesdk to fix this issue.
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb b/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb
index cec5247..6128d5e 100644
--- a/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb
+++ b/meta/recipes-graphics/fontconfig/fontconfig_2.12.6.bb
@@ -61,4 +61,4 @@ FONTCONFIG_FONT_DIRS ?= "no"
EXTRA_OECONF = " --disable-docs --with-default-fonts=${datadir}/fonts --with-cache-dir=${FONTCONFIG_CACHE_DIR} --with-add-fonts=${FONTCONFIG_FONT_DIRS}"
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 6/7] libsm: extend to nativesdk
2018-11-08 6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
` (4 preceding siblings ...)
2018-11-08 6:08 ` [PATCH 5/7] fontconfig: " mingli.yu
@ 2018-11-08 6:08 ` mingli.yu
2018-11-08 6:08 ` [PATCH 7/7] libice: " mingli.yu
2018-11-08 6:12 ` [PATCH v2 0/7] python/python3: add tk support mingli.yu
7 siblings, 0 replies; 27+ messages in thread
From: mingli.yu @ 2018-11-08 6:08 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
After enable tk via PACKAGECONFIG for python3,
there comes below error:
Missing or unbuildable dependency chain was: ['buildtools-tarball', 'nativesdk-python3-testtools', 'nativesdk-python3-pbr', 'nativesdk-python3', 'nativesdk-tk', 'nativesdk-libxt', 'nativesdk-libsm']
Extend libsm to nativesdk to fix this issue.
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
meta/recipes-graphics/xorg-lib/libsm_1.2.2.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/xorg-lib/libsm_1.2.2.bb b/meta/recipes-graphics/xorg-lib/libsm_1.2.2.bb
index fdc693b..4b76302 100644
--- a/meta/recipes-graphics/xorg-lib/libsm_1.2.2.bb
+++ b/meta/recipes-graphics/xorg-lib/libsm_1.2.2.bb
@@ -22,7 +22,7 @@ PE = "1"
XORG_PN = "libSM"
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
SRC_URI[md5sum] = "499a7773c65aba513609fe651853c5f3"
SRC_URI[sha256sum] = "0baca8c9f5d934450a70896c4ad38d06475521255ca63b717a6510fdb6e287bd"
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 7/7] libice: extend to nativesdk
2018-11-08 6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
` (5 preceding siblings ...)
2018-11-08 6:08 ` [PATCH 6/7] libsm: " mingli.yu
@ 2018-11-08 6:08 ` mingli.yu
2018-11-08 6:12 ` [PATCH v2 0/7] python/python3: add tk support mingli.yu
7 siblings, 0 replies; 27+ messages in thread
From: mingli.yu @ 2018-11-08 6:08 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
After enable tk via PACKAGECONFIG for python3,
there comes below error:
Missing or unbuildable dependency chain was: ['buildtools-tarball', 'nativesdk-python3-git', 'nativesdk-python3-gitdb', 'nativesdk-python3-async', 'nativesdk-python3', 'nativesdk-tk', 'nativesdk-libxt', 'nativesdk-libsm', 'nativesdk-libice']
Extend libice to nativesdk to fix this issue.
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
meta/recipes-graphics/xorg-lib/libice_1.0.9.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/xorg-lib/libice_1.0.9.bb b/meta/recipes-graphics/xorg-lib/libice_1.0.9.bb
index 999434e..c1b1913 100644
--- a/meta/recipes-graphics/xorg-lib/libice_1.0.9.bb
+++ b/meta/recipes-graphics/xorg-lib/libice_1.0.9.bb
@@ -18,7 +18,7 @@ PE = "1"
XORG_PN = "libICE"
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
SRC_URI[md5sum] = "addfb1e897ca8079531669c7c7711726"
SRC_URI[sha256sum] = "8f7032f2c1c64352b5423f6b48a8ebdc339cc63064af34d66a6c9aa79759e202"
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 0/7] python/python3: add tk support
2018-11-08 6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
` (6 preceding siblings ...)
2018-11-08 6:08 ` [PATCH 7/7] libice: " mingli.yu
@ 2018-11-08 6:12 ` mingli.yu
7 siblings, 0 replies; 27+ messages in thread
From: mingli.yu @ 2018-11-08 6:12 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod, openembedded-core
Changed in v2:
1, add support for tk via PACKAGECONFIG, and tk is disabled
by default.
2, add tk support also for python3.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/7] python3: add tk support
2018-11-08 6:08 ` [PATCH 2/7] python3: " mingli.yu
@ 2018-11-08 13:49 ` Burton, Ross
2018-11-09 1:38 ` Yu, Mingli
2018-11-14 9:36 ` [PATCH v2] " mingli.yu
1 sibling, 1 reply; 27+ messages in thread
From: Burton, Ross @ 2018-11-08 13:49 UTC (permalink / raw)
To: Mingli Yu; +Cc: OE-core
On Thu, 8 Nov 2018 at 06:09, <mingli.yu@windriver.com> wrote:
> + if "tkinter" in pypackage and "tk" in pkgconfig:
> + d.appendVar('FILES_' + pypackage, ' ' + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so")
> + if "tkinter" in pypackage and "tk" in pkgconfig:
> + d.appendVar('RDEPENDS_' + pypackage, ' ' + 'tk')
Why is this here and not in the manifest?
Ross
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/7] python3: add tk support
2018-11-08 13:49 ` Burton, Ross
@ 2018-11-09 1:38 ` Yu, Mingli
2018-11-09 13:02 ` Burton, Ross
0 siblings, 1 reply; 27+ messages in thread
From: Yu, Mingli @ 2018-11-09 1:38 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 2018年11月08日 21:49, Burton, Ross wrote:
> On Thu, 8 Nov 2018 at 06:09, <mingli.yu@windriver.com> wrote:
>> + if "tkinter" in pypackage and "tk" in pkgconfig:
>> + d.appendVar('FILES_' + pypackage, ' ' + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so")
>> + if "tkinter" in pypackage and "tk" in pkgconfig:
>> + d.appendVar('RDEPENDS_' + pypackage, ' ' + 'tk')
>
> Why is this here and not in the manifest?
It's because we can optionally enable or disable tk via PACKAGECONFIG,
if add it to manifest then we need to always enable tk which is also the
implement in v1.
Thanks,
Grace
>
> Ross
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/7] python3: add tk support
2018-11-09 1:38 ` Yu, Mingli
@ 2018-11-09 13:02 ` Burton, Ross
2018-11-12 2:28 ` Yu, Mingli
0 siblings, 1 reply; 27+ messages in thread
From: Burton, Ross @ 2018-11-09 13:02 UTC (permalink / raw)
To: Mingli Yu; +Cc: OE-core
On Fri, 9 Nov 2018 at 01:39, Yu, Mingli <mingli.yu@windriver.com> wrote:
> > Why is this here and not in the manifest?
>
> It's because we can optionally enable or disable tk via PACKAGECONFIG,
> if add it to manifest then we need to always enable tk which is also the
> implement in v1.
Are you sure? As I understand it there won't be any errors if the
contents don't exist. And to be honest if there are, then the
manifest tooling should handle that neatly without special-casing.
Ross
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/7] python3: add tk support
2018-11-09 13:02 ` Burton, Ross
@ 2018-11-12 2:28 ` Yu, Mingli
2018-11-12 15:28 ` Alejandro Hernandez
0 siblings, 1 reply; 27+ messages in thread
From: Yu, Mingli @ 2018-11-12 2:28 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 2018年11月09日 21:02, Burton, Ross wrote:
> On Fri, 9 Nov 2018 at 01:39, Yu, Mingli <mingli.yu@windriver.com> wrote:
>>> Why is this here and not in the manifest?
>>
>> It's because we can optionally enable or disable tk via PACKAGECONFIG,
>> if add it to manifest then we need to always enable tk which is also the
>> implement in v1.
>
> Are you sure? As I understand it there won't be any errors if the
> contents don't exist. And to be honest if there are, then the
> manifest tooling should handle that neatly without special-casing.
Hi Ross,
Thanks for your feedback!
I didn't quite understand what you mean. As I know, if we add the the
setting in manifest as below:
diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json
b/meta/recipes-devtools/python/python3/python3-manifest.json
index f922561..09c9199 100644
--- a/meta/recipes-devtools/python/python3/python3-manifest.json
+++ b/meta/recipes-devtools/python/python3/python3-manifest.json
@@ -1056,10 +1056,12 @@
"tkinter": {
"summary": "Python Tcl/Tk bindings",
"rdepends": [
- "core"
+ "core",
+ "tk"
],
"files": [
- "${libdir}/python${PYTHON_MAJMIN}/tkinter"
+ "${libdir}/python${PYTHON_MAJMIN}/tkinter",
+ "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
],
"cached": []
},
There comes below error:
ERROR: Nothing RPROVIDES 'python3-tk' (but
/mybuild/layers/oe-core/meta/recipes-devtools/python/python3_3.5.6.bb
RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'python3-tk' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['python3-tk']
ERROR: Required build target 'python3' has no buildable providers.
Missing or unbuildable dependency chain was: ['python3', 'python3-tk']
That's to say, we still need to add some fix in
meta/recipes-devtools/python/python3_3.5.6.bb. If so, it may be flexible
and clear to directly to make the implement just as what I send in the RR.
Thanks,
>
> Ross
>
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 2/7] python3: add tk support
2018-11-12 2:28 ` Yu, Mingli
@ 2018-11-12 15:28 ` Alejandro Hernandez
2018-11-13 3:03 ` Yu, Mingli
0 siblings, 1 reply; 27+ messages in thread
From: Alejandro Hernandez @ 2018-11-12 15:28 UTC (permalink / raw)
To: Yu, Mingli, Burton, Ross; +Cc: OE-core
Hey Yu,
On 11/11/2018 6:28 PM, Yu, Mingli wrote:
>
>
> On 2018年11月09日 21:02, Burton, Ross wrote:
>> On Fri, 9 Nov 2018 at 01:39, Yu, Mingli <mingli.yu@windriver.com> wrote:
>>>> Why is this here and not in the manifest?
>>>
>>> It's because we can optionally enable or disable tk via PACKAGECONFIG,
>>> if add it to manifest then we need to always enable tk which is also
>>> the
>>> implement in v1.
>>
>> Are you sure? As I understand it there won't be any errors if the
>> contents don't exist. And to be honest if there are, then the
>> manifest tooling should handle that neatly without special-casing.
>
> Hi Ross,
>
> Thanks for your feedback!
>
> I didn't quite understand what you mean. As I know, if we add the the
> setting in manifest as below:
> diff --git
> a/meta/recipes-devtools/python/python3/python3-manifest.json
> b/meta/recipes-devtools/python/python3/python3-manifest.json
> index f922561..09c9199 100644
> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
> @@ -1056,10 +1056,12 @@
> "tkinter": {
> "summary": "Python Tcl/Tk bindings",
> "rdepends": [
> - "core"
> + "core",
> + "tk"
This error is happening because you are trying to add python3-tk on
RDEPENDS, and that package doesn't exist, when you specify "foo" on the
"rdepends" section of the manifest it is translated to ${PN}-foo.
So two things:
1. The manifest can have the _tkinter.*.so on the "files section of
tkinter (please note that this is _tkinter.*.so and not _tkinter*.so,
the wildcard should be after a "." this is to keep a standard which the
tooling can handle more easily.
When the PACKAGECONFIG is enabled, the files for tkinter will be picked
up correctly.
2. You should not manually add "rdepends" to the manifest, the tool
itself should populate those automatically, this is better because we
would avoid this kind of errors.
Please add the package to the manifest, populate the "files" and
"summary" section and then run $ bitbake python3 -c create_manifest to
populate the rdepends section automatically, also keep in mind that you
should run this when the PACKAGECONFIG is enabled for the native package
as well (thats how it will pick up the dependencies).
Cheers,
Alejandro
> ],
> "files": [
> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
> ],
> "cached": []
> },
>
> There comes below error:
> ERROR: Nothing RPROVIDES 'python3-tk' (but
> /mybuild/layers/oe-core/meta/recipes-devtools/python/python3_3.5.6.bb
> RDEPENDS on or otherwise requires it)
> NOTE: Runtime target 'python3-tk' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['python3-tk']
> ERROR: Required build target 'python3' has no buildable providers.
> Missing or unbuildable dependency chain was: ['python3', 'python3-tk']
>
> That's to say, we still need to add some fix in
> meta/recipes-devtools/python/python3_3.5.6.bb. If so, it may be
> flexible and clear to directly to make the implement just as what I
> send in the RR.
>
> Thanks,
>
>>
>> Ross
>>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/7] python3: add tk support
2018-11-12 15:28 ` Alejandro Hernandez
@ 2018-11-13 3:03 ` Yu, Mingli
2018-11-13 8:25 ` Alejandro Hernandez
0 siblings, 1 reply; 27+ messages in thread
From: Yu, Mingli @ 2018-11-13 3:03 UTC (permalink / raw)
To: Alejandro Hernandez, Burton, Ross; +Cc: OE-core
Hi Alejandro,
Many thanks for your comments, please check my comments inline.
On 2018年11月12日 23:28, Alejandro Hernandez wrote:
> Hey Yu,
>
>
> On 11/11/2018 6:28 PM, Yu, Mingli wrote:
>>
>>
>> On 2018年11月09日 21:02, Burton, Ross wrote:
>>> On Fri, 9 Nov 2018 at 01:39, Yu, Mingli <mingli.yu@windriver.com> wrote:
>>>>> Why is this here and not in the manifest?
>>>>
>>>> It's because we can optionally enable or disable tk via PACKAGECONFIG,
>>>> if add it to manifest then we need to always enable tk which is also
>>>> the
>>>> implement in v1.
>>>
>>> Are you sure? As I understand it there won't be any errors if the
>>> contents don't exist. And to be honest if there are, then the
>>> manifest tooling should handle that neatly without special-casing.
>>
>> Hi Ross,
>>
>> Thanks for your feedback!
>>
>> I didn't quite understand what you mean. As I know, if we add the the
>> setting in manifest as below:
>> diff --git
>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>> index f922561..09c9199 100644
>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>> @@ -1056,10 +1056,12 @@
>> "tkinter": {
>> "summary": "Python Tcl/Tk bindings",
>> "rdepends": [
>> - "core"
>> + "core",
>> + "tk"
>
>
> This error is happening because you are trying to add python3-tk on
> RDEPENDS, and that package doesn't exist, when you specify "foo" on the
> "rdepends" section of the manifest it is translated to ${PN}-foo.
Yes, that's why I point out that we need to add extra logic in python3
recipe to make it rdepends on tk after add the logic as below:
diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json
b/meta/recipes-devtools/python/python3/python3-manifest.json
index f922561..09c9199 100644
--- a/meta/recipes-devtools/python/python3/python3-manifest.json
+++ b/meta/recipes-devtools/python/python3/python3-manifest.json
@@ -1056,10 +1056,12 @@
"tkinter": {
"summary": "Python Tcl/Tk bindings",
"rdepends": [
- "core"
+ "core",
+ "tk"
],
"files": [
- "${libdir}/python${PYTHON_MAJMIN}/tkinter"
+ "${libdir}/python${PYTHON_MAJMIN}/tkinter",
+ "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
],
"cached": []
},
>
> So two things:
>
> 1. The manifest can have the _tkinter.*.so on the "files section of
> tkinter (please note that this is _tkinter.*.so and not _tkinter*.so,
> the wildcard should be after a "." this is to keep a standard which the
> tooling can handle more easily.
Got it, thanks!
>
> When the PACKAGECONFIG is enabled, the files for tkinter will be picked
> up correctly.
>
> 2. You should not manually add "rdepends" to the manifest, the tool
> itself should populate those automatically, this is better because we
> would avoid this kind of errors.
>
> Please add the package to the manifest, populate the "files" and
> "summary" section and then run $ bitbake python3 -c create_manifest to
> populate the rdepends section automatically, also keep in mind that you
> should run this when the PACKAGECONFIG is enabled for the native package
> as well (thats how it will pick up the dependencies).
No new package needed to add to manifest, we only need to update the
items for the existed package tkinter and per your suggestion not
manually add "rdepends" to the manifest, so I only add files to manifest
as below in manifest file,
diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json
b/meta/recipes-devtools/python/python3/python3-manifest.json
index f922561..09c9199 100644
--- a/meta/recipes-devtools/python/python3/python3-manifest.json
+++ b/meta/recipes-devtools/python/python3/python3-manifest.json
@@ -1056,10 +1056,12 @@
"tkinter": {
"summary": "Python Tcl/Tk bindings",
"rdepends": [
"core"
],
"files": [
- "${libdir}/python${PYTHON_MAJMIN}/tkinter"
+ "${libdir}/python${PYTHON_MAJMIN}/tkinter",
+ "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
],
"cached": []
},
And also the update the python3 recipe,
diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
b/meta/recipes-devtools/python/python3_3.5.6.bb
index 2a45476..e50e7dc 100644
--- a/meta/recipes-devtools/python/python3_3.5.6.bb
+++ b/meta/recipes-devtools/python/python3_3.5.6.bb
@@ -78,10 +78,11 @@ export CCSHARED = "-fPIC"
# Fix cross compilation of different modules
export CROSSPYTHONPATH =
"${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/:${B}/build/lib.linux-${TARGET_ARCH}-${PYTHON_MAJMIN}:${S}/Lib:${S}/Lib/plat-linux"
-PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
'qemu-usermode', 'pgo', '', d)}"
+PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
'qemu-usermode', 'pgo', '', d)} tk"
PACKAGECONFIG[readline] = ",,readline"
# Use profile guided optimisation by running PyBench inside qemu-user
PACKAGECONFIG[pgo] = "--enable-optimizations"
+PACKAGECONFIG[tk] = ",,tk,tk"
And then I run $ bitbake python3 -c create_manifest, but there is no
change in manifest file.
Thanks,
>
>
> Cheers,
>
> Alejandro
>
>
>> ],
>> "files": [
>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>> ],
>> "cached": []
>> },
>>
>> There comes below error:
>> ERROR: Nothing RPROVIDES 'python3-tk' (but
>> /mybuild/layers/oe-core/meta/recipes-devtools/python/python3_3.5.6.bb
>> RDEPENDS on or otherwise requires it)
>> NOTE: Runtime target 'python3-tk' is unbuildable, removing...
>> Missing or unbuildable dependency chain was: ['python3-tk']
>> ERROR: Required build target 'python3' has no buildable providers.
>> Missing or unbuildable dependency chain was: ['python3', 'python3-tk']
>>
>> That's to say, we still need to add some fix in
>> meta/recipes-devtools/python/python3_3.5.6.bb. If so, it may be
>> flexible and clear to directly to make the implement just as what I
>> send in the RR.
>>
>> Thanks,
>>
>>>
>>> Ross
>>>
>
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 2/7] python3: add tk support
2018-11-13 3:03 ` Yu, Mingli
@ 2018-11-13 8:25 ` Alejandro Hernandez
2018-11-13 9:10 ` Yu, Mingli
0 siblings, 1 reply; 27+ messages in thread
From: Alejandro Hernandez @ 2018-11-13 8:25 UTC (permalink / raw)
To: Yu, Mingli, Alejandro Hernandez, Burton, Ross; +Cc: OE-core
On 11/12/2018 7:03 PM, Yu, Mingli wrote:
> Hi Alejandro,
>
> Many thanks for your comments, please check my comments inline.
>
> On 2018年11月12日 23:28, Alejandro Hernandez wrote:
>> Hey Yu,
>>
>>
>> On 11/11/2018 6:28 PM, Yu, Mingli wrote:
>>>
>>>
>>> On 2018年11月09日 21:02, Burton, Ross wrote:
>>>> On Fri, 9 Nov 2018 at 01:39, Yu, Mingli <mingli.yu@windriver.com>
>>>> wrote:
>>>>>> Why is this here and not in the manifest?
>>>>>
>>>>> It's because we can optionally enable or disable tk via
>>>>> PACKAGECONFIG,
>>>>> if add it to manifest then we need to always enable tk which is also
>>>>> the
>>>>> implement in v1.
>>>>
>>>> Are you sure? As I understand it there won't be any errors if the
>>>> contents don't exist. And to be honest if there are, then the
>>>> manifest tooling should handle that neatly without special-casing.
>>>
>>> Hi Ross,
>>>
>>> Thanks for your feedback!
>>>
>>> I didn't quite understand what you mean. As I know, if we add the the
>>> setting in manifest as below:
>>> diff --git
>>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>>> index f922561..09c9199 100644
>>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>>> @@ -1056,10 +1056,12 @@
>>> "tkinter": {
>>> "summary": "Python Tcl/Tk bindings",
>>> "rdepends": [
>>> - "core"
>>> + "core",
>>> + "tk"
>>
>>
>> This error is happening because you are trying to add python3-tk on
>> RDEPENDS, and that package doesn't exist, when you specify "foo" on the
>> "rdepends" section of the manifest it is translated to ${PN}-foo.
>
> Yes, that's why I point out that we need to add extra logic in python3
> recipe to make it rdepends on tk after add the logic as below:
>
> diff --git
> a/meta/recipes-devtools/python/python3/python3-manifest.json
> b/meta/recipes-devtools/python/python3/python3-manifest.json
> index f922561..09c9199 100644
> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
> @@ -1056,10 +1056,12 @@
> "tkinter": {
> "summary": "Python Tcl/Tk bindings",
> "rdepends": [
> - "core"
> + "core",
> + "tk"
> ],
> "files": [
> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
> ],
> "cached": []
> },
>
>>
>> So two things:
>>
>> 1. The manifest can have the _tkinter.*.so on the "files section of
>> tkinter (please note that this is _tkinter.*.so and not _tkinter*.so,
>> the wildcard should be after a "." this is to keep a standard which the
>> tooling can handle more easily.
>
> Got it, thanks!
>
>>
>> When the PACKAGECONFIG is enabled, the files for tkinter will be picked
>> up correctly.
>>
>> 2. You should not manually add "rdepends" to the manifest, the tool
>> itself should populate those automatically, this is better because we
>> would avoid this kind of errors.
>>
>> Please add the package to the manifest, populate the "files" and
>> "summary" section and then run $ bitbake python3 -c create_manifest to
>> populate the rdepends section automatically, also keep in mind that you
>> should run this when the PACKAGECONFIG is enabled for the native package
>> as well (thats how it will pick up the dependencies).
>
> No new package needed to add to manifest, we only need to update the
> items for the existed package tkinter and per your suggestion not
> manually add "rdepends" to the manifest, so I only add files to
> manifest as below in manifest file,
My mistake I thought you were adding a new package.
Anyway, as a matter of fact, all you need to do is to add the same
PACKAGECONFIG on the python3 native recipe and enable it, once its
enabled you can run the create_manifest task and it should automatically
generate you a new manifest with the required files (clarifying that it
doesnt have to be enabled by default but it has to be enabled on the
native package when the create_manifest task is run), meaning that you
don't actually need to add the _tkinter.*.so file manually to the
manifest, it should be picked up automatically, this is because the
create_manifest tool assumes that the python3 and python3-native
packages are exact copies of each other.
Regarding the extra logic, I also agree with Ross, and I don't
personally like having the extra logic there, either for that package or
for handling each package that would need a PACKAGECONFIG, I think using
RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk',
'tk', '', d)}"
should be enough.
Alejandro
>
> diff --git
> a/meta/recipes-devtools/python/python3/python3-manifest.json
> b/meta/recipes-devtools/python/python3/python3-manifest.json
> index f922561..09c9199 100644
> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
> @@ -1056,10 +1056,12 @@
> "tkinter": {
> "summary": "Python Tcl/Tk bindings",
> "rdepends": [
> "core"
> ],
> "files": [
> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
> ],
> "cached": []
> },
>
> And also the update the python3 recipe,
>
> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
> b/meta/recipes-devtools/python/python3_3.5.6.bb
> index 2a45476..e50e7dc 100644
> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> @@ -78,10 +78,11 @@ export CCSHARED = "-fPIC"
> # Fix cross compilation of different modules
> export CROSSPYTHONPATH =
> "${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/:${B}/build/lib.linux-${TARGET_ARCH}-${PYTHON_MAJMIN}:${S}/Lib:${S}/Lib/plat-linux"
>
> -PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
> 'qemu-usermode', 'pgo', '', d)}"
> +PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
> 'qemu-usermode', 'pgo', '', d)} tk"
> PACKAGECONFIG[readline] = ",,readline"
> # Use profile guided optimisation by running PyBench inside qemu-user
> PACKAGECONFIG[pgo] = "--enable-optimizations"
> +PACKAGECONFIG[tk] = ",,tk,tk"
>
> And then I run $ bitbake python3 -c create_manifest, but there is no
> change in manifest file.
>
> Thanks,
>
>>
>>
>> Cheers,
>>
>> Alejandro
>>
>>
>>> ],
>>> "files": [
>>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>>> ],
>>> "cached": []
>>> },
>>>
>>> There comes below error:
>>> ERROR: Nothing RPROVIDES 'python3-tk' (but
>>> /mybuild/layers/oe-core/meta/recipes-devtools/python/python3_3.5.6.bb
>>> RDEPENDS on or otherwise requires it)
>>> NOTE: Runtime target 'python3-tk' is unbuildable, removing...
>>> Missing or unbuildable dependency chain was: ['python3-tk']
>>> ERROR: Required build target 'python3' has no buildable providers.
>>> Missing or unbuildable dependency chain was: ['python3', 'python3-tk']
>>>
>>> That's to say, we still need to add some fix in
>>> meta/recipes-devtools/python/python3_3.5.6.bb. If so, it may be
>>> flexible and clear to directly to make the implement just as what I
>>> send in the RR.
>>>
>>> Thanks,
>>>
>>>>
>>>> Ross
>>>>
>>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/7] python3: add tk support
2018-11-13 8:25 ` Alejandro Hernandez
@ 2018-11-13 9:10 ` Yu, Mingli
2018-11-13 21:26 ` Alejandro Hernandez
0 siblings, 1 reply; 27+ messages in thread
From: Yu, Mingli @ 2018-11-13 9:10 UTC (permalink / raw)
To: Alejandro Hernandez, Burton, Ross; +Cc: OE-core
On 2018年11月13日 16:25, Alejandro Hernandez wrote:
> On 11/12/2018 7:03 PM, Yu, Mingli wrote:
>> Hi Alejandro,
>>
>> Many thanks for your comments, please check my comments inline.
>>
>> On 2018年11月12日 23:28, Alejandro Hernandez wrote:
>>> Hey Yu,
>>>
>>>
>>> On 11/11/2018 6:28 PM, Yu, Mingli wrote:
>>>>
>>>>
>>>> On 2018年11月09日 21:02, Burton, Ross wrote:
>>>>> On Fri, 9 Nov 2018 at 01:39, Yu, Mingli <mingli.yu@windriver.com>
>>>>> wrote:
>>>>>>> Why is this here and not in the manifest?
>>>>>>
>>>>>> It's because we can optionally enable or disable tk via
>>>>>> PACKAGECONFIG,
>>>>>> if add it to manifest then we need to always enable tk which is also
>>>>>> the
>>>>>> implement in v1.
>>>>>
>>>>> Are you sure? As I understand it there won't be any errors if the
>>>>> contents don't exist. And to be honest if there are, then the
>>>>> manifest tooling should handle that neatly without special-casing.
>>>>
>>>> Hi Ross,
>>>>
>>>> Thanks for your feedback!
>>>>
>>>> I didn't quite understand what you mean. As I know, if we add the the
>>>> setting in manifest as below:
>>>> diff --git
>>>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> index f922561..09c9199 100644
>>>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> @@ -1056,10 +1056,12 @@
>>>> "tkinter": {
>>>> "summary": "Python Tcl/Tk bindings",
>>>> "rdepends": [
>>>> - "core"
>>>> + "core",
>>>> + "tk"
>>>
>>>
>>> This error is happening because you are trying to add python3-tk on
>>> RDEPENDS, and that package doesn't exist, when you specify "foo" on the
>>> "rdepends" section of the manifest it is translated to ${PN}-foo.
>>
>> Yes, that's why I point out that we need to add extra logic in python3
>> recipe to make it rdepends on tk after add the logic as below:
>>
>> diff --git
>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>> index f922561..09c9199 100644
>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>> @@ -1056,10 +1056,12 @@
>> "tkinter": {
>> "summary": "Python Tcl/Tk bindings",
>> "rdepends": [
>> - "core"
>> + "core",
>> + "tk"
>> ],
>> "files": [
>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>> ],
>> "cached": []
>> },
>>
>>>
>>> So two things:
>>>
>>> 1. The manifest can have the _tkinter.*.so on the "files section of
>>> tkinter (please note that this is _tkinter.*.so and not _tkinter*.so,
>>> the wildcard should be after a "." this is to keep a standard which the
>>> tooling can handle more easily.
>>
>> Got it, thanks!
>>
>>>
>>> When the PACKAGECONFIG is enabled, the files for tkinter will be picked
>>> up correctly.
>>>
>>> 2. You should not manually add "rdepends" to the manifest, the tool
>>> itself should populate those automatically, this is better because we
>>> would avoid this kind of errors.
>>>
>>> Please add the package to the manifest, populate the "files" and
>>> "summary" section and then run $ bitbake python3 -c create_manifest to
>>> populate the rdepends section automatically, also keep in mind that you
>>> should run this when the PACKAGECONFIG is enabled for the native package
>>> as well (thats how it will pick up the dependencies).
>>
>> No new package needed to add to manifest, we only need to update the
>> items for the existed package tkinter and per your suggestion not
>> manually add "rdepends" to the manifest, so I only add files to
>> manifest as below in manifest file,
>
>
> My mistake I thought you were adding a new package.
>
> Anyway, as a matter of fact, all you need to do is to add the same
> PACKAGECONFIG on the python3 native recipe and enable it, once its
Many thanks for Alejandro's hints!
I still failed to let the files(_tkinter.*.so) automatically added to
manifest though I run $ bitbake python3 -c create_manifest altogether
with below logic. Could you help to take a look is there anything I miss?
$ git diff
diff --git a/meta/recipes-devtools/python/python3-native_3.5.6.bb
b/meta/recipes-devtools/python/python3-native_3.5.6.bb
index d5953cf..80f9678 100644
--- a/meta/recipes-devtools/python/python3-native_3.5.6.bb
+++ b/meta/recipes-devtools/python/python3-native_3.5.6.bb
@@ -28,6 +28,8 @@
file://0003-bpo-32947-Fixes-for-TLS-1.3-and-OpenSSL-1.1.1-GH-876.patch \
file://0004-bpo-33570-TLS-1.3-ciphers-for-OpenSSL-1.1.1-GH-6976.patch \
file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
"
+PACKAGECONFIG ??= "tkinter"
+PACKAGECONFIG[tkinter] = ",,tk,tk"
EXTRANATIVEPATH += "bzip2-native"
DEPENDS = "openssl-native bzip2-replacement-native zlib-native
readline-native sqlite3-native gdbm-native"
diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
b/meta/recipes-devtools/python/python3_3.5.6.bb
index 2a45476..edc9d18 100644
--- a/meta/recipes-devtools/python/python3_3.5.6.bb
+++ b/meta/recipes-devtools/python/python3_3.5.6.bb
@@ -78,10 +78,11 @@ export CCSHARED = "-fPIC"
# Fix cross compilation of different modules
export CROSSPYTHONPATH =
"${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/:${B}/build/lib.linux-${TARGET_ARCH}-${PYTHON_MAJMIN}:${S}/Lib:${S}/Lib/plat-linux"
-PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
'qemu-usermode', 'pgo', '', d)}"
+PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
'qemu-usermode', 'pgo', '', d)} tkinter"
PACKAGECONFIG[readline] = ",,readline"
# Use profile guided optimisation by running PyBench inside qemu-user
PACKAGECONFIG[pgo] = "--enable-optimizations"
+PACKAGECONFIG[tkinter] = ",,tk,tk"
do_configure_append() {
rm -f ${S}/Makefile.orig
Thanks,
> enabled you can run the create_manifest task and it should automatically
> generate you a new manifest with the required files (clarifying that it
> doesnt have to be enabled by default but it has to be enabled on the
> native package when the create_manifest task is run), meaning that you
> don't actually need to add the _tkinter.*.so file manually to the
> manifest, it should be picked up automatically, this is because the
> create_manifest tool assumes that the python3 and python3-native
> packages are exact copies of each other.
>
> Regarding the extra logic, I also agree with Ross, and I don't
> personally like having the extra logic there, either for that package or
> for handling each package that would need a PACKAGECONFIG, I think using
>
> RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk',
> 'tk', '', d)}"
>
> should be enough.
>
>
> Alejandro
>
>
>>
>> diff --git
>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>> index f922561..09c9199 100644
>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>> @@ -1056,10 +1056,12 @@
>> "tkinter": {
>> "summary": "Python Tcl/Tk bindings",
>> "rdepends": [
>> "core"
>> ],
>> "files": [
>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>> ],
>> "cached": []
>> },
>>
>> And also the update the python3 recipe,
>>
>> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
>> b/meta/recipes-devtools/python/python3_3.5.6.bb
>> index 2a45476..e50e7dc 100644
>> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
>> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
>> @@ -78,10 +78,11 @@ export CCSHARED = "-fPIC"
>> # Fix cross compilation of different modules
>> export CROSSPYTHONPATH =
>> "${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/:${B}/build/lib.linux-${TARGET_ARCH}-${PYTHON_MAJMIN}:${S}/Lib:${S}/Lib/plat-linux"
>>
>>
>> -PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
>> 'qemu-usermode', 'pgo', '', d)}"
>> +PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
>> 'qemu-usermode', 'pgo', '', d)} tk"
>> PACKAGECONFIG[readline] = ",,readline"
>> # Use profile guided optimisation by running PyBench inside qemu-user
>> PACKAGECONFIG[pgo] = "--enable-optimizations"
>> +PACKAGECONFIG[tk] = ",,tk,tk"
>>
>> And then I run $ bitbake python3 -c create_manifest, but there is no
>> change in manifest file.
>>
>> Thanks,
>>
>>>
>>>
>>> Cheers,
>>>
>>> Alejandro
>>>
>>>
>>>> ],
>>>> "files": [
>>>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>>>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>>>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>>>> ],
>>>> "cached": []
>>>> },
>>>>
>>>> There comes below error:
>>>> ERROR: Nothing RPROVIDES 'python3-tk' (but
>>>> /mybuild/layers/oe-core/meta/recipes-devtools/python/python3_3.5.6.bb
>>>> RDEPENDS on or otherwise requires it)
>>>> NOTE: Runtime target 'python3-tk' is unbuildable, removing...
>>>> Missing or unbuildable dependency chain was: ['python3-tk']
>>>> ERROR: Required build target 'python3' has no buildable providers.
>>>> Missing or unbuildable dependency chain was: ['python3', 'python3-tk']
>>>>
>>>> That's to say, we still need to add some fix in
>>>> meta/recipes-devtools/python/python3_3.5.6.bb. If so, it may be
>>>> flexible and clear to directly to make the implement just as what I
>>>> send in the RR.
>>>>
>>>> Thanks,
>>>>
>>>>>
>>>>> Ross
>>>>>
>>>
>
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 2/7] python3: add tk support
2018-11-13 9:10 ` Yu, Mingli
@ 2018-11-13 21:26 ` Alejandro Hernandez
2018-11-14 8:23 ` Yu, Mingli
0 siblings, 1 reply; 27+ messages in thread
From: Alejandro Hernandez @ 2018-11-13 21:26 UTC (permalink / raw)
To: Yu, Mingli, Alejandro Hernandez, Burton, Ross; +Cc: OE-core
On 11/13/2018 1:10 AM, Yu, Mingli wrote:
>
>
> On 2018年11月13日 16:25, Alejandro Hernandez wrote:
>> On 11/12/2018 7:03 PM, Yu, Mingli wrote:
>>> Hi Alejandro,
>>>
>>> Many thanks for your comments, please check my comments inline.
>>>
>>> On 2018年11月12日 23:28, Alejandro Hernandez wrote:
>>>> Hey Yu,
>>>>
>>>>
>>>> On 11/11/2018 6:28 PM, Yu, Mingli wrote:
>>>>>
>>>>>
>>>>> On 2018年11月09日 21:02, Burton, Ross wrote:
>>>>>> On Fri, 9 Nov 2018 at 01:39, Yu, Mingli <mingli.yu@windriver.com>
>>>>>> wrote:
>>>>>>>> Why is this here and not in the manifest?
>>>>>>>
>>>>>>> It's because we can optionally enable or disable tk via
>>>>>>> PACKAGECONFIG,
>>>>>>> if add it to manifest then we need to always enable tk which is
>>>>>>> also
>>>>>>> the
>>>>>>> implement in v1.
>>>>>>
>>>>>> Are you sure? As I understand it there won't be any errors if the
>>>>>> contents don't exist. And to be honest if there are, then the
>>>>>> manifest tooling should handle that neatly without special-casing.
>>>>>
>>>>> Hi Ross,
>>>>>
>>>>> Thanks for your feedback!
>>>>>
>>>>> I didn't quite understand what you mean. As I know, if we add the the
>>>>> setting in manifest as below:
>>>>> diff --git
>>>>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>>>>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>>>>> index f922561..09c9199 100644
>>>>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>>>>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>>>>> @@ -1056,10 +1056,12 @@
>>>>> "tkinter": {
>>>>> "summary": "Python Tcl/Tk bindings",
>>>>> "rdepends": [
>>>>> - "core"
>>>>> + "core",
>>>>> + "tk"
>>>>
>>>>
>>>> This error is happening because you are trying to add python3-tk on
>>>> RDEPENDS, and that package doesn't exist, when you specify "foo" on
>>>> the
>>>> "rdepends" section of the manifest it is translated to ${PN}-foo.
>>>
>>> Yes, that's why I point out that we need to add extra logic in python3
>>> recipe to make it rdepends on tk after add the logic as below:
>>>
>>> diff --git
>>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>>> index f922561..09c9199 100644
>>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>>> @@ -1056,10 +1056,12 @@
>>> "tkinter": {
>>> "summary": "Python Tcl/Tk bindings",
>>> "rdepends": [
>>> - "core"
>>> + "core",
>>> + "tk"
>>> ],
>>> "files": [
>>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>>> ],
>>> "cached": []
>>> },
>>>
>>>>
>>>> So two things:
>>>>
>>>> 1. The manifest can have the _tkinter.*.so on the "files section of
>>>> tkinter (please note that this is _tkinter.*.so and not _tkinter*.so,
>>>> the wildcard should be after a "." this is to keep a standard which
>>>> the
>>>> tooling can handle more easily.
>>>
>>> Got it, thanks!
>>>
>>>>
>>>> When the PACKAGECONFIG is enabled, the files for tkinter will be
>>>> picked
>>>> up correctly.
>>>>
>>>> 2. You should not manually add "rdepends" to the manifest, the tool
>>>> itself should populate those automatically, this is better because we
>>>> would avoid this kind of errors.
>>>>
>>>> Please add the package to the manifest, populate the "files" and
>>>> "summary" section and then run $ bitbake python3 -c create_manifest to
>>>> populate the rdepends section automatically, also keep in mind that
>>>> you
>>>> should run this when the PACKAGECONFIG is enabled for the native
>>>> package
>>>> as well (thats how it will pick up the dependencies).
>>>
>>> No new package needed to add to manifest, we only need to update the
>>> items for the existed package tkinter and per your suggestion not
>>> manually add "rdepends" to the manifest, so I only add files to
>>> manifest as below in manifest file,
>>
>>
>> My mistake I thought you were adding a new package.
>>
>> Anyway, as a matter of fact, all you need to do is to add the same
>> PACKAGECONFIG on the python3 native recipe and enable it, once its
>
> Many thanks for Alejandro's hints!
>
> I still failed to let the files(_tkinter.*.so) automatically added to
> manifest though I run $ bitbake python3 -c create_manifest altogether
> with below logic. Could you help to take a look is there anything I miss?
>
> $ git diff
> diff --git a/meta/recipes-devtools/python/python3-native_3.5.6.bb
> b/meta/recipes-devtools/python/python3-native_3.5.6.bb
> index d5953cf..80f9678 100644
> --- a/meta/recipes-devtools/python/python3-native_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3-native_3.5.6.bb
> @@ -28,6 +28,8 @@
> file://0003-bpo-32947-Fixes-for-TLS-1.3-and-OpenSSL-1.1.1-GH-876.patch \
> file://0004-bpo-33570-TLS-1.3-ciphers-for-OpenSSL-1.1.1-GH-6976.patch \
> file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
> "
> +PACKAGECONFIG ??= "tkinter"
> +PACKAGECONFIG[tkinter] = ",,tk,tk"
Wouldn't you have to DEPEND on tk-native here?
I believe that might be the issue, you can check if the _tkinter.*.so
file is generated from the native build (basically if its not generated,
its impossible for the create_manifest task to pick it up).
$ find python3-native/3.5.6-r1.0/image/ | grep _tkinter.*.so
If you can confirm that it is generated but the create_manifest task
isn't picking it up we can keep debugging, but first lets check if its
there.
Cheers,
Alejandro
>
> EXTRANATIVEPATH += "bzip2-native"
> DEPENDS = "openssl-native bzip2-replacement-native zlib-native
> readline-native sqlite3-native gdbm-native"
> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
> b/meta/recipes-devtools/python/python3_3.5.6.bb
> index 2a45476..edc9d18 100644
> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> @@ -78,10 +78,11 @@ export CCSHARED = "-fPIC"
> # Fix cross compilation of different modules
> export CROSSPYTHONPATH =
> "${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/:${B}/build/lib.linux-${TARGET_ARCH}-${PYTHON_MAJMIN}:${S}/Lib:${S}/Lib/plat-linux"
>
> -PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
> 'qemu-usermode', 'pgo', '', d)}"
> +PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
> 'qemu-usermode', 'pgo', '', d)} tkinter"
> PACKAGECONFIG[readline] = ",,readline"
> # Use profile guided optimisation by running PyBench inside qemu-user
> PACKAGECONFIG[pgo] = "--enable-optimizations"
> +PACKAGECONFIG[tkinter] = ",,tk,tk"
>
> do_configure_append() {
> rm -f ${S}/Makefile.orig
>
>
> Thanks,
>
>> enabled you can run the create_manifest task and it should automatically
>> generate you a new manifest with the required files (clarifying that it
>> doesnt have to be enabled by default but it has to be enabled on the
>> native package when the create_manifest task is run), meaning that you
>> don't actually need to add the _tkinter.*.so file manually to the
>> manifest, it should be picked up automatically, this is because the
>> create_manifest tool assumes that the python3 and python3-native
>> packages are exact copies of each other.
>>
>> Regarding the extra logic, I also agree with Ross, and I don't
>> personally like having the extra logic there, either for that package or
>> for handling each package that would need a PACKAGECONFIG, I think using
>>
>> RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk',
>> 'tk', '', d)}"
>>
>> should be enough.
>>
>>
>> Alejandro
>>
>>
>>>
>>> diff --git
>>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>>> index f922561..09c9199 100644
>>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>>> @@ -1056,10 +1056,12 @@
>>> "tkinter": {
>>> "summary": "Python Tcl/Tk bindings",
>>> "rdepends": [
>>> "core"
>>> ],
>>> "files": [
>>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>>> ],
>>> "cached": []
>>> },
>>>
>>> And also the update the python3 recipe,
>>>
>>> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
>>> b/meta/recipes-devtools/python/python3_3.5.6.bb
>>> index 2a45476..e50e7dc 100644
>>> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
>>> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
>>> @@ -78,10 +78,11 @@ export CCSHARED = "-fPIC"
>>> # Fix cross compilation of different modules
>>> export CROSSPYTHONPATH =
>>> "${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/:${B}/build/lib.linux-${TARGET_ARCH}-${PYTHON_MAJMIN}:${S}/Lib:${S}/Lib/plat-linux"
>>>
>>>
>>>
>>> -PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
>>> 'qemu-usermode', 'pgo', '', d)}"
>>> +PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
>>> 'qemu-usermode', 'pgo', '', d)} tk"
>>> PACKAGECONFIG[readline] = ",,readline"
>>> # Use profile guided optimisation by running PyBench inside qemu-user
>>> PACKAGECONFIG[pgo] = "--enable-optimizations"
>>> +PACKAGECONFIG[tk] = ",,tk,tk"
>>>
>>> And then I run $ bitbake python3 -c create_manifest, but there is no
>>> change in manifest file.
>>>
>>> Thanks,
>>>
>>>>
>>>>
>>>> Cheers,
>>>>
>>>> Alejandro
>>>>
>>>>
>>>>> ],
>>>>> "files": [
>>>>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>>>>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>>>>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>>>>> ],
>>>>> "cached": []
>>>>> },
>>>>>
>>>>> There comes below error:
>>>>> ERROR: Nothing RPROVIDES 'python3-tk' (but
>>>>> /mybuild/layers/oe-core/meta/recipes-devtools/python/python3_3.5.6.bb
>>>>> RDEPENDS on or otherwise requires it)
>>>>> NOTE: Runtime target 'python3-tk' is unbuildable, removing...
>>>>> Missing or unbuildable dependency chain was: ['python3-tk']
>>>>> ERROR: Required build target 'python3' has no buildable providers.
>>>>> Missing or unbuildable dependency chain was: ['python3',
>>>>> 'python3-tk']
>>>>>
>>>>> That's to say, we still need to add some fix in
>>>>> meta/recipes-devtools/python/python3_3.5.6.bb. If so, it may be
>>>>> flexible and clear to directly to make the implement just as what I
>>>>> send in the RR.
>>>>>
>>>>> Thanks,
>>>>>
>>>>>>
>>>>>> Ross
>>>>>>
>>>>
>>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/7] python3: add tk support
2018-11-13 21:26 ` Alejandro Hernandez
@ 2018-11-14 8:23 ` Yu, Mingli
0 siblings, 0 replies; 27+ messages in thread
From: Yu, Mingli @ 2018-11-14 8:23 UTC (permalink / raw)
To: Alejandro Hernandez, Burton, Ross; +Cc: OE-core
On 2018年11月14日 05:26, Alejandro Hernandez wrote:
> On 11/13/2018 1:10 AM, Yu, Mingli wrote:
>>
>>
>> On 2018年11月13日 16:25, Alejandro Hernandez wrote:
>>> On 11/12/2018 7:03 PM, Yu, Mingli wrote:
>>>> Hi Alejandro,
>>>>
>>>> Many thanks for your comments, please check my comments inline.
>>>>
>>>> On 2018年11月12日 23:28, Alejandro Hernandez wrote:
>>>>> Hey Yu,
>>>>>
>>>>>
>>>>> On 11/11/2018 6:28 PM, Yu, Mingli wrote:
>>>>>>
>>>>>>
>>>>>> On 2018年11月09日 21:02, Burton, Ross wrote:
>>>>>>> On Fri, 9 Nov 2018 at 01:39, Yu, Mingli <mingli.yu@windriver.com>
>>>>>>> wrote:
>>>>>>>>> Why is this here and not in the manifest?
>>>>>>>>
>>>>>>>> It's because we can optionally enable or disable tk via
>>>>>>>> PACKAGECONFIG,
>>>>>>>> if add it to manifest then we need to always enable tk which is
>>>>>>>> also
>>>>>>>> the
>>>>>>>> implement in v1.
>>>>>>>
>>>>>>> Are you sure? As I understand it there won't be any errors if the
>>>>>>> contents don't exist. And to be honest if there are, then the
>>>>>>> manifest tooling should handle that neatly without special-casing.
>>>>>>
>>>>>> Hi Ross,
>>>>>>
>>>>>> Thanks for your feedback!
>>>>>>
>>>>>> I didn't quite understand what you mean. As I know, if we add the the
>>>>>> setting in manifest as below:
>>>>>> diff --git
>>>>>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>>>>>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>>>>>> index f922561..09c9199 100644
>>>>>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>>>>>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>>>>>> @@ -1056,10 +1056,12 @@
>>>>>> "tkinter": {
>>>>>> "summary": "Python Tcl/Tk bindings",
>>>>>> "rdepends": [
>>>>>> - "core"
>>>>>> + "core",
>>>>>> + "tk"
>>>>>
>>>>>
>>>>> This error is happening because you are trying to add python3-tk on
>>>>> RDEPENDS, and that package doesn't exist, when you specify "foo" on
>>>>> the
>>>>> "rdepends" section of the manifest it is translated to ${PN}-foo.
>>>>
>>>> Yes, that's why I point out that we need to add extra logic in python3
>>>> recipe to make it rdepends on tk after add the logic as below:
>>>>
>>>> diff --git
>>>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> index f922561..09c9199 100644
>>>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> @@ -1056,10 +1056,12 @@
>>>> "tkinter": {
>>>> "summary": "Python Tcl/Tk bindings",
>>>> "rdepends": [
>>>> - "core"
>>>> + "core",
>>>> + "tk"
>>>> ],
>>>> "files": [
>>>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>>>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>>>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>>>> ],
>>>> "cached": []
>>>> },
>>>>
>>>>>
>>>>> So two things:
>>>>>
>>>>> 1. The manifest can have the _tkinter.*.so on the "files section of
>>>>> tkinter (please note that this is _tkinter.*.so and not _tkinter*.so,
>>>>> the wildcard should be after a "." this is to keep a standard which
>>>>> the
>>>>> tooling can handle more easily.
>>>>
>>>> Got it, thanks!
>>>>
>>>>>
>>>>> When the PACKAGECONFIG is enabled, the files for tkinter will be
>>>>> picked
>>>>> up correctly.
>>>>>
>>>>> 2. You should not manually add "rdepends" to the manifest, the tool
>>>>> itself should populate those automatically, this is better because we
>>>>> would avoid this kind of errors.
>>>>>
>>>>> Please add the package to the manifest, populate the "files" and
>>>>> "summary" section and then run $ bitbake python3 -c create_manifest to
>>>>> populate the rdepends section automatically, also keep in mind that
>>>>> you
>>>>> should run this when the PACKAGECONFIG is enabled for the native
>>>>> package
>>>>> as well (thats how it will pick up the dependencies).
>>>>
>>>> No new package needed to add to manifest, we only need to update the
>>>> items for the existed package tkinter and per your suggestion not
>>>> manually add "rdepends" to the manifest, so I only add files to
>>>> manifest as below in manifest file,
>>>
>>>
>>> My mistake I thought you were adding a new package.
>>>
>>> Anyway, as a matter of fact, all you need to do is to add the same
>>> PACKAGECONFIG on the python3 native recipe and enable it, once its
>>
>> Many thanks for Alejandro's hints!
>>
>> I still failed to let the files(_tkinter.*.so) automatically added to
>> manifest though I run $ bitbake python3 -c create_manifest altogether
>> with below logic. Could you help to take a look is there anything I miss?
>>
>> $ git diff
>> diff --git a/meta/recipes-devtools/python/python3-native_3.5.6.bb
>> b/meta/recipes-devtools/python/python3-native_3.5.6.bb
>> index d5953cf..80f9678 100644
>> --- a/meta/recipes-devtools/python/python3-native_3.5.6.bb
>> +++ b/meta/recipes-devtools/python/python3-native_3.5.6.bb
>> @@ -28,6 +28,8 @@
>> file://0003-bpo-32947-Fixes-for-TLS-1.3-and-OpenSSL-1.1.1-GH-876.patch \
>> file://0004-bpo-33570-TLS-1.3-ciphers-for-OpenSSL-1.1.1-GH-6976.patch \
>> file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
>> "
>> +PACKAGECONFIG ??= "tkinter"
>> +PACKAGECONFIG[tkinter] = ",,tk,tk"
>
> Wouldn't you have to DEPEND on tk-native here?
Yes, it should be tk-native.
Thanks very much for your guide!
I finally succeeded to let _tkinter.*.so automatically added to manifest.
I run $ bitbake python3 -c create_manifest altogether with below logic:
$ git diff
diff --git a/meta/recipes-devtools/python/python3-native_3.5.6.bb
b/meta/recipes-devtools/python/python3-native_3.5.6.bb
index d5953cf..71bee6f 100644
--- a/meta/recipes-devtools/python/python3-native_3.5.6.bb
+++ b/meta/recipes-devtools/python/python3-native_3.5.6.bb
@@ -12,7 +12,7 @@ file://130-readline-setup.patch \
file://150-fix-setupterm.patch \
file://python-3.3-multilib.patch \
file://03-fix-tkinter-detection.patch \
-file://avoid_warning_about_tkinter.patch \
+${@bb.utils.contains('PACKAGECONFIG', 'tk', '',
'file://avoid_warning_about_tkinter.patch', d)} \
file://0001-h2py-Fix-issue-13032-where-it-fails-with-UnicodeDeco.patch \
file://sysroot-include-headers.patch \
file://unixccompiler.patch \
@@ -28,6 +28,8 @@
file://0003-bpo-32947-Fixes-for-TLS-1.3-and-OpenSSL-1.1.1-GH-876.patch \
file://0004-bpo-33570-TLS-1.3-ciphers-for-OpenSSL-1.1.1-GH-6976.patch \
file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
"
+PACKAGECONFIG ??= "tk"
+PACKAGECONFIG[tk] = ",,tk-native"
EXTRANATIVEPATH += "bzip2-native"
DEPENDS = "openssl-native bzip2-replacement-native zlib-native
readline-native sqlite3-native gdbm-native"
I will resend V3 for python tkinter support.
Thanks,
>
>
> I believe that might be the issue, you can check if the _tkinter.*.so
> file is generated from the native build (basically if its not generated,
> its impossible for the create_manifest task to pick it up).
>
> $ find python3-native/3.5.6-r1.0/image/ | grep _tkinter.*.so
>
> If you can confirm that it is generated but the create_manifest task
> isn't picking it up we can keep debugging, but first lets check if its
> there.
>
>
> Cheers,
>
> Alejandro
>
>
>>
>> EXTRANATIVEPATH += "bzip2-native"
>> DEPENDS = "openssl-native bzip2-replacement-native zlib-native
>> readline-native sqlite3-native gdbm-native"
>> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
>> b/meta/recipes-devtools/python/python3_3.5.6.bb
>> index 2a45476..edc9d18 100644
>> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
>> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
>> @@ -78,10 +78,11 @@ export CCSHARED = "-fPIC"
>> # Fix cross compilation of different modules
>> export CROSSPYTHONPATH =
>> "${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/:${B}/build/lib.linux-${TARGET_ARCH}-${PYTHON_MAJMIN}:${S}/Lib:${S}/Lib/plat-linux"
>>
>>
>> -PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
>> 'qemu-usermode', 'pgo', '', d)}"
>> +PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
>> 'qemu-usermode', 'pgo', '', d)} tkinter"
>> PACKAGECONFIG[readline] = ",,readline"
>> # Use profile guided optimisation by running PyBench inside qemu-user
>> PACKAGECONFIG[pgo] = "--enable-optimizations"
>> +PACKAGECONFIG[tkinter] = ",,tk,tk"
>>
>> do_configure_append() {
>> rm -f ${S}/Makefile.orig
>>
>>
>> Thanks,
>
>
>>
>>> enabled you can run the create_manifest task and it should automatically
>>> generate you a new manifest with the required files (clarifying that it
>>> doesnt have to be enabled by default but it has to be enabled on the
>>> native package when the create_manifest task is run), meaning that you
>>> don't actually need to add the _tkinter.*.so file manually to the
>>> manifest, it should be picked up automatically, this is because the
>>> create_manifest tool assumes that the python3 and python3-native
>>> packages are exact copies of each other.
>>>
>>> Regarding the extra logic, I also agree with Ross, and I don't
>>> personally like having the extra logic there, either for that package or
>>> for handling each package that would need a PACKAGECONFIG, I think using
>>>
>>> RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk',
>>> 'tk', '', d)}"
>>>
>>> should be enough.
>>>
>>>
>>> Alejandro
>>>
>>>
>>>>
>>>> diff --git
>>>> a/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> b/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> index f922561..09c9199 100644
>>>> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
>>>> @@ -1056,10 +1056,12 @@
>>>> "tkinter": {
>>>> "summary": "Python Tcl/Tk bindings",
>>>> "rdepends": [
>>>> "core"
>>>> ],
>>>> "files": [
>>>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>>>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>>>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>>>> ],
>>>> "cached": []
>>>> },
>>>>
>>>> And also the update the python3 recipe,
>>>>
>>>> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
>>>> b/meta/recipes-devtools/python/python3_3.5.6.bb
>>>> index 2a45476..e50e7dc 100644
>>>> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
>>>> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
>>>> @@ -78,10 +78,11 @@ export CCSHARED = "-fPIC"
>>>> # Fix cross compilation of different modules
>>>> export CROSSPYTHONPATH =
>>>> "${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/:${B}/build/lib.linux-${TARGET_ARCH}-${PYTHON_MAJMIN}:${S}/Lib:${S}/Lib/plat-linux"
>>>>
>>>>
>>>>
>>>> -PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
>>>> 'qemu-usermode', 'pgo', '', d)}"
>>>> +PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES',
>>>> 'qemu-usermode', 'pgo', '', d)} tk"
>>>> PACKAGECONFIG[readline] = ",,readline"
>>>> # Use profile guided optimisation by running PyBench inside qemu-user
>>>> PACKAGECONFIG[pgo] = "--enable-optimizations"
>>>> +PACKAGECONFIG[tk] = ",,tk,tk"
>>>>
>>>> And then I run $ bitbake python3 -c create_manifest, but there is no
>>>> change in manifest file.
>>>>
>>>> Thanks,
>>>>
>>>>>
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Alejandro
>>>>>
>>>>>
>>>>>> ],
>>>>>> "files": [
>>>>>> - "${libdir}/python${PYTHON_MAJMIN}/tkinter"
>>>>>> + "${libdir}/python${PYTHON_MAJMIN}/tkinter",
>>>>>> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so"
>>>>>> ],
>>>>>> "cached": []
>>>>>> },
>>>>>>
>>>>>> There comes below error:
>>>>>> ERROR: Nothing RPROVIDES 'python3-tk' (but
>>>>>> /mybuild/layers/oe-core/meta/recipes-devtools/python/python3_3.5.6.bb
>>>>>> RDEPENDS on or otherwise requires it)
>>>>>> NOTE: Runtime target 'python3-tk' is unbuildable, removing...
>>>>>> Missing or unbuildable dependency chain was: ['python3-tk']
>>>>>> ERROR: Required build target 'python3' has no buildable providers.
>>>>>> Missing or unbuildable dependency chain was: ['python3',
>>>>>> 'python3-tk']
>>>>>>
>>>>>> That's to say, we still need to add some fix in
>>>>>> meta/recipes-devtools/python/python3_3.5.6.bb. If so, it may be
>>>>>> flexible and clear to directly to make the implement just as what I
>>>>>> send in the RR.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>>>
>>>>>>> Ross
>>>>>>>
>>>>>
>>>
>
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2] python3: add tk support
2018-11-08 6:08 ` [PATCH 2/7] python3: " mingli.yu
2018-11-08 13:49 ` Burton, Ross
@ 2018-11-14 9:36 ` mingli.yu
2018-11-19 1:32 ` Yu, Mingli
2018-11-23 1:29 ` Yu, Mingli
1 sibling, 2 replies; 27+ messages in thread
From: mingli.yu @ 2018-11-14 9:36 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod,
alejandro.enedino.hernandez-samaniego, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
Add support to enable tk via PACKAGECONFIG.
before this patch:
# python3
Python 3.5.6 (default, Nov 8 2018, 04:53:45)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tkinter
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib64/python3.5/tkinter/__init__.py", line 35, in <module>
import _tkinter # If this fails your Python may not be configured for Tk
ImportError: No module named '_tkinter'
>>>
After this patch, if enable tk in PACKAGECONFIG, then
# python3
Python 3.5.6 (default, Nov 8 2018, 03:15:52)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tkinter
>>>
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
meta/recipes-devtools/python/python3-native_3.5.6.bb | 3 ++-
meta/recipes-devtools/python/python3/python3-manifest.json | 1 +
meta/recipes-devtools/python/python3_3.5.6.bb | 5 +++--
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-devtools/python/python3-native_3.5.6.bb b/meta/recipes-devtools/python/python3-native_3.5.6.bb
index d5953cf..1e98c03 100644
--- a/meta/recipes-devtools/python/python3-native_3.5.6.bb
+++ b/meta/recipes-devtools/python/python3-native_3.5.6.bb
@@ -12,7 +12,7 @@ file://130-readline-setup.patch \
file://150-fix-setupterm.patch \
file://python-3.3-multilib.patch \
file://03-fix-tkinter-detection.patch \
-file://avoid_warning_about_tkinter.patch \
+${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
file://0001-h2py-Fix-issue-13032-where-it-fails-with-UnicodeDeco.patch \
file://sysroot-include-headers.patch \
file://unixccompiler.patch \
@@ -28,6 +28,7 @@ file://0003-bpo-32947-Fixes-for-TLS-1.3-and-OpenSSL-1.1.1-GH-876.patch \
file://0004-bpo-33570-TLS-1.3-ciphers-for-OpenSSL-1.1.1-GH-6976.patch \
file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
"
+PACKAGECONFIG[tk] = ",,tk-native"
EXTRANATIVEPATH += "bzip2-native"
DEPENDS = "openssl-native bzip2-replacement-native zlib-native readline-native sqlite3-native gdbm-native"
diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json b/meta/recipes-devtools/python/python3/python3-manifest.json
index 5329bf7..617256a 100644
--- a/meta/recipes-devtools/python/python3/python3-manifest.json
+++ b/meta/recipes-devtools/python/python3/python3-manifest.json
@@ -1060,6 +1060,7 @@
"core"
],
"files": [
+ "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter.*.so",
"${libdir}/python${PYTHON_MAJMIN}/tkinter"
],
"cached": []
diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb b/meta/recipes-devtools/python/python3_3.5.6.bb
index 31f8ead..5c80421 100644
--- a/meta/recipes-devtools/python/python3_3.5.6.bb
+++ b/meta/recipes-devtools/python/python3_3.5.6.bb
@@ -21,7 +21,7 @@ ${DISTRO_SRC_URI} \
SRC_URI += "\
file://03-fix-tkinter-detection.patch \
- file://avoid_warning_about_tkinter.patch \
+ ${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
file://cgi_py.patch \
file://host_include_contamination.patch \
file://python-3.3-multilib.patch \
@@ -82,6 +82,7 @@ PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES', 'qemu-userm
PACKAGECONFIG[readline] = ",,readline"
# Use profile guided optimisation by running PyBench inside qemu-user
PACKAGECONFIG[pgo] = "--enable-optimizations"
+PACKAGECONFIG[tk] = ",,tk"
do_configure_append() {
rm -f ${S}/Makefile.orig
@@ -246,7 +247,7 @@ PACKAGES += "${PN}-man"
FILES_${PN}-man = "${datadir}/man"
RDEPENDS_${PN}-ptest = "${PN}-modules ${PN}-tests unzip bzip2"
-
+RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', 'tk', '', d)}"
RDEPENDS_${PN}-dev = ""
BBCLASSEXTEND = "nativesdk"
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v3] python: add tk support
2018-11-08 6:08 ` [PATCH v2 1/7] python: " mingli.yu
@ 2018-11-14 9:38 ` mingli.yu
2018-11-19 1:31 ` Yu, Mingli
2018-11-23 1:30 ` Yu, Mingli
0 siblings, 2 replies; 27+ messages in thread
From: mingli.yu @ 2018-11-14 9:38 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod,
alejandro.enedino.hernandez-samaniego, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
Add support to enable tk via PACKGECONFIG.
before the patch:
# python
Python 2.7.15 (default, Nov 8 2018, 04:53:50)
[GCC 8.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import Tkinter
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib64/python2.7/lib-tk/Tkinter.py", line 39, in <module>
import _tkinter # If this fails your Python may not be configured for Tk
ImportError: No module named _tkinter
>>>
After the patch, if enable tk in PACKGECONFIG, then
# python
Python 2.7.15 (default, Oct 25 2018, 08:12:45)
[GCC 8.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import Tkinter
>>>
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
meta/recipes-devtools/python/python/python2-manifest.json | 3 ++-
meta/recipes-devtools/python/python_2.7.15.bb | 5 +++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-devtools/python/python/python2-manifest.json b/meta/recipes-devtools/python/python/python2-manifest.json
index 260fa6f..a9f3924 100644
--- a/meta/recipes-devtools/python/python/python2-manifest.json
+++ b/meta/recipes-devtools/python/python/python2-manifest.json
@@ -966,6 +966,7 @@
"core"
],
"files": [
+ "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter.so",
"${libdir}/python2.7/lib-tk"
]
},
@@ -1043,4 +1044,4 @@
"${libdir}/python2.7/lib-dynload/zlib.so"
]
}
-}
\ No newline at end of file
+}
diff --git a/meta/recipes-devtools/python/python_2.7.15.bb b/meta/recipes-devtools/python/python_2.7.15.bb
index dd969d8..6a60aa7 100644
--- a/meta/recipes-devtools/python/python_2.7.15.bb
+++ b/meta/recipes-devtools/python/python_2.7.15.bb
@@ -21,7 +21,7 @@ SRC_URI += "\
file://setuptweaks.patch \
file://check-if-target-is-64b-not-host.patch \
file://search_db_h_in_inc_dirs_and_avoid_warning.patch \
- file://avoid_warning_about_tkinter.patch \
+ ${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
file://avoid_warning_for_sunos_specific_module.patch \
file://python-2.7.3-remove-bsdb-rpath.patch \
file://run-ptest \
@@ -45,6 +45,7 @@ EXTRA_OECONF += "ac_cv_file__dev_ptmx=yes ac_cv_file__dev_ptc=no"
PACKAGECONFIG ??= "bdb"
PACKAGECONFIG[bdb] = ",,db"
+PACKAGECONFIG[tk] = ",,tk"
do_configure_append() {
rm -f ${S}/Makefile.orig
@@ -172,7 +173,7 @@ RDEPENDS_${PN}-modules += "${PN}-misc"
# ptest
RDEPENDS_${PN}-ptest = "${PN}-modules ${PN}-tests unzip"
-
+RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', 'tk', '', d)}"
# catch manpage
PACKAGES += "${PN}-man"
FILES_${PN}-man = "${datadir}/man"
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v3] python: add tk support
2018-11-14 9:38 ` [PATCH v3] " mingli.yu
@ 2018-11-19 1:31 ` Yu, Mingli
2018-11-23 1:30 ` Yu, Mingli
1 sibling, 0 replies; 27+ messages in thread
From: Yu, Mingli @ 2018-11-19 1:31 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod,
alejandro.enedino.hernandez-samaniego, openembedded-core
Ping.
Thanks,
On 2018年11月14日 17:38, mingli.yu@windriver.com wrote:
> From: Mingli Yu <Mingli.Yu@windriver.com>
>
> Add support to enable tk via PACKGECONFIG.
> before the patch:
> # python
> Python 2.7.15 (default, Nov 8 2018, 04:53:50)
> [GCC 8.2.0] on linux2
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import Tkinter
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> File "/usr/lib64/python2.7/lib-tk/Tkinter.py", line 39, in <module>
> import _tkinter # If this fails your Python may not be configured for Tk
> ImportError: No module named _tkinter
> >>>
>
> After the patch, if enable tk in PACKGECONFIG, then
> # python
> Python 2.7.15 (default, Oct 25 2018, 08:12:45)
> [GCC 8.2.0] on linux2
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import Tkinter
> >>>
>
> Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
> ---
> meta/recipes-devtools/python/python/python2-manifest.json | 3 ++-
> meta/recipes-devtools/python/python_2.7.15.bb | 5 +++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-devtools/python/python/python2-manifest.json b/meta/recipes-devtools/python/python/python2-manifest.json
> index 260fa6f..a9f3924 100644
> --- a/meta/recipes-devtools/python/python/python2-manifest.json
> +++ b/meta/recipes-devtools/python/python/python2-manifest.json
> @@ -966,6 +966,7 @@
> "core"
> ],
> "files": [
> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter.so",
> "${libdir}/python2.7/lib-tk"
> ]
> },
> @@ -1043,4 +1044,4 @@
> "${libdir}/python2.7/lib-dynload/zlib.so"
> ]
> }
> -}
> \ No newline at end of file
> +}
> diff --git a/meta/recipes-devtools/python/python_2.7.15.bb b/meta/recipes-devtools/python/python_2.7.15.bb
> index dd969d8..6a60aa7 100644
> --- a/meta/recipes-devtools/python/python_2.7.15.bb
> +++ b/meta/recipes-devtools/python/python_2.7.15.bb
> @@ -21,7 +21,7 @@ SRC_URI += "\
> file://setuptweaks.patch \
> file://check-if-target-is-64b-not-host.patch \
> file://search_db_h_in_inc_dirs_and_avoid_warning.patch \
> - file://avoid_warning_about_tkinter.patch \
> + ${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
> file://avoid_warning_for_sunos_specific_module.patch \
> file://python-2.7.3-remove-bsdb-rpath.patch \
> file://run-ptest \
> @@ -45,6 +45,7 @@ EXTRA_OECONF += "ac_cv_file__dev_ptmx=yes ac_cv_file__dev_ptc=no"
>
> PACKAGECONFIG ??= "bdb"
> PACKAGECONFIG[bdb] = ",,db"
> +PACKAGECONFIG[tk] = ",,tk"
>
> do_configure_append() {
> rm -f ${S}/Makefile.orig
> @@ -172,7 +173,7 @@ RDEPENDS_${PN}-modules += "${PN}-misc"
>
> # ptest
> RDEPENDS_${PN}-ptest = "${PN}-modules ${PN}-tests unzip"
> -
> +RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', 'tk', '', d)}"
> # catch manpage
> PACKAGES += "${PN}-man"
> FILES_${PN}-man = "${datadir}/man"
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2] python3: add tk support
2018-11-14 9:36 ` [PATCH v2] " mingli.yu
@ 2018-11-19 1:32 ` Yu, Mingli
2018-11-23 1:29 ` Yu, Mingli
1 sibling, 0 replies; 27+ messages in thread
From: Yu, Mingli @ 2018-11-19 1:32 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod,
alejandro.enedino.hernandez-samaniego, openembedded-core
Ping.
Thanks,
On 2018年11月14日 17:36, mingli.yu@windriver.com wrote:
> From: Mingli Yu <Mingli.Yu@windriver.com>
>
> Add support to enable tk via PACKAGECONFIG.
> before this patch:
> # python3
> Python 3.5.6 (default, Nov 8 2018, 04:53:45)
> [GCC 8.2.0] on linux
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import tkinter
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> File "/usr/lib64/python3.5/tkinter/__init__.py", line 35, in <module>
> import _tkinter # If this fails your Python may not be configured for Tk
> ImportError: No module named '_tkinter'
> >>>
>
> After this patch, if enable tk in PACKAGECONFIG, then
> # python3
> Python 3.5.6 (default, Nov 8 2018, 03:15:52)
> [GCC 8.2.0] on linux
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import tkinter
> >>>
>
> Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
> ---
> meta/recipes-devtools/python/python3-native_3.5.6.bb | 3 ++-
> meta/recipes-devtools/python/python3/python3-manifest.json | 1 +
> meta/recipes-devtools/python/python3_3.5.6.bb | 5 +++--
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-devtools/python/python3-native_3.5.6.bb b/meta/recipes-devtools/python/python3-native_3.5.6.bb
> index d5953cf..1e98c03 100644
> --- a/meta/recipes-devtools/python/python3-native_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3-native_3.5.6.bb
> @@ -12,7 +12,7 @@ file://130-readline-setup.patch \
> file://150-fix-setupterm.patch \
> file://python-3.3-multilib.patch \
> file://03-fix-tkinter-detection.patch \
> -file://avoid_warning_about_tkinter.patch \
> +${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
> file://0001-h2py-Fix-issue-13032-where-it-fails-with-UnicodeDeco.patch \
> file://sysroot-include-headers.patch \
> file://unixccompiler.patch \
> @@ -28,6 +28,7 @@ file://0003-bpo-32947-Fixes-for-TLS-1.3-and-OpenSSL-1.1.1-GH-876.patch \
> file://0004-bpo-33570-TLS-1.3-ciphers-for-OpenSSL-1.1.1-GH-6976.patch \
> file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
> "
> +PACKAGECONFIG[tk] = ",,tk-native"
>
> EXTRANATIVEPATH += "bzip2-native"
> DEPENDS = "openssl-native bzip2-replacement-native zlib-native readline-native sqlite3-native gdbm-native"
> diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json b/meta/recipes-devtools/python/python3/python3-manifest.json
> index 5329bf7..617256a 100644
> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
> @@ -1060,6 +1060,7 @@
> "core"
> ],
> "files": [
> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter.*.so",
> "${libdir}/python${PYTHON_MAJMIN}/tkinter"
> ],
> "cached": []
> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb b/meta/recipes-devtools/python/python3_3.5.6.bb
> index 31f8ead..5c80421 100644
> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> @@ -21,7 +21,7 @@ ${DISTRO_SRC_URI} \
>
> SRC_URI += "\
> file://03-fix-tkinter-detection.patch \
> - file://avoid_warning_about_tkinter.patch \
> + ${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
> file://cgi_py.patch \
> file://host_include_contamination.patch \
> file://python-3.3-multilib.patch \
> @@ -82,6 +82,7 @@ PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES', 'qemu-userm
> PACKAGECONFIG[readline] = ",,readline"
> # Use profile guided optimisation by running PyBench inside qemu-user
> PACKAGECONFIG[pgo] = "--enable-optimizations"
> +PACKAGECONFIG[tk] = ",,tk"
>
> do_configure_append() {
> rm -f ${S}/Makefile.orig
> @@ -246,7 +247,7 @@ PACKAGES += "${PN}-man"
> FILES_${PN}-man = "${datadir}/man"
>
> RDEPENDS_${PN}-ptest = "${PN}-modules ${PN}-tests unzip bzip2"
> -
> +RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', 'tk', '', d)}"
> RDEPENDS_${PN}-dev = ""
>
> BBCLASSEXTEND = "nativesdk"
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2] python3: add tk support
2018-11-14 9:36 ` [PATCH v2] " mingli.yu
2018-11-19 1:32 ` Yu, Mingli
@ 2018-11-23 1:29 ` Yu, Mingli
2018-11-23 11:03 ` richard.purdie
1 sibling, 1 reply; 27+ messages in thread
From: Yu, Mingli @ 2018-11-23 1:29 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod,
alejandro.enedino.hernandez-samaniego, openembedded-core
Ping.
Thanks,
On 2018年11月14日 17:36, mingli.yu@windriver.com wrote:
> From: Mingli Yu <Mingli.Yu@windriver.com>
>
> Add support to enable tk via PACKAGECONFIG.
> before this patch:
> # python3
> Python 3.5.6 (default, Nov 8 2018, 04:53:45)
> [GCC 8.2.0] on linux
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import tkinter
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> File "/usr/lib64/python3.5/tkinter/__init__.py", line 35, in <module>
> import _tkinter # If this fails your Python may not be configured for Tk
> ImportError: No module named '_tkinter'
> >>>
>
> After this patch, if enable tk in PACKAGECONFIG, then
> # python3
> Python 3.5.6 (default, Nov 8 2018, 03:15:52)
> [GCC 8.2.0] on linux
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import tkinter
> >>>
>
> Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
> ---
> meta/recipes-devtools/python/python3-native_3.5.6.bb | 3 ++-
> meta/recipes-devtools/python/python3/python3-manifest.json | 1 +
> meta/recipes-devtools/python/python3_3.5.6.bb | 5 +++--
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-devtools/python/python3-native_3.5.6.bb b/meta/recipes-devtools/python/python3-native_3.5.6.bb
> index d5953cf..1e98c03 100644
> --- a/meta/recipes-devtools/python/python3-native_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3-native_3.5.6.bb
> @@ -12,7 +12,7 @@ file://130-readline-setup.patch \
> file://150-fix-setupterm.patch \
> file://python-3.3-multilib.patch \
> file://03-fix-tkinter-detection.patch \
> -file://avoid_warning_about_tkinter.patch \
> +${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
> file://0001-h2py-Fix-issue-13032-where-it-fails-with-UnicodeDeco.patch \
> file://sysroot-include-headers.patch \
> file://unixccompiler.patch \
> @@ -28,6 +28,7 @@ file://0003-bpo-32947-Fixes-for-TLS-1.3-and-OpenSSL-1.1.1-GH-876.patch \
> file://0004-bpo-33570-TLS-1.3-ciphers-for-OpenSSL-1.1.1-GH-6976.patch \
> file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
> "
> +PACKAGECONFIG[tk] = ",,tk-native"
>
> EXTRANATIVEPATH += "bzip2-native"
> DEPENDS = "openssl-native bzip2-replacement-native zlib-native readline-native sqlite3-native gdbm-native"
> diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json b/meta/recipes-devtools/python/python3/python3-manifest.json
> index 5329bf7..617256a 100644
> --- a/meta/recipes-devtools/python/python3/python3-manifest.json
> +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
> @@ -1060,6 +1060,7 @@
> "core"
> ],
> "files": [
> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter.*.so",
> "${libdir}/python${PYTHON_MAJMIN}/tkinter"
> ],
> "cached": []
> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb b/meta/recipes-devtools/python/python3_3.5.6.bb
> index 31f8ead..5c80421 100644
> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> @@ -21,7 +21,7 @@ ${DISTRO_SRC_URI} \
>
> SRC_URI += "\
> file://03-fix-tkinter-detection.patch \
> - file://avoid_warning_about_tkinter.patch \
> + ${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
> file://cgi_py.patch \
> file://host_include_contamination.patch \
> file://python-3.3-multilib.patch \
> @@ -82,6 +82,7 @@ PACKAGECONFIG ??= "readline ${@bb.utils.contains('MACHINE_FEATURES', 'qemu-userm
> PACKAGECONFIG[readline] = ",,readline"
> # Use profile guided optimisation by running PyBench inside qemu-user
> PACKAGECONFIG[pgo] = "--enable-optimizations"
> +PACKAGECONFIG[tk] = ",,tk"
>
> do_configure_append() {
> rm -f ${S}/Makefile.orig
> @@ -246,7 +247,7 @@ PACKAGES += "${PN}-man"
> FILES_${PN}-man = "${datadir}/man"
>
> RDEPENDS_${PN}-ptest = "${PN}-modules ${PN}-tests unzip bzip2"
> -
> +RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', 'tk', '', d)}"
> RDEPENDS_${PN}-dev = ""
>
> BBCLASSEXTEND = "nativesdk"
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3] python: add tk support
2018-11-14 9:38 ` [PATCH v3] " mingli.yu
2018-11-19 1:31 ` Yu, Mingli
@ 2018-11-23 1:30 ` Yu, Mingli
1 sibling, 0 replies; 27+ messages in thread
From: Yu, Mingli @ 2018-11-23 1:30 UTC (permalink / raw)
To: richard.purdie, ross.burton, raj.khem, randy.macleod,
alejandro.enedino.hernandez-samaniego, openembedded-core
Ping.
Thanks,
On 2018年11月14日 17:38, mingli.yu@windriver.com wrote:
> From: Mingli Yu <Mingli.Yu@windriver.com>
>
> Add support to enable tk via PACKGECONFIG.
> before the patch:
> # python
> Python 2.7.15 (default, Nov 8 2018, 04:53:50)
> [GCC 8.2.0] on linux2
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import Tkinter
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> File "/usr/lib64/python2.7/lib-tk/Tkinter.py", line 39, in <module>
> import _tkinter # If this fails your Python may not be configured for Tk
> ImportError: No module named _tkinter
> >>>
>
> After the patch, if enable tk in PACKGECONFIG, then
> # python
> Python 2.7.15 (default, Oct 25 2018, 08:12:45)
> [GCC 8.2.0] on linux2
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import Tkinter
> >>>
>
> Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
> ---
> meta/recipes-devtools/python/python/python2-manifest.json | 3 ++-
> meta/recipes-devtools/python/python_2.7.15.bb | 5 +++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-devtools/python/python/python2-manifest.json b/meta/recipes-devtools/python/python/python2-manifest.json
> index 260fa6f..a9f3924 100644
> --- a/meta/recipes-devtools/python/python/python2-manifest.json
> +++ b/meta/recipes-devtools/python/python/python2-manifest.json
> @@ -966,6 +966,7 @@
> "core"
> ],
> "files": [
> + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter.so",
> "${libdir}/python2.7/lib-tk"
> ]
> },
> @@ -1043,4 +1044,4 @@
> "${libdir}/python2.7/lib-dynload/zlib.so"
> ]
> }
> -}
> \ No newline at end of file
> +}
> diff --git a/meta/recipes-devtools/python/python_2.7.15.bb b/meta/recipes-devtools/python/python_2.7.15.bb
> index dd969d8..6a60aa7 100644
> --- a/meta/recipes-devtools/python/python_2.7.15.bb
> +++ b/meta/recipes-devtools/python/python_2.7.15.bb
> @@ -21,7 +21,7 @@ SRC_URI += "\
> file://setuptweaks.patch \
> file://check-if-target-is-64b-not-host.patch \
> file://search_db_h_in_inc_dirs_and_avoid_warning.patch \
> - file://avoid_warning_about_tkinter.patch \
> + ${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
> file://avoid_warning_for_sunos_specific_module.patch \
> file://python-2.7.3-remove-bsdb-rpath.patch \
> file://run-ptest \
> @@ -45,6 +45,7 @@ EXTRA_OECONF += "ac_cv_file__dev_ptmx=yes ac_cv_file__dev_ptc=no"
>
> PACKAGECONFIG ??= "bdb"
> PACKAGECONFIG[bdb] = ",,db"
> +PACKAGECONFIG[tk] = ",,tk"
>
> do_configure_append() {
> rm -f ${S}/Makefile.orig
> @@ -172,7 +173,7 @@ RDEPENDS_${PN}-modules += "${PN}-misc"
>
> # ptest
> RDEPENDS_${PN}-ptest = "${PN}-modules ${PN}-tests unzip"
> -
> +RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', 'tk', '', d)}"
> # catch manpage
> PACKAGES += "${PN}-man"
> FILES_${PN}-man = "${datadir}/man"
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2] python3: add tk support
2018-11-23 1:29 ` Yu, Mingli
@ 2018-11-23 11:03 ` richard.purdie
2018-11-23 11:14 ` Richard Purdie
0 siblings, 1 reply; 27+ messages in thread
From: richard.purdie @ 2018-11-23 11:03 UTC (permalink / raw)
To: Yu, Mingli, ross.burton, raj.khem, randy.macleod,
alejandro.enedino.hernandez-samaniego, openembedded-core
On Fri, 2018-11-23 at 09:29 +0800, Yu, Mingli wrote:
> Ping.
>
> Thanks,
Why are you sending ping requests for both v2 and v3 of the same patch?
Cheers,
Richard
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2] python3: add tk support
2018-11-23 11:03 ` richard.purdie
@ 2018-11-23 11:14 ` Richard Purdie
0 siblings, 0 replies; 27+ messages in thread
From: Richard Purdie @ 2018-11-23 11:14 UTC (permalink / raw)
To: Yu, Mingli, ross.burton, raj.khem, randy.macleod,
alejandro.enedino.hernandez-samaniego, openembedded-core
On Fri, 2018-11-23 at 11:03 +0000, richard.purdie@linuxfoundation.org
wrote:
> On Fri, 2018-11-23 at 09:29 +0800, Yu, Mingli wrote:
> > Ping.
> >
> > Thanks,
>
> Why are you sending ping requests for both v2 and v3 of the same
> patch?
Sorry, I understand now, there is a patch for python2 and a patch for
python3 which are at differing versions. Too many similar but different
numbers!
Cheers,
Richard
^ permalink raw reply [flat|nested] 27+ messages in thread
end of thread, other threads:[~2018-11-23 11:14 UTC | newest]
Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
2018-11-08 6:08 ` [PATCH v2 1/7] python: " mingli.yu
2018-11-14 9:38 ` [PATCH v3] " mingli.yu
2018-11-19 1:31 ` Yu, Mingli
2018-11-23 1:30 ` Yu, Mingli
2018-11-08 6:08 ` [PATCH 2/7] python3: " mingli.yu
2018-11-08 13:49 ` Burton, Ross
2018-11-09 1:38 ` Yu, Mingli
2018-11-09 13:02 ` Burton, Ross
2018-11-12 2:28 ` Yu, Mingli
2018-11-12 15:28 ` Alejandro Hernandez
2018-11-13 3:03 ` Yu, Mingli
2018-11-13 8:25 ` Alejandro Hernandez
2018-11-13 9:10 ` Yu, Mingli
2018-11-13 21:26 ` Alejandro Hernandez
2018-11-14 8:23 ` Yu, Mingli
2018-11-14 9:36 ` [PATCH v2] " mingli.yu
2018-11-19 1:32 ` Yu, Mingli
2018-11-23 1:29 ` Yu, Mingli
2018-11-23 11:03 ` richard.purdie
2018-11-23 11:14 ` Richard Purdie
2018-11-08 6:08 ` [PATCH 3/7] libxt: extend to nativesdk mingli.yu
2018-11-08 6:08 ` [PATCH 4/7] libxft: " mingli.yu
2018-11-08 6:08 ` [PATCH 5/7] fontconfig: " mingli.yu
2018-11-08 6:08 ` [PATCH 6/7] libsm: " mingli.yu
2018-11-08 6:08 ` [PATCH 7/7] libice: " mingli.yu
2018-11-08 6:12 ` [PATCH v2 0/7] python/python3: add tk support mingli.yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.