All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 1/2] wayland : Bump to 1.2.0 version
@ 2013-10-10 12:23 Ewan LE BIDEAU-CANEVET
  2013-10-10 12:23 ` [PATCH v3 2/2] weston " Ewan LE BIDEAU-CANEVET
  2013-10-10 14:16 ` [PATCH v3 1/2] wayland " Burton, Ross
  0 siblings, 2 replies; 6+ messages in thread
From: Ewan LE BIDEAU-CANEVET @ 2013-10-10 12:23 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Ewan LE BIDEAU-CANEVET <Ewan.LEBIDEAU-CANEVET@eurogiciel.fr>
---
 .../wayland/wayland/just-scanner.patch             |   36 --------------------
 .../wayland/{wayland_1.1.0.bb => wayland_1.2.0.bb} |   18 ++--------
 2 files changed, 2 insertions(+), 52 deletions(-)
 delete mode 100644 meta/recipes-graphics/wayland/wayland/just-scanner.patch
 rename meta/recipes-graphics/wayland/{wayland_1.1.0.bb => wayland_1.2.0.bb} (59%)

diff --git a/meta/recipes-graphics/wayland/wayland/just-scanner.patch b/meta/recipes-graphics/wayland/wayland/just-scanner.patch
deleted file mode 100644
index 234a9c5..0000000
--- a/meta/recipes-graphics/wayland/wayland/just-scanner.patch
+++ /dev/null
@@ -1,36 +0,0 @@
-We only build wayland-native for the scanner, so disable the bits we don't
-actually need.  This gives us a small speed up but importantly should allow
-wayland-native to compile on older hosts such as CentOS 5 which currently fails:
-
-| wayland-1.0.6/src/wayland-server.c:1245: error: 'O_CLOEXEC' undeclared (first use in this function)
-| wayland-1.0.6/src/event-loop.c:34:25: error: sys/timerfd.h: No such file or directory
-| wayland-1.0.6/src/event-loop.c:199: error: 'CLOCK_MONOTONIC' undeclared (first use in this function)
-| wayland-1.0.6/src/event-loop.c:199: error: 'TFD_CLOEXEC' undeclared (first use in this function)
-| wayland-1.0.6/src/event-loop.c:268: error: 'SFD_CLOEXEC' undeclared (first use in this function)
-
-Upstream-Status: Inappropriate
-Signed-off-by: Ross Burton <ross.burton@intel.com>
-
-diff --git a/Makefile.am b/Makefile.am
-index 306d7b3..571fe89 100644
---- a/Makefile.am
-+++ b/Makefile.am
-@@ -2,7 +2,7 @@ if BUILD_DOCS
- doc_subdir = doc
- endif
- 
--SUBDIRS = src protocol $(doc_subdir) tests cursor
-+SUBDIRS = src protocol $(doc_subdir)
- 
- ACLOCAL_AMFLAGS = -I m4 ${ACLOCAL_FLAGS}
- 
-diff --git a/src/Makefile.am b/src/Makefile.am
-index e1d04ea..702342e 100644
---- a/src/Makefile.am
-+++ b/src/Makefile.am
-@@ -1,4 +1,4 @@
--lib_LTLIBRARIES = libwayland-server.la libwayland-client.la
-+#lib_LTLIBRARIES = libwayland-server.la libwayland-client.la
- noinst_LTLIBRARIES = libwayland-util.la
- 
- include_HEADERS =				\
diff --git a/meta/recipes-graphics/wayland/wayland_1.1.0.bb b/meta/recipes-graphics/wayland/wayland_1.2.0.bb
similarity index 59%
rename from meta/recipes-graphics/wayland/wayland_1.1.0.bb
rename to meta/recipes-graphics/wayland/wayland_1.2.0.bb
index a71402e..f001b43 100644
--- a/meta/recipes-graphics/wayland/wayland_1.1.0.bb
+++ b/meta/recipes-graphics/wayland/wayland_1.2.0.bb
@@ -11,11 +11,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=1d4476a7d98dd5691c53d4d43a510c72 \
                     file://src/wayland-server.c;endline=21;md5=079ae21dbf98ada52ec23744851b0a5c"
 
 SRC_URI = "http://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz"
-SRC_URI[md5sum] = "d2dc9398a83692cafc16eba6e45f85d8"
-SRC_URI[sha256sum] = "2ef587cf1a0e52b6dee44eeb9c288110e8180819abf4e419d247dfe234867a5c"
-
-SRC_URI_append_class-native = " file://just-scanner.patch"
-
+SRC_URI[md5sum] = "48d375afb15f3e68a72cf7b4fd8f4a63"
+SRC_URI[sha256sum] = "6b0439a017185bc5b2fed96c178bed3abf7f19188f3078f4d69fd3ce222d654c"
 inherit autotools pkgconfig
 
 # We need wayland-native for the wayland-scanner utility
@@ -26,14 +23,3 @@ DEPENDS = "expat libffi wayland-native"
 
 EXTRA_OECONF_virtclass-native = "--disable-documentation"
 EXTRA_OECONF = "--disable-documentation --disable-scanner"
-
-# Wayland installs a M4 macro for other projects to use. This M4 macro includes
-# a path to a Makefile fragment to get the rules to generate stubs from protocol
-# description files.  The paths to the sysroot end up incorrect, so fix them.
-do_configure_append_class-native() {
-  sed -e 's,@prefix@,${STAGING_DIR_NATIVE},g' \
-      -e 's,@exec_prefix@,${STAGING_DIR_NATIVE},g' \
-      -e 's,@bindir@,${STAGING_BINDIR_NATIVE},g' \
-      -e 's,@datarootdir@,${STAGING_DATADIR_NATIVE},g' \
-  ${S}/wayland-scanner.m4.in > ${B}/wayland-scanner.m4
-}
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v3 2/2] weston : Bump to 1.2.0 version
  2013-10-10 12:23 [PATCH v3 1/2] wayland : Bump to 1.2.0 version Ewan LE BIDEAU-CANEVET
@ 2013-10-10 12:23 ` Ewan LE BIDEAU-CANEVET
  2013-10-10 14:21   ` Burton, Ross
  2013-10-10 14:16 ` [PATCH v3 1/2] wayland " Burton, Ross
  1 sibling, 1 reply; 6+ messages in thread
From: Ewan LE BIDEAU-CANEVET @ 2013-10-10 12:23 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Ewan LE BIDEAU-CANEVET <Ewan.LEBIDEAU-CANEVET@eurogiciel.fr>
---
 meta/recipes-graphics/wayland/weston/groups.patch  |   47 ------
 .../wayland/weston/weston-launch-shell.patch       |   74 ---------
 .../wayland/{weston_1.1.0.bb => weston_1.2.0.bb}   |  162 ++++++++++----------
 3 files changed, 79 insertions(+), 204 deletions(-)
 delete mode 100644 meta/recipes-graphics/wayland/weston/groups.patch
 delete mode 100644 meta/recipes-graphics/wayland/weston/weston-launch-shell.patch
 rename meta/recipes-graphics/wayland/{weston_1.1.0.bb => weston_1.2.0.bb} (83%)

diff --git a/meta/recipes-graphics/wayland/weston/groups.patch b/meta/recipes-graphics/wayland/weston/groups.patch
deleted file mode 100644
index 9dc043a..0000000
--- a/meta/recipes-graphics/wayland/weston/groups.patch
+++ /dev/null
@@ -1,47 +0,0 @@
-Upstream-Status: Submitted (https://bugs.freedesktop.org/show_bug.cgi?id=65933)
-Signed-off-by: Ross Burton <ross.burton@intel.com>
-
-From 42821739a228a85ce3432be1796858e5cc31688b Mon Sep 17 00:00:00 2001
-From: Quentin Glidic <sardemff7+git@sardemff7.net>
-Date: Wed, 19 Jun 2013 15:27:11 +0200
-Subject: [PATCH weston] weston-launch: Set all groups for user
-
-Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
----
- configure.ac        | 2 +-
- src/weston-launch.c | 4 ++++
- 2 files changed, 5 insertions(+), 1 deletion(-)
-
-diff --git a/configure.ac b/configure.ac
-index b625221..db3feb0 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -52,7 +52,7 @@ AC_CHECK_DECL(CLOCK_MONOTONIC,[],
- 	      [[#include <time.h>]])
- AC_CHECK_HEADERS([execinfo.h])
- 
--AC_CHECK_FUNCS([mkostemp strchrnul])
-+AC_CHECK_FUNCS([mkostemp strchrnul initgroups])
- 
- COMPOSITOR_MODULES="wayland-server >= 1.1.90 xkbcommon pixman-1"
- 
-diff --git a/src/weston-launch.c b/src/weston-launch.c
-index 76dcede..7d7b556 100644
---- a/src/weston-launch.c
-+++ b/src/weston-launch.c
-@@ -631,9 +631,13 @@ main(int argc, char *argv[])
- 		}
- 
- 		if (setgid(wl.pw->pw_gid) < 0 ||
-+#ifdef HAVE_INITGROUPS
-+                    initgroups(wl.pw->pw_name, wl.pw->pw_gid) < 0 ||
-+#endif
- 		    setuid(wl.pw->pw_uid) < 0)
- 			error(1, errno, "dropping privilidges failed");
- 
-+
- 		if (sleep_fork) {
- 			if (wl.verbose)
- 				printf("weston-launch: waiting %d seconds\n", sleep_fork);
--- 
-1.8.3
diff --git a/meta/recipes-graphics/wayland/weston/weston-launch-shell.patch b/meta/recipes-graphics/wayland/weston/weston-launch-shell.patch
deleted file mode 100644
index ffe0608..0000000
--- a/meta/recipes-graphics/wayland/weston/weston-launch-shell.patch
+++ /dev/null
@@ -1,74 +0,0 @@
-Upstream-Status: Backport
-Signed-off-by: Ross Burton <ross.burton@intel.com>
-
-From ff3230952a68077669e0ea0ac3ceb234273556fc Mon Sep 17 00:00:00 2001
-From: Quentin Glidic <sardemff7+git@sardemff7.net>
-Date: Fri, 17 May 2013 16:20:37 +0200
-Subject: [PATCH] weston-launch: Run weston in the user login shell
-
-This patch brings back the user environment from the shell.
-In the future, weston-launch could create the Wayland socket earlier, in
-which case the user's shell could be used to run Wayland-specific tools
-in the new Weston session.
-
-Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
----
- src/weston-launch.c |   19 ++++++++++++++++---
- 1 file changed, 16 insertions(+), 3 deletions(-)
-
-diff --git a/src/weston-launch.c b/src/weston-launch.c
-index 64d4a8a..89c3c5a 100644
---- a/src/weston-launch.c
-+++ b/src/weston-launch.c
-@@ -60,6 +60,8 @@
- 
- #include "weston-launch.h"
- 
-+#define MAX_ARGV_SIZE 256
-+
- struct weston_launch {
- 	struct pam_conv pc;
- 	pam_handle_t *ph;
-@@ -523,8 +525,9 @@ main(int argc, char *argv[])
- 	struct weston_launch wl;
- 	char **env;
- 	int i, c;
--	char **child_argv;
-+	char *child_argv[MAX_ARGV_SIZE];
- 	char *tty = NULL, *new_user = NULL;
-+	char *term;
- 	int sleep_fork = 0;
- 	struct option opts[] = {
- 		{ "user",    required_argument, NULL, 'u' },
-@@ -562,8 +565,8 @@ main(int argc, char *argv[])
- 		}
- 	}
- 
--	child_argv = &argv[optind-1];
--	child_argv[0] = BINDIR "/weston";
-+	if ((argc - optind) > (MAX_ARGV_SIZE - 5))
-+		error(1, E2BIG, "Too many arguments to pass to weston");
- 
- 	if (new_user)
- 		wl.pw = getpwnam(new_user);
-@@ -572,7 +575,17 @@ main(int argc, char *argv[])
- 	if (wl.pw == NULL)
- 		error(1, errno, "failed to get username");
- 
-+	child_argv[0] = wl.pw->pw_shell;
-+	child_argv[1] = "-l";
-+	child_argv[2] = "-c";
-+	child_argv[3] = BINDIR "/weston \"$@\"";
-+	child_argv[4] = "weston";
-+	for (i = 0; i < (argc - optind); ++i)
-+		child_argv[5+i] = argv[optind+i];
-+
-+	term = getenv("TERM");
- 	clearenv();
-+	setenv("TERM", term, 1);
- 	setenv("USER", wl.pw->pw_name, 1);
- 	setenv("LOGNAME", wl.pw->pw_name, 1);
- 	setenv("HOME", wl.pw->pw_dir, 1);
--- 
-1.7.10.4
-
diff --git a/meta/recipes-graphics/wayland/weston_1.1.0.bb b/meta/recipes-graphics/wayland/weston_1.2.0.bb
similarity index 83%
rename from meta/recipes-graphics/wayland/weston_1.1.0.bb
rename to meta/recipes-graphics/wayland/weston_1.2.0.bb
index 8280bf2..d320f88 100644
--- a/meta/recipes-graphics/wayland/weston_1.1.0.bb
+++ b/meta/recipes-graphics/wayland/weston_1.2.0.bb
@@ -1,83 +1,79 @@
-SUMMARY = "Weston, a Wayland compositor"
-DESCRIPTION = "Weston is the reference implementation of a Wayland compositor"
-HOMEPAGE = "http://wayland.freedesktop.org"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://COPYING;md5=275efac2559a224527bd4fd593d38466 \
-                    file://src/compositor.c;endline=23;md5=aa98a8db03480fe7d500d0b1f4b8850c"
-
-SRC_URI = "http://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
-           file://install-examples.patch \
-           file://weston-launch-shell.patch \
-           file://groups.patch \
-           file://weston.png \
-           file://weston.desktop"
-SRC_URI[md5sum] = "dd9f3043fc5228c6bc4e99873fae2254"
-SRC_URI[sha256sum] = "e7715d2c731f77a729c994a599ffdaebac1307b2dd9336136706869fa53618b4"
-
-
-inherit autotools pkgconfig useradd
-
-DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 jpeg"
-DEPENDS += "wayland virtual/mesa virtual/egl pango"
-
-EXTRA_OECONF = "--disable-android-compositor \
-                --enable-setuid-install \
-                --disable-tablet-shell \
-                --disable-xwayland \
-                --enable-simple-clients \
-                --enable-clients \
-                --disable-simple-egl-clients \
-                --disable-libunwind \
-                --disable-rpi-compositor \
-                --disable-rdp-compositor"
-
-
-PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'wayland', 'kms wayland', '', d)} \
-                   ${@base_contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
-                   ${@base_contains('DISTRO_FEATURES', 'opengles2', 'gles', '', d)} \
-                   ${@base_contains('DISTRO_FEATURES', 'pam', 'launch', '', d)} \
-                  "
-#
-# Compositor choices
-#
-# Weston on KMS
-PACKAGECONFIG[kms] = "--enable-drm-compositor,--disable-drm-compositor,drm udev mesa mtdev"
-# Weston on Wayland (nested Weston)
-PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-wayland-compositor,mesa"
-# Weston on X11
-PACKAGECONFIG[x11] = "--enable-x11-compositor,--disable-x11-compositor,virtual/libx11 libxcb libxcb libxcursor cairo"
-# Headless Weston
-PACKAGECONFIG[headless] = "--enable-headless-compositor,--disable-headless-compositor"
-# Weston on framebuffer
-PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor,--disable-fbdev-compositor,udev mtdev"
-# weston-launch
-PACKAGECONFIG[launch] = "--enable-weston-launch,--disable-weston-launch,libpam"
-# Use cairo-gl or cairo-glesv2
-PACKAGECONFIG[gles] = "--with-cairo-glesv2,,virtual/libgles2"
-
-do_install_append() {
-	# Weston doesn't need the .la files to load modules, so wipe them
-	rm -f ${D}/${libdir}/weston/*.la
-
-	for feature in ${DISTRO_FEATURES}; do
-		# If X11, ship a desktop file to launch it
-		if [ "$feature" = "x11" ]; then
-			install -d ${D}${datadir}/applications
-			install ${WORKDIR}/weston.desktop ${D}${datadir}/applications
-
-			install -d ${D}${datadir}/icons/hicolor/48x48/apps
-			install ${WORKDIR}/weston.png ${D}${datadir}/icons/hicolor/48x48/apps
-                fi
-	done
-}
-
-PACKAGES += "${PN}-examples"
-
-FILES_${PN} = "${bindir}/weston* ${bindir}/wcap-decode ${libexecdir} ${datadir}"
-FILES_${PN}-examples = "${bindir}/*"
-
-RDEPENDS_${PN} += "xkeyboard-config"
-RRECOMMENDS_${PN} = "liberation-fonts"
-
-USERADD_PACKAGES = "${PN}"
-GROUPADD_PARAM_${PN} = "--system weston-launch"
+SUMMARY = "Weston, a Wayland compositor"
+DESCRIPTION = "Weston is the reference implementation of a Wayland compositor"
+HOMEPAGE = "http://wayland.freedesktop.org"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://COPYING;md5=275efac2559a224527bd4fd593d38466 \
+                    file://src/compositor.c;endline=23;md5=aa98a8db03480fe7d500d0b1f4b8850c"
+
+SRC_URI = "http://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
+           file://install-examples.patch \
+           file://weston.png \
+           file://weston.desktop"
+SRC_URI[md5sum] = "86f8c9e865923e138ce44ee41d951500"
+SRC_URI[sha256sum] = "122e12ae8e4ec4618780465c0cc31d70d67054900a2aac458f82ed6eb5d397b7"
+
+
+inherit autotools pkgconfig useradd
+
+DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 jpeg"
+DEPENDS += "wayland mesa virtual/egl pango"
+BBCLASSEXTEND = "native"
+EXTRA_OECONF = "--disable-android-compositor \
+                --enable-setuid-install \
+                --disable-tablet-shell \
+                --disable-xwayland \
+                --enable-simple-clients \
+                --enable-clients \
+                --disable-simple-egl-clients \
+                --disable-libunwind \
+                --disable-rpi-compositor \
+                --disable-rdp-compositor"
+
+
+PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'wayland', 'kms wayland', '', d)} \
+                   ${@base_contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
+                   ${@base_contains('DISTRO_FEATURES', 'opengles2', 'gles', '', d)} \
+                  "
+#
+# Compositor choices
+#
+# Weston on KMS
+PACKAGECONFIG[kms] = "--enable-drm-compositor --enable-weston-launch,--disable-drm-compositor --disable-weston-launch,drm udev mesa mtdev libpam"
+# Weston on Wayland (nested Weston)
+PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-wayland-compositor,mesa"
+# Weston on X11
+PACKAGECONFIG[x11] = "--enable-x11-compositor,--disable-x11-compositor,virtual/libx11 libxcb libxcb libxcursor cairo"
+# Headless Weston
+PACKAGECONFIG[headless] = "--enable-headless-compositor,--disable-headless-compositor"
+# Weston on framebuffer
+PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor,--disable-fbdev-compositor,udev mtdev"
+
+# Use cairo-gl or cairo-glesv2
+PACKAGECONFIG[gles] = "--with-cairo-glesv2,,virtual/libgles2"
+
+do_install_append() {
+	# Weston doesn't need the .la files to load modules, so wipe them
+	rm -f ${D}/${libdir}/weston/*.la
+
+	for feature in ${DISTRO_FEATURES}; do
+		# If X11, ship a desktop file to launch it
+		if [ "$feature" = "x11" ]; then
+			install -d ${D}${datadir}/applications
+			install ${WORKDIR}/weston.desktop ${D}${datadir}/applications
+
+			install -d ${D}${datadir}/icons/hicolor/48x48/apps
+			install ${WORKDIR}/weston.png ${D}${datadir}/icons/hicolor/48x48/apps
+                fi
+	done
+}
+
+PACKAGES += "${PN}-examples"
+
+FILES_${PN} = "${bindir}/weston* ${bindir}/wcap-decode ${libexecdir} ${datadir}"
+FILES_${PN}-examples = "${bindir}/*"
+
+RDEPENDS_${PN} += "xkeyboard-config"
+RRECOMMENDS_${PN} = "liberation-fonts"
+
+USERADD_PACKAGES = "${PN}"
+GROUPADD_PARAM_${PN} = "--system weston-launch"
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 1/2] wayland : Bump to 1.2.0 version
  2013-10-10 12:23 [PATCH v3 1/2] wayland : Bump to 1.2.0 version Ewan LE BIDEAU-CANEVET
  2013-10-10 12:23 ` [PATCH v3 2/2] weston " Ewan LE BIDEAU-CANEVET
@ 2013-10-10 14:16 ` Burton, Ross
  2013-10-10 15:44   ` Ewan LE BIDEAU-CANEVET
  1 sibling, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2013-10-10 14:16 UTC (permalink / raw)
  To: Ewan LE BIDEAU-CANEVET; +Cc: OE-core

On 10 October 2013 13:23, Ewan LE BIDEAU-CANEVET
<Ewan.LEBIDEAU-CANEVET@eurogiciel.fr> wrote:
> -SRC_URI_append_class-native = " file://just-scanner.patch"

That patch -  as it says - serves a useful purpose.  What is the
rationale for deleting it?  If there's a good reason, please say what
it is.

> -# Wayland installs a M4 macro for other projects to use. This M4 macro includes
> -# a path to a Makefile fragment to get the rules to generate stubs from protocol
> -# description files.  The paths to the sysroot end up incorrect, so fix them.
> -do_configure_append_class-native() {
> -  sed -e 's,@prefix@,${STAGING_DIR_NATIVE},g' \
> -      -e 's,@exec_prefix@,${STAGING_DIR_NATIVE},g' \
> -      -e 's,@bindir@,${STAGING_BINDIR_NATIVE},g' \
> -      -e 's,@datarootdir@,${STAGING_DATADIR_NATIVE},g' \
> -  ${S}/wayland-scanner.m4.in > ${B}/wayland-scanner.m4
> -}

Wayland is still installing this m4 file, so why delete this fix?
From a glance at Wayland 1.2 it looks like it isn't required anymore
as pkgconfig is used to determine the paths, but you need to state
this in the commit message.

Also, there's a 1.2.1 release now.

Ross


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] weston : Bump to 1.2.0 version
  2013-10-10 12:23 ` [PATCH v3 2/2] weston " Ewan LE BIDEAU-CANEVET
@ 2013-10-10 14:21   ` Burton, Ross
  0 siblings, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2013-10-10 14:21 UTC (permalink / raw)
  To: Ewan LE BIDEAU-CANEVET; +Cc: OE-core

On 10 October 2013 13:23, Ewan LE BIDEAU-CANEVET
<Ewan.LEBIDEAU-CANEVET@eurogiciel.fr> wrote:

Apologies if the formatting is messed up here, the patch wasn't sent
with -M so I had to re-generate the diff and manually add quotation
marks.

> SRC_URI = "http://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
>            file://install-examples.patch \
>-           file://weston-launch-shell.patch \
>-           file://groups.patch \
>            file://weston.png \
>            file://weston.desktop"

When removing patches, please say why.

>-DEPENDS += "wayland virtual/mesa virtual/egl pango"
>-
>+DEPENDS += "wayland mesa virtual/egl pango"

You've probably inadvertently reverted a fix here: the dependency
should be virtual/mesa.

>+BBCLASSEXTEND = "native"

Why do you need a native weston?

>-                   ${@base_contains('DISTRO_FEATURES', 'pam', 'launch', '', d)} \
>-PACKAGECONFIG[kms] = "--enable-drm-compositor,--disable-drm-compositor,drm udev mesa mtdev"
>+PACKAGECONFIG[kms] = "--enable-drm-compositor --enable-weston-launch,--disable-drm-compositor --disable-weston-launch,drm udev mesa mtdev libpam"
>-# weston-launch
>-PACKAGECONFIG[launch] = "--enable-weston-launch,--disable-weston-launch,libpam"
>+

Another revert.

This is why we ask for patches with -M: it makes it easy to see what
the changes are.  In this case there are several fixes lost that were
made in between your original change and the re-submission

Ross


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 1/2] wayland : Bump to 1.2.0 version
  2013-10-10 14:16 ` [PATCH v3 1/2] wayland " Burton, Ross
@ 2013-10-10 15:44   ` Ewan LE BIDEAU-CANEVET
  2013-10-10 15:59     ` Burton, Ross
  0 siblings, 1 reply; 6+ messages in thread
From: Ewan LE BIDEAU-CANEVET @ 2013-10-10 15:44 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 2085 bytes --]

On 10/10/2013 16:16, Burton, Ross wrote:
> On 10 October 2013 13:23, Ewan LE BIDEAU-CANEVET
> <Ewan.LEBIDEAU-CANEVET@eurogiciel.fr> wrote:
>> -SRC_URI_append_class-native = " file://just-scanner.patch"
> That patch -  as it says - serves a useful purpose.  What is the
> rationale for deleting it?  If there's a good reason, please say what
> it is.
>
>> -# Wayland installs a M4 macro for other projects to use. This M4 macro includes
>> -# a path to a Makefile fragment to get the rules to generate stubs from protocol
>> -# description files.  The paths to the sysroot end up incorrect, so fix them.
>> -do_configure_append_class-native() {
>> -  sed -e 's,@prefix@,${STAGING_DIR_NATIVE},g' \
>> -      -e 's,@exec_prefix@,${STAGING_DIR_NATIVE},g' \
>> -      -e 's,@bindir@,${STAGING_BINDIR_NATIVE},g' \
>> -      -e 's,@datarootdir@,${STAGING_DATADIR_NATIVE},g' \
>> -  ${S}/wayland-scanner.m4.in > ${B}/wayland-scanner.m4
>> -}
> Wayland is still installing this m4 file, so why delete this fix?
>  From a glance at Wayland 1.2 it looks like it isn't required anymore
> as pkgconfig is used to determine the paths, but you need to state
> this in the commit message.
This file

wayland-scanner.m4*.**in**  *

doesn't exist anymore. In fact there is only "wayland-scanner.m4"
Run sed command on a missing  file wayland-scanner.m4.in  is now 
useless, correct ?
Furthermore, in wayland-scanner.m4 has no reference to strings

@prefix@
@exec_prefix@
@bindir@
@datarootdir@

So if we let this instruction wayland-scanner.m4 will  be cleared. So 
this leads to build faillure.

> Also, there's a 1.2.1 release now.
You're right :). I have started this work few weeks ago.
I noticed that there is a 1.3.0 version, and I have started to take a 
look on it. I'll probably post my work in 1 or 2 weeks.


As I saw , we need to do the same change (Remove : 
do_configure_append_class-native function => last existing 
wayland-scanner.m4.in was in 1.1.0 version.)

Apologies for removing your just-scanner.patch file, my mistake.


Ewan

[-- Attachment #2: Type: text/html, Size: 3179 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 1/2] wayland : Bump to 1.2.0 version
  2013-10-10 15:44   ` Ewan LE BIDEAU-CANEVET
@ 2013-10-10 15:59     ` Burton, Ross
  0 siblings, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2013-10-10 15:59 UTC (permalink / raw)
  To: Ewan LE BIDEAU-CANEVET; +Cc: OE-core

On 10 October 2013 16:44, Ewan LE BIDEAU-CANEVET
<ewan.lebideau-canevet@eurogiciel.fr> wrote:
> Wayland is still installing this m4 file, so why delete this fix?
> From a glance at Wayland 1.2 it looks like it isn't required anymore
> as pkgconfig is used to determine the paths, but you need to state
> this in the commit message.
>
> This file
>
> wayland-scanner.m4.in
>
> doesn't exist anymore. In fact there is only "wayland-scanner.m4"
> Run sed command on a missing  file wayland-scanner.m4.in  is now useless,
> correct ?
> Furthermore, in wayland-scanner.m4 has no reference to strings
>
> @prefix@
> @exec_prefix@
> @bindir@
> @datarootdir@
>
> So if we let this instruction wayland-scanner.m4 will  be cleared. So this
> leads to build faillure.

Sure, but this rationale needs to be in the commit message, ideally
after verifying that the pkgconfig file doesn't have the same problem
that the m4 had.

Ross


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-10-10 15:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-10 12:23 [PATCH v3 1/2] wayland : Bump to 1.2.0 version Ewan LE BIDEAU-CANEVET
2013-10-10 12:23 ` [PATCH v3 2/2] weston " Ewan LE BIDEAU-CANEVET
2013-10-10 14:21   ` Burton, Ross
2013-10-10 14:16 ` [PATCH v3 1/2] wayland " Burton, Ross
2013-10-10 15:44   ` Ewan LE BIDEAU-CANEVET
2013-10-10 15:59     ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.