All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cpulimit: introduce support for this package
@ 2019-03-08 16:43 BOUBAKER Bassem
  2019-03-08 23:42 ` Burton, Ross
  2019-03-09  0:00 ` Andre McCurdy
  0 siblings, 2 replies; 4+ messages in thread
From: BOUBAKER Bassem @ 2019-03-08 16:43 UTC (permalink / raw)
  To: openembedded-core; +Cc: SAMMOUDA Ahmed

    * Now, cpulimit recipe is put under recipes-support. Binary will be installed by the recipe under /usr/sbin

	# cpulimit -h
	Usage: cpulimit [OPTIONS...] TARGET
		OPTIONS
		-l, --limit=N          percentage of cpu allowed from 0 to 100 (required)
		-v, --verbose          show control statistics
		-z, --lazy             exit if there is no target process, or if it dies
		-i, --include-children limit also the children processes
		-h, --help             display this help and exit
		TARGET must be exactly one of these:
		-p, --pid=N            pid of the process (implies -z)
		-e, --exe=FILE         name of the executable program file or path name
		COMMAND [ARGS]         run this command and limit it (implies -z)

		Report bugs to <marlonx80@hotmail.com>.

Signed-off-by: Bassem Boubaker <bassem.boubaker@actia.fr>
---
 meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb

diff --git a/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb b/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
new file mode 100644
index 0000000..d0c524e
--- /dev/null
+++ b/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
@@ -0,0 +1,22 @@
+DESCRIPTION = "cpulimit is a tool which limits the CPU usage of a process from bash prespective"
+HOMEPAGE = "http://cpulimit.sourceforge.net/"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=86c1c0d961a437e529db93aa3bb32dc4"
+
+PR = "r0"
+
+SRCREV ?= "f4d2682804931e7aea02a869137344bb5452a3cd"
+
+SRC_URI = "git://git@github.com/opsengine/cpulimit.git;protocol=https"
+
+SRC_URI[md5sum] = "4f805fe26c8cf28e8251d64d0ace21d4"
+SRC_URI[sha256sum] = "544516d0d80c685b1df1344a71c900e845270551cf210300fa4d13876e10817a"
+
+inherit autotools
+
+S = "${WORKDIR}/git"
+
+do_install() {
+        install -d ${D}${sbindir}
+        install -m 0755 ${S}/src/${PN} ${D}${sbindir}/
+}
\ No newline at end of file
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] cpulimit: introduce support for this package
  2019-03-08 16:43 [PATCH] cpulimit: introduce support for this package BOUBAKER Bassem
@ 2019-03-08 23:42 ` Burton, Ross
  2019-03-09  0:55   ` BOUBAKER Bassem
  2019-03-09  0:00 ` Andre McCurdy
  1 sibling, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2019-03-08 23:42 UTC (permalink / raw)
  To: BOUBAKER Bassem; +Cc: SAMMOUDA Ahmed, openembedded-core

Unless there's a great reason to put this into oe-core, I suggest that
it be added to meta-oe instead.

Ross

On Fri, 8 Mar 2019 at 23:24, BOUBAKER Bassem via Openembedded-core
<openembedded-core@lists.openembedded.org> wrote:
>
>     * Now, cpulimit recipe is put under recipes-support. Binary will be installed by the recipe under /usr/sbin
>
>         # cpulimit -h
>         Usage: cpulimit [OPTIONS...] TARGET
>                 OPTIONS
>                 -l, --limit=N          percentage of cpu allowed from 0 to 100 (required)
>                 -v, --verbose          show control statistics
>                 -z, --lazy             exit if there is no target process, or if it dies
>                 -i, --include-children limit also the children processes
>                 -h, --help             display this help and exit
>                 TARGET must be exactly one of these:
>                 -p, --pid=N            pid of the process (implies -z)
>                 -e, --exe=FILE         name of the executable program file or path name
>                 COMMAND [ARGS]         run this command and limit it (implies -z)
>
>                 Report bugs to <marlonx80@hotmail.com>.
>
> Signed-off-by: Bassem Boubaker <bassem.boubaker@actia.fr>
> ---
>  meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
>
> diff --git a/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb b/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
> new file mode 100644
> index 0000000..d0c524e
> --- /dev/null
> +++ b/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
> @@ -0,0 +1,22 @@
> +DESCRIPTION = "cpulimit is a tool which limits the CPU usage of a process from bash prespective"
> +HOMEPAGE = "http://cpulimit.sourceforge.net/"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=86c1c0d961a437e529db93aa3bb32dc4"
> +
> +PR = "r0"
> +
> +SRCREV ?= "f4d2682804931e7aea02a869137344bb5452a3cd"
> +
> +SRC_URI = "git://git@github.com/opsengine/cpulimit.git;protocol=https"
> +
> +SRC_URI[md5sum] = "4f805fe26c8cf28e8251d64d0ace21d4"
> +SRC_URI[sha256sum] = "544516d0d80c685b1df1344a71c900e845270551cf210300fa4d13876e10817a"
> +
> +inherit autotools
> +
> +S = "${WORKDIR}/git"
> +
> +do_install() {
> +        install -d ${D}${sbindir}
> +        install -m 0755 ${S}/src/${PN} ${D}${sbindir}/
> +}
> \ No newline at end of file
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cpulimit: introduce support for this package
  2019-03-08 16:43 [PATCH] cpulimit: introduce support for this package BOUBAKER Bassem
  2019-03-08 23:42 ` Burton, Ross
@ 2019-03-09  0:00 ` Andre McCurdy
  1 sibling, 0 replies; 4+ messages in thread
From: Andre McCurdy @ 2019-03-09  0:00 UTC (permalink / raw)
  To: BOUBAKER Bassem; +Cc: SAMMOUDA Ahmed, openembedded-core

On Fri, Mar 8, 2019 at 3:24 PM BOUBAKER Bassem via Openembedded-core
<openembedded-core@lists.openembedded.org> wrote:
>
>     * Now, cpulimit recipe is put under recipes-support. Binary will be installed by the recipe under /usr/sbin
>
>         # cpulimit -h
>         Usage: cpulimit [OPTIONS...] TARGET
>                 OPTIONS
>                 -l, --limit=N          percentage of cpu allowed from 0 to 100 (required)
>                 -v, --verbose          show control statistics
>                 -z, --lazy             exit if there is no target process, or if it dies
>                 -i, --include-children limit also the children processes
>                 -h, --help             display this help and exit
>                 TARGET must be exactly one of these:
>                 -p, --pid=N            pid of the process (implies -z)
>                 -e, --exe=FILE         name of the executable program file or path name
>                 COMMAND [ARGS]         run this command and limit it (implies -z)
>
>                 Report bugs to <marlonx80@hotmail.com>.

A few review comments to address before resubmitting to meta-oe.

> Signed-off-by: Bassem Boubaker <bassem.boubaker@actia.fr>
> ---
>  meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
>
> diff --git a/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb b/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
> new file mode 100644
> index 0000000..d0c524e
> --- /dev/null
> +++ b/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
> @@ -0,0 +1,22 @@
> +DESCRIPTION = "cpulimit is a tool which limits the CPU usage of a process from bash prespective"

Typo (or two typos?).

> +HOMEPAGE = "http://cpulimit.sourceforge.net/"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=86c1c0d961a437e529db93aa3bb32dc4"
> +
> +PR = "r0"

No need to set PR to its default.

> +SRCREV ?= "f4d2682804931e7aea02a869137344bb5452a3cd"
> +
> +SRC_URI = "git://git@github.com/opsengine/cpulimit.git;protocol=https"
> +
> +SRC_URI[md5sum] = "4f805fe26c8cf28e8251d64d0ace21d4"
> +SRC_URI[sha256sum] = "544516d0d80c685b1df1344a71c900e845270551cf210300fa4d13876e10817a"

No need for SRC_URI hashes when SRC_URI fetches from git.

> +inherit autotools
> +
> +S = "${WORKDIR}/git"

By convention S should be set before "inherit autotools". Try to stick
to the OE Styleguide unless there's a clear reason to deviate.

  http://www.openembedded.org/wiki/Styleguide

> +do_install() {
> +        install -d ${D}${sbindir}
> +        install -m 0755 ${S}/src/${PN} ${D}${sbindir}/

Even though ${S} and ${B} may be the same directory, conceptually it
makes more sense to install binaries from ${B} (ie the build
directory), rather than ${S} (ie the source directory).

> +}
> \ No newline at end of file

Should be fixed.

> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cpulimit: introduce support for this package
  2019-03-08 23:42 ` Burton, Ross
@ 2019-03-09  0:55   ` BOUBAKER Bassem
  0 siblings, 0 replies; 4+ messages in thread
From: BOUBAKER Bassem @ 2019-03-09  0:55 UTC (permalink / raw)
  To: Burton, Ross; +Cc: SAMMOUDA Ahmed, openembedded-core

Hi,

Submitted on meta-oe mailing list with some fixes of the recipe.

Bassem

>Unless there's a great reason to put this into oe-core, I suggest that
>it be added to meta-oe instead.
>
>Ross
>
>On Fri, 8 Mar 2019 at 23:24, BOUBAKER Bassem via Openembedded-core
><openembedded-core@lists.openembedded.org> wrote:
>>
>>     * Now, cpulimit recipe is put under recipes-support. Binary will be installed by the recipe under /usr/sbin
>>
>>         # cpulimit -h
>>         Usage: cpulimit [OPTIONS...] TARGET
>>                 OPTIONS
>>                 -l, --limit=N          percentage of cpu allowed from 0 to 100 (required)
>>                 -v, --verbose          show control statistics
>>                 -z, --lazy             exit if there is no target process, or if it dies
>>                 -i, --include-children limit also the children processes
>>                 -h, --help             display this help and exit
>>                 TARGET must be exactly one of these:
>>                 -p, --pid=N            pid of the process (implies -z)
>>                 -e, --exe=FILE         name of the executable program file or path name
>>                 COMMAND [ARGS]         run this command and limit it (implies -z)
>>
>>                 Report bugs to <marlonx80@hotmail.com>.
>>
>> Signed-off-by: Bassem Boubaker <bassem.boubaker@actia.fr>
>> ---
>>  meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>  create mode 100644 meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
>>
>> diff --git a/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb b/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
>> new file mode 100644
>> index 0000000..d0c524e
>> --- /dev/null
>> +++ b/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
>> @@ -0,0 +1,22 @@
>> +DESCRIPTION = "cpulimit is a tool which limits the CPU usage of a process from bash prespective"
>> +HOMEPAGE = "http://cpulimit.sourceforge.net/"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=86c1c0d961a437e529db93aa3bb32dc4"
>> +
>> +PR = "r0"
>> +
>> +SRCREV ?= "f4d2682804931e7aea02a869137344bb5452a3cd"
>> +
>> +SRC_URI = "git://git@github.com/opsengine/cpulimit.git;protocol=https"
>> +
>> +SRC_URI[md5sum] = "4f805fe26c8cf28e8251d64d0ace21d4"
>> +SRC_URI[sha256sum] = "544516d0d80c685b1df1344a71c900e845270551cf210300fa4d13876e10817a"
>> +
>> +inherit autotools
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +do_install() {
>> +        install -d ${D}${sbindir}
>> +        install -m 0755 ${S}/src/${PN} ${D}${sbindir}/
>> +}
>> \ No newline at end of file
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
    

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-09  5:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-08 16:43 [PATCH] cpulimit: introduce support for this package BOUBAKER Bassem
2019-03-08 23:42 ` Burton, Ross
2019-03-09  0:55   ` BOUBAKER Bassem
2019-03-09  0:00 ` Andre McCurdy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.