All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Burton, Ross" <ross.burton@intel.com>
To: Andrej Valek <andrej.valek@siemens.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 1/3] busybox: fix conflict with runlevel applet
Date: Tue, 9 Oct 2018 11:51:47 +0100	[thread overview]
Message-ID: <CAJTo0LafoJckLNPwDDnDzDhPg+B72N3fm65BR4WAuENbkKHD6w@mail.gmail.com> (raw)
In-Reply-To: <20181009073848.8492-1-andrej.valek@siemens.com>

[-- Attachment #1: Type: text/plain, Size: 2331 bytes --]

Don't you want to delete runlevel here too?

Ross

On Tue, 9 Oct 2018 at 08:45, Andrej Valek <andrej.valek@siemens.com> wrote:

> - remove OE runlevel script which conflicts with busybox's applet
> - don't install empty directories
>
> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
> ---
>  meta/recipes-core/busybox/busybox.inc      | 4 +---
>  meta/recipes-core/busybox/busybox/init.cfg | 1 +
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/busybox/busybox.inc
> b/meta/recipes-core/busybox/busybox.inc
> index e1fba4243a..7b427ab0f7 100644
> --- a/meta/recipes-core/busybox/busybox.inc
> +++ b/meta/recipes-core/busybox/busybox.inc
> @@ -254,8 +254,7 @@ do_install () {
>                         ln -sf busybox ${D}${base_bindir}/busybox.nosuid
>                 fi
>         else
> -               install -d ${D}${base_bindir} ${D}${base_sbindir}
> -               install -d ${D}${libdir} ${D}${bindir} ${D}${sbindir}
> +               install -d ${D}${base_bindir} ${D}${bindir} ${D}${libdir}
>                 cat busybox.links | while read FILE; do
>                         NAME=`basename "$FILE"`
>                         install -m 0755 "0_lib/$NAME" "${D}$FILE.${BPN}"
> @@ -316,7 +315,6 @@ do_install () {
>          if grep "CONFIG_INIT=y" ${B}/.config; then
>                  install -D -m 0777 ${WORKDIR}/rcS
> ${D}${sysconfdir}/init.d/rcS
>                  install -D -m 0777 ${WORKDIR}/rcK
> ${D}${sysconfdir}/init.d/rcK
> -                install -D -m 0755 ${WORKDIR}/runlevel
> ${D}${base_sbindir}/runlevel
>          fi
>
>      if
> ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
> diff --git a/meta/recipes-core/busybox/busybox/init.cfg
> b/meta/recipes-core/busybox/busybox/init.cfg
> index 3c1fdd42b6..b69fe0ea9c 100644
> --- a/meta/recipes-core/busybox/busybox/init.cfg
> +++ b/meta/recipes-core/busybox/busybox/init.cfg
> @@ -1,4 +1,5 @@
>  CONFIG_INIT=y
> +CONFIG_RUNLEVEL=y
>  CONFIG_FEATURE_USE_INITTAB=y
>  CONFIG_HALT=y
>  CONFIG_POWEROFF=y
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3149 bytes --]

  reply	other threads:[~2018-10-09 10:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 10:41 [PATCH] busybox: fix conflict with runlevel applet Andrej Valek
2018-10-04 10:48 ` Martin Jansa
2018-10-04 10:59   ` Andrej Valek
2018-10-04 11:27     ` Martin Jansa
2018-10-08 15:39       ` Burton, Ross
2018-10-08 15:44         ` Khem Raj
2018-10-09  7:38           ` [PATCH v2 1/3] " Andrej Valek
2018-10-09 10:51             ` Burton, Ross [this message]
2018-10-09 10:59               ` [PATCH v3 " Andrej Valek
2018-10-09 10:59               ` [PATCH v3 2/3] busybox: do not write grep outputs into log Andrej Valek
2018-10-09 10:59               ` [PATCH v3 3/3] busybox: unify recipe style Andrej Valek
2018-10-09  7:38           ` [PATCH v2 2/3] busybox: do not write grep outputs into log Andrej Valek
2018-10-09  7:38           ` [PATCH v2 3/3] busybox: unify recipe style Andrej Valek
2018-10-09 11:07 ` ✗ patchtest: failure for busybox: fix conflict with runlevel applet (rev4) Patchwork
2018-10-09 11:07 ` ✗ patchtest: failure for busybox: fix conflict with runlevel applet (rev5) Patchwork
2018-10-09 12:55 ` [PATCH v4 0/3] busybox: refactor Andrej Valek
2018-10-09 12:56 ` [PATCH v4 1/3] busybox: fix conflict with runlevel applet Andrej Valek
2018-10-09 12:56 ` [PATCH v4 2/3] busybox: do not write grep outputs into log Andrej Valek
2018-10-09 12:56 ` [PATCH v4 3/3] busybox: unify recipe style Andrej Valek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJTo0LafoJckLNPwDDnDzDhPg+B72N3fm65BR4WAuENbkKHD6w@mail.gmail.com \
    --to=ross.burton@intel.com \
    --cc=andrej.valek@siemens.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.