All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] busybox: fix conflict with runlevel applet
Date: Mon, 8 Oct 2018 08:44:38 -0700	[thread overview]
Message-ID: <CAMKF1souez4aWHQx3pgKjoqAuhh0xQ0cyYSPWiwmo4spqB+_mw@mail.gmail.com> (raw)
In-Reply-To: <CAJTo0LYo-+Cn47mP8rHvqEb51jcD+Np_hnPubs9YW4Z0YmOUzg@mail.gmail.com>

On Mon, Oct 8, 2018 at 8:39 AM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Thu, 4 Oct 2018 at 12:28, Martin Jansa <martin.jansa@gmail.com> wrote:
>>
>> On Thu, Oct 04, 2018 at 12:59:37PM +0200, Andrej Valek wrote:
>> > This init feature was introduced via
>> > http://lists.openembedded.org/pipermail/openembedded-core/2016-January/116109.html
>> > which is from 2016. Busybox has this runlevel applet available from 2005.
>> >
>> > I think, Raj was trying to make this system really tiny. So, I am not
>> > sure, what would be the impact, if we dropped this runlevel script.
>>
>> OK, fair enough. I don't use busybox init anyway.
>>
>> I was just curious, because there is also runlevel from upstart which we were
>> using (and I have u-a for runlevel in busybox.bbappend because of that).
>> So I was surprised that there is actually 3rd implementation as OE
>> specific shell script.
>
>
> Khem, do you have an opinion?  I suspect that shell script including comment is longer than the compiled size of the runlevel applet in busybox...  We could simplify by just having the applet and removing that runlevel stub.

we should enable runlevel unconditionally when selecting busybox init
and delete the file that I added for runlevel, that way we will be
inline with busybox for this applet.

>
> Ross


  reply	other threads:[~2018-10-08 15:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 10:41 [PATCH] busybox: fix conflict with runlevel applet Andrej Valek
2018-10-04 10:48 ` Martin Jansa
2018-10-04 10:59   ` Andrej Valek
2018-10-04 11:27     ` Martin Jansa
2018-10-08 15:39       ` Burton, Ross
2018-10-08 15:44         ` Khem Raj [this message]
2018-10-09  7:38           ` [PATCH v2 1/3] " Andrej Valek
2018-10-09 10:51             ` Burton, Ross
2018-10-09 10:59               ` [PATCH v3 " Andrej Valek
2018-10-09 10:59               ` [PATCH v3 2/3] busybox: do not write grep outputs into log Andrej Valek
2018-10-09 10:59               ` [PATCH v3 3/3] busybox: unify recipe style Andrej Valek
2018-10-09  7:38           ` [PATCH v2 2/3] busybox: do not write grep outputs into log Andrej Valek
2018-10-09  7:38           ` [PATCH v2 3/3] busybox: unify recipe style Andrej Valek
2018-10-09 11:07 ` ✗ patchtest: failure for busybox: fix conflict with runlevel applet (rev4) Patchwork
2018-10-09 11:07 ` ✗ patchtest: failure for busybox: fix conflict with runlevel applet (rev5) Patchwork
2018-10-09 12:55 ` [PATCH v4 0/3] busybox: refactor Andrej Valek
2018-10-09 12:56 ` [PATCH v4 1/3] busybox: fix conflict with runlevel applet Andrej Valek
2018-10-09 12:56 ` [PATCH v4 2/3] busybox: do not write grep outputs into log Andrej Valek
2018-10-09 12:56 ` [PATCH v4 3/3] busybox: unify recipe style Andrej Valek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMKF1souez4aWHQx3pgKjoqAuhh0xQ0cyYSPWiwmo4spqB+_mw@mail.gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.