[PATCH] devshell: start in ${B} not ${S}

[PATCH] devshell: start in ${B} not ${S}

[Ross Burton]

When S=B this is a no-op, but when B!=S this means you can run make and so on
without having to change directory first.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/classes/devshell.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/devshell.bbclass b/meta/classes/devshell.bbclass
index 41164a3..051ab72 100644
--- a/meta/classes/devshell.bbclass
+++ b/meta/classes/devshell.bbclass
@@ -17,7 +17,7 @@ python do_devshell () {
 
 addtask devshell after do_patch
 
-do_devshell[dirs] = "${S}"
+do_devshell[dirs] = "${B}"
 do_devshell[nostamp] = "1"
 
 # devshell and fakeroot/pseudo need careful handling since only the final
-- 
1.7.10.4

Re: [PATCH] devshell: start in ${B} not ${S}

[Andre McCurdy]

On Tue, Mar 10, 2015 at 10:50 AM, Ross Burton <ross.burton@intel.com> wrote:
> When S=B this is a no-op, but when B!=S this means you can run make and so on
> without having to change directory first.

Just my opinion, but I'd vote against this change. Running
"../temp/run.do_compile" works from either directory but editing
sources and running "quilt refresh" etc only works from ${S}.

>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/classes/devshell.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/devshell.bbclass b/meta/classes/devshell.bbclass
> index 41164a3..051ab72 100644
> --- a/meta/classes/devshell.bbclass
> +++ b/meta/classes/devshell.bbclass
> @@ -17,7 +17,7 @@ python do_devshell () {
>
>  addtask devshell after do_patch
>
> -do_devshell[dirs] = "${S}"
> +do_devshell[dirs] = "${B}"
>  do_devshell[nostamp] = "1"
>
>  # devshell and fakeroot/pseudo need careful handling since only the final
> --
> 1.7.10.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] devshell: start in ${B} not ${S}

[Otavio Salvador]

On Tue, Mar 10, 2015 at 3:57 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Tue, Mar 10, 2015 at 10:50 AM, Ross Burton <ross.burton@intel.com> wrote:
>> When S=B this is a no-op, but when B!=S this means you can run make and so on
>> without having to change directory first.
>
> Just my opinion, but I'd vote against this change. Running
> "../temp/run.do_compile" works from either directory but editing
> sources and running "quilt refresh" etc only works from ${S}.

+1

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] devshell: start in ${B} not ${S}

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

On 10 March 2015 at 19:53, Otavio Salvador <otavio@ossystems.com.br> wrote:

> > Just my opinion, but I'd vote against this change. Running
> > "../temp/run.do_compile" works from either directory but editing
> > sources and running "quilt refresh" etc only works from ${S}.
>
> +1


Clearly I'm the only person who mainly does build testing and not source
patching in a devshell :)

Ross

[-- Attachment #2: Type: text/html, Size: 803 bytes --]