[PATCH] speex: upgrade 1.2rc2 -> 1.2.0

[PATCH] speex: upgrade 1.2rc2 -> 1.2.0

[Marc Ferland]

Upgrade speex to 1.2.0. Very small diff between 1.2rc2 and 1.2.0, mostly
compiler warning fixes, tabs vs spaces, trailing whitespaces and one
liners.

Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
---
 meta/recipes-multimedia/speex/speex_1.2.0.bb  | 19 +++++++++++++++++++
 meta/recipes-multimedia/speex/speex_1.2rc2.bb | 19 -------------------
 2 files changed, 19 insertions(+), 19 deletions(-)
 create mode 100644 meta/recipes-multimedia/speex/speex_1.2.0.bb
 delete mode 100644 meta/recipes-multimedia/speex/speex_1.2rc2.bb

diff --git a/meta/recipes-multimedia/speex/speex_1.2.0.bb b/meta/recipes-multimedia/speex/speex_1.2.0.bb
new file mode 100644
index 0000000..fc020a2
--- /dev/null
+++ b/meta/recipes-multimedia/speex/speex_1.2.0.bb
@@ -0,0 +1,19 @@
+SUMMARY = "Speech Audio Codec"
+DESCRIPTION = "Speex is an Open Source/Free Software patent-free audio compression format designed for speech."
+HOMEPAGE = "http://www.speex.org"
+SECTION = "libs"
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://COPYING;md5=314649d8ba9dd7045dfb6683f298d0a8 \
+                    file://include/speex/speex.h;beginline=1;endline=34;md5=ef8c8ea4f7198d71cf3509c6ed05ea50"
+DEPENDS = "libogg speexdsp"
+
+SRC_URI = "http://downloads.us.xiph.org/releases/speex/speex-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "8ab7bb2589110dfaf0ed7fa7757dc49c"
+SRC_URI[sha256sum] = "eaae8af0ac742dc7d542c9439ac72f1f385ce838392dc849cae4536af9210094"
+
+inherit autotools pkgconfig lib_package
+
+EXTRA_OECONF = "\
+        ${@bb.utils.contains('TARGET_FPU', 'soft', '--enable-fixed-point --disable-float-api --disable-vbr', '', d)} \
+"
diff --git a/meta/recipes-multimedia/speex/speex_1.2rc2.bb b/meta/recipes-multimedia/speex/speex_1.2rc2.bb
deleted file mode 100644
index f7d23db..0000000
--- a/meta/recipes-multimedia/speex/speex_1.2rc2.bb
+++ /dev/null
@@ -1,19 +0,0 @@
-SUMMARY = "Speech Audio Codec"
-DESCRIPTION = "Speex is an Open Source/Free Software patent-free audio compression format designed for speech."
-HOMEPAGE = "http://www.speex.org"
-SECTION = "libs"
-LICENSE = "BSD"
-LIC_FILES_CHKSUM = "file://COPYING;md5=314649d8ba9dd7045dfb6683f298d0a8 \
-                    file://include/speex/speex.h;beginline=1;endline=34;md5=ef8c8ea4f7198d71cf3509c6ed05ea50"
-DEPENDS = "libogg speexdsp"
-
-SRC_URI = "http://downloads.us.xiph.org/releases/speex/speex-${PV}.tar.gz"
-
-SRC_URI[md5sum] = "6ae7db3bab01e1d4b86bacfa8ca33e81"
-SRC_URI[sha256sum] = "caa27c7247ff15c8521c2ae0ea21987c9e9710a8f2d3448e8b79da9806bce891"
-
-inherit autotools pkgconfig lib_package
-
-EXTRA_OECONF = "\
-        ${@bb.utils.contains('TARGET_FPU', 'soft', '--enable-fixed-point --disable-float-api --disable-vbr', '', d)} \
-"
-- 
2.7.4

Re: [PATCH] speex: upgrade 1.2rc2 -> 1.2.0

[Tanu Kaskinen]

On Thu, 2017-04-27 at 11:39 -0400, Marc Ferland wrote:
> Upgrade speex to 1.2.0. Very small diff between 1.2rc2 and 1.2.0, mostly
> compiler warning fixes, tabs vs spaces, trailing whitespaces and one
> liners.
> 
> Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
> ---
>  meta/recipes-multimedia/speex/speex_1.2.0.bb  | 19 +++++++++++++++++++
>  meta/recipes-multimedia/speex/speex_1.2rc2.bb | 19 -------------------
>  2 files changed, 19 insertions(+), 19 deletions(-)
>  create mode 100644 meta/recipes-multimedia/speex/speex_1.2.0.bb
>  delete mode 100644 meta/recipes-multimedia/speex/speex_1.2rc2.bb
> 
> diff --git a/meta/recipes-multimedia/speex/speex_1.2.0.bb b/meta/recipes-multimedia/speex/speex_1.2.0.bb
> new file mode 100644
> index 0000000..fc020a2
> --- /dev/null
> +++ b/meta/recipes-multimedia/speex/speex_1.2.0.bb
> @@ -0,0 +1,19 @@
> +SUMMARY = "Speech Audio Codec"
> +DESCRIPTION = "Speex is an Open Source/Free Software patent-free audio compression format designed for speech."
> +HOMEPAGE = "http://www.speex.org"
> +SECTION = "libs"
> +LICENSE = "BSD"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=314649d8ba9dd7045dfb6683f298d0a8 \
> +                    file://include/speex/speex.h;beginline=1;endline=34;md5=ef8c8ea4f7198d71cf3509c6ed05ea50"
> +DEPENDS = "libogg speexdsp"
> +
> +SRC_URI = "http://downloads.us.xiph.org/releases/speex/speex-${PV}.tar.gz"
> +
> +SRC_URI[md5sum] = "8ab7bb2589110dfaf0ed7fa7757dc49c"
> +SRC_URI[sha256sum] = "eaae8af0ac742dc7d542c9439ac72f1f385ce838392dc849cae4536af9210094"
> +
> +inherit autotools pkgconfig lib_package
> +
> +EXTRA_OECONF = "\
> +        ${@bb.utils.contains('TARGET_FPU', 'soft', '--enable-fixed-point --disable-float-api --disable-vbr', '', d)} \
> +"
> diff --git a/meta/recipes-multimedia/speex/speex_1.2rc2.bb b/meta/recipes-multimedia/speex/speex_1.2rc2.bb
> deleted file mode 100644
> index f7d23db..0000000
> --- a/meta/recipes-multimedia/speex/speex_1.2rc2.bb
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -SUMMARY = "Speech Audio Codec"
> -DESCRIPTION = "Speex is an Open Source/Free Software patent-free audio compression format designed for speech."
> -HOMEPAGE = "http://www.speex.org"
> -SECTION = "libs"
> -LICENSE = "BSD"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=314649d8ba9dd7045dfb6683f298d0a8 \
> -                    file://include/speex/speex.h;beginline=1;endline=34;md5=ef8c8ea4f7198d71cf3509c6ed05ea50"
> -DEPENDS = "libogg speexdsp"
> -
> -SRC_URI = "http://downloads.us.xiph.org/releases/speex/speex-${PV}.tar.gz"
> -
> -SRC_URI[md5sum] = "6ae7db3bab01e1d4b86bacfa8ca33e81"
> -SRC_URI[sha256sum] = "caa27c7247ff15c8521c2ae0ea21987c9e9710a8f2d3448e8b79da9806bce891"
> -
> -inherit autotools pkgconfig lib_package
> -
> -EXTRA_OECONF = "\
> -        ${@bb.utils.contains('TARGET_FPU', 'soft', '--enable-fixed-point --disable-float-api --disable-vbr', '', d)} \
> -"
> -- 
> 2.7.4

Oh, I'm on speex-dev, and I missed the announcement of the new
version... The recipe reporting system didn't notice the new version
either, probably because it thought "1.2.0" is less than "1.2rc2". I
wonder if this will be a problem for package managers too...

It's hard to see from the patch what you changed. I've sent a couple of
similar patches before I discovered the diff.renames option in git. I
recommend you set diff.renames to "true" in your git configuration.

-- 
Tanu

https://www.patreon.com/tanuk

Re: [PATCH] speex: upgrade 1.2rc2 -> 1.2.0

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On 28 April 2017 at 14:15, Tanu Kaskinen <tanuk@iki.fi> wrote:

> Oh, I'm on speex-dev, and I missed the announcement of the new
> version... The recipe reporting system didn't notice the new version
> either, probably because it thought "1.2.0" is less than "1.2rc2". I
> wonder if this will be a problem for package managers too...
>

dpkg thinks that 1.2rc2 is less than 1.2.0, I suspect the RRS doesn't use
the same algorithm.  Not sure what opkg and dpkg think of it.

(1.2rc2 was a badly chosen version for the recipe and we should have
noticed)

Ross

[-- Attachment #2: Type: text/html, Size: 1067 bytes --]

Re: [PATCH] speex: upgrade 1.2rc2 -> 1.2.0

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

On 28 April 2017 at 14:58, Burton, Ross <ross.burton@intel.com> wrote:

> dpkg thinks that 1.2rc2 is less than 1.2.0, I suspect the RRS doesn't use
> the same algorithm.  Not sure what opkg and dpkg think of it.
>

I meant opkg and rpm, obviously.

Good news is that RPM says 1.2rc2 < 1.2.0 too.

Ross

[-- Attachment #2: Type: text/html, Size: 789 bytes --]

Re: [PATCH] speex: upgrade 1.2rc2 -> 1.2.0

[Marc Ferland]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

On Fri, Apr 28, 2017 at 12:30 PM, Burton, Ross <ross.burton@intel.com>
wrote:

>
> On 28 April 2017 at 14:58, Burton, Ross <ross.burton@intel.com> wrote:
>
>> dpkg thinks that 1.2rc2 is less than 1.2.0, I suspect the RRS doesn't use
>> the same algorithm.  Not sure what opkg and dpkg think of it.
>>
>
> I meant opkg and rpm, obviously.
>
> Good news is that RPM says 1.2rc2 < 1.2.0 too.
>


Looks good with opkg:

$ opkg compare-versions '1.2rc2' '<<' '1.2.0'; echo $?
0

Tested with opkg HEAD revision. I also tested with 0.3.0 but it seems the
'compare-versions' command was broken...

Marc

[-- Attachment #2: Type: text/html, Size: 1411 bytes --]

Re: [PATCH] speex: upgrade 1.2rc2 -> 1.2.0

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

On 28 April 2017 at 19:01, Marc Ferland <ferlandm@amotus.ca> wrote:

> Tested with opkg HEAD revision. I also tested with 0.3.0 but it seems the
> 'compare-versions' command was broken...
>

Thanks for verifying.

Yes, it was.  I tried writing a test case for this last year, discovered
that opkg had three commands to check version that behaved differently, and
rpm5 had no programmatic way of accessing the comparison logic...

Ross

[-- Attachment #2: Type: text/html, Size: 804 bytes --]