* [PATCH] insane: add sanity checks to SRC_URI
@ 2019-05-17 22:48 Ross Burton
[not found] ` <c400aa2a-4685-edd7-88ce-dcf5f13d4349@mikrodidakt.se>
0 siblings, 1 reply; 2+ messages in thread
From: Ross Burton @ 2019-05-17 22:48 UTC (permalink / raw)
To: openembedded-core
The SRC_URI almost definitely shouldn't be using ${BPN}, and GitHub */archive/*
tarballs are dynamically generated so the checksums will change over time.
Detect both of these, and emit a QA warning if found.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
meta/classes/insane.bbclass | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 9ca5aefe544..59bb8be5470 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -25,7 +25,7 @@ QA_SANE = "True"
WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \
textrel already-stripped incompatible-license files-invalid \
installed-vs-shipped compile-host-path install-host-path \
- pn-overrides infodir build-deps \
+ pn-overrides infodir build-deps src-uri-bad \
unknown-configure-option symlink-to-sysroot multilib \
invalid-packageconfig host-user-contaminated uppercase-pn patch-fuzz \
"
@@ -898,6 +898,17 @@ def package_qa_check_host_user(path, name, d, elf, messages):
return False
return True
+QARECIPETEST[src-uri-bad] = "package_qa_check_src_uri"
+def package_qa_check_src_uri(pn, d, messages):
+ import re
+
+ if "${PN}" in d.getVar("SRC_URI", False):
+ package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn, d)
+
+ pn = d.getVar("SRC_URI")
+ if re.search(r"github\.com/.+/.+/archive/.+", pn):
+ package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d)
+
# The PACKAGE FUNC to scan each package
python do_package_qa () {
--
2.20.1 (Apple Git-117)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] insane: add sanity checks to SRC_URI
[not found] ` <c400aa2a-4685-edd7-88ce-dcf5f13d4349@mikrodidakt.se>
@ 2019-05-17 23:38 ` Burton, Ross
0 siblings, 0 replies; 2+ messages in thread
From: Burton, Ross @ 2019-05-17 23:38 UTC (permalink / raw)
To: Jacob Kroon; +Cc: openembedded-core
On Fri, 17 May 2019 at 16:24, Jacob Kroon <jacob.kroon@mikrodidakt.se> wrote:
> On 5/18/19 12:48 AM, Ross Burton wrote:
> > The SRC_URI almost definitely shouldn't be using ${BPN}, and GitHub */archive/*
> "... shouldn't be using ${PN} ..." ?
Whoops! Fixed.
Ross
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-17 23:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-17 22:48 [PATCH] insane: add sanity checks to SRC_URI Ross Burton
[not found] ` <c400aa2a-4685-edd7-88ce-dcf5f13d4349@mikrodidakt.se>
2019-05-17 23:38 ` Burton, Ross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.