* [PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional
@ 2019-03-07 13:18 Max Kellermann
2019-03-07 13:23 ` Burton, Ross
0 siblings, 1 reply; 4+ messages in thread
From: Max Kellermann @ 2019-03-07 13:18 UTC (permalink / raw)
To: openembedded-core; +Cc: Max Kellermann
From: Max Kellermann <max.kellermann@gmail.com>
Signed-off-by: Max Kellermann <max.kellermann@gmail.com>
---
meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb b/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
index eb2c719d8d..7b5eb4f71c 100644
--- a/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
+++ b/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
@@ -1,7 +1,7 @@
SUMMARY = "Audio format Conversion library"
HOMEPAGE = "http://www.mega-nerd.com/libsndfile"
AUTHOR = "Erik de Castro Lopo"
-DEPENDS = "flac libogg libvorbis sqlite3"
+DEPENDS = ""
SECTION = "libs/multimedia"
LICENSE = "LGPLv2.1"
@@ -27,8 +27,10 @@ CVE_PRODUCT = "libsndfile"
S = "${WORKDIR}/libsndfile-${PV}"
-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'alsa', d)}"
+PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'alsa', d)} sqlite external-libs"
PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
+PACKAGECONFIG[sqlite] = "--enable-sqlite,--disable-sqlite,sqlite3"
+PACKAGECONFIG[external-libs] = "--enable-external-libs,--disable-external-libs,flac libogg libvorbis"
inherit autotools lib_package pkgconfig
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional
2019-03-07 13:18 [PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional Max Kellermann
@ 2019-03-07 13:23 ` Burton, Ross
2019-03-07 13:27 ` Max Kellermann
0 siblings, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2019-03-07 13:23 UTC (permalink / raw)
To: Max Kellermann; +Cc: Max Kellermann, OE-core
I just double-took at the sqlite dependency. This is only used by a
testing tool that we don't build or install.
How about renaming the option to regtest and disabling by default?
Ross
On Thu, 7 Mar 2019 at 13:18, Max Kellermann <max+openembedded@blarg.de> wrote:
>
> From: Max Kellermann <max.kellermann@gmail.com>
>
> Signed-off-by: Max Kellermann <max.kellermann@gmail.com>
> ---
> meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb b/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
> index eb2c719d8d..7b5eb4f71c 100644
> --- a/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
> +++ b/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
> @@ -1,7 +1,7 @@
> SUMMARY = "Audio format Conversion library"
> HOMEPAGE = "http://www.mega-nerd.com/libsndfile"
> AUTHOR = "Erik de Castro Lopo"
> -DEPENDS = "flac libogg libvorbis sqlite3"
> +DEPENDS = ""
> SECTION = "libs/multimedia"
> LICENSE = "LGPLv2.1"
>
> @@ -27,8 +27,10 @@ CVE_PRODUCT = "libsndfile"
>
> S = "${WORKDIR}/libsndfile-${PV}"
>
> -PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'alsa', d)}"
> +PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'alsa', d)} sqlite external-libs"
> PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> +PACKAGECONFIG[sqlite] = "--enable-sqlite,--disable-sqlite,sqlite3"
> +PACKAGECONFIG[external-libs] = "--enable-external-libs,--disable-external-libs,flac libogg libvorbis"
>
> inherit autotools lib_package pkgconfig
>
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional
2019-03-07 13:23 ` Burton, Ross
@ 2019-03-07 13:27 ` Max Kellermann
2019-03-07 13:28 ` Burton, Ross
0 siblings, 1 reply; 4+ messages in thread
From: Max Kellermann @ 2019-03-07 13:27 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 2019/03/07 14:23, "Burton, Ross" <ross.burton@intel.com> wrote:
> I just double-took at the sqlite dependency. This is only used by a
> testing tool that we don't build or install.
>
> How about renaming the option to regtest and disabling by default?
What do you think about disabling it unconditionally?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional
2019-03-07 13:27 ` Max Kellermann
@ 2019-03-07 13:28 ` Burton, Ross
0 siblings, 0 replies; 4+ messages in thread
From: Burton, Ross @ 2019-03-07 13:28 UTC (permalink / raw)
To: Burton, Ross, OE-core
On Thu, 7 Mar 2019 at 13:27, Max Kellermann <max+openembedded@blarg.de> wrote:
> > How about renaming the option to regtest and disabling by default?
>
> What do you think about disabling it unconditionally?
I wouldn't object.
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-07 13:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07 13:18 [PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional Max Kellermann
2019-03-07 13:23 ` Burton, Ross
2019-03-07 13:27 ` Max Kellermann
2019-03-07 13:28 ` Burton, Ross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.