how to configure the build packages of a makefile based libary

how to configure the build packages of a makefile based libary

[S.Jaritz]

[-- Attachment #1: Type: text/plain, Size: 1928 bytes --]

Hej

I like to include the hiredis library. I created a recipe and modified the 
EXTRA_OEMAKE. The compilation works (in the git directory object, "so" and 
"a" files are generated). But the generated files are not placed into 
packages.

Any ideas?

below there is the "libhiredis.bb" file:
#########
SUMMARY = "libhiredis"
SECTION = "sek4"
LICENSE = "COPYING"
LIC_FILES_CHKSUM = "file://$
{WORKDIR}/git/COPYING;md5=d84d659a35c666d23233e54503aaea51"

# 0.13.3
# SRCREV = "010756025e8cefd1bc66c6d4ed3b1648ef6f1f95"
SRC_URI = "git://github.com/redis/hiredis.git;rev=v0.13.3"

S = "${WORKDIR}/git/"

# we need to pass the Cxx parameter extra to the make call
EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} 
-I${S}/include' 'BUILDDIR=${S}'"
#########

Regards!
Stefan

------------------------------------------------------------
ESA Elektroschaltanlagen Grimma GmbH
Broner Ring 30
04668 Grimma
Telefon: +49 3437 9211 176
Telefax: +49 3437 9211 26
E-Mail: s.jaritz@esa-grimma.de
Internet: www.esa-grimma.de


Geschäftsführer:
Dipl.-Ing. Jörg Gaitzsch
Jörg Reinker

Sitz der Gesellschaft: Grimma
Ust.-ID: DE 141784437
Amtsgericht: Leipzig, HRB 5159
Steuernummer: 238/108/00755


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte 
Informationen. 
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich 
erhalten 
haben, informieren Sie bitte sofort den Absender und löschen Sie diese 
Nachricht. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser 
Mail 
ist nicht gestattet.

This e-mail may contain confidential and/or privileged information. If you 
are 
not the intended recipient (or have received this e-mail in error) please 
notify the sender immediately and destroy this e-mail. Any unauthorized 
copying, disclosure or distribution of the material in this e-mail is 
strictly 
forbidden.

[-- Attachment #2: Type: text/html, Size: 3195 bytes --]

Re: how to configure the build packages of a makefile based libary

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

On 28 April 2016 at 10:50, <S.Jaritz@esa-grimma.de> wrote:

> I like to include the hiredis library. I created a recipe and modified the
> EXTRA_OEMAKE. The compilation works (in the git directory object, "so" and
> "a" files are generated). But the generated files are not placed into
> packages.
>
> Any ideas?
>

You need to look at the makefile to see if it has an install target, and if
it does what it's called, and if it has a way of controlling where files
actually go (both respecting $prefix instead of /usr, and letting you
relocate via ${D} so it doesn't try and install to /usr on your build
machine).  If it does all of those right then you can write a do_install()
that just calls the right make commands.  Chances are that it does
something wrong and it's easier to just write a do_install() that creates
directories and copies files manually.

This is why it doesn't happen automatically unless you're using something
like automake - there's no standard way.

Ross

[-- Attachment #2: Type: text/html, Size: 1539 bytes --]

Re: how to configure the build packages of a makefile based libary

[S.Jaritz]

[-- Attachment #1: Type: text/plain, Size: 5042 bytes --]

Hej

The makefile has an install section. I relocated it with the ${D}. By 
doing that I managed that the compiler filled the "package" directory. But 
there is still a packing issue.
Below is the log (and below of it is the libhiredis.bb).

Now my question: How to define the FILES variable for a proper packing?

#### log ######
NOTE: Executing RunQueue Tasks
WARNING: libhiredis: No generic license file exists for: COPYING in any 
provider
ERROR: QA Issue: libhiredis: Files/directories were installed but not 
shipped in any package:
  /usr/local
  /usr/local/lib
  /usr/local/include
  /usr/local/lib/libhiredis.so
  /usr/local/lib/libhiredis.so.0.13
  /usr/local/lib/libhiredis.a
  /usr/local/lib/.debug
  /usr/local/lib/pkgconfig
  /usr/local/lib/.debug/libhiredis.so.0.13
  /usr/local/lib/pkgconfig/hiredis.pc
  /usr/local/include/hiredis
  /usr/local/include/hiredis/sds.h
  /usr/local/include/hiredis/read.h
  /usr/local/include/hiredis/async.h
  /usr/local/include/hiredis/hiredis.h
  /usr/local/include/hiredis/adapters
  /usr/local/include/hiredis/adapters/glib.h
  /usr/local/include/hiredis/adapters/macosx.h
  /usr/local/include/hiredis/adapters/libev.h
  /usr/local/include/hiredis/adapters/libevent.h
  /usr/local/include/hiredis/adapters/qt.h
  /usr/local/include/hiredis/adapters/libuv.h
  /usr/local/include/hiredis/adapters/ae.h
  /usr/local/include/hiredis/adapters/ivykis.h
Please set FILES such that these items are packaged. Alternatively if they 
are unneeded, avoid installing them or delete them within do_install.
libhiredis: 24 installed and not shipped files. [installed-vs-shipped]
NOTE: Tasks Summary: Attempted 388 tasks of which 375 didn't need to be 
rerun and all succeeded.

Summary: There were 2 WARNING messages shown.
Summary: There was 1 ERROR message shown, returning a non-zero exit code.
#### end of log ######

#### libhiredis ######
SUMMARY = "libhiredis"
SECTION = "sek4"
LICENSE = "COPYING"
LIC_FILES_CHKSUM = "file://$
{WORKDIR}/git/COPYING;md5=d84d659a35c666d23233e54503aaea51"

# 0.13.3
# SRCREV = "010756025e8cefd1bc66c6d4ed3b1648ef6f1f95"
SRC_URI = "git://github.com/redis/hiredis.git;rev=v0.13.3"

S = "${WORKDIR}/git/"

# we need to pass the Cxx parameter extra to the make call
EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} 
-I${S}/include' 'BUILDDIR=${S}' 'DESTDIR=${D}'"

inherit autotools-brokensep

do_compile() {
        oe_runmake all 'CC=${CC}'
}

do_install() {
        oe_runmake install 'DESTDIR=${D}'
}
#### libhiredis of log ######


with kind regards

Stefan Jaritz

Entwickler

------------------------------------------------------------
ESA Elektroschaltanlagen Grimma GmbH
Broner Ring 30
04668 Grimma
Telefon: +49 3437 9211 176
Telefax: +49 3437 9211 26
E-Mail: s.jaritz@esa-grimma.de
Internet: www.esa-grimma.de


Geschäftsführer:
Dipl.-Ing. Jörg Gaitzsch
Jörg Reinker

Sitz der Gesellschaft: Grimma
Ust.-ID: DE 141784437
Amtsgericht: Leipzig, HRB 5159
Steuernummer: 238/108/00755


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte 
Informationen. 
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich 
erhalten 
haben, informieren Sie bitte sofort den Absender und löschen Sie diese 
Nachricht. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser 
Mail 
ist nicht gestattet.

This e-mail may contain confidential and/or privileged information. If you 
are 
not the intended recipient (or have received this e-mail in error) please 
notify the sender immediately and destroy this e-mail. Any unauthorized 
copying, disclosure or distribution of the material in this e-mail is 
strictly 
forbidden.



Von:    "Burton, Ross" <ross.burton@intel.com>
An:     S.Jaritz@esa-grimma.de
Kopie:  "yocto@yoctoproject.org" <yocto@yoctoproject.org>
Datum:  28.04.2016 12:52
Betreff:        Re: [yocto] how to configure the build packages of a 
makefile based libary




On 28 April 2016 at 10:50, <S.Jaritz@esa-grimma.de> wrote:
I like to include the hiredis library. I created a recipe and modified the 
EXTRA_OEMAKE. The compilation works (in the git directory object, "so" and 
"a" files are generated). But the generated files are not placed into 
packages. 

Any ideas? 

You need to look at the makefile to see if it has an install target, and 
if it does what it's called, and if it has a way of controlling where 
files actually go (both respecting $prefix instead of /usr, and letting 
you relocate via ${D} so it doesn't try and install to /usr on your build 
machine).  If it does all of those right then you can write a do_install() 
that just calls the right make commands.  Chances are that it does 
something wrong and it's easier to just write a do_install() that creates 
directories and copies files manually.

This is why it doesn't happen automatically unless you're using something 
like automake - there's no standard way.

Ross

[-- Attachment #2: Type: text/html, Size: 9228 bytes --]

Re: how to configure the build packages of a makefile based libary

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

On 28 April 2016 at 13:09, <S.Jaritz@esa-grimma.de> wrote:

> ERROR: QA Issue: libhiredis: Files/directories were installed but not
> shipped in any package:
>   /usr/local
>

It either hard-codes /usr/local as the prefix, or if it respects a prefix
variable you should also pass in ${prefix} ${libdir} ${includedir} and so
on.

Ross

[-- Attachment #2: Type: text/html, Size: 780 bytes --]

Re: how to configure the build packages of a makefile based libary

[Fred Ollinger]

Add to bb recipe:


FILES_${PN} += "/usr/local"


Section 9.2:


https://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html#qa-errors-and-warnings



________________________________
From: yocto-bounces@yoctoproject.org <yocto-bounces@yoctoproject.org> on behalf of Burton, Ross <ross.burton@intel.com>
Sent: Thursday, April 28, 2016 5:44 AM
To: S.Jaritz@esa-grimma.de
Cc: yocto@yoctoproject.org
Subject: Re: [yocto] how to configure the build packages of a makefile based libary


On 28 April 2016 at 13:09, <S.Jaritz@esa-grimma.de<mailto:S.Jaritz@esa-grimma.de>> wrote:
ERROR: QA Issue: libhiredis: Files/directories were installed but not shipped in any package:
  /usr/local

It either hard-codes /usr/local as the prefix, or if it respects a prefix variable you should also pass in ${prefix} ${libdir} ${includedir} and so on.

Ross

Re: how to configure the build packages of a makefile based libary

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

On 28 April 2016 at 16:25, Fred Ollinger <Fred.Ollinger@seescan.com> wrote:

> FILES_${PN} += "/usr/local"
>

Please don't do this unless that's actually what you want - nothing else in
the image will be using those paths so eg libraries in there might not be
found.

Ross

[-- Attachment #2: Type: text/html, Size: 693 bytes --]

Antwort: Re: how to configure the build packages of a makefile based libary

[S.Jaritz]

[-- Attachment #1: Type: text/plain, Size: 3769 bytes --]

Hej

sorry - that does not work. Maybe you can show me some working/common 
code.

Do I have to create the FILE_${PV} or/and FILE_${PV}-dev, 
FILE_${PV}-static?

The builded files go into the Git dir & the autotools-brokensep is 
generating the package dir. I repeat my question: What are the commands in 
the bb file to build the packages (release, static, dev, whatever ...)?

Sorry - I do not understand at all the steps and theire parameters to 
build a libary. Is there somewhere an example given?

Below my bb file and the console error print.

#### libhiredis ####
SUMMARY = "libhiredis"
SECTION = "sek4"
LICENSE = "COPYING"
LIC_FILES_CHKSUM = "file://$
{WORKDIR}/git/COPYING;md5=d84d659a35c666d23233e54503aaea51"

# 0.13.3
# SRCREV = "010756025e8cefd1bc66c6d4ed3b1648ef6f1f95"
SRC_URI = "git://github.com/redis/hiredis.git;rev=v0.13.3"

S = "${WORKDIR}/git/"

# we need to pass the Cxx parameter extra to the make call
EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} 
-I${S}/include' 'BUILDDIR=${S}' 'DESTDIR=${D}'"

inherit autotools-brokensep

do_compile() {
        oe_runmake all 'CC=${CC}'
}

do_install() {
        oe_runmake install 'DESTDIR=${D}'
}
FILES_${PN} += "/user/local"
########

### consol error ###
ERROR: QA Issue: libhiredis: Files/directories were installed but not 
shipped in any package:
  /usr/local
  /usr/local/lib
  /usr/local/include
  /usr/local/lib/libhiredis.so
  /usr/local/lib/libhiredis.so.0.13
  /usr/local/lib/libhiredis.a
  /usr/local/lib/.debug
  /usr/local/lib/pkgconfig
  /usr/local/lib/.debug/libhiredis.so.0.13
  /usr/local/lib/pkgconfig/hiredis.pc
  /usr/local/include/hiredis
  /usr/local/include/hiredis/sds.h
  /usr/local/include/hiredis/read.h
  /usr/local/include/hiredis/async.h
  /usr/local/include/hiredis/hiredis.h
  /usr/local/include/hiredis/adapters
  /usr/local/include/hiredis/adapters/glib.h
  /usr/local/include/hiredis/adapters/macosx.h
  /usr/local/include/hiredis/adapters/libev.h
  /usr/local/include/hiredis/adapters/libevent.h
  /usr/local/include/hiredis/adapters/qt.h
  /usr/local/include/hiredis/adapters/libuv.h
  /usr/local/include/hiredis/adapters/ae.h
  /usr/local/include/hiredis/adapters/ivykis.h
Please set FILES such that these items are packaged. Alternatively if they 
are unneeded, avoid installing them or delete them within do_install.
libhiredis: 24 installed and not shipped files. [installed-vs-shipped]
NOTE: Tasks Summary: Attempted 388 tasks of which 375 didn't need to be 
rerun and all succeeded.
########
Mit freundlichen Grüßen

Stefan Jaritz
Entwickler

------------------------------------------------------------
ESA Elektroschaltanlagen Grimma GmbH
Broner Ring 30
04668 Grimma
Telefon: +49 3437 9211 176
Telefax: +49 3437 9211 26
E-Mail: s.jaritz@esa-grimma.de
Internet: www.esa-grimma.de


Geschäftsführer:
Dipl.-Ing. Jörg Gaitzsch
Jörg Reinker

Sitz der Gesellschaft: Grimma
Ust.-ID: DE 141784437
Amtsgericht: Leipzig, HRB 5159
Steuernummer: 238/108/00755


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte 
Informationen. 
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich 
erhalten 
haben, informieren Sie bitte sofort den Absender und löschen Sie diese 
Nachricht. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser 
Mail 
ist nicht gestattet.

This e-mail may contain confidential and/or privileged information. If you 
are 
not the intended recipient (or have received this e-mail in error) please 
notify the sender immediately and destroy this e-mail. Any unauthorized 
copying, disclosure or distribution of the material in this e-mail is 
strictly 
forbidden.

[-- Attachment #2: Type: text/html, Size: 6817 bytes --]

Re: how to configure the build packages of a makefile based libary

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

On 28 April 2016 at 17:09, <S.Jaritz@esa-grimma.de> wrote:

> EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS}
> -I${S}/include' 'BUILDDIR=${S}' 'DESTDIR=${D}'"
>

Neater to pass DESTDIR via do_install, so remove DESTDIR from here.

However you want to tell it where PREFIX is, and that goes into the build
files, so add PREFIX=${prefix}.  This will put the install into the right
directory (/usr) instead of the default (/usr/local).


> inherit autotools-brokensep
>

You're not using autotools so don't do this.


> do_compile() {
>         oe_runmake all 'CC=${CC}'
> }
>
> do_install() {
>         oe_runmake install 'DESTDIR=${D}'
> }
>


> FILES_${PN} += "/user/local"


The workaround didn't work as you put "user" instead of "usr", but by
passing PREFIX you can remove this line as pulling all of /usr/local into
PN would break packaging.

Ross

[-- Attachment #2: Type: text/html, Size: 2272 bytes --]

Re: Antwort: Re: how to configure the build packages of a makefile based libary

[Fred Ollinger]

I don't know why that won't work.


Note, if you don't set the PREFIX, they will add /usr/local anyway. Perhaps that's the problem.


Here's the relevant Makefile bits for the others to look at:


# Installation related variables and target
PREFIX?=/usr/local
INCLUDE_PATH?=include/hiredis
LIBRARY_PATH?=lib
PKGCONF_PATH?=pkgconfig
INSTALL_INCLUDE_PATH= $(DESTDIR)$(PREFIX)/$(INCLUDE_PATH)
INSTALL_LIBRARY_PATH= $(DESTDIR)$(PREFIX)/$(LIBRARY_PATH)
INSTALL_PKGCONF_PATH= $(INSTALL_LIBRARY_PATH)/$(PKGCONF_PATH)



install: $(DYLIBNAME) $(STLIBNAME) $(PKGCONFNAME)
    mkdir -p $(INSTALL_INCLUDE_PATH) $(INSTALL_LIBRARY_PATH)
    $(INSTALL) hiredis.h async.h read.h sds.h adapters $(INSTALL_INCLUDE_PATH)
    $(INSTALL) $(DYLIBNAME) $(INSTALL_LIBRARY_PATH)/$(DYLIB_MINOR_NAME)
    cd $(INSTALL_LIBRARY_PATH) && ln -sf $(DYLIB_MINOR_NAME) $(DYLIBNAME)
    $(INSTALL) $(STLIBNAME) $(INSTALL_LIBRARY_PATH)
    mkdir -p $(INSTALL_PKGCONF_PATH)
    $(INSTALL) $(PKGCONFNAME) $(INSTALL_PKGCONF_PATH)


________________________________
From: S.Jaritz@esa-grimma.de <S.Jaritz@esa-grimma.de>
Sent: Thursday, April 28, 2016 9:09 AM
To: Burton, Ross
Cc: Fred Ollinger; yocto@yoctoproject.org
Subject: Antwort: Re: [yocto] how to configure the build packages of a makefile based libary

Hej

sorry - that does not work. Maybe you can show me some working/common code.

Do I have to create the FILE_${PV} or/and FILE_${PV}-dev, FILE_${PV}-static?

The builded files go into the Git dir & the autotools-brokensep is generating the package dir. I repeat my question: What are the commands in the bb file to build the packages (release, static, dev, whatever ...)?

Sorry - I do not understand at all the steps and theire parameters to build a libary. Is there somewhere an example given?

Below my bb file and the console error print.

#### libhiredis ####
SUMMARY = "libhiredis"
SECTION = "sek4"
LICENSE = "COPYING"
LIC_FILES_CHKSUM = "file://$<file://$/>{WORKDIR}/git/COPYING;md5=d84d659a35c666d23233e54503aaea51"

# 0.13.3
# SRCREV = "010756025e8cefd1bc66c6d4ed3b1648ef6f1f95"
SRC_URI = "git://github.com/redis/hiredis.git;rev=v0.13.3"

S = "${WORKDIR}/git/"

# we need to pass the Cxx parameter extra to the make call
EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include' 'BUILDDIR=${S}' 'DESTDIR=${D}'"

inherit autotools-brokensep

do_compile() {
        oe_runmake all 'CC=${CC}'
}

do_install() {
        oe_runmake install 'DESTDIR=${D}'
}
FILES_${PN} += "/user/local"
########

### consol error ###
ERROR: QA Issue: libhiredis: Files/directories were installed but not shipped in any package:
  /usr/local
  /usr/local/lib
  /usr/local/include
  /usr/local/lib/libhiredis.so
  /usr/local/lib/libhiredis.so.0.13
  /usr/local/lib/libhiredis.a
  /usr/local/lib/.debug
  /usr/local/lib/pkgconfig
  /usr/local/lib/.debug/libhiredis.so.0.13
  /usr/local/lib/pkgconfig/hiredis.pc
  /usr/local/include/hiredis
  /usr/local/include/hiredis/sds.h
  /usr/local/include/hiredis/read.h
  /usr/local/include/hiredis/async.h
  /usr/local/include/hiredis/hiredis.h
  /usr/local/include/hiredis/adapters
  /usr/local/include/hiredis/adapters/glib.h
  /usr/local/include/hiredis/adapters/macosx.h
  /usr/local/include/hiredis/adapters/libev.h
  /usr/local/include/hiredis/adapters/libevent.h
  /usr/local/include/hiredis/adapters/qt.h
  /usr/local/include/hiredis/adapters/libuv.h
  /usr/local/include/hiredis/adapters/ae.h
  /usr/local/include/hiredis/adapters/ivykis.h
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libhiredis: 24 installed and not shipped files. [installed-vs-shipped]
NOTE: Tasks Summary: Attempted 388 tasks of which 375 didn't need to be rerun and all succeeded.
########
Mit freundlichen Grüßen

Stefan Jaritz
Entwickler

------------------------------------------------------------
ESA Elektroschaltanlagen Grimma GmbH
Broner Ring 30
04668 Grimma
Telefon: +49 3437 9211 176
Telefax: +49 3437 9211 26
E-Mail: s.jaritz@esa-grimma.de
Internet: www.esa-grimma.de


Geschäftsführer:
Dipl.-Ing. Jörg Gaitzsch
Jörg Reinker

Sitz der Gesellschaft: Grimma
Ust.-ID: DE 141784437
Amtsgericht: Leipzig, HRB 5159
Steuernummer: 238/108/00755


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen.
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten
haben, informieren Sie bitte sofort den Absender und löschen Sie diese
Nachricht. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail
ist nicht gestattet.

This e-mail may contain confidential and/or privileged information. If you are
not the intended recipient (or have received this e-mail in error) please
notify the sender immediately and destroy this e-mail. Any unauthorized
copying, disclosure or distribution of the material in this e-mail is strictly
forbidden.

Re: Antwort: Re: how to configure the build packages of a makefile based libary

[YUKATHARSANI JEYACHANDRA]

[-- Attachment #1: Type: text/plain, Size: 4291 bytes --]

Hi,


Use INSANE_SKIP_${PN} = "installed-vs-shipped"  in your recipe to avoid this error. Orelse, add FILES_${PN} += "/usr/local/" in your recipe.


Thanks and Regards,

Yukatharsani J.

________________________________
From: yocto-bounces@yoctoproject.org <yocto-bounces@yoctoproject.org> on behalf of S.Jaritz@esa-grimma.de <S.Jaritz@esa-grimma.de>
Sent: Thursday, April 28, 2016 12:09:53 PM
To: Burton, Ross
Cc: yocto@yoctoproject.org
Subject: [yocto] Antwort: Re: how to configure the build packages of a makefile based libary

Hej

sorry - that does not work. Maybe you can show me some working/common code.

Do I have to create the FILE_${PV} or/and FILE_${PV}-dev, FILE_${PV}-static?

The builded files go into the Git dir & the autotools-brokensep is generating the package dir. I repeat my question: What are the commands in the bb file to build the packages (release, static, dev, whatever ...)?

Sorry - I do not understand at all the steps and theire parameters to build a libary. Is there somewhere an example given?

Below my bb file and the console error print.

#### libhiredis ####
SUMMARY = "libhiredis"
SECTION = "sek4"
LICENSE = "COPYING"
LIC_FILES_CHKSUM = "file://$<file://$/>{WORKDIR}/git/COPYING;md5=d84d659a35c666d23233e54503aaea51"

# 0.13.3
# SRCREV = "010756025e8cefd1bc66c6d4ed3b1648ef6f1f95"
SRC_URI = "git://github.com/redis/hiredis.git;rev=v0.13.3"

S = "${WORKDIR}/git/"

# we need to pass the Cxx parameter extra to the make call
EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include' 'BUILDDIR=${S}' 'DESTDIR=${D}'"

inherit autotools-brokensep

do_compile() {
        oe_runmake all 'CC=${CC}'
}

do_install() {
        oe_runmake install 'DESTDIR=${D}'
}
FILES_${PN} += "/user/local"
########

### consol error ###
ERROR: QA Issue: libhiredis: Files/directories were installed but not shipped in any package:
  /usr/local
  /usr/local/lib
  /usr/local/include
  /usr/local/lib/libhiredis.so
  /usr/local/lib/libhiredis.so.0.13
  /usr/local/lib/libhiredis.a
  /usr/local/lib/.debug
  /usr/local/lib/pkgconfig
  /usr/local/lib/.debug/libhiredis.so.0.13
  /usr/local/lib/pkgconfig/hiredis.pc
  /usr/local/include/hiredis
  /usr/local/include/hiredis/sds.h
  /usr/local/include/hiredis/read.h
  /usr/local/include/hiredis/async.h
  /usr/local/include/hiredis/hiredis.h
  /usr/local/include/hiredis/adapters
  /usr/local/include/hiredis/adapters/glib.h
  /usr/local/include/hiredis/adapters/macosx.h
  /usr/local/include/hiredis/adapters/libev.h
  /usr/local/include/hiredis/adapters/libevent.h
  /usr/local/include/hiredis/adapters/qt.h
  /usr/local/include/hiredis/adapters/libuv.h
  /usr/local/include/hiredis/adapters/ae.h
  /usr/local/include/hiredis/adapters/ivykis.h
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libhiredis: 24 installed and not shipped files. [installed-vs-shipped]
NOTE: Tasks Summary: Attempted 388 tasks of which 375 didn't need to be rerun and all succeeded.
########
Mit freundlichen Grüßen

Stefan Jaritz
Entwickler

------------------------------------------------------------
ESA Elektroschaltanlagen Grimma GmbH
Broner Ring 30
04668 Grimma
Telefon: +49 3437 9211 176
Telefax: +49 3437 9211 26
E-Mail: s.jaritz@esa-grimma.de
Internet: www.esa-grimma.de


Geschäftsführer:
Dipl.-Ing. Jörg Gaitzsch
Jörg Reinker

Sitz der Gesellschaft: Grimma
Ust.-ID: DE 141784437
Amtsgericht: Leipzig, HRB 5159
Steuernummer: 238/108/00755


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen.
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten
haben, informieren Sie bitte sofort den Absender und löschen Sie diese
Nachricht. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail
ist nicht gestattet.

This e-mail may contain confidential and/or privileged information. If you are
not the intended recipient (or have received this e-mail in error) please
notify the sender immediately and destroy this e-mail. Any unauthorized
copying, disclosure or distribution of the material in this e-mail is strictly
forbidden.

[-- Attachment #2: Type: text/html, Size: 8250 bytes --]

Re: Antwort: Re: how to configure the build packages of a makefile based libary

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On 28 April 2016 at 17:18, YUKATHARSANI JEYACHANDRA <
yukatharsanij@tataelxsi.co.in> wrote:

> Use INSANE_SKIP_${PN} = "installed-vs-shipped"  in your recipe to avoid
> this error. Orelse, add FILES_${PN} += "/usr/local/" in your recipe.
>
> No.

*Only* use installed-vs-shipped if you're incapable of a) packaging the
files or b) deleting the files in a do_install_append.  Skipping that
warning means you won't notice new files being added to the install that
you don't package, which could result in broken packages.

Ross

[-- Attachment #2: Type: text/html, Size: 995 bytes --]

Antwort: Re: Antwort: Re: how to configure the build packages of a makefile based libary

[S.Jaritz]

[-- Attachment #1: Type: text/plain, Size: 3529 bytes --]

Hej

sorry for the user -> usr misswriting. Now the packing works fine. Thanks 
for the help - now I understand much better how makefiles are processed. 
There is only the licence problem left. Are there some common way how to 
handle this?
below goes the bb file.
##############
SUMMARY = "libhiredis"
SECTION = "sek4"
LICENSE = "COPYING"
LIC_FILES_CHKSUM = "file://$
{WORKDIR}/git/COPYING;md5=d84d659a35c666d23233e54503aaea51"

# 0.13.3
# SRCREV = "010756025e8cefd1bc66c6d4ed3b1648ef6f1f95"
SRC_URI = "git://github.com/redis/hiredis.git;rev=v0.13.3"

S = "${WORKDIR}/git/"

EXTRA_OEMAKE = "'PREFIX=/usr/'"

do_compile() {
        oe_runmake all 'CC=${CC}'
}

do_install() {
        oe_runmake install 'DESTDIR=${D}'
}
#############

The commandline outputs:
#############
NOTE: Executing RunQueue Tasks
WARNING: QA Issue: libhiredis: /libhiredis-staticdev/usr/lib/libhiredis.a 
is owned by uid 1000, which is the same as the user running bitbake. This 
may be due to host contamination [host-user-contaminated]
WARNING: QA Issue: libhiredis: /libhiredis/usr/lib/libhiredis.so.0.13 is 
owned by uid 1000, which is the same as the user running bitbake. This may 
be due to host contamination [host-user-contaminated]
WARNING: QA Issue: libhiredis: 
/libhiredis-dev/usr/lib/pkgconfig/hiredis.pc is owned by uid 1000, which 
is the same as the user running bitbake. This may be due to host 
contamination [host-user-contaminated]
#############

regards!

Stefan Jaritz


------------------------------------------------------------
ESA Elektroschaltanlagen Grimma GmbH
Broner Ring 30
04668 Grimma
Telefon: +49 3437 9211 176
Telefax: +49 3437 9211 26
E-Mail: s.jaritz@esa-grimma.de
Internet: www.esa-grimma.de


Geschäftsführer:
Dipl.-Ing. Jörg Gaitzsch
Jörg Reinker

Sitz der Gesellschaft: Grimma
Ust.-ID: DE 141784437
Amtsgericht: Leipzig, HRB 5159
Steuernummer: 238/108/00755


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte 
Informationen. 
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich 
erhalten 
haben, informieren Sie bitte sofort den Absender und löschen Sie diese 
Nachricht. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser 
Mail 
ist nicht gestattet.

This e-mail may contain confidential and/or privileged information. If you 
are 
not the intended recipient (or have received this e-mail in error) please 
notify the sender immediately and destroy this e-mail. Any unauthorized 
copying, disclosure or distribution of the material in this e-mail is 
strictly 
forbidden.



Von:    "Burton, Ross" <ross.burton@intel.com>
An:     YUKATHARSANI JEYACHANDRA <yukatharsanij@tataelxsi.co.in>
Kopie:  "S.Jaritz@esa-grimma.de" <S.Jaritz@esa-grimma.de>, 
"yocto@yoctoproject.org" <yocto@yoctoproject.org>
Datum:  28.04.2016 18:26
Betreff:        Re: [yocto] Antwort: Re: how to configure the build 
packages of a makefile based libary




On 28 April 2016 at 17:18, YUKATHARSANI JEYACHANDRA <
yukatharsanij@tataelxsi.co.in> wrote:
Use INSANE_SKIP_${PN} = "installed-vs-shipped"  in your recipe to avoid 
this error. Orelse, add FILES_${PN} += "/usr/local/" in your recipe.
No.

*Only* use installed-vs-shipped if you're incapable of a) packaging the 
files or b) deleting the files in a do_install_append.  Skipping that 
warning means you won't notice new files being added to the install that 
you don't package, which could result in broken packages.

Ross

[-- Attachment #2: Type: text/html, Size: 6175 bytes --]

Re: Antwort: Re: how to configure the build packages of a makefile based libary

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]

Hi Stefan,

So close :)  Some more points:

On 29 April 2016 at 08:54, <S.Jaritz@esa-grimma.de> wrote:
> LICENSE = "COPYING"

This should be the name of the license itself, not the filename.  Looks a
bit like MIT to me.

> LIC_FILES_CHKSUM =
"file://${WORKDIR}/git/COPYING;md5=d84d659a35c666d23233e54503aaea51"

This URI is relative to ${S} so you can just do file://COPYING;md5=....

> EXTRA_OEMAKE = "'PREFIX=/usr/'"

Use PREFIX=${prefix} to respect the what the distro has configured.
Annoyingly you can't override the other paths such a libdir easily, so this
will break in multilib configurations or if I recall correctly, on aarch64.

The commandline outputs:
> #############
> NOTE: Executing RunQueue Tasks
> WARNING: QA Issue: libhiredis: /libhiredis-staticdev/usr/lib/libhiredis.a
> is owned by uid 1000, which is the same as the user running bitbake. This
> may be due to host contamination [host-user-contaminated]
> WARNING: QA Issue: libhiredis: /libhiredis/usr/lib/libhiredis.so.0.13 is
> owned by uid 1000, which is the same as the user running bitbake. This may
> be due to host contamination [host-user-contaminated]
> WARNING: QA Issue: libhiredis:
> /libhiredis-dev/usr/lib/pkgconfig/hiredis.pc is owned by uid 1000, which is
> the same as the user running bitbake. This may be due to host contamination
> [host-user-contaminated]
> #############
>

The upstream Makefile is using "cp -a" which preserves ownership, so as you
built the package the files are owned by you.  Luckily you can override
this by passing "INSTALL='cp -r' to the make install (they use cp to
recursively copy directories, so you need to pass -r instead).

I've a recipe locally with these changes and it builds without warnings and
is packaged correctly.

This is what happens when maintainers think autotools is too complicated
and a bare makefile is just fine: they do it wrong. :)

Ross

[-- Attachment #2: Type: text/html, Size: 3131 bytes --]

Antwort: Re: Re: Antwort: Re: how to configure the build packages of a makefile based libary

[S.Jaritz]

[-- Attachment #1: Type: text/plain, Size: 4229 bytes --]

Hej

Finally we made it - Thanks to you all for helping me! I attached my bb 
file for that case someone is searching for a bitbake recipe for building 
the libhiredis

##############
SUMMARY = "libhiredis"
SECTION = "lib"
LICENSE = "MIT"
LIC_FILES_CHKSUM = "file://COPYING;md5=d84d659a35c666d23233e54503aaea51"

# 0.13.3
# SRCREV = "010756025e8cefd1bc66c6d4ed3b1648ef6f1f95"
SRC_URI = "git://github.com/redis/hiredis.git;rev=v0.13.3"

S = "${WORKDIR}/git/"

# error handleing
# @PREFIX: set the path from /usr/local to /usr/
# @INSTALL: set the copy instruction from "cp -a" to "cp -r"
EXTRA_OEMAKE = "'PREFIX=${prefix}' 'INSTALL=''cp -r'''"

do_compile() {
        oe_runmake all 'CC=${CC}'
}

do_install() {
        oe_runmake install 'DESTDIR=${D}'
}
##############

regards

Stefan Jaritz
Entwickler

------------------------------------------------------------
ESA Elektroschaltanlagen Grimma GmbH
Broner Ring 30
04668 Grimma
Telefon: +49 3437 9211 176
Telefax: +49 3437 9211 26
E-Mail: s.jaritz@esa-grimma.de
Internet: www.esa-grimma.de


Geschäftsführer:
Dipl.-Ing. Jörg Gaitzsch
Jörg Reinker

Sitz der Gesellschaft: Grimma
Ust.-ID: DE 141784437
Amtsgericht: Leipzig, HRB 5159
Steuernummer: 238/108/00755


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte 
Informationen. 
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich 
erhalten 
haben, informieren Sie bitte sofort den Absender und löschen Sie diese 
Nachricht. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser 
Mail 
ist nicht gestattet.

This e-mail may contain confidential and/or privileged information. If you 
are 
not the intended recipient (or have received this e-mail in error) please 
notify the sender immediately and destroy this e-mail. Any unauthorized 
copying, disclosure or distribution of the material in this e-mail is 
strictly 
forbidden.



Von:    "Burton, Ross" <ross.burton@intel.com>
An:     S.Jaritz@esa-grimma.de
Kopie:  "yocto@yoctoproject.org" <yocto@yoctoproject.org>, YUKATHARSANI 
JEYACHANDRA <yukatharsanij@tataelxsi.co.in>
Datum:  29.04.2016 10:59
Betreff:        Re: Re: [yocto] Antwort: Re: how to configure the build 
packages of a makefile based libary



Hi Stefan,

So close :)  Some more points:

On 29 April 2016 at 08:54, <S.Jaritz@esa-grimma.de> wrote:
> LICENSE = "COPYING"

This should be the name of the license itself, not the filename.  Looks a 
bit like MIT to me.
 
> LIC_FILES_CHKSUM = "file://$
{WORKDIR}/git/COPYING;md5=d84d659a35c666d23233e54503aaea51"

This URI is relative to ${S} so you can just do file://COPYING;md5=....
 
> EXTRA_OEMAKE = "'PREFIX=/usr/'" 

Use PREFIX=${prefix} to respect the what the distro has configured.  
Annoyingly you can't override the other paths such a libdir easily, so 
this will break in multilib configurations or if I recall correctly, on 
aarch64.

The commandline outputs: 
############# 
NOTE: Executing RunQueue Tasks 
WARNING: QA Issue: libhiredis: /libhiredis-staticdev/usr/lib/libhiredis.a 
is owned by uid 1000, which is the same as the user running bitbake. This 
may be due to host contamination [host-user-contaminated] 
WARNING: QA Issue: libhiredis: /libhiredis/usr/lib/libhiredis.so.0.13 is 
owned by uid 1000, which is the same as the user running bitbake. This may 
be due to host contamination [host-user-contaminated] 
WARNING: QA Issue: libhiredis: 
/libhiredis-dev/usr/lib/pkgconfig/hiredis.pc is owned by uid 1000, which 
is the same as the user running bitbake. This may be due to host 
contamination [host-user-contaminated] 
#############  

The upstream Makefile is using "cp -a" which preserves ownership, so as 
you built the package the files are owned by you.  Luckily you can 
override this by passing "INSTALL='cp -r' to the make install (they use cp 
to recursively copy directories, so you need to pass -r instead).

I've a recipe locally with these changes and it builds without warnings 
and is packaged correctly.

This is what happens when maintainers think autotools is too complicated 
and a bare makefile is just fine: they do it wrong. :)

Ross

[-- Attachment #2: Type: text/html, Size: 7606 bytes --]

Re: Antwort: Re: how to configure the build packages of a makefile based libary

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

On 29 April 2016 at 10:59, <S.Jaritz@esa-grimma.de> wrote:

> Finally we made it - Thanks to you all for helping me! I attached my bb
> file for that case someone is searching for a bitbake recipe for building
> the libhiredis
>

If you submit the recipe to meta-oe then you can share development of the
recipe with others.

Oh, and I just noticed that you commented out SRCREV.  Ideally don't use a
tag name in the SRC_URI but set SRCREV to that tag's hash, so caches and
offline builds can work.

Ross

[-- Attachment #2: Type: text/html, Size: 978 bytes --]

Re: Antwort: Re: how to configure the build packages of a makefile based libary

[SIVA SUBRAMANIAN.P]

On Fri, Apr 29, 2016 at 4:41 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 29 April 2016 at 10:59, <S.Jaritz@esa-grimma.de> wrote:
>>
>> Finally we made it - Thanks to you all for helping me! I attached my bb
>> file for that case someone is searching for a bitbake recipe for building
>> the libhiredis
>
>
> If you submit the recipe to meta-oe then you can share development of the
> recipe with others.

How can we do that? Kindly guide.

>
> Oh, and I just noticed that you commented out SRCREV.  Ideally don't use a
> tag name in the SRC_URI but set SRCREV to that tag's hash, so caches and
> offline builds can work.
>
> Ross
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>

Re: Antwort: Re: how to configure the build packages of a makefile based libary

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

On 29 April 2016 at 15:01, SIVA SUBRAMANIAN.P <psiva87@gmail.com> wrote:

> > If you submit the recipe to meta-oe then you can share development of the
> > recipe with others.
>
> How can we do that? Kindly guide.
>

In general the README at the top of the layer that your recipe would be
suited for should tell you how to submit recipes to it.  For example, this
is meta-oe's README:

http://git.openembedded.org/meta-openembedded/tree/meta-oe/README

Ross

[-- Attachment #2: Type: text/html, Size: 1124 bytes --]

Re: how to configure the build packages of a makefile based libary

[SIVA SUBRAMANIAN.P]

If bins/libs are installed in non standard paths other than usr/bin or
/usr/lib in image directory, then you need to add them explicitly in
your recipe like

FILES_${PN} += "/lib/libxxxx.so"

On Thu, Apr 28, 2016 at 3:20 PM,  <S.Jaritz@esa-grimma.de> wrote:
> Hej
>
> I like to include the hiredis library. I created a recipe and modified the
> EXTRA_OEMAKE. The compilation works (in the git directory object, "so" and
> "a" files are generated). But the generated files are not placed into
> packages.
>
> Any ideas?
>
> below there is the "libhiredis.bb" file:
> #########
> SUMMARY = "libhiredis"
> SECTION = "sek4"
> LICENSE = "COPYING"
> LIC_FILES_CHKSUM =
> "file://${WORKDIR}/git/COPYING;md5=d84d659a35c666d23233e54503aaea51"
>
> # 0.13.3
> # SRCREV = "010756025e8cefd1bc66c6d4ed3b1648ef6f1f95"
> SRC_URI = "git://github.com/redis/hiredis.git;rev=v0.13.3"
>
> S = "${WORKDIR}/git/"
>
> # we need to pass the Cxx parameter extra to the make call
> EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS}
> -I${S}/include' 'BUILDDIR=${S}'"
> #########
>
> Regards!
> Stefan
>
> ------------------------------------------------------------
> ESA Elektroschaltanlagen Grimma GmbH
> Broner Ring 30
> 04668 Grimma
> Telefon: +49 3437 9211 176
> Telefax: +49 3437 9211 26
> E-Mail: s.jaritz@esa-grimma.de
> Internet: www.esa-grimma.de
>
>
> Geschäftsführer:
> Dipl.-Ing. Jörg Gaitzsch
> Jörg Reinker
>
> Sitz der Gesellschaft: Grimma
> Ust.-ID: DE 141784437
> Amtsgericht: Leipzig, HRB 5159
> Steuernummer: 238/108/00755
>
>
> Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
> Informationen.
> Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich
> erhalten
> haben, informieren Sie bitte sofort den Absender und löschen Sie diese
> Nachricht. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser
> Mail
> ist nicht gestattet.
>
> This e-mail may contain confidential and/or privileged information. If you
> are
> not the intended recipient (or have received this e-mail in error) please
> notify the sender immediately and destroy this e-mail. Any unauthorized
> copying, disclosure or distribution of the material in this e-mail is
> strictly
> forbidden.
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>