All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [patch] drm/i915: Update Slylake PCI IDs
@ 2020-04-29 11:40 Alexei Podtelezhnikov
  2020-04-29 11:54 ` Alexei Podtelezhnikov
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Alexei Podtelezhnikov @ 2020-04-29 11:40 UTC (permalink / raw)
  To: intel-gfx

Add three new devices 0x1913, 0x1915, and 0x1917 also known as 
iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15. Reclassify 0x1923, 0x1927, 
and 0x192A according to specifications. Of note, the second to last
digit seems to correspond to GT#.

Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com> 
---
 include/drm/i915_pciids.h | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 1d2c1221..c12bce9e 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -331,15 +331,18 @@
 	INTEL_VGA_DEVICE(0x22b3, info)
 
 #define INTEL_SKL_ULT_GT1_IDS(info) \
-	INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */
+	INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
+	INTEL_VGA_DEVICE(0x1913, info) /* ULT GT1.5 */
 
 #define INTEL_SKL_ULX_GT1_IDS(info) \
-	INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */
+	INTEL_VGA_DEVICE(0x190E, info), /* ULX GT1 */ \
+	INTEL_VGA_DEVICE(0x1915, info) /* ULX GT1.5 */
 
 #define INTEL_SKL_GT1_IDS(info)	\
 	INTEL_SKL_ULT_GT1_IDS(info), \
 	INTEL_SKL_ULX_GT1_IDS(info), \
 	INTEL_VGA_DEVICE(0x1902, info), /* DT  GT1 */ \
+	INTEL_VGA_DEVICE(0x1917, info), /* DT  GT1.5 */ \
 	INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
 	INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */
 
@@ -359,21 +362,21 @@
 	INTEL_VGA_DEVICE(0x191D, info)  /* WKS GT2 */
 
 #define INTEL_SKL_ULT_GT3_IDS(info) \
-	INTEL_VGA_DEVICE(0x1926, info) /* ULT GT3 */
+	INTEL_VGA_DEVICE(0x1923, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x1927, info), /* ULT GT3 28W */ \
+	INTEL_VGA_DEVICE(0x1926, info) /* ULT GT3e */
 
 #define INTEL_SKL_GT3_IDS(info) \
 	INTEL_SKL_ULT_GT3_IDS(info), \
-	INTEL_VGA_DEVICE(0x1923, info), /* ULT GT3 */ \
-	INTEL_VGA_DEVICE(0x1927, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x192A, info), /* SRV GT3 */ \
 	INTEL_VGA_DEVICE(0x192B, info), /* Halo GT3 */ \
-	INTEL_VGA_DEVICE(0x192D, info)  /* SRV GT3 */
+	INTEL_VGA_DEVICE(0x192D, info)  /* SRV GT3e */
 
 #define INTEL_SKL_GT4_IDS(info) \
 	INTEL_VGA_DEVICE(0x1932, info), /* DT GT4 */ \
 	INTEL_VGA_DEVICE(0x193B, info), /* Halo GT4 */ \
 	INTEL_VGA_DEVICE(0x193D, info), /* WKS GT4 */ \
-	INTEL_VGA_DEVICE(0x192A, info), /* SRV GT4 */ \
-	INTEL_VGA_DEVICE(0x193A, info)  /* SRV GT4e */
+	INTEL_VGA_DEVICE(0x193A, info)  /* SRV GT4 */
 
 #define INTEL_SKL_IDS(info)	 \
 	INTEL_SKL_GT1_IDS(info), \
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [patch] drm/i915: Add PCI IDs for Skylake GT1.5
@ 2020-04-28 13:57 Ville Syrjälä
  2020-04-29  3:27 ` [Intel-gfx] [patch] drm/i915: Update Slylake PCI IDs Alexei Podtelezhnikov
  0 siblings, 1 reply; 9+ messages in thread
From: Ville Syrjälä @ 2020-04-28 13:57 UTC (permalink / raw)
  To: Alexei Podtelezhnikov; +Cc: intel-gfx

On Mon, Apr 27, 2020 at 11:47:05PM -0400, Alexei Podtelezhnikov wrote:
> These devices are also known as iSKLULTGT15 and iSKLDTGT15.
> 
> Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com>
> ---
>  include/drm/i915_pciids.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/i915_pciids.h b/src/i915_pciids.h
> index 1d2c1221..a9c88eab 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -331,7 +355,8 @@ Add SKL GT1.5
>  	INTEL_VGA_DEVICE(0x22b3, info)
>  
>  #define INTEL_SKL_ULT_GT1_IDS(info) \
> -	INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */
> +	INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
> +	INTEL_VGA_DEVICE(0x1913, info) /* ULT GT1.5 */
>  
>  #define INTEL_SKL_ULX_GT1_IDS(info) \
>  	INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */

We also seem to be missing 0x1915 from the ulx list.

Another odd things I noticed in our SKL PCI ID lists is that
that 0x1923 and 0x1927 are potentially miscategorized. They
are listed as ULT in some parts of the spec whereas we have
them in the non-ULT/ULX list. Also 0x1927 is listed as Iris
graphics 550, and ark.intel.com says that it can be found
in the i5-6267U CPU, which is ULT. The other one is listed
as HD Graphics 535 which does give some ULT google hits based
on the Windows drivers. So looks like we should make these ULT.

The third odd thing is that 0x192a is listed as both GT3 and GT4
in the spec. Not really able to find corroborating evidence one
way or the other unfortunately.

> @@ -340,6 +365,7 @@ Add SKL GT1.5
>  	INTEL_SKL_ULT_GT1_IDS(info), \
>  	INTEL_SKL_ULX_GT1_IDS(info), \
>  	INTEL_VGA_DEVICE(0x1902, info), /* DT  GT1 */ \
> +	INTEL_VGA_DEVICE(0x1917, info), /* DT  GT1.5 */ \
>  	INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
>  	INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */
>  
> --
> 2.26.2
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-04-29 17:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 11:40 [Intel-gfx] [patch] drm/i915: Update Slylake PCI IDs Alexei Podtelezhnikov
2020-04-29 11:54 ` Alexei Podtelezhnikov
2020-04-29 13:00   ` Chris Wilson
2020-04-29 12:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-29 15:29 ` [Intel-gfx] [patch] " Alexei Podtelezhnikov
2020-04-29 17:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-04-28 13:57 [Intel-gfx] [patch] drm/i915: Add PCI IDs for Skylake GT1.5 Ville Syrjälä
2020-04-29  3:27 ` [Intel-gfx] [patch] drm/i915: Update Slylake PCI IDs Alexei Podtelezhnikov
2020-04-29  6:32   ` Ville Syrjälä
2020-04-29  8:52     ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.