All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: "Andreas K. Huettel" <andreas.huettel@ur.de>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	netdev <netdev@vger.kernel.org>,
	intel-wired-lan@lists.osuosl.org, Jakub Kicinski <kubakici@wp.pl>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Len Brown <lenb@kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [EXT] Re: [Intel-wired-lan] Intel I350 regression 5.10 -> 5.14 ("The NVM Checksum Is Not Valid") [8086:1521]
Date: Tue, 12 Oct 2021 19:58:47 +0200	[thread overview]
Message-ID: <CAJZ5v0gf0y6qDHUJOsvLFctqn8tgKeuTYn5S9rb6+T0Sj26aKw@mail.gmail.com> (raw)
In-Reply-To: <6faf4b92-78d5-47a4-63df-cc2bab7769d0@molgen.mpg.de>

On Tue, Oct 12, 2021 at 7:42 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> [Cc: +ACPI maintainers]
>
> Am 12.10.21 um 18:34 schrieb Andreas K. Huettel:
> >>> The messages easily identifiable are:
> >>>
> >>> huettel@pinacolada ~/tmp $ cat kernel-messages-5.10.59.txt |grep igb
> >>> Oct  5 15:11:18 dilfridge kernel: [    2.090675] igb: Intel(R) Gigabit Ethernet Network Driver
> >>> Oct  5 15:11:18 dilfridge kernel: [    2.090676] igb: Copyright (c) 2007-2014 Intel Corporation.
> >>> Oct  5 15:11:18 dilfridge kernel: [    2.090728] igb 0000:01:00.0: enabling device (0000 -> 0002)
> >>
> >> This line is missing below, it indicates that the kernel couldn't or
> >> didn't power up the PCIe for some reason. We're looking for something
> >> like ACPI or PCI patches (possibly PCI-Power management) to be the
> >> culprit here.
> >
> > So I did a git bisect from linux-v5.10 (good) to linux-v5.14.11 (bad).
> >
> > The result was:
> >
> > dilfridge /usr/src/linux-git # git bisect bad
> > 6381195ad7d06ef979528c7452f3ff93659f86b1 is the first bad commit
> > commit 6381195ad7d06ef979528c7452f3ff93659f86b1
> > Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Date:   Mon May 24 17:26:16 2021 +0200
> >
> >      ACPI: power: Rework turning off unused power resources
> > [...]
> >
> > I tried naive reverting of this commit on top of 5.14.11. That applies nearly cleanly,
> > and after a reboot the additional ethernet interfaces show up with their MAC in the
> > boot messages.
> >
> > (Not knowing how safe that experiment was, I did not go further than single mode and
> > immediately rebooted into 5.10 afterwards.)

Reverting this is rather not an option, because the code before it was
a one-off fix of an earlier issue, but it should be fixable given some
more information.

Basically, I need a boot log from both the good and bad cases and the
acpidump output from the affected machine.

WARNING: multiple messages have this Message-ID (diff)
From: Rafael J. Wysocki <rafael@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [EXT] Re: Intel I350 regression 5.10 -> 5.14 ("The NVM Checksum Is Not Valid") [8086:1521]
Date: Tue, 12 Oct 2021 19:58:47 +0200	[thread overview]
Message-ID: <CAJZ5v0gf0y6qDHUJOsvLFctqn8tgKeuTYn5S9rb6+T0Sj26aKw@mail.gmail.com> (raw)
In-Reply-To: <6faf4b92-78d5-47a4-63df-cc2bab7769d0@molgen.mpg.de>

On Tue, Oct 12, 2021 at 7:42 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> [Cc: +ACPI maintainers]
>
> Am 12.10.21 um 18:34 schrieb Andreas K. Huettel:
> >>> The messages easily identifiable are:
> >>>
> >>> huettel at pinacolada ~/tmp $ cat kernel-messages-5.10.59.txt |grep igb
> >>> Oct  5 15:11:18 dilfridge kernel: [    2.090675] igb: Intel(R) Gigabit Ethernet Network Driver
> >>> Oct  5 15:11:18 dilfridge kernel: [    2.090676] igb: Copyright (c) 2007-2014 Intel Corporation.
> >>> Oct  5 15:11:18 dilfridge kernel: [    2.090728] igb 0000:01:00.0: enabling device (0000 -> 0002)
> >>
> >> This line is missing below, it indicates that the kernel couldn't or
> >> didn't power up the PCIe for some reason. We're looking for something
> >> like ACPI or PCI patches (possibly PCI-Power management) to be the
> >> culprit here.
> >
> > So I did a git bisect from linux-v5.10 (good) to linux-v5.14.11 (bad).
> >
> > The result was:
> >
> > dilfridge /usr/src/linux-git # git bisect bad
> > 6381195ad7d06ef979528c7452f3ff93659f86b1 is the first bad commit
> > commit 6381195ad7d06ef979528c7452f3ff93659f86b1
> > Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Date:   Mon May 24 17:26:16 2021 +0200
> >
> >      ACPI: power: Rework turning off unused power resources
> > [...]
> >
> > I tried naive reverting of this commit on top of 5.14.11. That applies nearly cleanly,
> > and after a reboot the additional ethernet interfaces show up with their MAC in the
> > boot messages.
> >
> > (Not knowing how safe that experiment was, I did not go further than single mode and
> > immediately rebooted into 5.10 afterwards.)

Reverting this is rather not an option, because the code before it was
a one-off fix of an earlier issue, but it should be fixable given some
more information.

Basically, I need a boot log from both the good and bad cases and the
acpidump output from the affected machine.

  reply	other threads:[~2021-10-12 17:58 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 13:06 Intel I350 regression 5.10 -> 5.14 ("The NVM Checksum Is Not Valid") [8086:1521] Andreas K. Huettel
2021-10-04 14:48 ` Jakub Kicinski
2021-10-04 14:48   ` [Intel-wired-lan] " Jakub Kicinski
2021-10-04 23:39   ` Hisashi T Fujinaka
2021-10-04 23:39     ` Hisashi T Fujinaka
2021-10-05  0:12     ` [EXT] " Andreas K. Huettel
2021-10-05  0:12       ` [Intel-wired-lan] [EXT] " Andreas K. Huettel
2021-10-05  0:21       ` [EXT] Re: [Intel-wired-lan] " Hisashi T Fujinaka
2021-10-05  0:21         ` [Intel-wired-lan] [EXT] " Hisashi T Fujinaka
2021-10-05  6:50     ` [Intel-wired-lan] " Sasha Neftin
2021-10-05  6:50       ` Sasha Neftin
2021-10-05  9:40       ` Paul Menzel
2021-10-05  9:40         ` Paul Menzel
2021-10-05 18:20         ` Hisashi T Fujinaka
2021-10-05 18:20           ` Hisashi T Fujinaka
2021-10-05  9:34   ` Paul Menzel
2021-10-05  9:34     ` Paul Menzel
2021-10-05 13:43     ` [EXT] " Andreas K. Huettel
2021-10-05 13:43       ` [Intel-wired-lan] [EXT] " Andreas K. Huettel
2021-10-05 22:27       ` [EXT] Re: [Intel-wired-lan] " Jesse Brandeburg
2021-10-05 22:27         ` [Intel-wired-lan] [EXT] " Jesse Brandeburg
2021-10-12 16:34         ` [EXT] Re: [Intel-wired-lan] " Andreas K. Huettel
2021-10-12 16:34           ` [Intel-wired-lan] [EXT] " Andreas K. Huettel
2021-10-12 17:42           ` [EXT] Re: [Intel-wired-lan] " Paul Menzel
2021-10-12 17:42             ` [Intel-wired-lan] [EXT] " Paul Menzel
2021-10-12 17:58             ` Rafael J. Wysocki [this message]
2021-10-12 17:58               ` Rafael J. Wysocki
2021-10-12 19:28               ` [EXT] Re: [Intel-wired-lan] " Andreas K. Huettel
2021-10-12 19:28                 ` [Intel-wired-lan] [EXT] " Andreas K. Huettel
2021-10-14 12:09                 ` [EXT] Re: [Intel-wired-lan] " Rafael J. Wysocki
2021-10-14 12:09                   ` [Intel-wired-lan] [EXT] " Rafael J. Wysocki
2021-10-15 14:00                   ` [EXT] Re: [Intel-wired-lan] " Andreas K. Huettel
2021-10-15 14:00                     ` [Intel-wired-lan] [EXT] " Andreas K. Huettel
2021-10-15 18:42                     ` [EXT] Re: [Intel-wired-lan] " Rafael J. Wysocki
2021-10-15 18:42                       ` [Intel-wired-lan] [EXT] " Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0gf0y6qDHUJOsvLFctqn8tgKeuTYn5S9rb6+T0Sj26aKw@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=andreas.huettel@ur.de \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kubakici@wp.pl \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.