All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: James Morse <james.morse@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH] ARM: cpuidle: Pass on arm_cpuidle_suspend()'s return value
Date: Tue, 26 Apr 2016 21:05:57 +0200	[thread overview]
Message-ID: <CAJZ5v0h+P5baWVkTcbjxOjsXyp7aDy25+ik_9XHtUs6+jeN7Pw@mail.gmail.com> (raw)
In-Reply-To: <20160426113103.GB2204@red-moon>

On Tue, Apr 26, 2016 at 1:31 PM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> On Tue, Apr 26, 2016 at 12:15:01PM +0100, James Morse wrote:
>> arm_cpuidle_suspend() may return -EOPNOTSUPP, or any value returned
>> by the cpu_ops/cpuidle_ops suspend call. arm_enter_idle_state() doesn't
>> update 'ret' with this value, meaning we always signal success to
>> cpuidle_enter_state(), causing it to update the usage counters as if we
>> succeeded.
>>
>> Fixes: 191de17aa3c1 ("ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function")
>> Signed-off-by: James Morse <james.morse@arm.com>
>> ---
>>  drivers/cpuidle/cpuidle-arm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>
>>
>> diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c
>> index 545069d5fdfb..e342565e8715 100644
>> --- a/drivers/cpuidle/cpuidle-arm.c
>> +++ b/drivers/cpuidle/cpuidle-arm.c
>> @@ -50,7 +50,7 @@ static int arm_enter_idle_state(struct cpuidle_device *dev,
>>                * call the CPU ops suspend protocol with idle index as a
>>                * parameter.
>>                */
>> -             arm_cpuidle_suspend(idx);
>> +             ret = arm_cpuidle_suspend(idx);
>>
>>               cpu_pm_exit();
>>       }
>> --

OK

Should that go into -stable?

WARNING: multiple messages have this Message-ID (diff)
From: rafael@kernel.org (Rafael J. Wysocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cpuidle: Pass on arm_cpuidle_suspend()'s return value
Date: Tue, 26 Apr 2016 21:05:57 +0200	[thread overview]
Message-ID: <CAJZ5v0h+P5baWVkTcbjxOjsXyp7aDy25+ik_9XHtUs6+jeN7Pw@mail.gmail.com> (raw)
In-Reply-To: <20160426113103.GB2204@red-moon>

On Tue, Apr 26, 2016 at 1:31 PM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> On Tue, Apr 26, 2016 at 12:15:01PM +0100, James Morse wrote:
>> arm_cpuidle_suspend() may return -EOPNOTSUPP, or any value returned
>> by the cpu_ops/cpuidle_ops suspend call. arm_enter_idle_state() doesn't
>> update 'ret' with this value, meaning we always signal success to
>> cpuidle_enter_state(), causing it to update the usage counters as if we
>> succeeded.
>>
>> Fixes: 191de17aa3c1 ("ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function")
>> Signed-off-by: James Morse <james.morse@arm.com>
>> ---
>>  drivers/cpuidle/cpuidle-arm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>
>>
>> diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c
>> index 545069d5fdfb..e342565e8715 100644
>> --- a/drivers/cpuidle/cpuidle-arm.c
>> +++ b/drivers/cpuidle/cpuidle-arm.c
>> @@ -50,7 +50,7 @@ static int arm_enter_idle_state(struct cpuidle_device *dev,
>>                * call the CPU ops suspend protocol with idle index as a
>>                * parameter.
>>                */
>> -             arm_cpuidle_suspend(idx);
>> +             ret = arm_cpuidle_suspend(idx);
>>
>>               cpu_pm_exit();
>>       }
>> --

OK

Should that go into -stable?

  reply	other threads:[~2016-04-26 19:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 11:15 [PATCH] ARM: cpuidle: Pass on arm_cpuidle_suspend()'s return value James Morse
2016-04-26 11:15 ` James Morse
2016-04-26 11:31 ` Lorenzo Pieralisi
2016-04-26 11:31   ` Lorenzo Pieralisi
2016-04-26 19:05   ` Rafael J. Wysocki [this message]
2016-04-26 19:05     ` Rafael J. Wysocki
2016-04-27  9:14     ` Lorenzo Pieralisi
2016-04-27  9:14       ` Lorenzo Pieralisi
2016-04-27 15:04       ` Lina Iyer
2016-04-27 15:04         ` Lina Iyer
2016-04-28  8:20       ` Daniel Lezcano
2016-04-28  8:20         ` Daniel Lezcano
2016-05-04 21:20         ` Rafael J. Wysocki
2016-05-04 21:20           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0h+P5baWVkTcbjxOjsXyp7aDy25+ik_9XHtUs6+jeN7Pw@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.