[PATCH v3 0/3] Skip IRQ1 override for two laptops

[PATCH v3 0/3] Skip IRQ1 override for two laptops

[Chuanhong Guo]

The IRQ1 of these laptops with Ryzen 6000 and Insyde UEFI are
active low and defined in legacy format in ACPI DSDT. The
kernel override made their keyboard non-functional.
This patchset skips override for them.

Changes since v1:
 Match DMI_PRODUCT_NAME for ThinkBook because the board name
 is used for other completely different Lenovo laptops.
 Add a patch for RedmiBook

Changes since v2:
 Fix alphabetical order in skip_override_table
 Add a patch for Asus Zenbook

Chuanhong Guo (1):
  ACPI: skip IRQ1 override on Lenovo ThinkBook 14G4+ ARA

Kent Hou Man (1):
  ACPI: skip IRQ1 override on Asus Zenbook S 13 OLED UM5302

Tighe Donnelly (1):
  ACPI: skip IRQ1 override on Redmi Book Pro 15 2022

 drivers/acpi/resource.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

-- 
2.36.1

[PATCH v3 1/3] ACPI: skip IRQ1 override on Lenovo ThinkBook 14G4+ ARA

[Chuanhong Guo]

The IRQ is described as (Edge, ActiveLow, Shared, ) in ACPI DSDT and
it's correct. The override makes the keyboard interrupt polarity
inverted, resulting in non-functional keyboard.
Add an entry for skipping the override.

Cc: <stable@vger.kernel.org>
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
Change since v1:
 Match DMI_PRODUCT_NAME for ThinkBook because the board name
 is used for other completely different Lenovo laptops.

Change since v2:
 fix alphabetical order in skip_override_table

 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index c2d494784425..f888c62b8b96 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -399,6 +399,17 @@ static const struct dmi_system_id medion_laptop[] = {
 	{ }
 };
 
+static const struct dmi_system_id irq1_edge_low_shared[] = {
+	{
+		.ident = "Lenovo ThinkBook 14 G4+ ARA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
+		},
+	},
+	{ }
+};
+
 struct irq_override_cmp {
 	const struct dmi_system_id *system;
 	unsigned char irq;
@@ -408,6 +419,7 @@ struct irq_override_cmp {
 };
 
 static const struct irq_override_cmp skip_override_table[] = {
+	{ irq1_edge_low_shared, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1 },
 	{ medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0 },
 };
 
-- 
2.36.1

[PATCH v3 2/3] ACPI: skip IRQ1 override on Redmi Book Pro 15 2022

[Chuanhong Guo]

From: Tighe Donnelly <tighe.donnelly@protonmail.com>

The IRQ is described as (Edge, ActiveLow, Shared, ) in ACPI DSDT and
it's correct. The override makes the keyboard interrupt polarity
inverted, resulting in non-functional keyboard.
Add an entry for skipping the override.

Cc: <stable@vger.kernel.org>
Signed-off-by: Tighe Donnelly <tighe.donnelly@protonmail.com>
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
Change since v1: new patch
Change since v2: none

 drivers/acpi/resource.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index f888c62b8b96..30c0d85b2bf2 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -407,6 +407,13 @@ static const struct dmi_system_id irq1_edge_low_shared[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
 		},
 	},
+	{
+		.ident = "Redmi Book Pro 15 2022",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TIMI"),
+			DMI_MATCH(DMI_BOARD_NAME, "TM2113"),
+		},
+	},
 	{ }
 };
 
-- 
2.36.1

[PATCH v3 3/3] ACPI: skip IRQ1 override on Asus Zenbook S 13 OLED UM5302

[Chuanhong Guo]

From: Kent Hou Man <knthmn0@gmail.com>

This laptop also defines its active-low keyboard IRQ in legacy format.
Add IRQ override skipping for it.

Cc: <stable@vger.kernel.org>
Signed-off-by: Kent Hou Man <knthmn0@gmail.com>
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
Change since v2: none

 drivers/acpi/resource.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 30c0d85b2bf2..eff615f51d07 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -400,6 +400,13 @@ static const struct dmi_system_id medion_laptop[] = {
 };
 
 static const struct dmi_system_id irq1_edge_low_shared[] = {
+	{
+		.ident = "Asus Zenbook S 13 OLED UM5302",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "UM5302TA"),
+		},
+	},
 	{
 		.ident = "Lenovo ThinkBook 14 G4+ ARA",
 		.matches = {
-- 
2.36.1

Re: [PATCH v3 0/3] Skip IRQ1 override for two laptops

[Rafael J. Wysocki]

On Mon, Jun 20, 2022 at 5:30 PM Chuanhong Guo <gch981213@gmail.com> wrote:
>
> The IRQ1 of these laptops with Ryzen 6000 and Insyde UEFI are
> active low and defined in legacy format in ACPI DSDT. The
> kernel override made their keyboard non-functional.
> This patchset skips override for them.

Can you please merge the three patches in this series into one patch
and put the above information into its changelog?

> Changes since v1:
>  Match DMI_PRODUCT_NAME for ThinkBook because the board name
>  is used for other completely different Lenovo laptops.
>  Add a patch for RedmiBook
>
> Changes since v2:
>  Fix alphabetical order in skip_override_table
>  Add a patch for Asus Zenbook
>
> Chuanhong Guo (1):
>   ACPI: skip IRQ1 override on Lenovo ThinkBook 14G4+ ARA
>
> Kent Hou Man (1):
>   ACPI: skip IRQ1 override on Asus Zenbook S 13 OLED UM5302
>
> Tighe Donnelly (1):
>   ACPI: skip IRQ1 override on Redmi Book Pro 15 2022
>
>  drivers/acpi/resource.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> --
> 2.36.1
>

Re: [PATCH v3 0/3] Skip IRQ1 override for two laptops

[Chuanhong Guo]

On Thu, Jun 30, 2022 at 1:44 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Mon, Jun 20, 2022 at 5:30 PM Chuanhong Guo <gch981213@gmail.com> wrote:
> >
> > The IRQ1 of these laptops with Ryzen 6000 and Insyde UEFI are
> > active low and defined in legacy format in ACPI DSDT. The
> > kernel override made their keyboard non-functional.
> > This patchset skips override for them.
>
> Can you please merge the three patches in this series into one patch
> and put the above information into its changelog?

OK. I'll do that.

-- 
Regards,
Chuanhong Guo