All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ACPI: resource: Skip IRQ override on Asus Vivobook S5602ZA
@ 2022-10-14  5:19 Tamim Khan
  2022-10-26 11:42 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Tamim Khan @ 2022-10-14  5:19 UTC (permalink / raw)
  To: linux-acpi; +Cc: lenb, rafael, linux-kernel, Tamim Khan, Dzmitry

Like the Asus Vivobook K3402ZA/K3502ZA/S5402ZA Asus Vivobook S5602ZA
has an ACPI DSDT table the describes IRQ 1 as ActiveLow while the kernel
overrides it to Edge_High. This prevents the keyboard on this laptop
from working. To fix this add this laptop to the skip_override_table so
that the kernel does not override IRQ 1.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216579
Tested-by: Dzmitry <wrkedm@gmail.com>
Signed-off-by: Tamim Khan <tamim@fusetak.com>
---
This patch is similar to e12dee3736731e24b1e7367f87d66ac0fcd73ce7
(ACPI: resource: Skip IRQ override on Asus Vivobook K3402ZA/K3502Z) and
6e5cbe7c4b41824e500acbb42411da692d1435f1 (ACPI: resource: Add ASUS model
S5402ZA to quirks) and just adds another Asus Vivobook that has the
same IRQ override problem

 drivers/acpi/resource.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 6f9489edfb4e..0270421d12db 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -425,6 +425,13 @@ static const struct dmi_system_id asus_laptop[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "S5402ZA"),
 		},
 	},
+	{
+		.ident = "Asus Vivobook S5602ZA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
+		},
+	},
 	{ }
 };
 
-- 
2.37.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ACPI: resource: Skip IRQ override on Asus Vivobook S5602ZA
  2022-10-14  5:19 [PATCH] ACPI: resource: Skip IRQ override on Asus Vivobook S5602ZA Tamim Khan
@ 2022-10-26 11:42 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2022-10-26 11:42 UTC (permalink / raw)
  To: Tamim Khan; +Cc: linux-acpi, lenb, rafael, linux-kernel, Dzmitry

On Fri, Oct 14, 2022 at 7:22 AM Tamim Khan <tamim@fusetak.com> wrote:
>
> Like the Asus Vivobook K3402ZA/K3502ZA/S5402ZA Asus Vivobook S5602ZA
> has an ACPI DSDT table the describes IRQ 1 as ActiveLow while the kernel
> overrides it to Edge_High. This prevents the keyboard on this laptop
> from working. To fix this add this laptop to the skip_override_table so
> that the kernel does not override IRQ 1.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216579
> Tested-by: Dzmitry <wrkedm@gmail.com>
> Signed-off-by: Tamim Khan <tamim@fusetak.com>
> ---
> This patch is similar to e12dee3736731e24b1e7367f87d66ac0fcd73ce7
> (ACPI: resource: Skip IRQ override on Asus Vivobook K3402ZA/K3502Z) and
> 6e5cbe7c4b41824e500acbb42411da692d1435f1 (ACPI: resource: Add ASUS model
> S5402ZA to quirks) and just adds another Asus Vivobook that has the
> same IRQ override problem
>
>  drivers/acpi/resource.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 6f9489edfb4e..0270421d12db 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -425,6 +425,13 @@ static const struct dmi_system_id asus_laptop[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "S5402ZA"),
>                 },
>         },
> +       {
> +               .ident = "Asus Vivobook S5602ZA",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
> +               },
> +       },
>         { }
>  };
>
> --

Applied as 6.1-rc material, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-26 11:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-14  5:19 [PATCH] ACPI: resource: Skip IRQ override on Asus Vivobook S5602ZA Tamim Khan
2022-10-26 11:42 ` Rafael J. Wysocki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.