All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cpufreq: intel_pstate: Add Tigerlake support in no-HWP mode
       [not found] <003901d8c22d$02447f70$06cd7e50$@telus.net>
@ 2022-09-06 20:28 ` Doug Smythies
  2022-09-10 16:42   ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Doug Smythies @ 2022-09-06 20:28 UTC (permalink / raw)
  To: 'srinivas pandruvada', lenb, 'Rafael J. Wysocki'
  Cc: linux-pm, 'LKML', Doug Smythies, 'M. Cagri Ari'

Users may disable HWP in firmware, in which case intel_pstate wouldn't load
unless the CPU model is explicitly supported.

Add TIGERLAKE to the list of CPUs that can register intel_pstate while not
advertising the HWP capability. Without this change, an TIGERLAKE in no-HWP
mode could only use the acpi_cpufreq frequency scaling driver.

See also commits:
d8de7a44e11f: cpufreq: intel_pstate: Add Skylake servers support
fbdc21e9b038: cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode
706c5328851d: cpufreq: intel_pstate: Add Cometlake support in no-HWP mode

Reported by: M. Cargi Ari <cagriari@pm.me>
Signed-off-by: Doug Smythies <dsmythies@telus.net>
---
 drivers/cpufreq/intel_pstate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 57cdb3679885..fc3ebeb0bbe5 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -2416,6 +2416,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
 	X86_MATCH(SKYLAKE_X,		core_funcs),
 	X86_MATCH(COMETLAKE,		core_funcs),
 	X86_MATCH(ICELAKE_X,		core_funcs),
+	X86_MATCH(TIGERLAKE,		core_funcs),
 	{}
 };
 MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
--
2.25.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cpufreq: intel_pstate: Add Tigerlake support in no-HWP mode
  2022-09-06 20:28 ` [PATCH] cpufreq: intel_pstate: Add Tigerlake support in no-HWP mode Doug Smythies
@ 2022-09-10 16:42   ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2022-09-10 16:42 UTC (permalink / raw)
  To: Doug Smythies
  Cc: srinivas pandruvada, Len Brown, Rafael J. Wysocki, Linux PM,
	LKML, M. Cagri Ari

On Tue, Sep 6, 2022 at 10:29 PM Doug Smythies <dsmythies@telus.net> wrote:
>
> Users may disable HWP in firmware, in which case intel_pstate wouldn't load
> unless the CPU model is explicitly supported.
>
> Add TIGERLAKE to the list of CPUs that can register intel_pstate while not
> advertising the HWP capability. Without this change, an TIGERLAKE in no-HWP
> mode could only use the acpi_cpufreq frequency scaling driver.
>
> See also commits:
> d8de7a44e11f: cpufreq: intel_pstate: Add Skylake servers support
> fbdc21e9b038: cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode
> 706c5328851d: cpufreq: intel_pstate: Add Cometlake support in no-HWP mode
>
> Reported by: M. Cargi Ari <cagriari@pm.me>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
> ---
>  drivers/cpufreq/intel_pstate.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 57cdb3679885..fc3ebeb0bbe5 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2416,6 +2416,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
>         X86_MATCH(SKYLAKE_X,            core_funcs),
>         X86_MATCH(COMETLAKE,            core_funcs),
>         X86_MATCH(ICELAKE_X,            core_funcs),
> +       X86_MATCH(TIGERLAKE,            core_funcs),
>         {}
>  };
>  MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> --

Applied as 6.1 material, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-10 16:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <003901d8c22d$02447f70$06cd7e50$@telus.net>
2022-09-06 20:28 ` [PATCH] cpufreq: intel_pstate: Add Tigerlake support in no-HWP mode Doug Smythies
2022-09-10 16:42   ` Rafael J. Wysocki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.