All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 2/2] drm/i915/sysfs: make attrs arrays const
Date: Fri, 5 Oct 2018 08:55:46 +0200	[thread overview]
Message-ID: <CAJZ5v0hj-F_A5C3SkeAF=1vZwejryLY3j2XzrDpxUPcDStc0aA@mail.gmail.com> (raw)
In-Reply-To: <20181004143750.30880-2-jani.nikula@intel.com>

On Thu, Oct 4, 2018 at 4:38 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> They don't need to be modified.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index e5e6f6bb2b05..b9aa8515254e 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -483,7 +483,7 @@ static ssize_t gt_rp_mhz_show(struct device *kdev, struct device_attribute *attr
>         return snprintf(buf, PAGE_SIZE, "%d\n", val);
>  }
>
> -static const struct attribute *gen6_attrs[] = {
> +static const struct attribute * const gen6_attrs[] = {
>         &dev_attr_gt_act_freq_mhz.attr,
>         &dev_attr_gt_cur_freq_mhz.attr,
>         &dev_attr_gt_boost_freq_mhz.attr,
> @@ -495,7 +495,7 @@ static const struct attribute *gen6_attrs[] = {
>         NULL,
>  };
>
> -static const struct attribute *vlv_attrs[] = {
> +static const struct attribute * const vlv_attrs[] = {
>         &dev_attr_gt_act_freq_mhz.attr,
>         &dev_attr_gt_cur_freq_mhz.attr,
>         &dev_attr_gt_boost_freq_mhz.attr,
> --
> 2.11.0
>

WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 2/2] drm/i915/sysfs: make attrs arrays const
Date: Fri, 5 Oct 2018 08:55:46 +0200	[thread overview]
Message-ID: <CAJZ5v0hj-F_A5C3SkeAF=1vZwejryLY3j2XzrDpxUPcDStc0aA@mail.gmail.com> (raw)
In-Reply-To: <20181004143750.30880-2-jani.nikula@intel.com>

On Thu, Oct 4, 2018 at 4:38 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> They don't need to be modified.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index e5e6f6bb2b05..b9aa8515254e 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -483,7 +483,7 @@ static ssize_t gt_rp_mhz_show(struct device *kdev, struct device_attribute *attr
>         return snprintf(buf, PAGE_SIZE, "%d\n", val);
>  }
>
> -static const struct attribute *gen6_attrs[] = {
> +static const struct attribute * const gen6_attrs[] = {
>         &dev_attr_gt_act_freq_mhz.attr,
>         &dev_attr_gt_cur_freq_mhz.attr,
>         &dev_attr_gt_boost_freq_mhz.attr,
> @@ -495,7 +495,7 @@ static const struct attribute *gen6_attrs[] = {
>         NULL,
>  };
>
> -static const struct attribute *vlv_attrs[] = {
> +static const struct attribute * const vlv_attrs[] = {
>         &dev_attr_gt_act_freq_mhz.attr,
>         &dev_attr_gt_cur_freq_mhz.attr,
>         &dev_attr_gt_boost_freq_mhz.attr,
> --
> 2.11.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-10-05  6:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 14:37 [PATCH 1/2] sysfs: constify sysfs create/remove files harder Jani Nikula
2018-10-04 14:37 ` Jani Nikula
2018-10-04 14:37 ` [PATCH 2/2] drm/i915/sysfs: make attrs arrays const Jani Nikula
2018-10-05  6:55   ` Rafael J. Wysocki [this message]
2018-10-05  6:55     ` Rafael J. Wysocki
2018-10-04 14:51 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] sysfs: constify sysfs create/remove files harder Patchwork
2018-10-04 15:17 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-04 23:47 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-10-05  6:54 ` [PATCH 1/2] " Rafael J. Wysocki
2018-10-05  6:54   ` Rafael J. Wysocki
2018-10-05  7:36   ` Jani Nikula
2018-10-05  7:36     ` Jani Nikula
2018-10-05  7:41     ` Rafael J. Wysocki
2018-10-16 10:48 ` Greg Kroah-Hartman
2018-10-16 10:48   ` Greg Kroah-Hartman
2018-10-16 11:38   ` Jani Nikula
2018-10-16 11:38     ` Jani Nikula
2018-10-16 11:43     ` Greg Kroah-Hartman
2018-10-16 11:43       ` Greg Kroah-Hartman
2018-10-16 12:10       ` Jani Nikula
2018-10-16 12:10         ` Jani Nikula
2018-10-16 12:47         ` Greg Kroah-Hartman
2018-10-16 12:47           ` Greg Kroah-Hartman
2018-10-31 10:05           ` Jani Nikula
2018-10-31 10:05             ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJZ5v0hj-F_A5C3SkeAF=1vZwejryLY3j2XzrDpxUPcDStc0aA@mail.gmail.com' \
    --to=rafael@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.