* [PATCH] Revert "ACPI: resources: Add checks for ACPI IRQ override"
@ 2021-07-28 15:19 Hui Wang
2021-07-28 16:08 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Hui Wang @ 2021-07-28 15:19 UTC (permalink / raw)
To: linux-acpi, rafael.j.wysocki, stable; +Cc: manuelkrause, pgnet.dev
The commit 0ec4e55e9f57 ("ACPI: resources: Add checks for ACPI IRQ
override") introduces regression on some platforms, at least it makes
the UART can't get correct irq setting on two different platforms,
and it makes the kernel can't bootup on these two platforms.
This reverts commit 0ec4e55e9f571f08970ed115ec0addc691eda613.
Regression-discuss: https://bugzilla.kernel.org/show_bug.cgi?id=213031
Reported-by: PGNd <pgnet.dev@gmail.com>
Cc: 5.4+ <stable@vger.kernel.org> # 5.4+
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
drivers/acpi/resource.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index dc01fb550b28..ee78a210c606 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -423,13 +423,6 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
}
}
-static bool irq_is_legacy(struct acpi_resource_irq *irq)
-{
- return irq->triggering == ACPI_EDGE_SENSITIVE &&
- irq->polarity == ACPI_ACTIVE_HIGH &&
- irq->shareable == ACPI_EXCLUSIVE;
-}
-
/**
* acpi_dev_resource_interrupt - Extract ACPI interrupt resource information.
* @ares: Input ACPI resource object.
@@ -468,7 +461,7 @@ bool acpi_dev_resource_interrupt(struct acpi_resource *ares, int index,
}
acpi_dev_get_irqresource(res, irq->interrupts[index],
irq->triggering, irq->polarity,
- irq->shareable, irq_is_legacy(irq));
+ irq->shareable, true);
break;
case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
ext_irq = &ares->data.extended_irq;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "ACPI: resources: Add checks for ACPI IRQ override"
2021-07-28 15:19 [PATCH] Revert "ACPI: resources: Add checks for ACPI IRQ override" Hui Wang
@ 2021-07-28 16:08 ` Greg KH
2021-07-28 16:38 ` Rafael J. Wysocki
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2021-07-28 16:08 UTC (permalink / raw)
To: Hui Wang; +Cc: linux-acpi, rafael.j.wysocki, stable, manuelkrause, pgnet.dev
On Wed, Jul 28, 2021 at 11:19:58PM +0800, Hui Wang wrote:
> The commit 0ec4e55e9f57 ("ACPI: resources: Add checks for ACPI IRQ
> override") introduces regression on some platforms, at least it makes
> the UART can't get correct irq setting on two different platforms,
> and it makes the kernel can't bootup on these two platforms.
>
> This reverts commit 0ec4e55e9f571f08970ed115ec0addc691eda613.
>
> Regression-discuss: https://bugzilla.kernel.org/show_bug.cgi?id=213031
> Reported-by: PGNd <pgnet.dev@gmail.com>
> Cc: 5.4+ <stable@vger.kernel.org> # 5.4+
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
> drivers/acpi/resource.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "ACPI: resources: Add checks for ACPI IRQ override"
2021-07-28 16:08 ` Greg KH
@ 2021-07-28 16:38 ` Rafael J. Wysocki
2021-07-28 16:52 ` PGNet Dev
0 siblings, 1 reply; 7+ messages in thread
From: Rafael J. Wysocki @ 2021-07-28 16:38 UTC (permalink / raw)
To: Greg KH, Hui Wang
Cc: ACPI Devel Maling List, Rafael Wysocki, Stable, manuelkrause, pgnet.dev
On Wed, Jul 28, 2021 at 6:08 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Jul 28, 2021 at 11:19:58PM +0800, Hui Wang wrote:
> > The commit 0ec4e55e9f57 ("ACPI: resources: Add checks for ACPI IRQ
> > override") introduces regression on some platforms, at least it makes
> > the UART can't get correct irq setting on two different platforms,
> > and it makes the kernel can't bootup on these two platforms.
> >
> > This reverts commit 0ec4e55e9f571f08970ed115ec0addc691eda613.
> >
> > Regression-discuss: https://bugzilla.kernel.org/show_bug.cgi?id=213031
> > Reported-by: PGNd <pgnet.dev@gmail.com>
> > Cc: 5.4+ <stable@vger.kernel.org> # 5.4+
> > Signed-off-by: Hui Wang <hui.wang@canonical.com>
> > ---
> > drivers/acpi/resource.c | 9 +--------
> > 1 file changed, 1 insertion(+), 8 deletions(-)
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied as 5.14-rc material, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "ACPI: resources: Add checks for ACPI IRQ override"
2021-07-28 16:38 ` Rafael J. Wysocki
@ 2021-07-28 16:52 ` PGNet Dev
2021-07-28 16:54 ` Rafael J. Wysocki
2021-07-29 17:57 ` Sasha Levin
0 siblings, 2 replies; 7+ messages in thread
From: PGNet Dev @ 2021-07-28 16:52 UTC (permalink / raw)
To: rafael, gregkh, hui.wang
Cc: linux-acpi, rafael.j.wysocki, stable, manuelkrause
On 7/28/21 12:38 PM, Rafael J. Wysocki wrote:
> On Wed, Jul 28, 2021 at 6:08 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> Applied as 5.14-rc material, thanks!
ty!
Will this revert be auto-magically backported to earlier stable (5.12x/5.13x) trees?
Or does that require a manual trigger?
Or, is that a distro kernel release issue?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "ACPI: resources: Add checks for ACPI IRQ override"
2021-07-28 16:52 ` PGNet Dev
@ 2021-07-28 16:54 ` Rafael J. Wysocki
2021-07-28 18:23 ` PGNet Dev
2021-07-29 17:57 ` Sasha Levin
1 sibling, 1 reply; 7+ messages in thread
From: Rafael J. Wysocki @ 2021-07-28 16:54 UTC (permalink / raw)
To: PGNet Dev
Cc: Rafael J. Wysocki, Greg Kroah-Hartman, Hui Wang,
ACPI Devel Maling List, Rafael Wysocki, Stable, manuelkrause
On Wed, Jul 28, 2021 at 6:50 PM PGNet Dev <pgnet.dev@gmail.com> wrote:
>
> On 7/28/21 12:38 PM, Rafael J. Wysocki wrote:
> > On Wed, Jul 28, 2021 at 6:08 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > Applied as 5.14-rc material, thanks!
>
> ty!
>
> Will this revert be auto-magically backported to earlier stable (5.12x/5.13x) trees?
It carries the Cc:stable tag, so it should be picked up automatically.
> Or does that require a manual trigger?
> Or, is that a distro kernel release issue?
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "ACPI: resources: Add checks for ACPI IRQ override"
2021-07-28 16:54 ` Rafael J. Wysocki
@ 2021-07-28 18:23 ` PGNet Dev
0 siblings, 0 replies; 7+ messages in thread
From: PGNet Dev @ 2021-07-28 18:23 UTC (permalink / raw)
To: rafael
Cc: gregkh, hui.wang, linux-acpi, rafael.j.wysocki, stable, manuelkrause
On 7/28/21 12:54 PM, Rafael J. Wysocki wrote:
>> Will this revert be auto-magically backported to earlier stable (5.12x/5.13x) trees?
>
> It carries the Cc:stable tag, so it should be picked up automatically.
thx all!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "ACPI: resources: Add checks for ACPI IRQ override"
2021-07-28 16:52 ` PGNet Dev
2021-07-28 16:54 ` Rafael J. Wysocki
@ 2021-07-29 17:57 ` Sasha Levin
1 sibling, 0 replies; 7+ messages in thread
From: Sasha Levin @ 2021-07-29 17:57 UTC (permalink / raw)
To: PGNet Dev
Cc: rafael, gregkh, hui.wang, linux-acpi, rafael.j.wysocki, stable,
manuelkrause
On Wed, Jul 28, 2021 at 12:52:20PM -0400, PGNet Dev wrote:
>On 7/28/21 12:38 PM, Rafael J. Wysocki wrote:
>>On Wed, Jul 28, 2021 at 6:08 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>>Applied as 5.14-rc material, thanks!
>
>ty!
>
>Will this revert be auto-magically backported to earlier stable (5.12x/5.13x) trees?
>Or does that require a manual trigger?
>Or, is that a distro kernel release issue?
Since it has a cc to stable it should happen automagically.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-29 17:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 15:19 [PATCH] Revert "ACPI: resources: Add checks for ACPI IRQ override" Hui Wang
2021-07-28 16:08 ` Greg KH
2021-07-28 16:38 ` Rafael J. Wysocki
2021-07-28 16:52 ` PGNet Dev
2021-07-28 16:54 ` Rafael J. Wysocki
2021-07-28 18:23 ` PGNet Dev
2021-07-29 17:57 ` Sasha Levin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.