All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Timur Tabi <timur@codeaurora.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-arm-msm@vger.kernel.org,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / GED: unregister interrupts during shutdown
Date: Wed, 6 Dec 2017 14:37:29 +0100	[thread overview]
Message-ID: <CAJZ5v0hkajauiqEmEVv+k-OYeP+_S4wufjuR7vmhcxARpRpw=g@mail.gmail.com> (raw)
In-Reply-To: <0b661eec-f9c7-7818-ad09-f3d488adcefe@codeaurora.org>

On Wed, Dec 6, 2017 at 2:24 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
> On 12/5/2017 5:18 PM, Rafael J. Wysocki wrote:
>> On Tue, Dec 5, 2017 at 10:01 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
>>> Some GED interrupts could be pending by the time we are doing a reboot.

[cut]

>
>>
>>>         .probe = ged_probe,
>>>         .driver = {
>>>                 .name = MODULE_NAME,
>>> --
>>
>> Overall, it looks like we should just unbind the driver from all
>> devices on shutdown.
>
> I see that shutdown is getting called on all GED instances. That should
> take care of it, right?

Yes, it should, so I'm not sure why you need the list in the first place.

Also it looks like something along the lines of devres_release_all()
should be sufficient.

Thanks,
Rafael

WARNING: multiple messages have this Message-ID (diff)
From: rafael@kernel.org (Rafael J. Wysocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ACPI / GED: unregister interrupts during shutdown
Date: Wed, 6 Dec 2017 14:37:29 +0100	[thread overview]
Message-ID: <CAJZ5v0hkajauiqEmEVv+k-OYeP+_S4wufjuR7vmhcxARpRpw=g@mail.gmail.com> (raw)
In-Reply-To: <0b661eec-f9c7-7818-ad09-f3d488adcefe@codeaurora.org>

On Wed, Dec 6, 2017 at 2:24 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
> On 12/5/2017 5:18 PM, Rafael J. Wysocki wrote:
>> On Tue, Dec 5, 2017 at 10:01 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
>>> Some GED interrupts could be pending by the time we are doing a reboot.

[cut]

>
>>
>>>         .probe = ged_probe,
>>>         .driver = {
>>>                 .name = MODULE_NAME,
>>> --
>>
>> Overall, it looks like we should just unbind the driver from all
>> devices on shutdown.
>
> I see that shutdown is getting called on all GED instances. That should
> take care of it, right?

Yes, it should, so I'm not sure why you need the list in the first place.

Also it looks like something along the lines of devres_release_all()
should be sufficient.

Thanks,
Rafael

  reply	other threads:[~2017-12-06 13:37 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 21:01 [PATCH] ACPI / GED: unregister interrupts during shutdown Sinan Kaya
2017-12-05 21:01 ` Sinan Kaya
2017-12-05 22:18 ` Rafael J. Wysocki
2017-12-05 22:18   ` Rafael J. Wysocki
2017-12-05 22:18   ` Rafael J. Wysocki
2017-12-06 13:24   ` Sinan Kaya
2017-12-06 13:24     ` Sinan Kaya
2017-12-06 13:24     ` Sinan Kaya
2017-12-06 13:37     ` Rafael J. Wysocki [this message]
2017-12-06 13:37       ` Rafael J. Wysocki
2017-12-06 13:37       ` Rafael J. Wysocki
2017-12-06 14:57       ` Sinan Kaya
2017-12-06 14:57         ` Sinan Kaya
2017-12-06 14:57         ` Sinan Kaya
2017-12-06 16:11         ` Sinan Kaya
2017-12-06 16:11           ` Sinan Kaya
2017-12-06 16:11           ` Sinan Kaya
2017-12-06 16:41           ` Rafael J. Wysocki
2017-12-06 16:41             ` Rafael J. Wysocki
2017-12-06 16:41             ` Rafael J. Wysocki
2017-12-06 16:55             ` Sinan Kaya
2017-12-06 16:55               ` Sinan Kaya
2017-12-06 16:55               ` Sinan Kaya
2017-12-06 17:16               ` Rafael J. Wysocki
2017-12-06 17:16                 ` Rafael J. Wysocki
2017-12-06 17:16                 ` Rafael J. Wysocki
2017-12-06 23:19                 ` Rafael J. Wysocki
2017-12-06 23:19                   ` Rafael J. Wysocki
2017-12-06 23:19                   ` Rafael J. Wysocki
2017-12-07  8:29                   ` Greg Kroah-Hartman
2017-12-07  8:29                     ` Greg Kroah-Hartman
2017-12-07  8:29                     ` Greg Kroah-Hartman
2017-12-07 13:00                     ` Rafael J. Wysocki
2017-12-07 13:00                       ` Rafael J. Wysocki
2017-12-07 13:00                       ` Rafael J. Wysocki
2017-12-07 14:52                       ` Sinan Kaya
2017-12-07 14:52                         ` Sinan Kaya
2017-12-07 14:52                         ` Sinan Kaya
2017-12-07 17:10                         ` Rafael J. Wysocki
2017-12-07 17:10                           ` Rafael J. Wysocki
2017-12-07 17:10                           ` Rafael J. Wysocki
2017-12-07 17:18                           ` Sinan Kaya
2017-12-07 17:18                             ` Sinan Kaya
2017-12-07 17:18                             ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJZ5v0hkajauiqEmEVv+k-OYeP+_S4wufjuR7vmhcxARpRpw=g@mail.gmail.com' \
    --to=rafael@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=okaya@codeaurora.org \
    --cc=rjw@rjwysocki.net \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.